[Warlock CC] skiWarlock 3.0 for HB2 - ALL TREES -

[Xanathos]

What spell is used on mass pull, i would think its rein of fire but my lock is 38,hes pulls 4 mobs then just heals the pet. Even when the pet dosent need it, he trys channeling. i have fight adds set to true

Depends. What level and spec are you?

Rain of fire is NEVER used by the bot due to the fact that it is a targeted AE spell that can be pushed back very easily.

As far as what's used to mass pull, that's one of the standard DD spells of your repertoire. For my guy it seems to like using Haunt or Corruption when Haunt is on cooldown.

Post your log so thedrunk can take a look at it.

 

[thedrunk]

When 2 adds coming it wont dot or do anything else. Just switching targets is it normal ?

No. What spells did you have enabled/disabled? The log would tell me that...

What spell is used on mass pull, i would think its rein of fire but my lock is 38,hes pulls 4 mobs then just heals the pet. Even when the pet dosent need it, he trys channeling. i have fight adds set to true

Soc -> Dots -> Single Target Rotation. Log please? I need to look at your Health Funnel logging!

I rolled back to .69.... i would rather a pet that does not get healed over no pet at all

(log is useless its like its missing the check for pet and just goes around killing as normal)

Log please........... useless or not i cant fix anything without me reproducing the bug and these help. If you are super paranoid about privacy, remove all personalized information and post.

Edit: I have just retested Health Funnel. The information you gave is very vague, im guessing your Pet was getting healed a lot? What is your Health Funnel variable set to? What is the stop variable set to? What Pet?

I am having a problem where when I start the bot it just sits there "resting." If I wait several minutes it will start going, but once it aggros a mob it will often only cast a single spell, or send the felguard in to attack but again not do anything else. I have tried installing the newest HB version, downloading the newest CC here but nothing seems to work. The bot works fine one my shaman without any hesitation so it seems specific to this CC.
My lock is a level 61 demo spec. Running in hellfire right now and have tried several grinding profiles.

Did you have a weapon equipped? One hander and offhand or 2hander? Did it already have a weapon enchant?

i have changed pet to Imp but it still wont summon my Imp, any reason??, i am a lvl 11

Make sure you restart HB once you have learned your new Spells (in this case "Summon Imp"). HB only reloads your spell book on start up.

I have added a Spell Book reload on Level up to rev 71+

 

[isolate1990]

Did you have a weapon equipped? One hander and offhand or 2hander? Did it already have a weapon enchant?

Make sure you restart HB once you have learned your new Spells (in this case "Summon Imp"). HB only reloads your spell book on start up.

I have added a Spell Book reload on Level up to rev 71+

i am not sure how to post a "log" but i really dont see how it is going to help as to why it wont summon my imp eveytime, but if u tell me how i will do it because this is very annoying, i'm sorry i'm such a noob

 

[Xanathos]

i am not sure how to post a "log" but i really dont see how it is going to help as to why it wont summon my imp eveytime, but if u tell me how i will do it because this is very annoying, i'm sorry i'm such a noob

Go into your HB/Logs directory. Zip up the log from the day that the issue happened.

Hit Reply, Hit Go Advanced (if not in advanced edit mode by default), Click on the paperclip... The rest should be fairly self-explanatory.

 

[thedrunk]

skiWarlock v3.71
Fixed: Pet Presence checks - this should now correctly summon your Pet. Be patient from a fresh start.
Fixed: Pet re-summon check - checks if you have the correct Pet. If you dont, it will summon the correct Pet if you have enough Soul Shards.

 

[vittunaama]

I fix the problem Using metamorphosis and switch 2 add to 1 add now its good. Put before i have demo lock and dps rotation is immolate,corruption, curse of agony, sb. here is combat log before metamorphosis:

[01:04:11:499] [skiWarlock] Combat: Demonology: Demonic Empowerment
[01:04:11:507] Spell_C::CastSpell(47193, 0, 0x0, 0)
[01:04:11:802] Took 312 ms to cast demonic Empowerment
[01:04:12:161] Activity: Combat
[01:04:12:345] [skiWarlock] Warning: There are 2 attackers
[01:04:12:379] [skiWarlock] Combating Adds: 2
[01:04:12:407] [skiWarlock] Add: 1: Target: Elder Diemetradon
[01:04:13:247] [skiWarlock] Add: 1: Pet attack: Elder Diemetradon
[01:04:13:282] [skiWarlock] Add: 2: Target: Spiked Stegodon
[01:04:13:738] [skiWarlock] Add: 2: Pet attack: Spiked Stegodon
[01:04:13:932] Activity: Combat
[01:04:14:105] [skiWarlock] Combating Adds: 2
[01:04:14:152] [skiWarlock] Add: 1: Target: Elder Diemetradon
[01:04:14:995] [skiWarlock] Add: 1: Pet attack: Elder Diemetradon
[01:04:15:32] [skiWarlock] Add: 2: Target: Spiked Stegodon
[01:04:15:367] [skiWarlock] Add: 2: Pet attack: Spiked Stegodon
[01:04:15:520] Activity: Combat
[01:04:15:734] [skiWarlock] Combating Adds: 2
[01:04:15:760] [skiWarlock] Add: 1: Target: Spiked Stegodon
[01:04:15:784] [skiWarlock] Add: 1: Pet attack: Spiked Stegodon
[01:04:15:826] [skiWarlock] Add: 2: Target: Elder Diemetradon
[01:04:16:171] [skiWarlock] Add: 2: Pet attack: Elder Diemetradon
[01:04:16:202] [skiWarlock] Add: 2: Move: 17 yard from Pet
[01:04:16:769] Activity: Combat
[01:04:16:971] [skiWarlock] Combating Adds: 2
[01:04:16:997] [skiWarlock] Add: 1: Target: Elder Diemetradon
[01:04:17:21] [skiWarlock] Add: 1: Pet attack: Elder Diemetradon
[01:04:17:60] [skiWarlock] Add: 2: Target: Spiked Stegodon
[01:04:17:507] [skiWarlock] Add: 2: Pet attack: Spiked Stegodon
[01:04:17:666] Activity: Combat
[01:04:17:807] [skiWarlock] Combat: Pet attack: Spiked Stegodon
[01:04:17:850] [skiWarlock] Combating Adds: 2
[01:04:17:916] [skiWarlock] Add: 1: Target: Elder Diemetradon
[01:04:18:357] [skiWarlock] Add: 1: Pet attack: Elder Diemetradon
[01:04:18:390] [skiWarlock] Add: 2: Target: Spiked Stegodon
[01:04:18:629] [skiWarlock] Add: 2: Pet attack: Spiked Stegodon

Just switching targets wont dot or do anything else.

 

[Kuku]

skiWarlock v3.71
Fixed: Pet Presence checks - this should now correctly summon your Pet. Be patient from a fresh start.
Fixed: Pet re-summon check - checks if you have the correct Pet. If you dont, it will summon the correct Pet if you have enough Soul Shards.

I'm still waiting on logs from the other issues reported.

Still testing.. Till now it works great with Mass Pull..

EDIT:

Bot floods the following:

Activity: Combat
[skiWarlock] Combat: Healing: Use Health Potion if I have one
[skiWarlock] Combat: Healing: Use Mana Potion
[skiWarlock] Combat: Single Rotation: No valid spell found to cast, try adjusting your variables
Activity: Combat
[skiWarlock] Combat: Healing: Use Health Potion if I have one
[skiWarlock] Combat: Healing: Use Mana Potion
[skiWarlock] Combat: Single Rotation: No valid spell found to cast, try adjusting your variables
Activity: Combat
[skiWarlock] Combat: Healing: Use Health Potion if I have one
[skiWarlock] Combat: Healing: Use Mana Potion

Log:

View attachment 23.08.2010 Log.txt

EDIT2:

Hmm.. i looked up my config and there were several activted Spells.. so i don't know what the CC wants from me.

 

[peteyboy23]

Ski/Thedrunk : Wondering if you are considering adding some "instance specific" mode/profile to the bot itself. You mention (and of course you are right) about Rain of Fire being bad for soloing, but it's incredibly good for instancing. In fact, during testing this CC using InstanceBuddy, I got booted for not using it. Other things like soulstoning the healer, would also be a nice addition. Thank you very much.

 

[peteyboy23]

The first part you can change the lifetap variables to match what you want, the 2nd part you'll have to edit the movement logic and change the clicks from unit to unit-5y (or something along those lines)

Specifically, how would I change the lifetap variables? It only gives me a minimum health so I don't lifetap below that threshold. The only other lifetap setting states that below 75%, lifetap. I don't see how I can accomplish what I want given only those two variables.

Secondly, can you give me just a bit more insight on how/where to make these changes, to maintain a minimum distance, say of 6 yards? Perhaps this is something that should be coded in by default, is what I'm thinking, as why would a Warlock ever want to be within 5 yards of a mob? Thank you very much.

 

[Xanathos]

Ski/Thedrunk : Wondering if you are considering adding some "instance specific" mode/profile to the bot itself. You mention (and of course you are right) about Rain of Fire being bad for soloing, but it's incredibly good for instancing. In fact, during testing this CC using InstanceBuddy, I got booted for not using it. Other things like soulstoning the healer, would also be a nice addition. Thank you very much.

The problem is going down the road of trying to use Rain of Fire in instances is bad, bad, bad. Not only would they have to code in the ability for the .cc to handle a ground targeted spell, there are issues where in many dungeons you have to be careful on where you place your RoF so you don't necessarily draw more adds... etc. It really is just a pain in the ass for them to try and code since there are a few solutions that present themselves post 70 (which is where most of your time will be spent) that will have your ignore using RoF from that point on.

Plus, unless you're in a group of people that you know... Having the bot just follow the tank without any supervision is a bad idea(tm). There are plenty of places where you don't want to be right on the tank's ass due to them pulling, imo.

 

[thedrunk]

I fix the problem Using metamorphosis and switch 2 add to 1 add now its good. Put before i have demo lock and dps rotation is immolate,corruption, curse of agony, sb.

I accidentally left some testing code in rev 71 that stops the bot from using SoC.

if ([COLOR=red]false && [/COLOR]!InBattleground && !Me.IsInInstance  && SpellManager.CanCastSpell("Seed of Corruption") &&  !Mob.GetBuffs(true).ContainsKey("Seed of Corruption"))

This means SoC will never get used. But, it should fall back to DOTing all adds. I'm not sure why your bot is not doing that.

I have fixed this in v3.72

Ski/Thedrunk : Wondering if you are considering adding some "instance specific" mode/profile to the bot itself. You mention (and of course you are right) about Rain of Fire being bad for soloing, but it's incredibly good for instancing. In fact, during testing this CC using InstanceBuddy, I got booted for not using it. Other things like soulstoning the healer, would also be a nice addition. Thank you very much.

I have already added a whole bunch of things for InstanceBuddy/RAFing. You will see in your combat log it picks up the tanks target etc.

When i have time i might add more functionality.

Still testing.. Till now it works great with Mass Pull..
Bot floods the following:
Hmm.. i looked up my config and there were several activted Spells.. so i don't know what the CC wants from me.

No log, i cant help.

Please post your FULL log. At minimum i need to see A) the variable dump on bot start B) the problem section of the debug log.

Just post the whole damn log. Even if "there is nothing in it". No log, no help. I'm getting frustrated with this...

 

[thedrunk]

skiWarlock v3.72
Removed development code that forced the bot to never use Seed of Corruption - woaps.

 

[Kuku]

[/SIZE]Please post your FULL log. At minimum i need to see A) the variable dump on bot start B) the problem section of the debug log.

Just post the whole damn log. No log, no help. I'm getting frustrated with this...

I don't want to be ungrateful but if you would read teh whole fkn post you would see that i posted a FULL DAMN LOG in my LAST POST!

 

[thedrunk]

I don't want to be ungrateful but if you would read teh whole fkn post you would see that i posted a FULL DAMN LOG in my LAST POST!

Thank you, i didnt see it because it was not attached to the post and links here are black.... like the text.

 

[Xanathos]

Okay, after thinking it through there still needs to be two variables associated with healing your pet with Health Funnel, but instead they need to be threshold settings. Right now you have the setting for what % the pet's health triggers the bot casting Health Funnel once it goes below it... But as soon as it goes *above* it the bot will go back to combat.

What I propose is adding a second variable that is the pet health % that once Health Funnel is triggered, what the bot will heal the pet back up to before switching to something else.

That way you don't have this situations where the bot keeps re-casting Health Funnel during a fight after the pet hits that threshold and is continuing to take damage.

EDIT: Okay, I'm a moron. You already do this. It seems it is broken then. I've got a log attached in a post below.

 

[Xanathos]

Another couple of opions. The bot shouldn't cast SoC on a target that's in the last 5-10% of it's health. Plus it shouldn't cast SoC when you're on the last target, either.

 

[tvsian]

The problem is going down the road of trying to use Rain of Fire in instances is bad, bad, bad. Not only would they have to code in the ability for the .cc to handle a ground targeted spell, there are issues where in many dungeons you have to be careful on where you place your RoF so you don't necessarily draw more adds... etc.

It seems like if it dropped it directly on a tank (or other melee) that was actively fighting, it would be safe enough to use. It shouldn't pull anything extra if there's already someone standing right there.

The question is whether or not it can detect how many mobs are a) targeting the tank, b) in melee range of the tank, and c) likely to be standing there for a moment, so the cast would actually be worthwhile. It wouldn't use it on every pull, but at least it would use it sometimes.

Not that I plan on running this in instances any time soon, but since that seems to be the direction things are going it'd be a nice option. Unless it would be an incredible hassle to add in, in which case never mind.

 

[Xanathos]

I'm running into a situation when there are adds where the bot seems to be TOO aggressive with making sure everything has SoC that it forgets to use Healthstones and potions.

I keep cranking the %'s up to try and get it to maybe trigger earlier, but it doesn't seem to matter until I'm pretty much dead.

Same thing with using Dark Pact or Life Tap to get mana back. Once it is in "adds mode" I've actually watched it take my mana down to below 10% without using either ability.

It is cool watching it chain cast SoC like a beast, tho.

EDIT: Btw, I've never seen it ever cast Drain Life, even when all of the parameters are met.

 

[thedrunk]

Okay, after thinking it through there still needs to be two variables associated with healing your pet with Health Funnel, but instead they need to be threshold settings. Right now you have the setting for what % the pet's health triggers the bot casting Health Funnel once it goes below it... But as soon as it goes *above* it the bot will go back to combat.

What I propose is adding a second variable that is the pet health % that once Health Funnel is triggered, what the bot will heal the pet back up to before switching to something else.

That way you don't have this situations where the bot keeps re-casting Health Funnel during a fight after the pet hits that threshold and is continuing to take damage.

There are two variables. When to start Health Funnel and when to stop.

I just had a look at the code and i have found the problem, its checking the start AND stop variable once it gets into the Funneling loop. The Health Funnel code has changed a lot - a complete rewrite expect for that loop.

A fix is included in 3.73

To fix, change:

while (    Me.GotAlivePet &&
    Me.HealthPercent > Settings.DontHealPetBelow &&
    Me.Pet.HealthPercent < Settings.HealPetPercent &&
    Me.Pet.HealthPercent < Settings.HealPetStopPercent &&
    Me.ChanneledCasting != 0)
}

To:

while (    Me.GotAlivePet &&
    Me.HealthPercent > Settings.DontHealPetBelow &&
    Me.Pet.HealthPercent < Settings.HealPetStopPercent &&
    Me.ChanneledCasting != 0)
}

Another couple of opions. The bot shouldn't cast SoC on a target that's in the last 5-10% of it's health. Plus it shouldn't cast SoC when you're on the last target, either.

Why shouldn't it?

I like extra SoC's as it guarantees all mobs will die. If a mob dies with SoC on it, then SoC will explode causing its damage - if it ticked out or not.

What if you had 5 mobs on your with 5-10% HP each, you have 20% HP left, pet is dead.... would you rather single target them or fire off 1 more SoC?

In regards to SoCing with 1 target, It will SoC your last target when it is in the adds loop. This happens because you kill the mobs so fast that HB doesnt have time to update its Add Count (read: Race Condition)

 

[Xanathos]

Well half the time it tries to cast SoC on a mob with health that low the mob dies before it gets a chance to get the spell off... I'd rather see it switch to a target with more health out of the adds and let the explosion kill it (like you say).

But it is probably a quibbling point.

And that's what I thought about it SoC'ing a single target... It doesn't seem to KEEP SoC'ing it more then once after I watched it based on what you said. So I can live with that.