[Plugin] TidyBags 3.0 Reloaded!

[LiquidAtoR]

How about a disenchant option ?^^
I have the Liquid Disenchant 3.0 Plugin but it wont work for me.

sry for bad English

It's very understandable for me, so don't worry.
I don't know what you are trying to do, because it works fine for the rest of the people (at least I presume so, since I don't get any complaints or bug reports).
And it does it's job for me too.
To be clear: It only De's a item when it's a Uncommon Quality Bind on Equip (So NOT soulbound) item that is looted or taken from the mail and it's disenchantable (some green items are not!).

Attachment on the first post updated with the last few SVN commit's.
Just a few small things that are added, nothing shocking.

Revision 3.6.2.0: Added Greater Cache of Treasures (Scenario Reward).
Revision 3.6.2.1: Added Silkworm Cocoon (Tailoring Imperial Silk).
Revision 3.6.2.2: Added Amber Encased Treasure Pouch (LFR Loot).

Update obtainable trough SVN or download from the first post.

 

[Guadah]

Here are the Sealed Crate item's I've been able to find so far. I was going to run my guy fishing all night; however, my teenager deceided he wanted to play on my DeathKnight and logged my guy out. Little twerp. Anyways, copy and paste the following code around line 383 of the TidyBags.cs file. (Open with Notepad, or whatever file editor you use. - I use Notepad++, it's free and works great)

// Sealed Crates items you get while fishing.
19304, // Spiced Beef Jerky
19306, // Crunchy Frog
73260, // Salty Sea Dog
44941, // Fresh-Squeezed Limeade
78883, // Darkmoon Firewater (You may or may not want to keep this)
19299, // Fizzy Faire Drink
19223, // Darkmoon Dog
19222, // Cheap Beer
19221, // Darkmoon Special Reserve
19305, // Pickled Kodo Foot
19225, // Deep Fried Candybar
19300, // Bottled Winterspring Water
21151, // Rumsey Rum Black Label
44940, // Corn-Breaded Sausage
19224, // Red Hot Wings
74822  // Sasparilla Sinker

If I find more items, I will add them to this post.

 

[EuGoldservice]

Looks like with the new HB release Tidybags doesnt loot "Plump Intestines" anymore, if you dont have Auto Loot activated..
Enabling "Auto Loot" in the WoW Interface was not needed in the past and that was very helpful.
I'm using Tidybags since months and it was always workin fine, it still works, but only with "Auto Loot" enabled..Which is not that good, because reloggers mostly don't close WoW the correct way, so the ingame interface settings sometimes get resetted and so Tidybags will get bugged without "Auto Loot".
Hopefully you can fix this, you're doing a great job with your plugin, thanks man

 

[LiquidAtoR]

Looks like with the new HB release Tidybags doesnt loot "Plump Intestines" anymore, if you dont have Auto Loot activated..
Enabling "Auto Loot" in the WoW Interface was not needed in the past and that was very helpful.
I'm using Tidybags since months and it was always workin fine, it still works, but only with "Auto Loot" enabled..Which is not that good, because reloggers mostly don't close WoW the correct way, so the ingame interface settings sometimes get resetted and so Tidybags will get bugged without "Auto Loot".
Hopefully you can fix this, you're doing a great job with your plugin, thanks man

Add this in your TidyBags copy around line 219 (just under base.Initialize():

Lua.DoString("SetCVar('AutoLootDefault','1')");

This way every time you restart HB, TidyBags loads and will enable AutoLoot if it's off.
I've added this already on SVN (v3.6.2.5)

Good luck, LiquidAtoR.

 

[EuGoldservice]

Ah nice, thanks for your fast support, i'll try it

 

[doomexpt]

Any chance you could add Sha-Touched Leather ?

 

[MaxMuster]

maybe you can add this to the next version:

Lua.Events.AttachEvent("MAIL_CLOSED", MailboxFinished);

        private void MailboxFinished(object sender, LuaEventArgs args)
        {
            if (InventoryCheck == false)
            {
                InventoryCheck = true;
            }
        }

so he check the ventory after interact with a mailbox ^^

 

[LiquidAtoR]

Any chance you could add Sha-Touched Leather ?

You have to be a leatherworker to do this, so it's not gonna be added in the plugin.
But nothing's stopping you from adding this yourself.

Open TidyBags in your favorite editor (I prefer Notepad++)
Exchange line 340 - 342

        private HashSet<uint> _itemUseOnFive = new HashSet<uint>() {
            33567 // Borean Leather Scraps
        };

with

        private HashSet<uint> _itemUseOnFive = new HashSet<uint>() {
            33567, // Borean Leather Scraps
            72162  // Sha-Touched Leather
        };

As long as you update with SVN it should leave your edit alone and just add what I put in there.
If you update from the first post, then you will have to re-edit this each release you download.

maybe you can add this to the next version:

Lua.Events.AttachEvent("MAIL_CLOSED", MailboxFinished);

        private void MailboxFinished(object sender, LuaEventArgs args)
        {
            if (InventoryCheck == false)
            {
                InventoryCheck = true;
            }
        }

so he check the ventory after interact with a mailbox ^^

Makes me wonder what you could possibly send to a alt what needs to be unpacked ^^
Will add this to SVN for now (v3.6.2.6 will have this incorporated).

 

[MaxMuster]

Makes me wonder what you could possibly send to a alt what needs to be unpacked ^^
Will add this to SVN for now (v3.6.2.6 will have this incorporated).

i have 13 farm chars that gather ores and all have the problem that not all Crystallized turns.
so the farm char send some Crystallized items to the bank char.

but it seems that my mailbox code is not working ;-(

 

[tataros]

is it possible to exclude Mote of water?there are some recipes that need it ( a nice necklace blue with socket).Is there an easy way I can edit the file to exclude this? thanks

 

[LiquidAtoR]

i have 13 farm chars that gather ores and all have the problem that not all Crystallized turns.
so the farm char send some Crystallized items to the bank char.

but it seems that my mailbox code is not working ;-(

mhm, remember, it does this after the next execution.
So you picked up your stuff, when you would loot something afterwards, it should execute the script.
It's Always 1 action after what you do, not while you do it (Event Finished).
Unless you would attach it to the moment you open the mailbox (MAIL_SHOW or maybe even MAIL_INBOX_UPDATE)
I guess then it would run right away?
Give it a whirl and let me know what works ^^

is it possible to exclude Mote of water?there are some recipes that need it ( a nice necklace blue with socket).Is there an easy way I can edit the file to exclude this? thanks

Find the itemID that you want to exclude and just put // in front of it.
If you use NotePad++ the line should turn green (e.g. not active).
Save, reload plugins or restart HB and it should no longer do your motes of water.

 

[MaxMuster]

mhm, remember, it does this after the next execution.
So you picked up your stuff, when you would loot something afterwards, it should execute the script.
It's Always 1 action after what you do, not while you do it (Event Finished).
Unless you would attach it to the moment you open the mailbox (MAIL_SHOW or maybe even MAIL_INBOX_UPDATE)
I guess then it would run right away?
Give it a whirl and let me know what works ^^


Find the itemID that you want to exclude and just put // in front of it.
If you use NotePad++ the line should turn green (e.g. not active).
Save, reload plugins or restart HB and it should no longer do your motes of water.

and why you use LOOT_CLOSED and not LOOT_OPENED ? so it would use it after every loot.

 

[LiquidAtoR]

and why you use LOOT_CLOSED and not LOOT_OPENED ? so it would use it after every loot.

Because that would re-invoke the skinning bug which doesn't exist anymore since I attached it to events

 

[Doky86]

gently, put the download version 3.6.2.4 ... I autoloot function of 3.6.2.5 do not need!

 

[Pachiking]

added folder to plug-in with the rest of the pug-ins and i got this at start up:

\TidyBags\trunk\Tidybags\TidyBags.cs(213,18) : error CS0101: The namespace 'PluginTidyBags3' already contains a definition for 'TidyBags3'

 

[Momental]

I may be stupid as hell, but i just cant figure out how to get this plugin to combine my Crystallized'ed stuff on a bank char running the AH bot
It just wont do it!

Tried looking in the .cs file but i cant for the life of me see what i have to change.
Anyone got an idea?

 

[LiquidAtoR]

gently, put the download version 3.6.2.4 ... I autoloot function of 3.6.2.5 do not need!

If you use SVN just put 2 forward slashes at line 225 and with each update it should merge your change with mine (so no need for altering every update).
If you use the download version, just open in a tekst editor and look for this line of code

Lua.DoString("SetCVar('AutoLootDefault','1')");

And add the 2 forward slashes, save and close and voila.

added folder to plug-in with the rest of the pug-ins and i got this at start up:

\TidyBags\trunk\Tidybags\TidyBags.cs(213,18) : error CS0101: The namespace 'PluginTidyBags3' already contains a definition for 'TidyBags3'

You have 2 directories too many.
Plugin folder structure should look something like this:

\<HonorBuddy Installation Folder>\Plugins\TidyBags\TidyBags.cs

I may be stupid as hell, but i just cant figure out how to get this plugin to combine my Crystallized'ed stuff on a bank char running the AH bot
It just wont do it!

Tried looking in the .cs file but i cant for the life of me see what i have to change.
Anyone got an idea?

It probably has to do with the event it's attached to (alike MaxMuster has problems with mailbox).
You will have to experiment with different lootevents to attach to, to see what works best for you.
Read this post regarding the events.
I'm @ work so I don't have broadband nor alot of time to do anything. At least 2 weeks more so don't expect miracles

 

[ArfDogUser]

the notes say that the config file shows how to delete items, but I don't see (or fail to recognize) the delete item section, just open, use when 1 2 5 10 etc. where is the relevant section for destroying items?

thanks

 

[LiquidAtoR]

the notes say that the config file shows how to delete items, but I don't see (or fail to recognize) the delete item section, just open, use when 1 2 5 10 etc. where is the relevant section for destroying items?

thanks

From line 393 you will see the destroying part

private HashSet<uint> _destroyItems = new HashSet<uint>() {

 

[Pasterke]

the notes say that the config file shows how to delete items, but I don't see (or fail to recognize) the delete item section, just open, use when 1 2 5 10 etc. where is the relevant section for destroying items?

thanks

Look there :

private HashSet<uint> _destroyItems = new HashSet<uint>() {
45188, // Whitered Kelp
45189, // Torn Sail
45190, // Driftwood
45191, // Empty Clam
45194, // Tangled Fishing Line
45195, // Empty Rum Bottle
45196, // Tattered Cloth
45197, // Tree Branch
45198, // Weeds
45199, // Old Boot
45200, // Sickly Fish
45201, // Rock
45202, // Water Snail
19304, // Spiced Beef Jerky
19306, // Crunchy Frog
73260, // Salty Sea Dog
44941, // Fresh-Squeezed Limeade
78883, // Darkmoon Firewater (You may or may not want to keep this)
19299, // Fizzy Faire Drink
19223, // Darkmoon Dog
19222, // Cheap Beer
19221, // Darkmoon Special Reserve
19305, // Pickled Kodo Foot
19225, // Deep Fried Candybar
19300, // Bottled Winterspring Water
21151, // Rumsey Rum Black Label
44940, // Corn-Breaded Sausage
19224, // Red Hot Wings
74822 // Sasparilla Sinker
};