What's new
  • Visit Rebornbuddy
  • Visit Panda Profiles
  • Visit LLamamMagic
  • Visit Resources
  • Visit Downloads
  • Visit Portal
RebornBuddy Forums

Register a free account today to become a member! Once signed in, you'll be able to participate on this site by adding your own topics and posts, as well as connect with other members through your own private inbox!

[Plugin] TidyBags 3.0 Reloaded!

Thank you for your plugin LiquidAtoR. I edited a bit to support Empty Golden Carp/Emperor Salmon/Krasarang Paddlefish Containers. Works great so far.

But I have problems with grey/white junk filling all my inventory while angling. Is there a way to auto-destroy/sell it while angling?
 
Thank you for your plugin LiquidAtoR. I edited a bit to support Empty Golden Carp/Emperor Salmon/Krasarang Paddlefish Containers. Works great so far.

But I have problems with grey/white junk filling all my inventory while angling. Is there a way to auto-destroy/sell it while angling?
All depends on how comfortable you are with editing the file itself.
If you add a few things you can make it autodestroy anything you want as long as it's in a list alike it is now.
An example you can find here written by Pasterke (who edited TidyBags for this purpose).
I will integrate this in TidyBags permanently, but after some testing of other function changes on my side (I have a new approach on the skinning lootbug which I'm exploring currently)

Meanwhile TidyBags is getting a make-over and gets integrated with some of my other plugins and additions (which are not re-released after the API change).
Ofcourse TidyBags will exist in it's current form, but there will be something new on the plugin market ;)

And last but not least, I start my work again tomorrow for the next 3 weeks, so don't expect much activity from my side on the forums (unless I have nothing to do and have a internet connection to my availability).

Regards, Liquid.
 
Last edited:
SVN Test Version v3.6.1.8 SVN Test Version


This is a testversion with changes and addition in behaviour.
As long as this is not fully tested it's not pushed to release here on the forums, so SVN only.

  • Added: Destroying of items. For now the list contains mostly grey items from fishing. Feel free to expand on this (the rest of the darkmoon faire foodtrash for example).
  • Added: Initialise message on load or on-enable of the plugin
  • Changed: The way TidyBags will run. No longer on Pulse but on Lootevents. This might solve the skinning bug!
Feedback is much appreciated, particularly in the field of the skinning bug, since that's our main concern atm.
 
Last edited:
I edited some more items for destroying (dakmoon faire junkfood) and added support for golden carp/emperor salmon/krasarang paddlefish containers. works nice when angling jewel danio in vale of eternal blossoms for the pandaren banquet.

but now tidybags stopped opening sealed crates. using the grocery containers and destroying junks still works fine. i think the container part somehow overwrites the crate opening.

private HashSet<uint> _itemUseOnGoldenCarp = new HashSet<uint>() {
74866 // Golden Carp
};

private HashSet<uint> _itemUseOnEmperorSalmon = new HashSet<uint>() {
74859 // Emperor Salmon
};

private HashSet<uint> _itemUseOnKrasarangPaddlefish = new HashSet<uint>() {
74865 // Krasarang Paddlefish
};


private HashSet<uint> _itemRequiresSleep = new HashSet<uint>() {
61387, // Hidden Stash
67495, // Strange Bloated Stomach
67539, // Tiny Treasure Chest
72201, // Plump Intestines
87391, // Plundered Treasure (Luck of the Lotus Buff)
88496, // Sealed Crate (MoP version)
89613, // Cache of Treasures
90625, // Treasures of the Vale (Daily Quest Reward)
90716, // Good Fortune
90840 // Marauder's Gleaming Sack of Gold (World Boss gold drop)
};

private HashSet<uint> _destroyItems = new HashSet<uint>() {
45188, //Whitered Kelp
45189, //Torn Sail
45190, //Driftwood
45191, //Empty Clam
45194, //Tangled Fishing Line
45195, //Empty Rum Bottle
45196, //Tattered Cloth
45197, //Tree Branch
45198, //Weeds
45199, //Old Boot
45200, //Sickly Fish
45201, //Rock
45202, //Water Snail
19221, //Darkmoon Special Reserve
19222, //Cheap Beer
19223, //Darkmoon Dog
19224, //Red Hot Wings
19225, //Deep Fried Candybar
19299, //Fizzy Faire Drink
19300, //Bottled Winterspring Water
19304, //Spiced Beef Jerky
19305, //Pickled Kodo Foot
19306, //Crunchy Frog
21151, //Rumsey Rum Black Label
28284, //Don Carlos Tequila
44940, //Corn-Breaded Sausage
44941, //Fresh-Squeezed Limeade
73260, //Salty Sea Dog
74822 //Sasparilla Sinker

};

private static WoWItem emptyGoldenCarpContainer = null;
private static WoWItem emptyEmperorSalmonContainer = null;
private static WoWItem emptyKrasarangPaddlefishContainer = null;

public override void Pulse()
{
if (_init)
if (StyxWoW.Me.IsActuallyInCombat
|| StyxWoW.Me.Mounted
|| StyxWoW.Me.IsDead
|| StyxWoW.Me.IsGhost
) {
return;
}

if (InventoryCheck) { // Loot Event has Finished
uint goldenCarpCount = 0; // Golden carp count value
foreach (WoWItem item in ObjectManager.GetObjectsOfType<WoWItem>()) { // iterate over every item
if (item != null && item.BagSlot != -1) { // check if item exists and is in bag
if(item.Entry == (uint)87686){ // Empty Golden Carp Conatainer
emptyGoldenCarpContainer = item;
}
if (_itemUseOnGoldenCarp.Contains(item.Entry)) { // stacks of 60
goldenCarpCount += item.StackCount;
if (goldenCarpCount >= 60) {
if (emptyGoldenCarpContainer != null){
if (emptyGoldenCarpContainer.BagSlot != -1){
this.useItem(emptyGoldenCarpContainer);
} else {
emptyGoldenCarpContainer = null;
}
}
}
} else if (_destroyItems.Contains(item.Entry)) {
this.destroyItem(item);
}
}
}

uint emperorSalmonCount = 0; // Emperor Salmon count value
foreach (WoWItem item in ObjectManager.GetObjectsOfType<WoWItem>()) { // iterate over every item
if (item != null && item.BagSlot != -1 && StyxWoW.Me.FreeNormalBagSlots >= 1) { // check if item exists and is in bag and we have space
if(item.Entry == (uint)87680){ // Empty Emperor Salmon Container
emptyEmperorSalmonContainer = item;
}
if (_itemUseOnEmperorSalmon.Contains(item.Entry)) { // stacks of 20
emperorSalmonCount += item.StackCount;
if (emperorSalmonCount >= 20) {
if (emptyEmperorSalmonContainer != null){
if (emptyEmperorSalmonContainer.BagSlot != -1){
this.useItem(emptyEmperorSalmonContainer);
} else {
emptyEmperorSalmonContainer = null;
}
}
}
} else if (_destroyItems.Contains(item.Entry)) {
this.destroyItem(item);
}
}
}

uint krasarangPaddlefishCount = 0; // Krasarang Paddlefish count value
foreach (WoWItem item in ObjectManager.GetObjectsOfType<WoWItem>()) { // iterate over every item
if (item != null && item.BagSlot != -1) { // check if item exists and is in bag
if(item.Entry == (uint)87685){ // Empty Krasarang Paddlefish Container
emptyKrasarangPaddlefishContainer = item;
}
if (_itemUseOnKrasarangPaddlefish.Contains(item.Entry)) { // stacks of 20
krasarangPaddlefishCount += item.StackCount;
if (krasarangPaddlefishCount >= 20) {
if (emptyKrasarangPaddlefishContainer != null){
if (emptyKrasarangPaddlefishContainer.BagSlot != -1){
this.useItem(emptyKrasarangPaddlefishContainer);
} else {
emptyKrasarangPaddlefishContainer = null;
}
}
}
} else if (_destroyItems.Contains(item.Entry)) {
this.destroyItem(item);
}
}
}


InventoryCheck = false;
StyxWoW.SleepForLagDuration();
}
}
 
Last edited:
I edited some more items for destroying (dakmoon faire junkfood) and added support for golden carp/emperor salmon/krasarang paddlefish containers. works nice when angling jewel danio in vale of eternal blossoms for the pandaren banquet.

but now tidybags stopped opening sealed crates. using the grocery containers and destroying junks still works fine. i think the container part somehow overwrites the crate opening.
Looking at this (if it's all your code), you deleted the whole tidybags opening/combining/using code so no wonder it doesn't do the rest ^^
All that I see left here is the destroying code part and your baskets code.
 
Looking at this (if it's all your code), you deleted the whole tidybags opening/combining/using code so no wonder it doesn't do the rest ^^
All that I see left here is the destroying code part and your baskets code.

its just a part of the code. i only coppied the part i edited.


Edit: Here is the whole file. Maybe you can help me with it. Does everything fine but doesn't open the crates.

View attachment TidyBagsEdited.cs
 
Last edited:
its just a part of the code. i only coppied the part i edited.

Edit: Here is the whole file. Maybe you can help me with it. Does everything fine but doesn't open the crates.
As I said in my last post, you deleted all the on-use code from the Original tidybags...
Where in your edit file are the following 3 parts (which use the Original lists of TidyBags).
Code:
                        if (_itemUseOnFive.Contains(item.Entry)) { // stacks of 5
                            if (item.StackCount >= 5) {
                                this.useItem(item);
                            }
                        } else if (_itemUseOnTen.Contains(item.Entry)) { // stacks of 10
                            if (item.StackCount >= 10) {
                                this.useItem(item);
                            }
                        } else if (_itemUseOnOne.Contains(item.Entry)) { // stacks of 1
                            if (item.StackCount >= 1) {
                                this.useItem(item);
                            }
                        }
From the looks of it you replaced it with your fishing basket stuff (and just pasted it over the above part).
The destroying part works because you left that intact.
You will need to above as well to keep the old functionality intact.

On a sidenote I'm working on a groceries plugin for the baskets, but that's a work in progress.

Just edit this part:

private HashSet<uint> _itemUseOnFive = new HashSet<uint>() {
33567, // Borean Leather Scraps
72162 // Sha-Touched Leather
};
Thanks for helping your fellow botter.
tayfun369 is correct, just edit the file as he shown and it should work for your sha-touched leather.
I'm not adding this because it's profession related and not a general on-use for everyone (just leatherworkers can do this).
Not knowing leatherworking and having a few leathers would cause problems with the plugin.
 
Last edited:
Oh, i see what I did there. Blame on me. Would it be enough to add it in one of the container codes or must I add it in the code of all containers?

//Edit: I think i got it. Will try it when i got some time. Thank you again.
 
Last edited:
im getting some old mats, and i need 10 crystallized 'xxxx' but when i loot it goes to 9 and then starts a new stack, but will not make it into an eternal 'xxxx' even though i have more than 10 of them in my bags. any help?
 
dont works for me =(
Are you a leatherworker with the appropriate skill (hence the reason I don't add this to the Original).
im getting some old mats, and i need 10 crystallized 'xxxx' but when i loot it goes to 9 and then starts a new stack, but will not make it into an eternal 'xxxx' even though i have more than 10 of them in my bags. any help?
Would you consider a feature addition of stack management?
More than once I notice a lot of short stacks & if I move them all around I end up freeing up a slot or 2..
Used to be an "official" addon called Stacker that did it..old news though :-(
You mean a plugin for HB or a addon for WoW?
If you refer to a plugin, please link it to me so I can have a looksie.
There are still WoW addons that are up to date and perform this function, BankStack being one of them...
 
Zip Package updated on the first post to revision 3.6.1.9.

Revision 3.6.1.7: Added a different check to see if there's skinnables around. TidyBags will (hopefully) not run while skinning.
Revision 3.6.1.8: Added Marauder's Gleaming Sack of Gold and Pandaren Tea Set (Archaeology). Running a test with attachment to Loot Events for plugin to run. Added destroying of grey items (credits to Pasterke).
Revision 3.6.1.9: Added Cache of Mogu Riches (LFR Loot).

Due to lack of feedback on the possible fix since 3.6.1.8 for the skinning bug I decided to push this release on the first post instead of SVN Only.
Released v3.6.1.9 in the zip file and on SVN.

Destroying items:

Since v3.6.1.8 I've added destroying of items (you can thank Pasterke for the code).
If you open the file in your tekst editor, around line 355 you will see the list for destroying.
Currently it only contains grey items that you fish up:

Code:
		private HashSet<uint> _destroyItems = new HashSet<uint>() {
			45188, //Whitered Kelp
			45189, //Torn Sail
			45190, //Driftwood
			45191, //Empty Clam
			45194, //Tangled Fishing Line
			45195, //Empty Rum Bottle
			45196, //Tattered Cloth
			45197, //Tree Branch
			45198, //Weeds
			45199, //Old Boot
			45200, //Sickly Fish
			45201  //Rock
		};
Feel free to expand on this list, but keep in mind that on every update you will have to re-edit this back in (unless you use a SVN client, then you can merge your changes while updating).

I'm @ work for another 2 weeks so no regular answers on bugreports or other posts.
I'm hopefully leaving for Novara - Italy tonight trough Belgium, Luxembourg, France, Germany and Switzerland.
Normally a 1.5 day drive with the tanktruck, but with all the snow falling it's probably gonna cost me alot longer.

Have fun, LiquidAtoR.
 
dam this should be a wow addon... this is pissing me off even more when im not even botting.-.- !!!
 
How about a disenchant option ?^^
I have the Liquid Disenchant 3.0 Plugin but it wont work for me.

sry for bad English
 
Back
Top