[Plugin] TidyBags 3.0 Reloaded!

LiquidAtoR · Apr 14, 2013

laria said:
I see
Line 363: 89804, // Cache of Mogu Riches (LFR Loot)
Line 414: 89804, // Cache of Mogu Riches (LFR Loot)

this is duplicated, no idea why
On the other hand we are missing:

Cache of Mogu Riches - Item - World of Warcraft

The duplicate is a remnant when I moved items to the extra sleep version (due to lootlag of some BoP containers).

As I'm still at work, I'm not running LFR's, so I didn't see it yet.

Will try to run a few ID checks and update on SVN and attachment when I got most of them.
Am making my 24 hour break currently on a parking space in Holland.

Edit: Revision 3.6.3.4: Attachment + SVN - Changed the ID's to match the new 5.2 ID's for LFR bags (Thanks Laria for reporting 1 change).

The 5.2 patch has had it's item ID's on some containers updated because they now "Possibly" drop more items than before, and as far as I could run the checks only 3 ID's changed (the containers from the pre 5.2 MoP raids).
The new containers can now contain LFR level epic gear, battlepet stones and other 'valuables' besides the gold it contained before the changes in 5.2.

Zoke20 · Apr 14, 2013

I can't open the settings menu... any ideas.

finni · Apr 15, 2013

Zoke20 said:
I can't open the settings menu... any ideas.

same, anyone has a clue?

tumbum · Apr 15, 2013

finni said:
same, anyone has a clue?

there are no settings

LiquidAtoR · Apr 19, 2013

geekdude2001 said:
Hi could you please add Plundered Treasure (drops from Luck of the Lotus buff and Treasure Potions).

Code:

87391, // Plundered Treasure (Luck of the Lotus Buff)

Is already in there (and is in there for some time already)
Remember, after each next lootevent TidyBags performs it's trick.
Unless the ID has changed in patch 5.2 for this item?

Valpo · Apr 24, 2013

Hey LiquidAtoR,

Love the plugin. With my skinner/leatherworker, [Sha-Touched Leather] isn't being made in to [Exotic Leather].

Peace.

ubergoober · Apr 24, 2013

LiquidAtoR said:
Code:

87391, // Plundered Treasure (Luck of the Lotus Buff)

Is already in there (and is in there for some time already)
Remember, after each next lootevent TidyBags performs it's trick.
Unless the ID has changed in patch 5.2 for this item?

Not sure whats going on but WoWhead also lists the itemID# as 87391, but they still don't seem to be getting opened... I'm gonna look around to see if I can find a new ID#

ubergoober · Apr 24, 2013

Ok I just moved the

Code:

87391, // Plundered Treasure (Luck of the Lotus Buff)

from

Code:

private HashSet<uint> _itemRequiresSleep = new HashSet<uint>() {

to under the

Code:

private HashSet<uint> _itemUseOnOne = new HashSet<uint>() {

and now it works BEAUTIFULLY, not sure whats going on with the itemrequiressleep, but it doesn't seem to be working at all even for the other items listed under it

LiquidAtoR · Apr 25, 2013

ubergoober said:
Ok I just moved the

Code:

87391, // Plundered Treasure (Luck of the Lotus Buff)

from

Code:

private HashSet<uint> _itemRequiresSleep = new HashSet<uint>() {

to under the

Code:

private HashSet<uint> _itemUseOnOne = new HashSet<uint>() {

and now it works BEAUTIFULLY, not sure whats going on with the itemrequiressleep, but it doesn't seem to be working at all even for the other items listed under it

Probably moved too much around there ^^
As far as I remember it should be listed on both lists if there's a double sleep required (due to loot issues in the past with certain soulbound items).
Am home, but not yet settled back in after my working period.
In the next few days I can start running checks and quick updates if needed.
For now I have too much to do at home to get to anything else but reading a bit, posting here and there and check my email.

Edit: Reverted the deleted items from the initial list.
Revision available from SVN and attached to the first post as well.
Revision 3.6.3.5: Attachment + SVN - Cleaned up to much without able to test it, thanks ubergoober for pointing it out.
Edit2: Also added the Stormtouched Cache from Nalak to SVN and Attachment.
Revision 3.6.3.6: Attachment + SVN - Added Stormtouched Cache (Nalak World Boss Consolidation Loot).

laria · May 25, 2013

94296, one more thing to add

Proto · May 27, 2013

LiquidAtoR,

After your release of ver v3.6.1.3 I had been editing the plugin on my own, adding some items I found missing when MoP released. Now with 5.3 out, there were a few more items to be added.
So, I finally checking back into your thread and found that you'd been busy with several updates of your own.

Here are a few things I added to your old 3.6.1.3, that you may wish to add to your ongoing project..

First off in your "StackCount" section of code I added support for 3 count stackable items, such as older enchanting shards.

Code:

            if (sw.Elapsed.TotalSeconds > 1) { // throttle to 1s
                foreach (WoWItem item in ObjectManager.GetObjectsOfType<WoWItem>()) { // iterate over every item
                    if (item != null && item.BagSlot != -1) { // check if item exists and is in bag
                        if (_itemUseOnThree.Contains(item.Entry)) { // stacks of 3
                            if (item.StackCount >= 3) {
                                this.useItem(item);
                            }
                        } else if (_itemUseOnFive.Contains(item.Entry)) { // stacks of 5
                            if (item.StackCount >= 5) {
                                this.useItem(item);
                            }
                        } else if (_itemUseOnTen.Contains(item.Entry)) { // stacks of 10
                            if (item.StackCount >= 10) {
                                this.useItem(item);
                            }
                        } else if (_itemUseOnOne.Contains(item.Entry)) { // stacks of 1
                            if (item.StackCount >= 1) {
                                this.useItem(item);

Add for ItemUseOnThree

Code:

        };

        private HashSet<uint> _itemUseOnThree = new HashSet<uint>() {
            		74252, // Small Ethereal Shard
            		52720  // Small Heavenly Shard

Add for ItemUseOnTen (6 new Herbalism scrap items introduced in MoP 5.3. These are dropped when attempting to gather at below the required skill level for the herb node.)

Code:

        };

        private HashSet<uint> _itemUseOnTen = new HashSet<uint>() {
            		97619, // Torn Green Tea Leaf
            		97620, // Rain Poppy Petal
            		97621, // Silkweed Stem
            		97622, // Snow Lily Petal
            		97623, // Fool's Cap Spores
            		97624  // Desecrated Herb Pod

That's all I've done that you had not already done yourself on subsequent patches. Nice work!

Thanks,
Proto

DomesticWarlord · May 28, 2013

You may want to add the following into itemUseOnTen if you're a miner.

Code:

			97512, // Ghost Iron Nugget

kavlantis · May 30, 2013

Zamphire said:
You may want to add the following into itemUseOnTen if you're a miner.

Code:

97512, // Ghost Iron Nugget

Any chance u update the plugin to add ALL new pandaria petals plus the nugets also?

LiquidAtoR · Jun 1, 2013

Just came home after my 3 week working period so I can start looking into changes.
I didn't even get to see, play or feel the 5.3 patch yet, let alone download it

Will see for changes, concistencies, updates and other stuff as long as it's a neutral item (so it doesn't conflict with not having a certain profession).

Expect a update in the next few days when I'm settled in again @ home.

LiquidAtoR · Jun 2, 2013

Proto said:
LiquidAtoR,

After your release of ver v3.6.1.3 I had been editing the plugin on my own, adding some items I found missing when MoP released. Now with 5.3 out, there were a few more items to be added.
So, I finally checking back into your thread and found that you'd been busy with several updates of your own.

**SNAP**

Thanks,
Proto

You are way behind in updates my friend

I've added your UseOnThree part in the latest release (SVN atm, I have to repack it for the forums), and took the liberty to properly expand on that list (with all the old enchanting items).
I can't test unfortunately as I ran out of gametime to just check the compiling in HB itself.
I will get some in the next few days, just don't have the time yet to sit and play.
Anyways I need to get a new mouse first, the old one magically broke after my son had it for a day

Zamphire said:
You may want to add the following into itemUseOnTen if you're a miner.

Code:

97512, // Ghost Iron Nugget

Added to the last release together with the other item (the Kyparite Fragment).

kavlantis said:
Any chance u update the plugin to add ALL new pandaria petals plus the nugets also?

Yes, latest release has it all (at least I hope it does have it all).
Many new items, old items with new ID's and new drops have been introduced in patch 5.3
I've read trough many patch files and I hope I have most (if not all) the new ID's referenced in the plugin.
Also catched a few items that are separated in ID's with Alliance and Horde factions (and no horde players here complained, haha).

Am updating the SVN now, then I do the first post and get a changelog ready here.

Revision 3.6.3.7: Attachment + SVN - Added 5.3 items to the on-use lists (request by Proto, Zamphire and Kavlantis), Added a UseOnThree part (suggestion by Proto), Added *****ed Primal Egg (request by Laria), Added Kyparite Fragment, a few new ID's for older items and a all new Heroic Cache (Heroic Scenario Reward), Added the Gold container rewards for the Brawler Guild Fights, Separated Alliance and Horde reward ID's and a few more things I forgot to document.

Please do be aware this release is untested due to my gametime being expired on my account (I will get more time when I have time to play).
So if there's any bugs please be as clear as possible (if any post the line it occurs).
Thanks!

Edit: Presuming noone complained I take it this works

Proto · Jun 9, 2013

LiquidAtoR said:
You are way behind in updates my friend
I've added your UseOnThree part in the latest release (SVN atm, I have to repack it for the forums), and took the liberty to properly expand on that list (with all the old enchanting items).

Brilliant! I had not considered those other 3 stack enchanting items you've added. Works like a charm. And thanks so much for the SVN. No more manual personal updates for me, because I'm too lazy to get on the forum and download the latest zip. I'll leave the updates to you from now on my friend

klepp0906 · Jun 10, 2013

So is the directory structure supposed to be HB>Plugins>TidyBags>Trunk>TidyBags>TidyBags.cs ?

I have a feeling its not and if this is the case either your SVN link is wrong, or you cant update via SVN without having to move a buncha junk afterwards.

What am I missing?

Don't have this issue with other svns so im betting its that github crap! >.<

LiquidAtoR · Jun 11, 2013

klepp0906 said:
So is the directory structure supposed to be HB>Plugins>TidyBags>Trunk>TidyBags>TidyBags.cs ?

I have a feeling its not and if this is the case either your SVN link is wrong, or you cant update via SVN without having to move a buncha junk afterwards.

What am I missing?

Don't have this issue with other svns so im betting its that github crap! >.<

Nope, it's not the github crap.
Structure is wrong as you already suspected.

Should be HB > Plugins > TidyBags > TidyBags.cs

When you checkout, you can browse the structure and checkout what you need (and not the whole thing).
At least with TortoiseSVN it does for me.
I have a few SVN's also from other people where I don't want the root, but a subpart of the SVN.

tumbum · Jun 11, 2013

Any chance to get in Option to set On/Off for Skinners/Leatherworker to put the Scraps together while Farming?

LiquidAtoR · Jun 11, 2013

tumbum said:
Any chance to get in Option to set On/Off for Skinners/Leatherworker to put the Scraps together while Farming?

Just add them to your local copy?
A SVN checkout shouldn't delete what you add in there yourself (that is if you have it set to merge ofcourse).

[Plugin] TidyBags 3.0 Reloaded!

Community Developer

New Member

Member

Active Member

Community Developer

Member

New Member

New Member

Community Developer

Well-Known Member

New Member

Community Developer

New Member

Community Developer

Community Developer

New Member

Active Member

Community Developer

Active Member

Community Developer