Shaddar,
First of all i want to thank you for this awesome CC and all the work done by you.
I'm a bit of a novice playing warrior so i'm gonna ask you a few questions, is it normal that when the boss is at less than 20% the bot spams execute ? Shouldn't the rotation be execute till 5 charges of executioner then on open gcd (normally used for slam) or when buff is nearly expiring ? Maybe i wasn't paying attention and the boss didn't last that much longer while at < 20% and i freaked out.
Other thing, the conditional on Pummel isn't working. Since the bot tried to pummel a physical cast or something like that (a boss cast, like murazond's, you know what i mean)
Good work Shaddar
P.S: Please don't think bad of me i'm just trying to help improving the CC.
Something I was going to start looking into for interrupts Shaddar is how I could make a DB that listed all the spells that matter for interrupts and have it only pummel on those spells.
As for execute phase, yes. To theoretically min max your rotation you would Execute to 5 stacks then continue your normal rotation only using execute to keep stacks up or as a filler (in place of slam). I have been looking for a way to detect debuff stacks to use with Sunder Armor on Titan Shields and this could also be applied to Executioner.
Yeah, the stack issue is a small problem and shouldnt be a problem to implement.
However listing spells for interrupts is preferably done for PVP, however its better to search for some other code for PvE as you cannot list every single interruptable spell to the list.
Right, I wouldn't want to list every spell that's possible to interrupt, only the ones that matter in raids and heroics.
One solution could be removing pummel completely from the rotation, since this is going to be used with LazyRaider i guess people can press the key to interrupt.
I'm guessing if people had like a window where they could configure what Spell ID the CC would pummel or not, and some nifty stuff like that... i don't know if the time/reward of doing that is worth it.
By the way Shaddar, is the CC waiting for 3 stacks of Lambs to the Slaughter to pop CDs? And is it using Bladestorm as a single-target DPS ability?
Also... The ability to configure an hotkey to swap between single-target rotation and aoe rotation would be so badass... more control to the user over the CC. Not trying to diss your amazing AOE target detection.![]()
As I said before in the PM, I will do some excessive testing with V2.1 and suggest some changes later on. Unfortunately I'm quite busy today so it'll probaly be tomorrow late in the evening. Overall its an awesome job so far Shaddar, and this will be the best amrs cc out there for a long while!
Ps; I assume you're still working on stancedancing?
Alrighty, focus on your primary's first. Maybe I can check stancedance using the macro. Will let you know.Stance Dancing havent been my number one focus lately as i have to update all of my profiles to the new add detection code + debuff code.
I've got alot of work ahead of me as ive promised to update and fix Pyromancer and Bowman. And silly me even said i could update this one today aswell!
But yes, ill do my best to find time for stance dancing
I don't think stance dancing is worth it at the moment. And in a programmer's standpoint i think it's easy to program that. I'm gonna try to figure out how the CC is coded and make some suggestions code-wise.
Like i said before it's an awesome CC and Shaddar did a great job.
UpdateUpdate is to be expected 11.01.2012 between 05am - 08am; 1+ GMT.
Plans:
Use cooldowns at bosses only
New and improved execute phase
Pummel change/removal
Stance Dance if possible(dont get your hopes up to soon! not releasing a version with Stance Dance unless it works properly)
Will also be looking for other solutions to improve the DPS.
- Shaddar
if i may ask, dancing only requires you to be in zerker stance for slams and mortal strikes so how were you implementing it in your tests?Update
It now uses cooldowns at bosses instead of at X.HP. Only exception is Deadly Calm.
Improved execute phase. (new rotation).
No pummel/Charge/leap change as of yet.
Other small changes has been done aswell.
Stance dance has been tested out, it works decent but because of the constant Overpower proc it becomes unstable and forgets to cast mortal strike.
I will most likely not be looking into stance dancing again, unless some magic code appears.
I would like everyone to say whether they want Pummel/Charge/Leap in the next update or not.
As this is a lazyraider CC i understand if you want it removed, although its up to you guys.
- Shaddar
if i may ask, dancing only requires you to be in zerker stance for slams and mortal strikes so how were you implementing it in your tests?
I was making it berserker stance for all spells except overpower and rend actuallyand that never turned out well.
if (PlayerHasBuff("Taste for Blood") && !Me.HasAura("Battle Stance"))
{
if (CastSpell("Battle Stance") == true)
{
Logging.Write(Color.Aqua, "## Battle Stance ##");
}
}
if (!PlayerHasBuff("Taste for Blood") && TargetHasDebuff("Rend") && !Me.HasAura("Berserker Stance"))
{
if (CastSpell("Berserker Stance") == true)
{
Logging.Write(Color.Aqua, "## Berserker Stance ##");
}
}