Lemmi, Best to post them in the forum. Happy to look at any and all suuggestions. Be sure to attach a complete log with your post. -Bobby53
Hey! so. i don't know much about programming but after lurking the ccs trying to understand and comparing between different routines over the forums i have some basic understanding of what most lines mean, at least when it comes to the castings and some conditions, i even played around and made a custom but ended up breaking it (for example my mage wouldn't cast frostfire bolt with brain freeze, ever), so i think it would be better to let someone who really knows what he is doing do the job and help the community
.
The basic problems i found in this profile for pvp are.. first, the way it wastes a lot of deep freezes when he should be doing a good ol' powerfull shatter combo, i found several problems.
One is that being set in the common.cs to cast ice barrier, and the same with incanter's ward if under attack, on cd, it would often cast it after deeping the target instead of laying the law and pummeling some bastard ass. I would propose to put some conditions to not cast if the target is frozen or deeped. (i don't remember if it was an issue with this cc and i fixed it or was another cc, but also don't let it cast ring of frost to DFrozen targets) (the same is true for spell steal but i don't remember this CCs behaviour with it)
The second problem with wasted deeps is similar but with frost bomb, as he wants to cast it on cd he often find it is a really good time to do it when the target is deeped, and thus the bomb explodes after it expires (Note that if i was talented in living bomb or nether tempest i would want to cast the bomb on the frozen target as the incresed critical and damage stay for the whole duration of the bomb). I would propose that in the routine there should be a priority check starting with if the target is deeped he should change the routine to a shatter combo, by this i mean a combinations of frostbolt and icelance instantly after. Normally 1 frostbolt and 2 ice lances fit the deep duration without icy veins, with this buff 2 frostbolts and 1 icelance is posible and do better damage. He could decide to cast frostbolt or icelance depending on the duration of the deep freeze remaining on the target, something like If duration remaining > 2 seconds cast frostbolt, else icelance.. though maybe checking may take time and not instantly cast the ice lance after the bolt not being able to cast the second IL (this happened to me when i tried, i got some code from an old routine i found in the forums and adapted it to this CC, i could paste the line here if you want) and would be better to optimize damage to just have a pre defined sequence of FB-IL-IL and FB-FB-IL (maybe another IL) if i'm buffed with Icy veins or Bloodlust-heroism-timewarp.
The third problem, though i believe it would be fixed with the above change, is casting frostfire bolt in frozen targets, something unnecesary in mop since brain freeze now treats the target as frozen, a little more damage but a waste of frozenness (the word exists! i swear!).
Fourth would be casting pet freeze on deeped targets, but this started, i think, after i added frozen orb into the rotation with which it would DF the target, it gives 1 finger of frost charge when it reaches a target. It would be really usefull if it was smart enough to check the status of the target and not waste it. This smarter use could open the posibilty of new shatter combos (FB-IL) outside the DF, but is more complicated as it could mess the opening, you could allow the casting of Fbomb or frozen orb, so you don't delay them that much, and maybe shields if needed. Maybe i would leave it alone for now, and experiment with it after all the changes settle.
Another issue is that frozen orb is absent from the rotation, and yes i mean single target. This spell is a beast and should be casted on cd especially if the target is about to be frozen as the damage is really high, even in single target, and the procs it gives are a blessing. I took from.. king-wow i think, this line to make it work, don't know if it's really necesary for it to be exactly like this, but it works:
Spell.Cast("Frozen Orb", ret => Unit.UnfriendlyUnitsNearTarget(10f).Count() >= 1)
Something else that could be very useful is to enable the cc to detect if it has cold snap as a talent and use it everytime after an Ice block, maybe through the detection of Hypothermia, the cooldown or just a casting sequence after block. The talent is basically giving block 2 charges and a small heal, so its always best to use it right after a block.
Last, if you want to go far with optimiation, you could allow it to cast Fireblast if the bot is moving, doesn't have any cast on the move buffs, and no finger of frost or brain freeze procs, as it is the "hardest" hitting ability available.
Well, to give some sort of clearer view of what i mean, this would be, kind of, the order i would use (excluding pet freeze as it is more tricky and would leave it as it is right now):
If it is a priority check it should restart everytime any of the actions is completed right? not sure how it works.
- Check if target has Deep Freeze, if it is, change sequence and cast shatter combo until it expires, else keep going.
- Cast Frost Bomb
- Cast Frostfire Bolt if i have Brain Freeze buff.
- Cast Frozen Orb.
- Cast Deep Freeze if the target is frozen (nova'ed) or i have a Finger of Frost.
- Cast Ice Lance if i have Finger of Frost, and considering no changes to pet freeze behaviour, or the target is frozen.
- Cast Fire Blast on movement.
- Cast Ice Lance on movement.
- Cast Frost Bolt
And don't cast shields or spellsteal when the target is deeped!
I think this is all for now, maybe i forgot something, will check later.
Hope you consider this changes and they are helpful! I will check later if you have any questions.
