Howdy,
Firstly, nice work on ProfessionBuddy, it's an amazing tool.
I've been having some issues with it sending mails, and after stepping through the code, found it's a timing issue (it's calling SendMail a little too early and the client isn't actually sending the mail).
I know this because I added extra debugging to verify the SendMail was actually getting called, and with what parameters, and then called it manually and it sends.
This may be related to the optimisations done to HBCore of late, causing things to run slicker and quicker than they have before?
Anyway, I've modified MailItemAction.cs to fix the issue, and hopefully you're happy to commit.
This is the section that's calling SendMail too quickly
Code:
if (_itemList.Count == 0)
{
Professionbuddy.Debug("Sending any remaining items already in SendMail item slots. Mail subject will be: {0} ",_mailSubject);
Lua.DoString(
"for i=1,ATTACHMENTS_MAX_SEND do print(\"GetSendMailItem:\"..GetSendMailItem(i)) if GetSendMailItem(i) ~= nil then print(\"Sending. To {0}. Subject: |{1}|\") SendMail(\"{0}\",\"{1}\",'') end end ",
CharacterSettings.Instance.MailRecipient.ToFormatedUTF8(),
_mailSubject != null ? _mailSubject.ToFormatedUTF8() : " ");
Professionbuddy.Debug("Done sending mail");
IsDone = true;
return RunStatus.Failure;
}
My updates are as follows:
Declare a new Stopwatch in the class:
Code:
private readonly Stopwatch _itemAttached = new Stopwatch();
Just below the existing _itemSplitSW Stopwatch check, add the new one, so returns to the tree walker if running and reads as
Code:
if (_itemSplitSW.IsRunning && _itemSplitSW.ElapsedMilliseconds <= 2000)
return RunStatus.Success;
if (_itemAttached.IsRunning && _itemAttached.ElapsedMilliseconds <= 2000)
return RunStatus.Success;
When we've removed an item from our internal list, ensure we trigger the stopwatch:
Code:
if (done)
{
Professionbuddy.Debug("Removing item from list...");
_itemList.Remove(itemID);
_itemAttached.Reset();
_itemAttached.Start();
}
(I guess the stopwatch could be started from elsewhere, as this may delay between adding items, but this is tested and working).
Hope it helps!
