ok i got to test and raid v04 quite a bit with a lot of guesswork changes i made. v05 looks great, big thanks for all your work on this. ill make some comments for PVE serious raiding only (ie not afking LFR while doing minimal dps / ignoring mechanics)
- relax requirements for auto shadowdance, its not going off very often, it needs to go off every 60 sec pretty much. lowering the "StyxWoW.Me.CurrentEnergy > 75" requirement would work, or maybe something else. this also tends to start SD just as you get full 5 CPs, which is not good. pooling energy that high good in theory for human players but the bot ends up not triggering dance waaaay longer than any human would.
- dont autostealth, it screws with trying to prepot on countdown to pull. actually you just dont want to spend a 4 hour raid getting stealthed 1000 times
- add energy reqs for spammed abilites, eg ambush: && StyxWoW.Me.CurrentEnergy >= 40
- not sure if various CreateCombatRogueDefense abilities work in raid but if so they need to be disabled. same with feint for threat. obviously you cant blow cloak on low HP or some boss spell cast, and feint is used manually in most fights for raid damage and on HM morchok and Ultraxion so the raid doesn't instawipe
- never FoK no matter how many adds
sub has no aoe.
- i *think* you already have this programmed: you want shadowstep to go off AFTER the first ambush of each shadowdance, like on the 2nd or even 3rd ambush (so that find weakness is up)
- auto vanish: is shadowdance not on CD a requirement? shouldnt be. (this line: SpellManager.Spells["Shadow Dance"].CooldownTimeLeft().TotalSeconds <= 0). you just want SS cd to be up, no Find weakness of master of subtlety up, and of course not in middle of dance.
- i dont think auto vanish works reliably atm - ambush often doesnt go off i think because the bot instantly continues to autoattack unless i go out of melee ranges first. in any case i think most serious raiders will want to control vanish manually since you can't have the bot shadowstepping somewhere at some crazy time, same as you can't put killing spree on auto if you dont want to die every other boss. In that case there needs to be some kind of FULL STOP put into the CC for that aura if possible after manual vanish. not sure if it can be done - HB /LazyRaider seems to want to continue attack after vanish.
- hemo logic doesnt work, it spams it in between backstabs, sometimes every 5 sec, i think due to "// Only used if we don't have Backstab / can't Backstab
Spell.Cast("Hemorrhage", ret => (StyxWoW.Me.ComboPoints < 5 && StyxWoW.Me.CurrentEnergy > 90) || StyxWoW.Me.ComboPoints < 4)," line and BS pooling to 80 nrg being interpreted as "can't backstab". it seems like it should work but doesn't, so i changed that line and now it never hemo's unless bleed is down or we are in front
- Energy often caps at 100 waiting for 5th CP (might be less of an issue in raids), should have something to force BS at 95 or so.
- you'll need auto tricks of some sort, to focus, ToT, or manually set target. its a huge pain trying to tricks manually thru spammed abilities.
im attaching my file, obviously it's not meant as a replacement or next version its just to show what i changed to get raiding. (all done thru common sense / guesswork, i dont know programming)
for the manually done abilities, I use a dance macro that also triggers glove synapse springs (engi enchant), and a premed/SS/ambush macro to use after manual vanish (i also have to get out of range before vanishing since bot continues autoattack). the "// PVE Vanish Abilities" section of the CC will also do that automatically for those that want.
anyone know how to detarget / change targets with lazyraider? i have targeting to off in settings, but whacking ESC key doesnt stop the bot from instantly reaquiring target, and it does that if you mouse-target a friendly player too. this is really nasty in raids as often i need to stop dps, or not hit adds on the way to running someplace, or click on grid to target some player (eg to change focus). Don't know if its an HB / LazyRaider or CC issue, but if anyone knows some setting or plugin that will stop the bot from forcing targeting in combat would be awesome. if i hit ESC i want it to stay not targeted.
EDIT: as for engi glove enchants
http://www.thebuddyforum.com/honorbuddy-forum/classes/rogue/36443-apsalara-singular.html had them going off on CD. you can see the code in its subtlety.cs and common.cs. if you add some kind of a shadowdance aura requirement it should then only trigger every shadowdance.
new PrioritySelector(
Commons.CreateUseHandsEnchant(),
and in common.cs
public static Composite CreateUseHandsEnchant()
{
return new Decorator(
ret =>
Settings.UseHandsEnchant &&
Me.CurrentTarget.IsWithinMeleeRange,
Item.UseEquippedItem(9)
Really interested to see how it behaves.
