ShamWOW for HB2 - An Enhance/Elemental/Resto + PVP/RaF Healbot by Bobby53

[verythaiguy]

Couple other issues: First, shamanisticrage no longer restores mana... so I think we can remove the if statements before casting shamanisticrage in combatmelee() functioN: Also, it was not setting totems before casting stormstrike, earthshock(), etc. I think it has something to do with combatchecks(), but not sure. Here's my followign revised code with everything working perfectly. One other thing.. why don't we just use CombatMeleePVP() instead of combatmelee(). It seems to have all the below fixed and working....:

// use Shamanistic Rage when our mana is low and mob we are fighting has
// .. a lot of health left. Since it gives mana back for
//if (_me.ManaPercent < _cfg.ShamanisticRagePercent )
//{
// if (IsFightStressful() || (countEnemy > 1) || (_me.GotTarget && _me.CurrentTarget.HealthPercent >= 75))
// {
ShamanisticRage();
//}
//}

// for Enhancement: make first set of totems high priority
// if (!TotemsWereSet() && combatChecks() && AllowNonHealSpells())
if (!TotemsWereSet())
{
SetTotemsAsNeeded();
}

 

[verythaiguy]

One last thing I promise: Now that lava lash is far more powerful in the advent of this patch, should we not immediately cast LavaLash() right after StormStrke().. especially before EarthShock()? Sure I know that Stormstrike causes nature spells to do more dmg, but this should pale in comparison to the new dmg given to Lavalash and on top of it all the extra talents and glyphs we can get to improve it....

 

[ekimbo]

Hey bobby, could you please make it to work with Instancebuddy, i mean i have ele/resto spec, and could it choose the right spec and heal /dps when its needed? Thanks for answer.

 

[richarddoran]

Hey bobby, could you please make it to work with Instancebuddy, i mean i have ele/resto spec, and could it choose the right spec and heal /dps when its needed? Thanks for answer.

I just tested this. I dual specced ele/resto, and qued as both, and did 2 instances, one as healer, other as DPS, and the correct spec was chosen each time automatically. I like ele/resto cause the gear is mostly the same, and currently, IB won't "need" on items outside of your current spec, so if your main spec was enhance, but you healed the instance, and the BiS enh item drops, you will still DE/Greed it.

 

[ekimbo]

ye, but what should i choose, i mean, combat only, heal only, heal over dps ? Coz if i choose heal over dps, as dps, it heals all the time and low dps.

 

[whinnie]

got this whilst using IB it more or less stopped any heals being cast, i was set to healing only in instances

[11:05:47:29] >>> HB EXCEPTION in SpellManager.Spells[Healing Surge]
[11:05:47:29] >>> Spell 'Healing Surge' believed to be UNKNOWN was used
[11:05:47:29] System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.
at System.ThrowHelper.ThrowKeyNotFoundException()
at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
at ShamWOW.ShamWOW.Safe_CastSpell(WoWUnit unit, String sSpellName, SpellRange chkRng, SpellWait chkWait) in c:\Users\Lee\Desktop\Honorbuddy_devtest\CustomClasses\ShamWOW\Shaman.cs:line 934
[11:05:47:29] EXCEPTION in Combat() - HonorBuddy API or CC Error
[11:05:47:30] System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.
at System.ThrowHelper.ThrowKeyNotFoundException()
at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
at ShamWOW.ShamWOW.Safe_CastSpell(WoWUnit unit, String sSpellName, SpellRange chkRng, SpellWait chkWait) in c:\Users\Lee\Desktop\Honorbuddy_devtest\CustomClasses\ShamWOW\Shaman.cs:line 944
at ShamWOW.ShamWOW.HealPlayer(WoWPlayer p) in c:\Users\Lee\Desktop\Honorbuddy_devtest\CustomClasses\ShamWOW\Shaman.cs:line 6693
at ShamWOW.ShamWOW.HealRaid() in c:\Users\Lee\Desktop\Honorbuddy_devtest\CustomClasses\ShamWOW\Shaman.cs:line 6522
at ShamWOW.ShamWOW.CombatLogic() in c:\Users\Lee\Desktop\Honorbuddy_devtest\CustomClasses\ShamWOW\Shaman.cs:line 3116
at ShamWOW.ShamWOW.Combat() in c:\Users\Lee\Desktop\Honorbuddy_devtest\CustomClasses\ShamWOW\Shaman.cs:line 3073


Dont know if its something to do with trying to cast heals the char doesnt yet have, level 16

 

[Daydreamer]

ye, but what should i choose, i mean, combat only, heal only, heal over dps ? Coz if i choose heal over dps, as dps, it heals all the time and low dps.

It still heals you in combat mode, it will just focus on combat more

 

[Daydreamer]

I love this CC! It's so amazing!

 

[Lockwood]

Bobby I'm finding it refreshes the weapon enchants every 1 or 2 kills along with lightning shield.

Anyway to just make it refresh when it runs out? Slowly down the bot considerably.

 

[bobby53]

here it is.

Thanks for the log file tozededao. I know the healing spell selection is a big concern as indicated in several of your posts, so I committed an inordinate amount of time to the analysis of this one than I can typically afford. I parsed the log file and reviewed in detail the ebb and flow of mana % levels both in and out of combat.

In the 1 hour 2 minutes of recorded use, the low-mana levels all appeared to have stemmed from beginning instances at 0.0% mana due to a Talent Group change. For example, the lowest mana value at the end of any combat sequence was 12.8% at [8:05:11 PM:784], but that fight sequence was begun with only 47.7% mana (representing only 34.9% used in fight) due to the spec change issue above. The 0.0% mana at spec change was exacerbated by not having the configured Filtered Draenic Water in inventory.

Based upon this, I don't see the current healing spell priorities being in need of a overhaul. That doesn't mean changes aren't needed, but they aren't indicated by this log file.

User Recommendations from this analysis:
1. Avoid spec changes to Resto if possible. Groups often start immediately upon dungeon entry without checking mana levels, etc. resulting in initial combat sequences requiring healing while having dangerously low initial mana levels.
2. Keep drinks in inventory, so between combat the character is sitting down drinking when needed. This isn't just for the actual mana regen (which is important), but also for the visual cue it gives the tank that the healer is not ready to begin.

Changes to look at for ShamWOW:
1. Need to revise behavior when stopped to drink and no water in inventory. Currently posts a message saying out of drinks and stands in place till reaching the configured mana %, but if tank moves early need to follow. IB will attempt to force following tank when drinks are in bag by canceling the buff, but doesn't appear it can in the no drink situation.
2. Consider using mana potions Out of Combat when no drinks are available.
3. Consider using Mana Tide or Mana Stream when Out of Combat. These however cost mana if not already existing, so if the tank leaves it could result in less mana due to not having regenned the cost of the cast yet.
4. Look at issuing a party message when Healing and mana goes below Emergency Mana level. This may reduce tanks leaving quickly.

Thanks for the log file. The items listed as to do's for the CC development could not have been determined without it. Thanks again, Bobby53

 

[bobby53]

For some reason it's never casting lava lash.... I do not have the talent improved lava lash... and even if I did, I feel that fights are done way to quickly to warrant making the default logic such that you only cast lava lash after 5 applications of searing totem.... Can you put an option in the gui fo rthis so we can disable it if we want? But still, I do not have the talent so it shouldbe casting lava lash normally, but it doesn't .

verythaiguy, My apologies for any issue you may be having. Please see the ShamWOW FAQ [link -- click here] which is post #2 in this thread for information on the details needed when posting about issues with ShamWOW. I am not experiencing the issue described and don't have enough detail to try and duplicate it. I will need a complete debug log file to look into this further for you. Thanks for your help, Bobby53

 

[bobby53]

I think i might have found the bug to lavalash not being cast: If you look in the CombatMelee() function notice the following:
if ( IsStormstrikeNeeded() && Stormstrike())
return;
if (EarthShock())
return;
if (Stormstrike())
return;
I think you actually meant Lavalash instead of that second StormStrike() check? If not, there is no other reference to lavalash in the combatmelee(). There is on the otherhand one for pvpcombatmelee but not for the former combatmelee().

No, the above code is as intended and matches a SS_0 > ES > SS priority.

 

[Liferose]

So far from 1-37 (and a 1/4th) this cc has worked wonders on my elemental shaman..

 

[bobby53]

Couple other issues: First, shamanisticrage no longer restores mana... so I think we can remove the if statements before casting shamanisticrage in combatmelee() functioN: Also, it was not setting totems before casting stormstrike, earthshock(), etc. I think it has something to do with combatchecks(), but not sure. Here's my followign revised code with everything working perfectly. One other thing.. why don't we just use CombatMeleePVP() instead of combatmelee(). It seems to have all the below fixed and working....: // use Shamanistic Rage when our mana is low and mob we are fighting has
// .. a lot of health left. Since it gives mana back for
//if (_me.ManaPercent < _cfg.ShamanisticRagePercent )
//{
// if (IsFightStressful() || (countEnemy > 1) || (_me.GotTarget && _me.CurrentTarget.HealthPercent >= 75))
// {
ShamanisticRage();
//}
//}

// for Enhancement: make first set of totems high priority
// if (!TotemsWereSet() && combatChecks() && AllowNonHealSpells())
if (!TotemsWereSet())
{
SetTotemsAsNeeded();
}

verythaiguy, Thank you very much the interest and support. Shamanistic Rage no longer regens mana, but instead conserves it. I absolutely agree that with the current mechanic it should likely be cast off of cooldown in almost all situations so removing the conditional logic is reasonable. However, the glyphed behavior for Enhancement allows Shamanistic Rage to also cleanse Magic off the Shaman. Setting to Shamanistic Rage to cast at a lower Mana % would allow the ability to be preserved for use in response to the need for cleansing. I don't know specifically when that would be needed, but since I can change the default Mana % to 100 and achieve the same thing as removing the if statements it while still preserving the ability to account for the other specific use I'll leave it. So look for the default to be set to 100% in the next release. Thanks again for your post, Bobby53

Edit: Next version of ShamWOW will store the CC version that the .config file was created with, so upon load will automatically upgrade/update .config values as needed. Beginning with the next release, it will automatically update ShamWOW config files created prior to version 4.2.05 so ShamanisticRagePercent is 100%.

 

[bobby53]

One last thing I promise: Now that lava lash is far more powerful in the advent of this patch, should we not immediately cast LavaLash() right after StormStrke().. especially before EarthShock()? Sure I know that Stormstrike causes nature spells to do more dmg, but this should pale in comparison to the new dmg given to Lavalash and on top of it all the extra talents and glyphs we can get to improve it....

verythaiguy, Great point! +rep. I had been thinking the same thing. The current rotation is an initial pass. As a raiding rotation where fights last more than a few seconds it appears solid at this point. In WOW 3.x, the same rotation served Enhancements well while both leveling and raiding, but in WOW 4.x the briefer encounters will require a slightly different approach. I'll look at the priority change you mentioned for 15 second bursts and compare the results. Thanks for the feedback, Bobby53

 

[bobby53]

Hey bobby, could you please make it to work with Instancebuddy, i mean i have ele/resto spec, and could it choose the right spec and heal /dps when its needed? Thanks for answer.

Ekimbo, My apologies for any issue you may be having. ShamWOW does work with InstanceBuddy. Talent Group changes are initiated by InstanceBuddy, not ShamWOW so if your issue is related to that please post in the InstanceBuddy thread. Otherwise, please see the ShamWOW FAQ [link -- click here] which is post #2 in this thread for information on the details needed when posting about issues with ShamWOW. I don't have enough detail to duplicate your issue and need a complete debug log file to look into this further for you. Thanks for your help, Bobby53

ye, but what should i choose, i mean, combat only, heal only, heal over dps ? Coz if i choose heal over dps, as dps, it heals all the time and low dps.

You should leave it at the default for RaF Combat Style, which is Combat Only. If you enter an instance and InstanceBuddy changes the role to Healer and respecs you as Resto, it knows that you are a healer and treats this as Healing Over Combat. If you enter it as DPS, then it uses the actual settings which is Combat Only and you get the dps results you want.

I'll look at making a change to the user interface so this behavior is more clear. When in doubt however there is one key premise that should always work with ShamWOW. It is designed as a zero-config CC, meaning you should not have to change anything to get it to recognize your config and work well in any situation. So when in doubt, delete the .config file and let it use the defaults.

 

[bobby53]

got this whilst using IB it more or less stopped any heals being cast, i was set to healing only in instances
-- log cut/paste removed for space --
Dont know if its something to do with trying to cast heals the char doesnt yet have, level 16

Whinnie, My apologies for your issue and thank you very much for your post. I typically need a complete debug log file, but the one attached plus your explanation allowed me to find the problem. This is due to a bug in ShamWOW. Look for a solution in the next release which should be posted in the next 12 hours. Thanks again, Bobby53

 

[bobby53]

Bobby I'm finding it refreshes the weapon enchants every 1 or 2 kills along with lightning shield.
Anyway to just make it refresh when it runs out? Slowly down the bot considerably.

Lockwood, My apologies for any issue you may be having. Please see the ShamWOW FAQ [link -- click here] which is post #2 in this thread for information on the details needed when posting about issues with ShamWOW. I don't have enough detail to duplicate your issue and need a complete debug log file to look into this further for you. ShamWOW only refreshes the weapon enhancements when they expire and the character is out of combat, so the behavior you are seeing is some type of anomaly that I will need a log file for. Thanks for your help, Bobby53

 

[Artwebb]

This is what happens when i try to run instancebuddy with ShamWOW 4.2.04
I've tried changing specs and i do have the Stoneclaw Glyph and no matter what i set the totems to under PVP or Raf/Instances it always puts up those ones in the log.

>>> ### STARTING TEST ShamWOW v4.2.04 by Bobby53 ### <<<
Your Level 80 Draenei Restoration Shaman Build is:
Eleme/Enhan/Resto 2/3/31
Max Pull Ranged: 30
HB Pull Distance: 30
Cleanse Spirit: can remove Curses and Magic
Stoneclaw Totem: missing glyph, no Shaman Bubble available
^Totem Bar - Earth: Stoneskin Totem
^Totem Bar - Fire : Flametongue Totem
^Totem Bar - Water: Mana Spring Totem
^Totem Bar - Air : Grounding Totem
This profile does not contain any profiles fitting the character!
>>> ### STOPPING TEST ShamWOW v4.2.04 by Bobby53 ### <<<

 

[ekimbo]

its profile problem, not CC