I've been trying out the routine in bgs, to familiarize myself with it. Very impressed so far, even though I know it focuses on arena.
1. One thing I've noticed, is that regardless of the defensive cooldown thresholds you put in, there's some other logic that overrides them. Here I was fighting a shaman, dk, and hunter:
44:223 - HP: 81% - Rage: 55 - Me - 0y - 81% hp - Heroic Leap (Gap Closing on target)
44:448 - HP: 81% - Rage: 55 - (Shaman) - 5y - 80% hp - Hamstring
44:450 - HP: 81% - Rage: 55 - (Shaman) - 5y - 80% hp - Slam (Colossus Smash)
44:487 - HP: 81% - Rage: 55 - (Shaman) - 2y - 80% hp - Hamstring
47:448 - HP: 76% - Rage: 58 - Me - 0y - 76% hp - Heroic Leap (Gap Closing on target)
50:461 - HP: 71% - Rage: 61 - (Shaman) - 21y - 100% hp - Charge (Gap Closing on target)
51:154 - HP: 69% - Rage: 99 - (Shaman) - 5y - 100% hp - Hamstring
51:156 - HP: 69% - Rage: 99 - (Shaman) - 5y - 100% hp - Mortal Strike
51:192 - HP: 69% - Rage: 99 - (Shaman) - 4y - 100% hp - Hamstring
52:870 - HP: 64% - Rage: 100 - (Shaman) - 1y - 99% hp - Storm Bolt
53:613 - HP: 58% - Rage: 100 - (DeathKnight) - 3y - 100% hp - Disarm (Peel)
54:359 - HP: 44% - Rage: 100 - Me - 0y - 44% hp - Sweeping Strikes
54:399 - HP: 44% - Rage: 100 - Me - 0y - 44% hp - Thunder Clap
54:955 - HP: 31% - Rage: 63 - Me - 0y - 31% hp - Defensive Stance
55:916 - HP: 14% - Rage: 63 - (Shaman) - 1y - 100% hp - Overpower
56:841 - HP: 5% - Rage: 53 - (Shaman) - 1y - 100% hp - Hamstring
56:903 - HP: 5% - Rage: 53 - (Shaman) - 1y - 100% hp - Mortal Strike
56:948 - HP: 0% - Rage: 0 - (Shaman) - 1y - 95% hp - Hamstring
56:950 - HP: 0% - Rage: 0 - (Shaman) - 1y - 95% hp - Mortal Strike
The routine went from 81% to 0% in 12.5 seconds with only using defensive stance. No die by the sword, rallying cry, shield wall, or intimidating shout, despite the settings I had them at. All abilities were off cooldown and available. I have a hunch that the routine is assuming a healer and being extremely conservative with cooldowns, but this is too stingy.
Enjoying this, more feedback to follow
edit: on further testing I can see what's happening.
If a defensive cooldown threshold is set at 35% and you go from 36% to 33%, and stay at 33% for a few seconds, the cooldown will activate. But if you go from 80% to 50% to 20% to 0%, over a few seconds, you won't get any cooldowns, and you're as dead as a doornail.
Maybe could you have a selectable mode with a logic that assumes that no heals are coming?