What's new
By:
  • Visit Rebornbuddy
  • Visit Panda Profiles
  • Visit LLamamMagic
  • Visit Resources
  • Visit Downloads
  • Visit Portal

PureRotation V2

Millz said:
I use most of the defaults, but under Destruction set all 'false' to 'true' (i leave enhanced single target as false then toggle it with hotkey - in semi-auto mode). Change AoE count to 3. Disable burning rush unless it's a fight where you rely on quick movement.

As for not casting; post a log.
Click to expand...

I had same problem with standing and not doing anything for some time as destro and then again start and then again stop... Point is that nothing can be seen in logs, everything looks completely normal.

What happens:
After checking everything many times I have found out that Pure for some reason is changing Throttle time from 0,5 to 5 in General setting on its own and when this happens.

When it happens:
Most certain way to see it is to restart HB after one run and start it again. load Pure, open config and there it is 5 instead of 0,5.

Current solution:
Check it and change it whenever you enter instance. I personally delete all pure settings every time I enter instance, start new HB and quickly change settings to what I want them to be as I found it most reliable.

Because nothing else is getting changed in routine this is most definitely what is causing problem and with throttle time 0,5 it will top dps meter while with 5 it will do like 1/3 of normal dps. Pure really rocks as destro when this problem doesn't occur.

Just to be safe before posting I have checked it again and here is exactly what I have done so you can reproduce it:
1. Joined lfr
2. Start HB and load pure
3. Finish lfr and exit
4. Restart HB and load Pure
After that when you open config it will be 5 in Throttle time instead of 0,5
 
Warlocks - PvP Talents
- Added cast Blood Fear when off cooldown, and we don't have the aura. Will cast regardless of combat state.
- Added Dark Regeneration -> Setting for HP percent.
- Added Howl of Terror -> Setting for when HP below value, and when x number of units in 10 yds range of us.
- Added Unbound Will when we have an aura which is causing us to be any of the following (Asleep, Banished, Charmed, Disoriented, Fleeing, Horrified, Incapacitated, Polymorphed, Sapped). Also added a setting so this can be disabled.
 
Kurlebalo said:
I had same problem with standing and not doing anything for some time as destro and then again start and then again stop... Point is that nothing can be seen in logs, everything looks completely normal.

What happens:
After checking everything many times I have found out that Pure for some reason is changing Throttle time from 0,5 to 5 in General setting on its own and when this happens.

When it happens:
Most certain way to see it is to restart HB after one run and start it again. load Pure, open config and there it is 5 instead of 0,5.

Current solution:
Check it and change it whenever you enter instance. I personally delete all pure settings every time I enter instance, start new HB and quickly change settings to what I want them to be as I found it most reliable.

Because nothing else is getting changed in routine this is most definitely what is causing problem and with throttle time 0,5 it will top dps meter while with 5 it will do like 1/3 of normal dps. Pure really rocks as destro when this problem doesn't occur.

Just to be safe before posting I have checked it again and here is exactly what I have done so you can reproduce it:
1. Joined lfr
2. Start HB and load pure
3. Finish lfr and exit
4. Restart HB and load Pure
After that when you open config it will be 5 in Throttle time instead of 0,5
Click to expand...

That's odd. Default ThrottleTime is 0.5. Suggest deleting your <HB>/Settings/PureRotation/ folder to clear all settings.

Code: 
[Styx.Helpers.[B]DefaultValue[/B]([B]0.5[/B])]
[Category("General")]
[DisplayName("[B]ThrottleTime[/B]")]

*Edit* Nevermind saw you've done that already. I've moved all references to ThrottleTime in destro and replaced it with the default 0.5 - Update and try again.
 
Last edited:
The throttletime (the general one) is never changed by pure, there are some spells where we decide that the throttle time is not what we need and we set explicit values, like spells that does different things when having different buffs or spells that have traveltime, where the user shouldn't be the one who does the calculation ;)

but this will never change the general settings, in no situation.
the routines / rotations does never change existing settings! Never ever!
if it would be changed, we hade to call the save method, which automaticly should print out the new settings to the log (i'm glad that i added this!)
so it should be seen in the log that this action was performed, for whatever reasons, if this will not be printed out, it never happened
This is why we want a log all the time, your description is fine, and i will double check the core of pure for this, but a log is still necessary
in your case we need TWO logs :P
i've never had these issues and i'm raiding/questing and so on very often (multiple times a week on multiple toons), so i should have this problem too but never had it! (and this is again the reason why we will need the log!)
 
TheKrazed said:
Haha. Ahhh so that's how it works. I have it set to automatic? Would that make a difference? I did notice it was spamming "I'm in a PVE Rotation" in log every 2-3 seconds. I'll test each one now, see what happens.
Thanks for the info.
Click to expand...

uhm okay then i missed it to remove the logging for this^^
we had an issues with switching the rotation in UH and this is some debug shit to make sure / to see where we are currently
this shouldn't be in the log anymore, will remove it with one of the next commits :D

the switching of rotation works only in hotkeymode, in auto mode u can't switch it atm and will always execute the default single target rotation (or aoe when conditions are met)
 
Stormchasing said:
The throttletime (the general one) is never changed by pure, there are some spells where we decide that the throttle time is not what we need and we set explicit values, like spells that does different things when having different buffs or spells that have traveltime, where the user shouldn't be the one who does the calculation ;)

but this will never change the general settings, in no situation.
the routines / rotations does never change existing settings! Never ever!
if it would be changed, we hade to call the save method, which automaticly should print out the new settings to the log (i'm glad that i added this!)
so it should be seen in the log that this action was performed, for whatever reasons, if this will not be printed out, it never happened
This is why we want a log all the time, your description is fine, and i will double check the core of pure for this, but a log is still necessary
in your case we need TWO logs :P
i've never had these issues and i'm raiding/questing and so on very often (multiple times a week on multiple toons), so i should have this problem too but never had it! (and this is again the reason why we will need the log!)
Click to expand...


Well I don't know why it happens but it happens :)

Here are both logs just as I described in first post (note that I have updated Pure after Milz post), I didnt do fight on second start as I already know how bad performance will be but if its needed I will also do it.

Edit: About that part of not saving and saving getting printed... well I'm not idiot to not be able to see it when I open it and I dont have either intention or whatsoever reason to pull something false as issue or to change it on my own to give me worst possible outcome. I have described way to reproduce it and if its not happening to you also then problem is somewhere on my side and I will continue searching for issue. For me this is happening and I have way to solve it with deleting previous settings in Pure so even without change I dont mind doing it but there are many people around who dont even know how to change their setting and for them it will be pain in the ass.
 

Attachments

Last edited:
Kurlebalo said:
Well I don't know why it happens but it happens :)

Here are both logs just as I described in first post (note that I have updated Pure after Milz post), I didnt do fight on second start as I already know how bad performance will be but if its needed I will also do it.

Edit: About that part of not saving and saving getting printed... well I'm not idiot to not be able to see it when I open it and I dont have either intention or whatsoever reason to pull something false as issue or to change it on my own to give me worst possible outcome. I have described way to reproduce it and if its not happening to you also then problem is somewhere on my side and I will continue searching for issue. For me this is happening and I have way to solve it with deleting previous settings in Pure so even without change I dont mind doing it but there are many people around who dont even know how to change their setting and for them it will be pain in the ass.
Click to expand...

That's very odd, but there's nothing in the code which looks to be changing this value. I've removed the ThrottleTime references in the destruction routine, is it working better after the most recent update?
 
thanks for the logs, they were very helpful to find the issue

the problem is (and i can't currently say WHY it is, cause haven't looked through the complete code now!) that the value is saved as 0,5 instead of 0.5
means "," is a separator for thousands, which makes 0,5 to 05 to 5 instead of 0.5
i will investigate this issue, cause it'll happen only under special circumstances and i can't reproduce it with my two systems atm!
but we will fix it within the next hours (hopefully), it is something really small that has to be replaced :D i only have to find the correct place for this
 
I ran my Disc priest last night with the latest rev and it was through a lot of errors. I have attached the log from that run.
 

Attachments

bp423 said:
I ran my Disc priest last night with the latest rev and it was through a lot of errors. I have attached the log from that run.
Click to expand...

disable the dispelling, this will temporarly fix the problems, we will look at it
 
bp423 said:
I ran my Disc priest last night with the latest rev and it was through a lot of errors. I have attached the log from that run.
Click to expand...

Thanks for the log, we're aware of the massive amounts of issues with Healing and PureRotation. Healing is under-going a massive re-write at the moment, but it's slow and steady progress to avoid releasing something which isn't going to perform.
 
Kurlebalo said:
Well I don't know why it happens but it happens :)

Here are both logs just as I described in first post (note that I have updated Pure after Milz post), I didnt do fight on second start as I already know how bad performance will be but if its needed I will also do it.

Edit: About that part of not saving and saving getting printed... well I'm not idiot to not be able to see it when I open it and I dont have either intention or whatsoever reason to pull something false as issue or to change it on my own to give me worst possible outcome. I have described way to reproduce it and if its not happening to you also then problem is somewhere on my side and I will continue searching for issue. For me this is happening and I have way to solve it with deleting previous settings in Pure so even without change I dont mind doing it but there are many people around who dont even know how to change their setting and for them it will be pain in the ass.
Click to expand...

could u please check your current country settings of your comp?
- goto Control panel of your Windows
- Region Settings
- Date, Time, Currency
- Format (below Format is a link called something like "change sorting method" which opens a new dialog)
- switch to the first tab in the new Dialog (something like Currency or Numbers .. i think it's numbers)
- maybe there are some weird settings

for me they look like displayed in the screen (sorry this OS is localized to German ;)), does not mean u have to change them!!! i'm only interested in a screen of your settings for this, maybe i can see something weird, but as solution for the future and without touching your system (because different settings do not mean that they are wrong!!!) i'll try to set up the CultureInfo at runtime only for the application (in this case for PR)
 

Attachments

  • Unbenannt.webp
    Unbenannt.webp
    24.4 KB · Views: 41

Attachments

Kurlebalo said:
Well I don't know why it happens but it happens :)

Here are both logs just as I described in first post (note that I have updated Pure after Milz post), I didnt do fight on second start as I already know how bad performance will be but if its needed I will also do it.

Edit: About that part of not saving and saving getting printed... well I'm not idiot to not be able to see it when I open it and I dont have either intention or whatsoever reason to pull something false as issue or to change it on my own to give me worst possible outcome. I have described way to reproduce it and if its not happening to you also then problem is somewhere on my side and I will continue searching for issue. For me this is happening and I have way to solve it with deleting previous settings in Pure so even without change I dont mind doing it but there are many people around who dont even know how to change their setting and for them it will be pain in the ass.
Click to expand...

Update your PR
it will now save and load the correct value, maybe u have to adjust it one more time, but after that it should save/load correct values for throttle time
 
Stormchasing said:
could u please check your current country settings of your comp?
- goto Control panel of your Windows
- Region Settings
- Date, Time, Currency
- Format (below Format is a link called something like "change sorting method" which opens a new dialog)
- switch to the first tab in the new Dialog (something like Currency or Numbers .. i think it's numbers)
- maybe there are some weird settings

for me they look like displayed in the screen (sorry this OS is localized to German ;)), does not mean u have to change them!!! i'm only interested in a screen of your settings for this, maybe i can see something weird, but as solution for the future and without touching your system (because different settings do not mean that they are wrong!!!) i'll try to set up the CultureInfo at runtime only for the application (in this case for PR)
Click to expand...


Hmm :)

Didn't even consider that could be issue, my current Region setting are Serbia and thus numbers for which separator , is for decimal and . for thousands. Also Pure (or my system) didn't allow me to put . in 0.5 when I tried once (sorry didn't cross my mind it could be important) returning it as invalid input. Screen shoot of setting added :)

Ty for help :)

@Millz - Warlocks rock with Pure and your settings for green fire quest are perfect as I got it in 4th try with only 480 ilvl half blue equipment :D TY :D
 

Attachments

  • 8xwuZCo.webp
    8xwuZCo.webp
    16.9 KB · Views: 33
Obliv said:
First, let me apologize for breaking swipe. Second, tell me what I did to break swipe. Swipe is not casting at all in the AoE section, yet, every single other spell works fine.

[C#] #region Revision info /* * $Author: Alex & Wulf$ * $Date: 2013-06-04 22:1 - Pastebin.com - current Guardian druid modifications I'm using. The AoE section is about as simple as it can be, so I'm not sure how Swipe is having an issue.
Click to expand...

[C#] #region Revision info /* * $Author: Alex & Wulf$ * $Date: 2013-06-04 22:1 - Pastebin.com
take a look at my comments in the aoe part
I've never played a drood .. not feral nor guardian, but from my researches, my comments should explain the issue ;), i also added the cooldown check for berserk
 
Last edited:
Kurlebalo said:
Hmm :)

Didn't even consider that could be issue, my current Region setting are Serbia and thus numbers for which separator , is for decimal and . for thousands. Also Pure (or my system) didn't allow me to put . in 0.5 when I tried once (sorry didn't cross my mind it could be important) returning it as invalid input. Screen shoot of setting added :)

Ty for help :)
Click to expand...

Update your pure, this should be fixed now, and u should be able to insert values in format of your region settings
i've seen that my settings also were stored wrong, but i never had any issues with it ... but again, should be fixed now
 
Ty for the comments storm! Alex suggested putting it as first priority, and sure enough it cast it every time. I put it below Thrash, and it would never cast. I added Spell.Cast("Thrash", ret => Spell.GetSpellCooldown("Thrash").TotalSeconds == 0), and it started casting perfectly.
 
if u have finished tweaking the rotation and u think it should be used because better than the current one ... feel free to provide a paste that we can commit :)
 
Can any1 explain me the pureRotation feature in German? it would be nice :(
got many questions..
 
You must log in or register to reply here.
Back
Top