What's new
By:
  • Visit Rebornbuddy
  • Visit Panda Profiles
  • Visit LLamamMagic
  • Visit Resources
  • Visit Downloads
  • Visit Portal
RebornBuddy Forums

Register a free account today to become a member! Once signed in, you'll be able to participate on this site by adding your own topics and posts, as well as connect with other members through your own private inbox!

[Plugin] TidyBags 3.0 Reloaded!

LiquidAtoR said:
Will do in next release


Very nice write-up, thanks, but later you ask not to add this.
Not sure what it's going to be, maybe add a poll whether to add or not to add, haha :)
Click to expand...

Yep LiquidAtoR sorry about the confusion there. It was only after I posted the code to tidy up fish, that I discovered the fishing daily requirements.

You need to clean the fish.. that is in the process of cleaning/combining the fish stacks you get "fish eggs" needed to complete the fishing daily. And you only get those eggs when the daily quest is active in your quest log.

So it's probably in everyone's best interest to NOT tidy up fish if you plan to sell uncleaned stacks of fish in the AH for players that need them for completion of their daily quests. Seems money can be made in selling cleaned and uncleaned fish stacks.

That is why I hope you'll consider adding a configuration option to include or exclude item sets on the fly. Or your idea to poll the community is probably easier. But if it were up to me, I'd vote no on tidying up fish this expansion.
 
Oh.. and thumbs up on adding 110610, // Raw Beast Hide Scraps @ 10

Thanks! :)
 
Proto said:
That is why I hope you'll consider adding a configuration option to include or exclude item sets on the fly.
Click to expand...
If I ever start playing again I might (Don't hold your breath over it), but for now it's not in my interest to rewrite a addon when I'm not using it or playing the game, hmm ;-)
For now your writeup is embedded inside TidyBags, just deactivated.
Proto said:
Oh.. and thumbs up on adding 110610, // Raw Beast Hide Scraps @ 10
Click to expand...
When you add it yourself and use SVN it should merge with your changes should you choose to do so ^_^
As long as I don't rewrite or majorly change the code it should stay put.
 
Last edited:
which item ids require a skill to use them and tidy them up by combining and opening?
Is skill 1 of skinning required for all leather pieces?
 
laria said:
which item ids require a skill to use them and tidy them up by combining and opening?
Is skill 1 of skinning required for all leather pieces?
Click to expand...
You would have to look at each tooltip on Wowhead and see if there's a skill level (or character level) required besides the skinning or leatherworking skill besides the amounts etc.
 
I made a script out of my suggestion, not sure if it works, i couldn't try it yet.
Would appreciate feedback
 

Attachments

Last edited:
laria said:
I made a script out of my suggestion, not sure if it works, i couldn't try it yet.
Would appreciate feedback
Click to expand...
You will need feedback from 3 different cases to be 100% sure it works

1) A skinner with 10+ Raw Beast Hide Scraps in his bags.
2) A skinner (best a level 1 character with level 1 skinning) with 10+ Raw Beast Hide Scraps in his bags.
2) A non-skinner with 10+ Raw Beast Hide Scraps in his bags.
 
Last edited:
LiquidAtoR said:
https://www.thebuddyforum.com/honor...ags-3-0-reloaded-post1748385.html#post1748385
Read a bit further down in the post...
Click to expand...

not work. I added all strongboxes IDs to useonone and sleep lists...

Code: 
 private HashSet<uint> _itemUseOnOne = new HashSet<uint>() {
		    111598,
			111599,
			111600,
			119330,
			120354,
			120355,
			120356,
			120353,
            3352, // Ooze-covered Bag
            6351, // Dented Crate
            6352, // Waterlogged Crate
            6353, // Small Chest
            6356, // Battered Chest
            .........
Code: 
 private HashSet<uint> _itemRequiresSleep = new HashSet<uint>() {
            111598,
			111599,
			111600,
			119330,
			120354,
			120355,
			120356,
			120353,
			61387, // Hidden Stash
            67495, // Strange Bloated Stomach (Cataclysm Skinning)
            67539, // 
            .........
 
laria said:
I made a script out of my suggestion, not sure if it works, i couldn't try it yet.
Would appreciate feedback
Click to expand...
Code: 
						} else if (_skinningItemUseOnTen.Contains(item.Entry)) { // stacks of 10
                            if (item.StackCount >= 10) && (StyxWoW.Me.GetSkill(SkillLine.Skinning).CurrentValue >=1) ) {
                                this.useItem(item);
			    }

Should be

Code: 
						} else if (_skinningItemUseOnTen.Contains(item.Entry)) { // stacks of 10
                            if (item.StackCount >= 10 && StyxWoW.Me.GetSkill(SkillLine.Skinning).CurrentValue >=1) {
                                this.useItem(item);
			    }
 
With the help of Stormchasing , a small error in the file i uploaded was fixed and the code is now easier to read. New version is available in my original post.
 
laria said:
I made a script out of my suggestion, not sure if it works, i couldn't try it yet.
Would appreciate feedback
Click to expand...

For whatever reason, I have absolutely no luck with getting this version of the Plugin to work properly. I'll provide a logs and describe the exact problems if you'd like, not sure if anyone is really keeping this product up to date anymore (I know LiquidAtoR is busy).

Cheers,
XtO
 
eXtOphius said:
For whatever reason, I have absolutely no luck with getting this version of the Plugin to work properly.
Click to expand...

Does it even show up in the plugins menu? The first few people downloaded a file with compile errors.
 
laria said:
Does it even show up in the plugins menu? The first few people downloaded a file with compile errors.
Click to expand...

It's not a compiling error, it shows up just fine. It just doesn't seem to work for me. I am still farming in MoP for materials, and Sha-Touched Leather and Mote of Harmony do not combine for me.
 
log might be nice, for me it opens the winter veil gifts just fine
 
eXtOphius said:
(I know LiquidAtoR is busy)
Click to expand...
It's not that I'm too busy, but I'm simply not playing anymore (already for months now).
As it stands I might return to the game end summer - autumn or somewhere around that (for now let's say 60% chance I will return).
We'll see as time passes :-)

Meanwhile I will keep an eye out on this topic every now and then.
 
So here is a new version, which includes winterveil presents and other new items as well as a few debug messages to help us figure out why the leather combining doesn't work.
If you have issues with Raw Beast Hide Scraps , please upload a logfile
 

Attachments

You must log in or register to reply here.
Back
Top