[Plugin] Giles Stash & Loot Rule Replacer

[GilesSmith]

I got the same full inventory erro again, 3 times now, only with 1 of my 3 bots am i doing something wrong?

That log's helpful, but it does show signs of problems for you to get that many errors. Can you just confirm (be honest!) - have you tried a completely clean install of DemonBuddy - new folder, freshly downloaded, nothing else in the folder except that new DemonBuddy... and then just install latest plugins only, and don't use any reloggers (some of them have problems if you use many plugins or big plugins). It may well fix those random problems if you haven't ever tried that, found quite a lot of weird corruption occurs if you keep upgrading DemonBuddy over old copies (not to mention all the random edits people do over time to combat routines, rules files, old plugins they forgot about and leave disabled or in odd folders in DB etc.).

Anyway I've used your log-file to chuck some more handling in the spots where those errors happened, so if it keeps happening after version 1.8.4 (due tonight), then I'll be able to track down the cause even more accurately!

 

[fausto222]

Now it actually wrote something in the .cfg, checking if it's looting probably now.

Hmmmm. It seems to go normally for now. But it's still looting white items... I have no idea what's going on tbh. Noone else seem to have my problem.

 

[GilesSmith]

Hmmmm. It seems to go normally for now. But it's still looting white items... I have no idea what's going on tbh. Noone else seem to have my problem.

Oh I missed where you said you use Stove's goblin in last post! That plugin has custom item pickup code, so causes problems. You can reduce problems by using the loot-rules on post #337 of this thread (link available in compatibility section of post #1), setting config of stash replacer to "Use custom loot rules" instead of giles filters... and DON'T use world-object-handler option to disable loot rules. Let me know if that fixes the white-item-pickup for you.

 

[GilesSmith]

v1.8.4 Uploaded:
-- Many score alterations and tweaks to improve the automated "stash or trash" filters for all item slots.
-- More DB memory-handling error catching and logging to help track or even prevent possible DB memory bugs.
-- Fixed bug with not always saving the tomes/plans/follower item config settings.


If you have any problems at all: Always read through the "Compatibility", and the "Common Problems & Causes" sections of post #1 first. Yes, I really do actually have solutions listed that actually fix things! If you still have problems, when you post details of your problem please include a list of ALL plugins you use, and state whether or not you use any form of Relogger/Auto-Launcher/Batch-Restarter tool for DemonBuddy & Diablo, and whether or not you have gone through the common problems & compatibility section first.

 

[greenxeyezz]

running and updating to your latest as always....i havent come across MANY problems that are related to your plugin, still many that are related to DB (doesnt seem item, doesnt pick up items, etc etc)

 

[greenxeyezz]

Cannot tell if this is a DB or plugin issue, when whenever (i think) DB doesnt see an item, the bot does not and will not pick it up and then

[15:02:52.857 N] Blacklisting lootable (Amethyst_08-8947) after 10 seconds
[15:03:03.555 N] Blacklisting lootable (Sword_norm_base_flippy_04-8938) after 10 seconds

 

[sojufiend]

hmmm bot is picking up ilvl62 blue weapons as well?? its a 2 hander too... i dont see any reason to pick these up

 

[GilesSmith]

hmmm bot is picking up ilvl62 blue weapons as well?? its a 2 hander too... i dont see any reason to pick these up

As I said before, it picks them up if they meet a particular DPS threshold. Don't worry, I promise you it won't stash them if, when it does the town-run, the item evaluator deems them too low to be worth money. It just picks up any weapon over a particular DPS threshold (something like 60% of the "max" DPS based on the weapon-type, can't remember the limit off the top of my head) as a safety catch-all. Those blue weapons won't kill you, and last night TWO of my bots got good blue weapons worth about 5 mil and 7 mil each. If you really, REALLY want, I can add a feature that FORCES it to never loot a blue weapon. But you'll have to give me a reason for why you never want them looting - I'm happy to add customization requests, but I do like a good reason first!

Cannot tell if this is a DB or plugin issue, when whenever (i think) DB doesnt see an item, the bot does not and will not pick it up and then
[15:02:52.857 N] Blacklisting lootable (Amethyst_08-8947) after 10 seconds
[15:03:03.555 N] Blacklisting lootable (Sword_norm_base_flippy_04-8938) after 10 seconds

Likely DB, but if you can load the log file up (the full log that gets created in your /logs/ folder in DemonBuddy), and find those lines - and then paste to me the log about 20 lines above and 20 lines below (or maybe a timespan covering 90 seconds before and 90 seconds after), I can take a better look and see if it's anything you need to worry about or not

 

[speculoos]

Thanks Giles trying new version now Cheers

 

[sojufiend]

As I said before, it picks them up if they meet a particular DPS threshold. Don't worry, I promise you it won't stash them if, when it does the town-run, the item evaluator deems them too low to be worth money. It just picks up any weapon over a particular DPS threshold (something like 60% of the "max" DPS based on the weapon-type, can't remember the limit off the top of my head) as a safety catch-all. Those blue weapons won't kill you, and last night TWO of my bots got good blue weapons worth about 5 mil and 7 mil each. If you really, REALLY want, I can add a feature that FORCES it to never loot a blue weapon. But you'll have to give me a reason for why you never want them looting - I'm happy to add customization requests, but I do like a good reason first!

ya i see what you are saying and looting ilvl63 weaps with 60% threshhold is fine.. is there a way to filter out ilvl62s though? i mean like i saw it loot 800 dps two hander oni blade and bunch of other ilvl62 weaps filling the inventory.. this is just waste of space, makes bot go town more often for no reason.. hence making bot more inefficient.. all those extra town runs could be used for killing more elites!

edit: its not a big deal though.. just sayin i cant see ilvl62 blue weaps ever being good for sell.. anyways.. always many thanks for your hard work

 

[Hajkfas]

Hey Giles,

Noticed something interesting

[21:02:16.864 N] [GilesStashReplacer 1.8.3] Cavalry Spite [pants_hell_base_05-44] [Pants] = 1930
[21:08:48.020 N] [GilesStashReplacer 1.8.3] Cavalry Spite [pants_hell_base_05-205] [Pants] = 19198

Same pair of pants, evaluated at two different times (restarted DB for second evaluation).

Memory reading problems?

 

[GilesSmith]

Hey Giles,
Noticed something interesting
[21:02:16.864 N] [GilesStashReplacer 1.8.3] Cavalry Spite [pants_hell_base_05-44] [Pants] = 1930
[21:08:48.020 N] [GilesStashReplacer 1.8.3] Cavalry Spite [pants_hell_base_05-205] [Pants] = 19198
Same pair of pants, evaluated at two different times (restarted DB for second evaluation).
Memory reading problems?

Yup, nothing can do about that at all without a DB update. It happens. DemonBuddy just fails to latch onto the proper memory-address for an item - and nothing can read the stats from it, not DemonBuddy itself nor any plugins. Leaving/resuming the game can fix it, as can restarting DemonBuddy - we're still waiting that mythical update that fixes memory reading!

 

[Hajkfas]

Yup, nothing can do about that at all without a DB update. It happens. DemonBuddy just fails to latch onto the proper memory-address for an item - and nothing can read the stats from it, not DemonBuddy itself nor any plugins. Leaving/resuming the game can fix it, as can restarting DemonBuddy - we're still waiting that mythical update that fixes memory reading!

Haha, waiting for that mythical update indeed.

Thanks

 

[zilan89]

anyone mind posting the score that worth ? i can't seem to get any good stuff to test my own. sorry for the trouble.

 

[GilesSmith]

v1.8.5 Uploaded:
-- Altered pathing calculation and config file creation to try & fix setting-saving bugs some users were having.

^^ Quite a few users had a bug where it wouldn't create a config file the first time they ran the plugin. This should fix that. It might also fix any issues where the plugin simply wasn't loading your settings up for some rare users - give it a try if you ever had problems before.

Also going to paste the last update post again below as I want to spam-highlight the "read the compatibility and common problems sections if you have a problem, before posting" bit

v1.8.4 Uploaded:
-- Many score alterations and tweaks to improve the automated "stash or trash" filters for all item slots.
-- More DB memory-handling error catching and logging to help track or even prevent possible DB memory bugs.
-- Fixed bug with not always saving the tomes/plans/follower item config settings.


If you have any problems at all: Always read through the "Compatibility", and the "Common Problems & Causes" sections of post #1 first. Yes, I really do actually have solutions listed that actually fix things! If you still have problems, when you post details of your problem please include a list of ALL plugins you use, and state whether or not you use any form of Relogger/Auto-Launcher/Batch-Restarter tool for DemonBuddy & Diablo, and whether or not you have gone through the common problems & compatibility section first.

 

[Thirdi]

I still have to use the old 1.7 version because the newest version picks up all the whits / grays. I only use your addons and all up to date ones for A1 champ farming. I checked all the setting and tried with all different settings. No idea what is causing it but even a fresh install did not fix it Maybe your next version will work right for me but until then I have to use 1.7.

edit: Spoke to soon, just tried 1.8.5 and it works perfectly! Thanks Giles best plugins ever.

 

[GilesSmith]

I still have to use the old 1.7 version because the newest version picks up all the whits / grays. I only use your addons and all up to date ones for A1 champ farming. I checked all the setting and tried with all different settings. No idea what is causing it but even a fresh install did not fix it Maybe your next version will work right for me but until then I have to use 1.7.
edit: Spoke to soon, just tried 1.8.5 and it works perfectly! Thanks Giles best plugins ever.

Glad you have it working It probably just wasn't configured correctly (maybe due to the settings file bug I just fixed with 1.8.5?) - so it thought you didn't have the "Use Giles filters below" option selected (and so was just picking EVERYTHING up instead of filtering it).

 

[GCire]

I'm having a weird issue where when I edit the Score sliders of weapon/armor/jewelry and save settings then reopen the config all the scores are what the weapon score was selected to on the previous setting saved. I've reinstalled the plugin and DB as well.

Only plugins in use are Giles Monster Priority Changer, Stash & Replacer, World Object Handler, Profile Restarter.

 

[tesslerc]

Giles i just fixed my problem with him getting stuck in town, the log used to show lines like [ItemRules] Matched Confident Impellor of Frost with rule: Sell Everything:Sell
Now i installed 1.8.5 and the loot rules - it works perfect now.

 

[Midas]

man this is working so perfectly for me now! giles is the man.

Occasionally i see like 3 rares drop and none get picked up and I force the bot back and ..... nope they are all level 55 sorry stashreplacer, I should have trusted you hehe