<!-- Pick up plans and designs, blacksmithing/jewelcrafting -->
<ItemRule ruleType="PickUp" itemName="Plan*" stack="1" />
<ItemRule ruleType="PickUp" itemName="Design*" stack="1" />
<ItemRule itemBaseType="Weapon" twoHanded="true" description="High DPS 2h Weapons">
<StatRules>
<!-- Magic Weapons should have at least 1200 DPS -->
<Rule stat="DPS" minValue="1200" quality="Magic1" />
<!-- Rare weapons should have at least 1100 considering they provide extra stats most of the time. -->
<Rule stat="DPS" minValue="1100" quality="Rare4" />
</StatRules>
</ItemRule>
<ItemRule itemType="Ring" >
<StatRules>
<Rule stat="MagicFind" minValue="18" />
</StatRules>
</ItemRule>
<ItemRule itemType="Ring" >
<StatRules>
<Rule stat="GoldFind" minValue="18" />
</StatRules>
</ItemRule>
<ItemRule itemBaseType="Armor" description="Rare armor with 2 sockets"
<StatRules>
<!-- Looking for 2 opensocket pants/chest with dexterity-->
<Rule stat="Dexterity" minValue="70" quality="Rare4" />
<Rule stat="Sockets" minValue="2" />
</StatRules>
</ItemRule>
[B][SIZE=3]<ItemRule ruleType="Keep"[/SIZE] [/B]itemBaseType="Armor" description="Rare armor with 2 sockets"
<StatRules>
<!-- Looking for 2 open socket pants/chest with dexterity-->
<Rule stat="Dexterity" minValue="70" quality="Rare4" />
<Rule stat="Sockets" minValue="2" />
</StatRules>
</ItemRule>
Any updates on Life on Hit / Pick up radius stats?
I mentioned it to Apoc, he said that's the way it is and the way it'll stay since that's the item structure of Diablo3. You don't need to set the quality on every rule, just once at the top, and the rest will match it.A question for the devs mainly, but maybe players will point out the obvious reasoning to me if I've missed it... but wouldn't the "quality" stat be much more appropriate to set at <ItemRule> level rather than <Rule> level?
It just seems to really confuse how the rules work by setting the "quality" on every single individual rule within a ruleset, generally the entire ruleset should be specific to item quality?
I did this and is working great for me.
Code:<?xml version="1.0" encoding="utf-8" ?> <ItemRules name="Default Item Rules" useRoundedValues="true"> <Priority priority1="Keep" priority2="Salvage" priority3="Sell" /> <Categories> <Category ruleType="PickUp"> <ItemRule> <StatRules> <Rule quality="Magic1" /> </StatRules> </ItemRule> <ItemRule itemName="Gold" stack="250" /> <ItemRule itemName="Page of*" stack="1" /> <ItemRule itemName="Tome of*" stack="1" /> <ItemRule itemName="*Ruby*" stack="1" /> <ItemRule itemName="*Emerald*" stack="1" /> <ItemRule itemName="*Topaz*" stack="1" /> <ItemRule itemName="*Amethyst*" stack="1" /> <ItemRule itemName="*Health Potion*" stack="1" /> </Category> <Category ruleType="Keep"> <ItemRule itemBaseType="Weapon" twoHanded="true" description="High DPS 2h Weapons"> <StatRules> <Rule stat="DPS" minValue="1200" quality="Magic1" /> <Rule stat="DPS" minValue="1100" quality="Rare4" /> </StatRules> </ItemRule> <ItemRule itemBaseType="Weapon" twoHanded="false" description="High DPS 1h Weapons"> <StatRules> <Rule stat="DPS" minValue="1000" quality="Magic1" /> <Rule stat="DPS" minValue="900" quality="Rare4" /> </StatRules> </ItemRule> <ItemRule itemBaseType="Armor" description="Rare armor"> <StatRules> <Rule stat="Intelligence" minValue="160" quality="Rare4" /> <Rule stat="Vitality" minValue="160" quality="Rare4" /> <Rule stat="Dexterity" minValue="160" quality="Rare4" /> <Rule stat="Strength" minValue="160" quality="Rare4" /> <Rule stat="ResistAll" minValue="50" quality="Rare4" /> </StatRules> </ItemRule> <ItemRule itemBaseType="Jewelry" description="Rare jewelry"> <StatRules> <Rule stat="Intelligence" minValue="80" quality="Rare4" /> <Rule stat="Vitality" minValue="80" quality="Rare4" /> <Rule stat="Dexterity" minValue="80" quality="Rare4" /> <Rule stat="Strength" minValue="80" quality="Rare4" /> <Rule stat="ResistAll" minValue="30" quality="Rare4" /> <Rule stat="AttackSpeedPercent" minValue="17" quality="Rare4" /> </StatRules> </ItemRule> <ItemRule ruleType="Keep" description="Legendary"> <StatRules> <Rule quality="Legendary" /> </StatRules> </ItemRule> </Category> <Category ruleType="Salvage"> <ItemRule description="Salvage level 60 gear"> <StatRules> <Rule stat="Level" minValue="61" quality="Magic1" /> </StatRules> </ItemRule> </Category> <Category ruleType="Sell"> <ItemRule description="Sell Everything"> <StatRules> <Rule quality="Magic1" /> </StatRules> </ItemRule> </Category> </Categories> </ItemRules>
Few things that seem to be missing/are unclear;
1: LifeOnHit stat, globe&gold pickup radius bonus stat - neither of these are not listed - how can we filter them?
2: "WizardHat" has it's own item-type entry, implying it WON'T be filtered in the "Helm" itemType. However other unique itemtypes are missing, so I don't know if specific itemtype filters will catch them or not;
- Cloaks (a type of demon hunter chest armour).
- Mighty Belt (a type of barbarian belt).
- Spirit Stone (a type of monk helm).
- Voodoo mask (a type of witch doctor helm).
Since "WizardHat" has it's own itemtype, I'm suspicious that "cloaks" for example may always be ignored in any "Chest" itemType filters. Can we have some clarification here, or have these other specific itemtypes added?
3: It really makes no sense to have the "Quality" entry listed at <Rule> level instead of <itemRule> level. Quality should be taken off <Rule> and either given it's own unique XML entry, or stapled on as an optional extra on "itemRule". It doesn't matter how Diablo 3 items are internally, DemonBuddy handles the itemRules.xml itself and so can be coded any way the devs want.
It is DEFINITELY AND and not OR and everything works as intended. I have tested several different cases such as this one using the following item
I got to confirm the same.
<ItemRule itemBaseType="Weapon" twoHanded="true" description="High DPS 2h Weapons">
<StatRules>
<!-- Magic Weapons should have at least 1200 DPS -->
<Rule stat="DPS" minValue="1200" quality="Magic1" />
<!-- Rare weapons should have at least 1100 considering they provide extra stats most of the time. -->
<Rule stat="DPS" minValue="1100" quality="Rare4" />
</StatRules>
</ItemRule>
<ItemRule itemBaseType="Weapon" twoHanded="false" description="High DPS 1h Weapons">
<StatRules>
<Rule stat="DPS" minValue="1000" quality="Magic1" />
<Rule stat="DPS" minValue="900" quality="Rare4" />
</StatRules>
</ItemRule>