deams
Community Developer
- Joined
- Oct 20, 2014
- Messages
- 714
- Reaction score
- 25
[PAID] GarrisonButler
- Thread starter deams
- Start date
namednoob
Community Developer
- Joined
- Apr 25, 2014
- Messages
- 1,097
- Reaction score
- 25
Hi deams,
This update looks a lot better but I've encountered a few issues with it:
1) Movement still very close one step to another causing the bot to some times to do a complete 360º and lagging it
2) Bot doesn't enter the salvage building if you make the buidling near the gate thus failing to use the salvage stuff
Here is the hotspot for the specific place he needs to stand at(alliance side):
3) It seems you're checking for the cache existence too fast so the bot collects the cache and the check kicks in before the cache disappear causing it to try to interact with the non-existent cache again, so if you could increase a bit the check delay for the cache I guess that would do the job.
As you can above I had the cache collect with the first interaction and the second one failed as the cache no longer existed to be collected.
Aside from that mine and garden seemed to be just fine this time, and I am using Garrison Level 3.
If you could, make the work order thing per building I for one don't would not like the bot doing work orders from all the places currently available within my Garrison until you further implement more options for the work orders. For example, I have a trading post and the mats used for it change daily and some mats I would rather keep then having it automatically used on the work order. However garden and mine work orders are no problem.
This update looks a lot better but I've encountered a few issues with it:
1) Movement still very close one step to another causing the bot to some times to do a complete 360º and lagging it
2) Bot doesn't enter the salvage building if you make the buidling near the gate thus failing to use the salvage stuff
Here is the hotspot for the specific place he needs to stand at(alliance side):
Code:
<Hotspot X="1804.171" Y="192.0387" Z="70.83537" />3) It seems you're checking for the cache existence too fast so the bot collects the cache and the check kicks in before the cache disappear causing it to try to interact with the non-existent cache again, so if you could increase a bit the check delay for the cache I guess that would do the job.
Code:
[23:54:51.588 N] [GarrisonBuddy] 0.5: Collecting Garrison cache.
[23:54:51.589 D] Interacting with Garrison Cache (GameObject Id: 236916)
[23:54:53.590 N] [GarrisonBuddy] 0.5: Succesfully collected Garrison cache.
[23:54:53.649 N] [GarrisonBuddy] 0.5: Detected garrison cache available, moving to collect.
[23:54:53.649 D] [GarrisonBuddy] 0.5: Shipment Garrison Cache - 236916 - 23775: <1947.616, 286.6389, 88.96585>
[23:54:53.649 N] [GarrisonBuddy] 0.5: Collecting Garrison cache.
[23:54:53.798 D] Interacting with Garrison Cache (GameObject Id: 236916)
[23:54:55.325 N] [GarrisonBuddy] 0.5: Failed to collect Garrison cache. Already 0 attempts failed.
[23:54:55.394 N] [GarrisonBuddy] 0.5: Found 8 completed missions to turn in.
[23:54:56.877 D] [GarrisonBuddy] 0.5: ENS skipped 0 waypoints.As you can above I had the cache collect with the first interaction and the second one failed as the cache no longer existed to be collected.
Aside from that mine and garden seemed to be just fine this time, and I am using Garrison Level 3.
If you could, make the work order thing per building I for one don't would not like the bot doing work orders from all the places currently available within my Garrison until you further implement more options for the work orders. For example, I have a trading post and the mats used for it change daily and some mats I would rather keep then having it automatically used on the work order. However garden and mine work orders are no problem.
Hey dude loving the update.
Seems to be some pug with how long a node is allowed to be gathered before another attempt is made.
Dunno if its just me getting this? It basically gets stuck in a loop where it tries to gather the node over and over but cancels at the last fraction of a second. Getting the error "That is already being used."
Seems to be some pug with how long a node is allowed to be gathered before another attempt is made.
Code:
Interacting with True Iron Deposit (GameObject Id: 232544)[GarrisonBuddy] 0.5: Found ore to gather, moving to ore at:<1838.175, 186.4716, 11.58771>
Interacting with True Iron Deposit (GameObject Id: 232544)
[GarrisonBuddy] 0.5: Found ore to gather, moving to ore at:<1838.175, 186.4716, 11.58771>
Interacting with True Iron Deposit (GameObject Id: 232544)
[GarrisonBuddy] 0.5: Found ore to gather, moving to ore at:<1838.175, 186.4716, 11.58771>
Interacting with True Iron Deposit (GameObject Id: 232544)
[GarrisonBuddy] 0.5: Found ore to gather, moving to ore at:<1838.175, 186.4716, 11.58771>
Interacting with True Iron Deposit (GameObject Id: 232544)
[GarrisonBuddy] 0.5: Found ore to gather, moving to ore at:<1838.175, 186.4716, 11.58771>
Interacting with True Iron Deposit (GameObject Id: 232544)
[GarrisonBuddy] 0.5: Succesfully looted:
[GarrisonBuddy] 0.5: 2x True Iron Ore
[GarrisonBuddy] 0.5: 1x Draenic Stone
[GarrisonBuddy] 0.5: Found ore to gather, moving to ore at:<1838.175, 186.4716, 11.58771>Dunno if its just me getting this? It basically gets stuck in a loop where it tries to gather the node over and over but cancels at the last fraction of a second. Getting the error "That is already being used."
deams
Community Developer
- Joined
- Oct 20, 2014
- Messages
- 714
- Reaction score
- 25
Thanks for the feedback! Will let you know soon
So except for the salvage building, the rest is working but a bit faulty?
So it seems it succeeds in the end right?
Will look into it!
Last edited:
I'm having the same issue. Does eventually gather, but it takes 3-5 attempts each time.
namednoob
Community Developer
- Joined
- Apr 25, 2014
- Messages
- 1,097
- Reaction score
- 25
Thanks for the feedback! Will let you know soon
So except for the salvage building, the rest is working but a bit faulty?
Shipment is also not working next toon I run with it I will take the logs for you and work orders I had disabled for what I early mentioned.
Except for salvaging when its build next to the gate and the movement hotspot being too close generating lag everything else seems to be running smoothly,yes.
Deams what is your game latency while testing everything? out of curiosity...
Last edited:
It does eventually succeed yes! I guess maybe due to latency?
slator
Member
- Joined
- Nov 16, 2012
- Messages
- 378
- Reaction score
- 1
like everyone else, i'm getting the "that item is already being used" when trying to collect ore and herbs.
the performance in game is also very negatively affected when running the botbase.... must be running rapid checks on herb/ore nodes among other things.
Now it's just running back in forth in the herb garden on a loop.
the performance in game is also very negatively affected when running the botbase.... must be running rapid checks on herb/ore nodes among other things.
Now it's just running back in forth in the herb garden on a loop.
Last edited:
namednoob
Community Developer
- Joined
- Apr 25, 2014
- Messages
- 1,097
- Reaction score
- 25
Another thing I've noticed is that you use for example:
But the correct would be to check that cast time of what was used be it a spell or item.
For example, for the salvage something like:
Not sure if that is already in milliseconds if not:
Needless to say salvageCrate would be the actually WoWItem for that given salvage box, which I believe to have 3 different ones.
Same goes for the hearthstone after you use it.
You might also for safety want to add an extra millisecond to it.
This would at the very list prevent a spell from being reused too fast before its ready.
There could be a prettier way to get the cast time but that was one way I found to work with other stuff I tried.
Looking thru the code I've noticed you use arbitrary wait times for a lot of things which you could possible replace with something like I mentioned above for a more realistic response of the action.
Code:
await Buddy.Coroutines.Coroutine.Wait(5000, () => Me.IsCasting);But the correct would be to check that cast time of what was used be it a spell or item.
For example, for the salvage something like:
Code:
await Buddy.Coroutines.Coroutine.Wait(salvageCrate.GetEffect(0).Spell.CastTime, () => Me.IsCasting);Not sure if that is already in milliseconds if not:
Code:
await Buddy.Coroutines.Coroutine.Wait(TimeSpan.FromMilliseconds(salvageCrate.GetEffect(0).Spell.CastTime), () => Me.IsCasting);Needless to say salvageCrate would be the actually WoWItem for that given salvage box, which I believe to have 3 different ones.
Same goes for the hearthstone after you use it.
You might also for safety want to add an extra millisecond to it.
This would at the very list prevent a spell from being reused too fast before its ready.
There could be a prettier way to get the cast time but that was one way I found to work with other stuff I tried.
Looking thru the code I've noticed you use arbitrary wait times for a lot of things which you could possible replace with something like I mentioned above for a more realistic response of the action.
Last edited:
hi, it is great but also some problems.
1. when mining and herb, it trys to pick it so fast, what I means after mining/herb (the cast bar is finished). my toon gets the spam 'I can't loot that right now' with item 'that is already being used' message and while my toon knee down to loot he will stand up straight away so fast. may be give a small time delay on mining/herb or else it will just keep on trying to pick the same herb but not loot it. I paused it and it works fine. I think bot is trying to cancel and move to next spot before the 'loot window' shows up. cos my toon loots soo fast that usually that loot window appears for 0.0001 second. If the game lags just a tiny little bit, it will not able to loot. for example it takes 1.5 seconds to pick a herb/mine, it seems like bot is trying to give another command to game at 1.4999 second therefore the loot window never appear. I am getting 20ms lag but sometimes game has spikes cause by HB, and when the spike appears in game, for HB it will not count the spike lag into account for the harvest time. so sometimes I hear this 'kaaa' sound in game when mining/herb cast bar was half way... the 'kaaa' sound must be HB trying to send another command. im not sure what it is as it's not showing up on log.
2. enchanting is no good. the 'Daily cooldown' is Temporal Crystal, that gives skill up and turn 1 Luminous shard into 1 crystal, NOT luminous shard which turn 20 draenic dust into 1 shard. and because it has no daily cooldown it keep on making shards lucky I was there to cancel it and mail all my dust away so I can continue, or else it keep on making shards till u run out of dust. but after I mailed dust away my toon just stand there with message 'daily CD found'
3. will not pick up any work orders at all but try to queue new orders, this happen in every building, it just walk to the NPC that queue work orders but without picking up the box first. so it's not able to queue new orders as old one are not cleared.
1. when mining and herb, it trys to pick it so fast, what I means after mining/herb (the cast bar is finished). my toon gets the spam 'I can't loot that right now' with item 'that is already being used' message and while my toon knee down to loot he will stand up straight away so fast. may be give a small time delay on mining/herb or else it will just keep on trying to pick the same herb but not loot it. I paused it and it works fine. I think bot is trying to cancel and move to next spot before the 'loot window' shows up. cos my toon loots soo fast that usually that loot window appears for 0.0001 second. If the game lags just a tiny little bit, it will not able to loot. for example it takes 1.5 seconds to pick a herb/mine, it seems like bot is trying to give another command to game at 1.4999 second therefore the loot window never appear. I am getting 20ms lag but sometimes game has spikes cause by HB, and when the spike appears in game, for HB it will not count the spike lag into account for the harvest time. so sometimes I hear this 'kaaa' sound in game when mining/herb cast bar was half way... the 'kaaa' sound must be HB trying to send another command. im not sure what it is as it's not showing up on log.
2. enchanting is no good. the 'Daily cooldown' is Temporal Crystal, that gives skill up and turn 1 Luminous shard into 1 crystal, NOT luminous shard which turn 20 draenic dust into 1 shard. and because it has no daily cooldown it keep on making shards lucky I was there to cancel it and mail all my dust away so I can continue, or else it keep on making shards till u run out of dust. but after I mailed dust away my toon just stand there with message 'daily CD found'
3. will not pick up any work orders at all but try to queue new orders, this happen in every building, it just walk to the NPC that queue work orders but without picking up the box first. so it's not able to queue new orders as old one are not cleared.
Last edited:
deams
Community Developer
- Joined
- Oct 20, 2014
- Messages
- 714
- Reaction score
- 25
deams
Community Developer
- Joined
- Oct 20, 2014
- Messages
- 714
- Reaction score
- 25
Could you post a log concerning the work orders at least?
Will fix asap the enchanting.
Ok, bunch of stuff working correctly now, but when it goes to do the missions it still has problems running to the center of the room then running to table, kinda getting stuck in a loop of that, but it ended up stopping that and then it got stuck saying a cd was up.
View attachment 4408 2014-12-06 21.23.txt
awesome bot so far!
View attachment 4408 2014-12-06 21.23.txt
awesome bot so far!
mining and herb is too fast and toon may take 1 hour attempts to harvest 1 node, tested with a non-lv100 and funny thing that +40xp pop up just not able to loot fast enough..
Alliance leatherworking could not find NPC to start order, it also goes to another building and spam it's a Tannery.
[03:29:35.844 N] [GarrisonBuddy] 0.5: Moving to start work order:The Tannery
[03:29:35.844 D] [GarrisonBuddy] 0.5: Could not find unit (0), moving to default location.
If this message is spammed, please post the ID of the PNJ for your work orders on the forum post of Garrison Buddy!
NPC 78207
Marianne Levine - NPC - World of Warcraft
it's not collecting orders or making daily CD, spamming Daily CD found. I restarted it with all setting turned off except for collecting work orders and another do daily CD to get a cleaner log.
first log is with every setting off only do professions. it has major spam just saying it detect leatherworking burnished leather and secret of draenor leatherworking. this also apply to all other professions, its not making daily stuff for tailoring as well
2nd log is with everything turn off except collecting shipment. and not happening.
Alliance leatherworking could not find NPC to start order, it also goes to another building and spam it's a Tannery.
[03:29:35.844 N] [GarrisonBuddy] 0.5: Moving to start work order:The Tannery
[03:29:35.844 D] [GarrisonBuddy] 0.5: Could not find unit (0), moving to default location.
If this message is spammed, please post the ID of the PNJ for your work orders on the forum post of Garrison Buddy!
NPC 78207
Marianne Levine - NPC - World of Warcraft
it's not collecting orders or making daily CD, spamming Daily CD found. I restarted it with all setting turned off except for collecting work orders and another do daily CD to get a cleaner log.
first log is with every setting off only do professions. it has major spam just saying it detect leatherworking burnished leather and secret of draenor leatherworking. this also apply to all other professions, its not making daily stuff for tailoring as well
2nd log is with everything turn off except collecting shipment. and not happening.
Last edited:
whytegallo
New Member
- Joined
- Oct 14, 2012
- Messages
- 9
- Reaction score
- 0
I don't know what I am doing wrong here. When I downloaded angler it I just dropped the folder in my bots folder and it works fine. But for some reason with this bot here, I can not get it to even load.. It will not show up on my bot list or anything. I have checked for replys here on the forums and read on allI can, not sure what I am missing? is there a link to "how to install bots" maybe im just missing something? Even though I have installed other bots np?
deams
Community Developer
- Joined
- Oct 20, 2014
- Messages
- 714
- Reaction score
- 25
Your folder should look like this:
<Path to your folder>/Honorbuddy/Bots/BotsGarrisonBuddyBeta/GarrisonBuddy.cs
whytegallo
New Member
- Joined
- Oct 14, 2012
- Messages
- 9
- Reaction score
- 0
Thanks for your reply deams. I found out what I did wrong, I had the folder still named a new folder and I just used your zip file, so it wasnt loading it. Changed the name of the folder to garrisonbuddy and its good to go now about to see how it does. Thanks again!
*last minute edit*
I got it running mixed mode with grind bot, came up it was updating my stuff and then went to grinding, I had 1 complete mission and all my work orders are full right this second, when do I expect it will return to my garrison to pick up new missions and such?
*last minute edit*
I got it running mixed mode with grind bot, came up it was updating my stuff and then went to grinding, I had 1 complete mission and all my work orders are full right this second, when do I expect it will return to my garrison to pick up new missions and such?
Last edited:
