[PAID] GarrisonButler

[deams]

Thanks for your reply deams. I found out what I did wrong, I had the folder still named a new folder and I just used your zip file, so it wasnt loading it. Changed the name of the folder to garrisonbuddy and its good to go now about to see how it does. Thanks again!

*last minute edit*
I got it running mixed mode with grind bot, came up it was updating my stuff and then went to grinding, I had 1 complete mission and all my work orders are full right this second, when do I expect it will return to my garrison to pick up new missions and such?

This is part of the settings in the bot config!

 

[whytegallo]

That's what I was thinking, the 60 minute you have as default is its return time I assume. Perfect, just making sure. Thanks again! looks good so far, will +1 and leave my results !

 

[Deports]

Will this help with leveling the garrison?

 

[blablub]

Another thing I've noticed is that you use for example:

await Buddy.Coroutines.Coroutine.Wait(5000, () => Me.IsCasting);

But the correct would be to check that cast time of what was used be it a spell or item.

For example, for the salvage something like:

await Buddy.Coroutines.Coroutine.Wait(salvageCrate.GetEffect(0).Spell.CastTime, () => Me.IsCasting);

Not sure if that is already in milliseconds if not:

await Buddy.Coroutines.Coroutine.Wait(TimeSpan.FromMilliseconds(salvageCrate.GetEffect(0).Spell.CastTime), () => Me.IsCasting);

Needless to say salvageCrate would be the actually WoWItem for that given salvage box, which I believe to have 3 different ones.

Same goes for the hearthstone after you use it.

You might also for safety want to add an extra millisecond to it.

This would at the very list prevent a spell from being reused too fast before its ready.

There could be a prettier way to get the cast time but that was one way I found to work with other stuff I tried.

Looking thru the code I've noticed you use arbitrary wait times for a lot of things which you could possible replace with something like I mentioned above for a more realistic response of the action.

<3 thanks, changed mining 5000->6000 and 2000->3000 and its working flawless now for me.
~35ms world/realm, wow at 60 fps framelock high prio
before it took like 3-6 trys at least to get it looted, now not even once (tested with 3 chars after the change all lvl 3 mine)
but like you said i think the best way is to check it the other way and maybe add some rnd ms delay (200-700 ms) to look more human (if thats possible)

edit: herb collection still dosen´t work for me even with 6500 or 8000(Coroutine.Garden.cs), stopped hb deleted precompiled stuff etc.. -> started again

 

[namednoob]

<3 thanks, changed mining 5000->6000 and 2000->3000 and its working flawless now for me.
~35ms world/realm, wow at 60 fps framelock high prio
before it took like 3-6 trys at least to get it looted, now not even once (tested with 3 chars after the change all lvl 3 garden / mine)
but like you said i think the best way is to check it the other way and maybe add some rnd ms delay (200-700 ms) to look more human (if thats possible)

The correct would be to use the 3rd example + 1000 as it will take the correct value from wow rather than use an arbitrary value that can fail at some point.
The random additional amount of milliseconds is also a good option but correct cast time + 1000 is just for the safety to ensure it will not collide.

Either way I am sure Deams will be using it to further release so you don't need to manually change it.

 

[blablub]

yea i got it, i don´t really how to write lua / c# but some years ago i wrote some basic c and also php code so i get most of it when i read it.

just thought that you might have to change more so i just modified the waiting time

 

[namednoob]

yes it depends on what you're using that example was for getting the cast time of items' spell such as salvaging boxes, hearthstone and the such for spell there different and easier method, which is why I suggest you to wait for Deams update instead.

 

[vcreation]

The correct would be to use the 3rd example + 1000 as it will take the correct value from wow rather than use an arbitrary value that can fail at some point.
The random additional amount of milliseconds is also a good option but correct cast time + 1000 is just for the safety to ensure it will not collide.

Either way I am sure Deams will be using it to further release so you don't need to manually change it.

I just open those mining and herb file and find the 5000 change to 6000 and 2000 change to 3000... now I get that 'tak' sound when cast bar is half way.. but gathering works perfect now...

anyone else have professions, collecting shipment and work order and daily profession not working? ? ? ? none of them is working for me >_<

 

[namednoob]

Well I'm not saying you guys can't change it, all I am saying is that there is a proper way to change the code like the example which will not require you to set arbitrary number to have it properly functioning, that Deams will very like check that out.

If you in fact want to put numbers there then at least check the skill or item cast time at wowhead.com and use the proper value so you reduce the chances of having an issue with it

 

[vcreation]

tested it again and still not working, mining and herb don't work as it's trying to loot too fast

Alliance forge don't work
[05:14:56.537 N] [GarrisonBuddy] 0.5.1: Moving to start work order:The Forge
[05:14:56.537 D] [GarrisonBuddy] 0.5.1: Could not find unit (79817), moving to default location.
If this message is spammed, please post the ID of the PNJ for your work orders on the forum post of Garrison Buddy!

79817 is horde blacksmith assistant.

Name = Yulia Samras
Wowhead Id = 77792
Faction = 1733 [Alliance Generic]
Location = <1831.39, 203.0134, 72.79379>
<Vendor Name="Yulia Samras" Entry="77792" Type="Repair" X="1831.39" Y="203.0134" Z="72.79379" />


on top of that, there is a bug in game where when u talk to assistant to start work order but the UI will not open. it require u to move away from that NPC and try again. i wonder if it's possible to add that as it's very common problem.

 

[Kolgarn]

 private static readonly WoWPoint TableHorde = new WoWPoint(5557, 4606, 141);

That what i use for Garrison 3 lvl Horde. Perfect to active missions.

 

[blablub]

anyone else have professions, collecting shipment and work order and daily profession not working? ? ? ? none of them is working for me >_<

drawf bunker works at least -> spend garrnison ressourses for iron scraps
mine / herb didn´t worked for me also neither turn in nor collecting.
but since i updated form 0.4->0.5.1 it gets at least the garrison cache

 

[justinr1234]

New version is much better .... I've got a bug though:

The game complains about "that is already being used" on a mine node and then it gets stuck in a loop of now grabbing the loot inside and mine. It appears there needs to be more of a lag timer after issuing the interact command with an item otherwise the lag causes the bot to start moving and not finish looting the mine. I fixed it by changing your code to this:

Inside Coroutine.Mine.cs the task CleanMine()
http://i.imgur.com/tvCwVhe.png

 

[justinr1234]

Another bug: It will get stuck in an infinite loop if you're GREATER THAN 0 and less than MINIMUM required materials for a work order.

For instance:
Step 1 - Tailoring work orders exist
Step 2 - Go start all work orders
Step 3 - Only 2 Sumptuous Furs in inventory, when 5 are required per work order
Step 4 - Run "click start work button" routine
Step 5 - Loop back to Step 1

 

[wikki74]

Any idea what this could be?

Standing still: 60 fps
while moving: 10 fps

Happens only with this bot^^

 

[Niteowl]

Is there anyway you could have each building have its own on/off switch for work orders? I want the bot to collect and start work orders everywhere except dwarven bunker. I cant afford to use garrison resources on work orders, only reason I built the bunker is for the free raid bonus roll.

 

[DCarr]

Big Thanks to Deams for his work on this bot and for his work on AutoAngler. This bot is working but I am also having a serious issue with looting ore and herbs too quickly and as has been stated before an issue with a frame rate drop when moving. Not a moan, just wanting to make the issue known as it's a beta. Keep it going Deams, it is really appreciated.

 

[poltoseg]

Hi!
How to set a ban on placing orders only "military factory", as it requires resources that are already lacking. But all other orders he must perform.

 

[Ipad]

Same issue with mining/herb as the previous members stated get 2-3 tries to loot the mine sometime so i guess it need a 1000 ms timer between gathering casts to be sure it works with all combos(pc/world lag etc). Everything else seems ok for me.

 

[Tiebiex]

Is it possible that you add the "real" Prof cds to do? Not just the one of the buildings ( Enchanter research e.g.)