Wheredidigo
Community Developer
- Joined
- Dec 15, 2013
- Messages
- 417
New Version is up with all current BugFixes/Feature Requests put in...and then some.
You should really join the Skype Dev Chat we have going for RB.![]()
They do have a lot of adverts, but as long as you keep a chat window open, you shouldn't see them.If it was anything but Skype, I'd be there. I've had nothing but issues with that program and it confiscating system resources as it finds ways to generate more revenue from me.
I think I've figured out what is going on. I'm testing it more on my end first, but I should have a version out either today or tomorrow with a fix.For some reason its trying to change my job to adventurer?
[19:42:14.255 D] Reloading AssemblyLoader<ff14bot.Interfaces.ICombatRoutine> - Initializing
[19:42:21.232 D] [RoutineManager] Routines have been reloaded. Current class-specific list:
[19:42:21.232 D] Kupo [GladiatorPaladin] v1.0.279.0
[19:42:21.232 D] Ultima v1.0.0.0
[19:42:32.021 N] Bot Thread Started.
[19:42:32.202 N] Connection to 192.99.148.87:31214 established.
[19:42:32.218 N] Clearing all hooks.
[19:42:32.218 N] Adding Destiny V2.0.0.2 Hooks
[19:42:32.218 D] Inserted new hook [TreeStart @0] a947fd8d-9eba-49c5-bab8-f563e7dfebdb
[19:42:32.218 D] Inserted new hook [TreeStart @1] 05ce0968-1fa6-477b-ab15-c3e48fdae3fb
[19:42:32.218 D] Inserted new hook [TreeStart @2] 64ef742d-7823-4f60-9017-9d3dcd8b392c
[19:42:32.228 D] Added new hook [Pull] 5e7d5525-2d79-46d1-b0b7-ae13e9a8ed87
[19:42:32.228 D] Added new hook [RoutineCombat] 26bb1837-9fda-4e58-8d60-54047a550d0b
[19:42:32.229 D] Added new hook [HotspotPoi] 8809518b-3892-4e54-84be-3ba8098a01d7
[19:42:32.229 D] Added new hook [SetDeathPoi] a1d41e93-36b2-4300-ac99-34bd4fe60025
[19:42:32.229 D] Added new hook [SetCombatPoi] 8db5d360-01a7-4bcb-aaa3-b226ba142635
[19:42:32.229 D] Added new hook [SetHotspotPoi] 1a4a3097-f925-4ffc-87bc-abb9d265f194
[19:42:32.229 D] Added new hook [SelectPoiType] 6bf2b4df-b7dd-46ad-9f5e-57212136719e
[19:42:32.230 D] Added new hook [SetFatePoi] f0126040-440d-4504-a897-f0de5cbd292a
[19:42:32.230 D] Added new hook [SetRestPoi] 48e4e8d5-3252-4daa-bbfb-8f0baf7cc5f0
[19:42:32.231 D] Replaced hook [SelectPoiType] 831580d9-aef2-4c79-9457-3beb7c2c9804
[19:42:32.232 D] Added new hook [FatePoi] fac284b6-6292-4c09-8f6e-52b91843c401
[19:42:32.232 D] Added new hook [PoiAction] cce5cd9b-c171-4057-aa3c-0ede905533dd
[19:42:32.232 D] Added new hook [RestPoi] e5143f31-d1d1-4825-bf83-294c45672bad
[19:42:32.232 D] Added new hook [PoiAction2] 75115ebd-9529-4dc3-8d53-67adea233d78
[19:42:32.233 D] Added new hook [TreeStart] 8d362096-9602-48f2-aca0-ba2624412174
[19:42:32.236 N] Adding Destiny V2.0.0.2 Hooks
[19:42:32.236 D] Inserted new hook [TreeStart @0] a947fd8d-9eba-49c5-bab8-f563e7dfebdb
[19:42:32.236 D] Inserted new hook [TreeStart @1] 05ce0968-1fa6-477b-ab15-c3e48fdae3fb
[19:42:32.236 D] Inserted new hook [TreeStart @2] 64ef742d-7823-4f60-9017-9d3dcd8b392c
[19:42:32.297 N] [Ultima] Loading: Paladin
[19:42:32.325 N] [Destiny V2.0.0.2] Trying to change job to Adventurer
[19:42:32.329 D] Buddy.Coroutines.CoroutineUnhandledException: Exception was thrown by coroutine ---> System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.
at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
at DestinyPlugin.Destiny.<ChangeJob>d__17.MoveNext() in c:\Users\Parliam3nt\Documents\RBuddy\Plugins\Destiny\Destiny.cs:line 233
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at TreeSharp.ActionRunCoroutine....()
--- End of inner exception stack trace ---
at Buddy.Coroutines.Coroutine.CheckPostConditions(Boolean shouldBeCanceled)
at Buddy.Coroutines.Coroutine.Resume(Boolean forStop)
at Buddy.Coroutines.Coroutine.Resume()
at TreeSharp.ActionRunCoroutine.Run(Object context)
at TreeSharp.Action.RunAction(Object context)
at TreeSharp.Action.<Execute>d__0.MoveNext()
at TreeSharp.Composite.Tick(Object context)
at TreeSharp.Decorator.<Execute>d__0.MoveNext()
at TreeSharp.Composite.Tick(Object context)
at TreeSharp.PrioritySelector.<Execute>d__0.MoveNext()
at TreeSharp.Composite.Tick(Object context)
at ff14bot.Behavior.HookExecutor.Run(Object context)
at TreeSharp.Action.RunAction(Object context)
at TreeSharp.Action.<Execute>d__0.MoveNext()
at TreeSharp.Composite.Tick(Object context)
at TreeSharp.PrioritySelector.<Execute>d__0.MoveNext()
at TreeSharp.Composite.Tick(Object context)
at ff14bot.TreeRoot.() --> System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.
at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
at DestinyPlugin.Destiny.<ChangeJob>d__17.MoveNext() in c:\Users\Parliam3nt\Documents\RBuddy\Plugins\Destiny\Destiny.cs:line 233
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at TreeSharp.ActionRunCoroutine....()
[19:42:32.386 N] [Destiny V2.0.0.2] Trying to change job to Adventurer
I think I've figured out what is going on. I'm testing it more on my end first, but I should have a version out either today or tomorrow with a fix.
private static void SetFateBotSettings()
{
FatebotSettings.Instance.BossEnabled = Settings.Instance.BossEnabled;
FatebotSettings.Instance.EscortEnabled = Settings.Instance.EscortEnabled;
FatebotSettings.Instance.MonsterSlayingEnabled = Settings.Instance.MonsterSlayingEnabled;
FatebotSettings.Instance.LevelCheck = Settings.Instance.LevelCheck;
FatebotSettings.Instance.MaxLevel = Settings.Instance.MaxLevel;
FatebotSettings.Instance.MinLevel = Core.Me.ClassLevel - Settings.Instance.MinLevel;
FatebotSettings.Instance.BossPercentRequired = Settings.Instance.BossPercentRequired;
}
private void MinLevelUpDown_ValueChanged(object sender, EventArgs e)
{
Settings.Instance.MinLevel = (int)MinLevelUpDown.Value;
Settings.Instance.Save();
FatebotSettings.Instance.MinLevel = (int)MinLevelUpDown.Value;
FatebotSettings.Instance.Save();
}
Started this with level 8 MRD set Horizon for 1-9 and aleport for 10-14. The bot is at level 11 and still in horizon. I manually ported to aleport and started the bot and in teleported to horizon
Started this with level 8 MRD set Horizon for 1-9 and aleport for 10-14. The bot is at level 11 and still in horizon. I manually ported to aleport and started the bot and in teleported to horizon
For some reason, setting the "Max Levels Below" parameter is directly setting that variable to the Fatebot's minimum level field; Any number I set this to is placed directly in the Botbase setting's Min Level field. I know that this code is being used:
Code:private static void SetFateBotSettings() { FatebotSettings.Instance.BossEnabled = Settings.Instance.BossEnabled; FatebotSettings.Instance.EscortEnabled = Settings.Instance.EscortEnabled; FatebotSettings.Instance.MonsterSlayingEnabled = Settings.Instance.MonsterSlayingEnabled; FatebotSettings.Instance.LevelCheck = Settings.Instance.LevelCheck; FatebotSettings.Instance.MaxLevel = Settings.Instance.MaxLevel; FatebotSettings.Instance.MinLevel = Core.Me.ClassLevel - Settings.Instance.MinLevel; FatebotSettings.Instance.BossPercentRequired = Settings.Instance.BossPercentRequired; }
which makes me think that the Core.Me.ClassLevel value is empty/null. I'll try to investigate this a bit and find the root cause and suggest a fix. Unfortunately, settings changes are not logged, but even if they were I don't think it could tell me anything more then I already observed at this point.
Edit: Running the code in the console (replacing the Settings class properties with direct int values) works without issue; not sure why the same code has a hiccup in the plugin. I'll hunt through it and see if the MinLevel field is used anywhere else in the plugin.
Edit 2: Found it. Looks like this code runs instead when you first set it instead of using Core.Me.ClassLevel:
Code:private void MinLevelUpDown_ValueChanged(object sender, EventArgs e) { Settings.Instance.MinLevel = (int)MinLevelUpDown.Value; Settings.Instance.Save(); FatebotSettings.Instance.MinLevel = (int)MinLevelUpDown.Value; FatebotSettings.Instance.Save(); }
Just need to update it to match the other codeI would also recomend adding the SetFateBotSettings() function call to the OnBotStart method to avoid an issue caused by the user inputing the settings as one class and then changing to the class to be leveled before starting the bot.
Here are the files with the changes I suggested:
View attachment 180451
View attachment 180452
You were being effected by the "[05:47:23.888 N] [Destiny V2.0.0.2] Trying to change job to Adventurer" bug. It was causing the plugin to throw an exception which is why it wasn't teleporting to the correct location. The bug does indeed have to do with settings, so the next time you restarted the bot, the settings would have been correct and the bug goes away.
I'll have a fix out for the bug sometime later today. I'm trying to get Patrol working in Destiny so hopefully I'll be able to get the fix out with the new feature of Patrol. If I can't get Patrol working by the end of the day, I'll just release a version that contains bugfixes.
No, you will want to disable and remove any versions of the Patrol plugin you have.I'm assuming you still need the patrol plugin enabled together with Destiny. Using it now without any issues.. yet. Will continue to test it out. Thanks for the update!
it seems like the range of the patrol dunction is very limited. I often find my character just standing around idle.
In fate bot i have selected "nothing" as action to do when no fates are available. always had it like that when using Patrol.
Whats the recommended setting to use with Destiny? And is it a range issue with the plugin? maybe set too low?
while (counter <= 5 && target.Distance(Core.Me.Location) > RoutineManager.Current.PullRange)
return GameObjectManager.GetObjectsOfType<BattleCharacter>()
It seems like the range is based on what you have set in your CR from this code:
For mine, it is set to 15 and I do not know how to change it; even in the console, the property is read-only. Ultima does not have a setting for it within it's interface.Code:while (counter <= 5 && target.Distance(Core.Me.Location) > RoutineManager.Current.PullRange)
Edit: I misread it, the code already has the targets by that point and the portion quoted just causes it to spend between 3 and 15 seconds moving to target before trying to attack again. It looks like this code actually adds the targets to the stack:
though I do not know the range that is being usedCode:return GameObjectManager.GetObjectsOfType<BattleCharacter>()