hey iggi, its been working great
i ended up decreasing the min distance, increasing the max distance, and increasing the number of tries (because of the distances) but I still rarely get a ray cast problems when it doesnt realize it can fish while standing in the shallow water. it already fishes from shallow water elsewhere, so I assume you just need a tweak on how deep it can go.
ive also got water walking, but it seems to ignore that. fishing + waterwalking seems buggy anyway, i fall through often. so I probably wouldnt bother with it.
ive noticed when it flys in to fish from a spot i can tell its targeted a specific spot, usually right on the edge of something, but it ends up short or too far usually by less than 1 foot and ends up falling down into the water instead. often it sits there swimming just under the surface (because of the fall) and doesnt know what to do, and i have to intervene or die from drowning. seems exaggerated by the fact that it flys down instead of dismounting and falling (probably for safety?), so sometimes while its holding the down key my mounted char slides down a slight ramp that it wouldn't have done if it fell, and ends up in the water too. but, this seems to only happen if it misses the target like i mentioned.
i noticed a bug with the bounce mode, after fishing a pool it seems to forget which way it was going. seems like a 50/50 chance of returning the direction you just came from, often finding another pool, then backtracking again. because of this i think 'i' fished two pools that constantly respawned back and forward for a good hour, great for lots of fish, but it doesnt really look natural.
another suggestion, that might be too much effort for the result. would be to ban pools that disappear more than once after landing. usually because of phasing, or bugged pools or something. this is especially evident in uldum, but ive also seen it in twilight highlands and in deepholm. obviously it may just be normal wow stuff that made it disappear so one might have to detect if we've returned to the pool several times and if it happened every time, then ban it. the alternative of course, is for me to blacklist the location in my profile.
thanks for all your effort into this bot.