It's all of them, really.
Is there a line I can add to the default logic that states If the enemy pet is 4 levels or more higher than mine, then the low level pet casts one spell, then swaps out? If there is, that would make this bot simply perfect.
This is an ongoing request with the plugin, so not a new issue.
One answer is to use meta logic to 'handle' the specific requirements for pet levelling, ie to code it into the normal combat logic, but not every pet has a cooldown, and the combat + logic system does not count each turn at all currently.
The puppy logic system in the development version is an attempt to avoid meta-logic, ie a list of settings controlling how to swap between pets, what conditions to swap with, and what pets to swap from and to, outside of combat, and while in combat.
To illustrate, meta-logic, ie swap - logic, for want of a better name, a set of variables would have to be parsed universally as part of every round, to determine if a swap should occur, every few ticks. Based on family vs family. Group health. Enemy timers/cc. Cooldowns. Counters. Rounds of combat, when to forfeit, etc.
Much easier if it was limited to special situations where the results can be validated by others, ie complex trainer combat options with prearranged team builds.
Essentially this would replace pet swapper, and also change the internal combat system as well, so it could handle the trainer fights at higher levels.
Essentially a 30 line logic that considers which trainer pet is starting first, swaps to the appropriate pet, engages, forfeits if the situation breaks down or the enemy pet hasn't been hit, or the enemy swaps out, heals himself, etc.
Coding the celestial tourney system needs to be that retentive, due to the strategy often applied while people attempt lowbie swaps in the tourney for 5k pet xp.
Technically, you can't make every pet have a 1 turn swapout, just isn't logically possible as there are a handful that don't have cd's at level 5.
Second option is to code a logic handler for levelling, just to identify a lowbie pet by petid, and override the standard logic for lowbie pets, so the normal logic is ignored, the pet swaps in, and is considered to be dead for the encounter once the round has completed or a cool down has completed.
This option would require a few variables, the petid in each combat slot, a 'dive' variable with the petid to use when the petid identified has been sent in, and a round counter for all 3 pets.
Both strategies can use the same multi logic system, or a straight single logic system, but one requires a few months of testing.
And some migraine inducing logic handling.
I've even changed the default logic, but that isn't working either. Could you tell me what I'm doing wrong?
If you guys want something done, it doesn't have to be done by me. I'll look into these things then.