[Bot] PokehBuddy (Conversion of Plugin)

[Prostak]

This is a fix in WantSwapping() that so far works for me in Ringerx2 mode: no swapping in loop, no trying to load a dead pet:

if (slot1rating < slot2rating || slot1rating < slot3rating)
{
//swap pet
Log("Swapping Pets");
if (slot2rating >= slot3rating && myPets[1].Health > 30 ) CombatCallPet(2);
if (slot2rating < slot3rating) CombatCallPet(3);
//Thread.Sleep(1000);

}
else
{
if( CanSelect(3) ) CombatCallPet(3);
if( CanSelect(2) ) CombatCallPet(2);
CombatCallPet(1);
}

Changes are in bold and are Ringerx2 oriented. They may be helpful in other modes preventing loops and hangs but may break the desired strategy.

Next thing that bothers me now (or should I say "next disaster"?) is: Favorites Only filter is not working in PBS. I've modified the code to execute it unconditionally, still I am getting all my pets in the result. I want to level like 10 more pets, but 60 are included in the levelling loop.
Lua.DoString("C_PetJournal.SetFlagFilter(LE_PET_JOURNAL_FLAG_FAVORITES, true);");
Has Blizzard changed flag value or something?

 

[hackersrage]

This is a fix in WantSwapping() that so far works for me in Ringerx2 mode: no swapping in loop, no trying to load a dead pet:

Changes are in bold and are Ringerx2 oriented. They may be helpful in other modes preventing loops and hangs but may break the desired strategy.

Next thing that bothers me now (or should I say "next disaster"?) is: Favorites Only filter is not working in PBS. I've modified the code to execute it unconditionally, still I am getting all my pets in the result. I want to level like 10 more pets, but 60 are included in the levelling loop.
Lua.DoString("C_PetJournal.SetFlagFilter(LE_PET_JOURNAL_FLAG_FAVORITES, true);");
Has Blizzard changed flag value or something?

I am unsure where to put that contribution. The latest version I posted has a brand spanky new UI. It doesn't have any of the rule-generation stuff aside from white/blacklist. I am unsure what exactly is needed from the Logic creation thing as over 50% of the buttons there crash the plugin (and have done this since day 1). Blizzard did change the way that pet swapping can occur though.

 

[Prostak]

I am unsure where to put that contribution.

This is not a contribution yet. This is sort of recommendation to persons who are comfortable with changing cs code re "How to avoid swapout loops in Ringerx2 mode". Not a GUI-related problem.

 

[powstrike]

Hi, excited that you are putting in all the effort to fix this and appreciate it. However I tried running it and the bot would not even start, did a fresh install of Honorbuddy v2.5.11936.755 and loaded guadah's pet profiles.

 

[hackersrage]

I have it working now. To keep this thread shorter, I have moved this to it's own topic here >> [Botbase] PokehBuddy (Revised for WoD)

PS: Testing for 5 minutes, I leveled 3 pets from level 1 to 5.

 

[Prostak]

This is a fix in WantSwapping() that so far works for me in Ringerx2 mode: no swapping in loop, no trying to load a dead pet:

This (not loading a dead pet) appeared to be not true. One more fix is needed to avoid hangs on dead pets.
In the file PokehBuddy.cs replace the function SelectNewAction with:

        private Composite SelectNewAction()
        {
            return new Styx.TreeSharp.Action(
                ctx =>
                {
		    if( CanSelect(3) ) CombatCallPet(3);
		    else if( CanSelect(2) ) CombatCallPet(2);
                    else CombatCallPet(1);
                    
                    return RunStatus.Success;
                });

Original logic had a bug and I see a little reason to fix it.
The new logic is very simple, it implements a fixed swaping order: when a pet dies (in Ringerx2 mode done properly it should be Pet2), the code will try to load Pet3, if it is also dead it will try to load Pet2 - just in case, and only then - Pet1.
In Ringerx2 mode I have 25 in slots 2 and 3 and am running them to death, no swapping.

BTW in order to make your ringers fight to death as opposed to swapping out upon reaching health<30 your should replace
SWAPOUT Health(THISPET) ISLESSTHAN 30
with
SWAPOUT Health(THISPET) ISLESSTHAN 0
in like thousand different places, in both cs and xml files. Or you should change logic parser to ignore this line, whichever is easier.

 

[zennn]

Can anyone explain to me what ringerx2 mode is

 

[zennn]

Or Just pass me one of their working versions

 

[harrow90]

For some reason I can't see it in the drop down menu in the honorbuddy client.. I've installed it via SVN in Honorbuddy/Bots/PokehBuddy - any idea what i've done wrong?

 

[zennn]

For some reason I can't see it in the drop down menu in the honorbuddy client.. I've installed it via SVN in Honorbuddy/Bots/PokehBuddy - any idea what i've done wrong?

Try de rar on the frontpagina , worked for me

 

[Petuldo]

OK guys, I had 2 issues -
#1 unnecessary (low health) swapping
# 2 - not changing new pet after 1 dies

This one works for me with Ringerx2 PetBattleSwapper, even with coding in pet CDs (3rd button)

Try it and let me know

JUST Unpack to HonorBuddy/Bots

 

[KopyHB]

does not change from one pet to die (swaping pet)

 

[Vevio]

I have done all the steps but i cant see the pokehbuddy selection in the honorbuddy drop down for bot base selection...

 

[Prostak]

I have done all the steps but i cant see the pokehbuddy selection in the honorbuddy drop down for bot base selection...

Try this: https://www.thebuddyforum.com/honor...198180-bot-prosto_pets-battle-pets-4-1-a.html

 

[Vevio]

I tried the linked bot but that doesn't seem to run the profile I want to use which appears to be made for this bot base . Anyone know why I'm unable to see the bot as a option in the drop down list

 

[Bahnas]

I get this which causes me to not see the bot in the honorbuddy bot dropdown selector. Help pls. ps. did everything exactly like you said.

Compiler Error: d:\Honorbuddy\Bots\AutoAngler2\Coroutines.Fishing.cs(88,56) : error CS0103: The name 'FilletFish' does not exist in the current context

 

[OWGrand]

Could somebody say is any botbases for pets that work for non eng client? Want to level up my pets. Thanks!

 

[mcphaidin]

This is my error

Compiler Error: c:\Honorbuddy\Bots\PokehBuddy\PokehBuddy.cs(416,50) : error CS1501: No overload for method 'Dismount' takes 0 arguments

 

[Slifty]

Fresh hb installation and svn folder

Error:

Compiler Error: E:\Software\Honorbuddy\Bots\PokehBuddy\PokehBuddy.cs(416,71) : error CS7036: There is no argument given that corresponds to the required formal parameter 'reason' of 'Mount.Dismount(string)'

 

[antonov314]

Fresh hb installation and svn folder

Error:

Compiler Error: E:\Software\Honorbuddy\Bots\PokehBuddy\PokehBuddy.cs(416,71) : error CS7036: There is no argument given that corresponds to the required formal parameter 'reason' of 'Mount.Dismount(string)'

Go the same error