Damn, you're going to make me look at the code aren't you? What you've given should work.
My thoughts on this are:
Leave the tank to generate aggro normally and just boost priority for dps.
Add the id definition to the list with the others to keep it together.
Put the code in the dps snippet between the Shadow Pan Warden and the Gripping Hatred.
Code:
if (StyxWoW.Me.IsDps())
{
if (unit.Entry == ShadoPanWardenId && unit.CastingSpellId == FocusEnergy)
priority.Score += 500;
[B]if (unit.Entry == RegeneratingSha)
priority.Score +=50000;[/B]
if (unit.Entry == GrippingHatred)
priority.Score += 50000;
}
This should keep the code in logical sequence for if you need to debug. Keep it in encounter order if possible.