[Plugin] Giles Stash & Loot Rule Replacer

[thegosu]

How do you know what items the plugin keeps?

 

[Midas]

How do you know what items the plugin keeps?

Not quite sure exactly what you're asking but I will try three different interpretations of your question;

1. "Where are mah itemz at?"
Have a look in your stash, the kept items should be there, unless you had an awful run full of deaths and bad luck in which case you will be empty handed. The bar is set pretty high, you don't want a bunch of 10K items to sort through do ya?

2. "Uhh what did it do with the 1500 items collected in the last 24 hours?"
In the plugin folder there will be two logs.
One for stashed items, conveniently named StashLog.log
And another for junked items named...you guessed it JunkLog.log

3. "How does this magical gilesbot decide what items make the cut?"
Click on the settings for the plugin where you can set score threshold for each item group.
Gilesbot evaluates each item based on some secret sauce including 532 herbs and spices known only to giles himself and gives the item a score. This is an attempt to weed out cheap junk items and give you only the expensive ones. It's based on what qualities sell for good $ on the AH. You may be skeptical, but in time you will learn to trust gilesbot...mainly because who wants to sort through 1500 items? haha

 

[ysosrslawl]

I figured out what my issues were when using ur plugins, good work

 

[darkfriend77]

Finally, until DemonBuddy, I'd never programmed before

that's why i gave u some tips like the dictonary ...

but anyway ...

the problem still appears on all 3 bots .... as soon as they are in need to repair the will get stuck in an infinit loop ^^^ ... if i go manually ...to the repair npc and click on him ...
the bot continues ... but then it goes to salvage ... and gets between the salvager and the stash at the corner .. ^^ maybee u should calculate a way around obstacles ...

its all in act2 infern ...quest city of blood

 

[sinterlkaas]

hey giles..

I think you have to change some of your code to make it work better for ppl that have problems when using demonbuddys autostart commandline argument..

The event hooking like onstart + onjoin ... etc should go to the plugin OnInitialized and in OnEnabled you should add a global boolean that will set to true if the plugin gets enabled and in ondisable to set it to false

in the eventhooks just add the if (!isEnabled) return; ... this should fix the salvage problem I guess ..
did not test this but from a quick scan on your code I think this could be the problem

EDIT:

LOL this wont ofc .. it does exactly the same ... only a bit different
just out of bed .. so brains don't work that well yet hehe ..

2nd Brainfart would be this:

add in OnEnabled()
if (BotMain.IsRunning)
Call the HandleBotStart event ..
and if (zeta.isingame)
Call the HandleGameJoin thingy .. if needed

 

[MrWizard516]

Hello Giles I was wondering if it would be possible for you to add in an option for low levels to be able to pickup ALL Magic1+ Items and gems and salvage them as well? This would be awesome for those of us leveling characters.

 

[GilesSmith]

that's why i gave u some tips like the dictonary ...
but anyway ..
the problem still appears on all 3 bots .... as soon as they are in need to repair the will get stuck in an infinit loop ^^^ ... if i go manually ...to the repair npc and click on him ...
the bot continues ... but then it goes to salvage ... and gets between the salvager and the stash at the corner .. ^^ maybee u should calculate a way around obstacles ...
its all in act2 infern ...quest city of blood

Thanks, I see the issue now - it seems to be only if like you say it tries to go straight to the sell vendor instead of to salvage first. I'll have a fix for this in the next version (a couple of safety waypoints first to force it around the corners, like I did in act 1 and act 3). Act 2 needs an extra safety waypoint because of the cornering & stairs. Check for a new version tonight!

Hello Giles I was wondering if it would be possible for you to add in an option for low levels to be able to pickup ALL Magic1+ Items and gems and salvage them as well? This would be awesome for those of us leveling characters.

Yes I was thinking about this. I mean the main focus of the plugin previously was for inferno farming, since it was all about the scoring of items and evaluating good from bad... but since then it's evolved into a replacement, optimized, and less buggy item and town-run handler in general (and now with lots of funky stats!). I'm contemplating combining item auto-equipper and world object handler in for version 2.0 and renaming it "Giles Item Handler Replacement" or something - since it's no longer just about the stash & loot-rules as it once was! Though I'm aware that not everyone wants my scoring/stashing system instead of old-fashioned loot-rules, but still want to use world object handler by itself, so it's a tricky one. We'll see... I may well incorporate it all, add some options to disable parts, and then make it work for low-level characters too (complete with auto-equipping if they want). At this point, I'm still unsure! At the very least I could enable looting of any ilvl gems/potions/tomes/items I suppose for those that want to use the town-run and looting replacements while levelling

hey giles..

What is the actual cause of the issue though? I thought it was simply a case of DemonBuddy not loading plugins before starting (something Apoc says he's now aware of and is going to try and fix for the next release)!?!? I think we can probably just wait for the next DB release to fix it properly rather than trying awkward workarounds!?

 

[MrWizard516]

Yes I was thinking about this. I mean the main focus of the plugin previously was for inferno farming, since it was all about the scoring of items and evaluating good from bad... but since then it's evolved into a replacement, optimized, and less buggy item and town-run handler in general (and now with lots of funky stats!). I'm contemplating combining item auto-equipper and world object handler in for version 2.0 and renaming it "Giles Item Handler Replacement" or something - since it's no longer just about the stash & loot-rules as it once was! Though I'm aware that not everyone wants my scoring/stashing system instead of old-fashioned loot-rules, but still want to use world object handler by itself, so it's a tricky one. We'll see... I may well incorporate it all, add some options to disable parts, and then make it work for low-level characters too (complete with auto-equipping if they want). At this point, I'm still unsure! At the very least I could enable looting of any ilvl gems/potions/tomes/items I suppose for those that want to use the town-run and looting replacements while levelling

Thank you for your response.

 

[darkfriend77]

Thanks, I see the issue now - it seems to be only if like you say it tries to go straight to the sell vendor instead of to salvage first. I'll have a fix for this in the next version (a couple of safety waypoints first to force it around the corners, like I did in act 1 and act 3). Act 2 needs an extra safety waypoint because of the cornering & stairs. Check for a new version tonight!

thx ... it's nice that u put so much effort in to this ... gona do some debugging on the functions of demonbuddy ... which u think are buggy ... maybee they fixed it ....^^ allready ... an other thing that would be great is to ... work the same kind as d3 is ... d3inferno.com shows from reversenginering how the structure is build up ... the mods and the items ... this way you could build up much acurater evaluating algorithms .. i builded up the structure already so if u want the code i can give it to u ...

 

[PainfulDeath]

So, have anyone found a way to handle freezes/disconnects and restart d3/db without having the "plugins not loading properly" issue, or is at this time bot with this particular plugin not afkable at all? Going out of town for a couple of days, would've loved to see a full stash of goodies when I come back

[20:30:51.353 N] [GilesStashReplacer 1.8.5] Chest sockets=1
[20:30:51.443 N] [GilesStashReplacer 1.8.5] Chest sockets=3
[20:30:53.393 N] [GilesStashReplacer 1.8.5] Chest sockets=1
[20:30:53.423 N] [GilesStashReplacer 1.8.5] Chest sockets=3
[20:30:53.773 N] [GilesStashReplacer 1.8.5] Chest sockets=1
[20:30:53.813 N] [GilesStashReplacer 1.8.5] Chest sockets=3
[20:30:54.183 N] [GilesStashReplacer 1.8.5] Chest sockets=1
[20:30:54.213 N] [GilesStashReplacer 1.8.5] Chest sockets=3
[20:30:54.583 N] [GilesStashReplacer 1.8.5] Chest sockets=1
[20:30:54.613 N] [GilesStashReplacer 1.8.5] Chest sockets=3
[20:30:54.943 N] [GilesStashReplacer 1.8.5] Chest sockets=1
[20:30:54.973 N] [GilesStashReplacer 1.8.5] Chest sockets=3
[20:30:55.323 N] [GilesStashReplacer 1.8.5] Chest sockets=1
[20:30:55.363 N] [GilesStashReplacer 1.8.5] Chest sockets=3
[20:30:55.723 N] [GilesStashReplacer 1.8.5] Chest sockets=1
[20:30:55.763 N] [GilesStashReplacer 1.8.5] Chest sockets=3
[20:30:56.123 N] [GilesStashReplacer 1.8.5] Chest sockets=1
[20:30:56.153 N] [GilesStashReplacer 1.8.5] Chest sockets=3
[20:30:56.563 N] [GilesStashReplacer 1.8.5] Chest sockets=1
[20:30:56.593 N] [GilesStashReplacer 1.8.5] Chest sockets=3
[20:30:56.913 N] [GilesStashReplacer 1.8.5] Chest sockets=1
[20:30:56.953 N] [GilesStashReplacer 1.8.5] Chest sockets=3
[20:30:57.283 N] [GilesStashReplacer 1.8.5] Chest sockets=1
[20:30:57.323 N] [GilesStashReplacer 1.8.5] Chest sockets=3
[20:30:57.653 N] [GilesStashReplacer 1.8.5] Chest sockets=1
[20:30:57.683 N] [GilesStashReplacer 1.8.5] Chest sockets=3
[20:30:57.893 N] [GilesStashReplacer 1.8.5] Chest sockets=1
[20:30:57.923 N] [GilesStashReplacer 1.8.5] Chest sockets=3
[20:30:58.173 N] [GilesStashReplacer 1.8.5] Chest sockets=1
[20:30:58.213 N] [GilesStashReplacer 1.8.5] Chest sockets=3
[20:30:58.433 N] [GilesStashReplacer 1.8.5] Chest sockets=1
[20:30:58.463 N] [GilesStashReplacer 1.8.5] Chest sockets=3
[20:30:58.673 N] [GilesStashReplacer 1.8.5] Chest sockets=1
[20:30:58.713 N] [GilesStashReplacer 1.8.5] Chest sockets=3
[20:30:58.873 N] [GilesStashReplacer 1.8.5] Chest sockets=1
[20:30:58.903 N] [GilesStashReplacer 1.8.5] Chest sockets=3
[20:30:59.213 N] [GilesStashReplacer 1.8.5] Chest sockets=1
[20:30:59.243 N] [GilesStashReplacer 1.8.5] Chest sockets=3
[20:30:59.453 N] [GilesStashReplacer 1.8.5] Chest sockets=1
[20:30:59.483 N] [GilesStashReplacer 1.8.5] Chest sockets=3
[20:30:59.683 N] [GilesStashReplacer 1.8.5] Chest sockets=1
[20:30:59.723 N] [GilesStashReplacer 1.8.5] Chest sockets=3
[20:31:04.059 N] [GilesStashReplacer 1.8.5] Chest sockets=1
[20:31:06.009 N] [GilesStashReplacer 1.8.5] Chest sockets=3

Instead of the usual "sold bla-bla" or stuff like that - this is what I got after IDing a full inv of items

 

[GilesSmith]

So, have anyone found a way to handle freezes/disconnects and restart d3/db without having the "plugins not loading properly" issue, or is at this time bot with this particular plugin not afkable at all? Going out of town for a couple of days, would've loved to see a full stash of goodies when I come back

Atm no BUT but but but... the problem has now been officially acknowledged and I suspect may be fixed next release of DemonBuddy (along with a fix for the current crashing issues with the latest DB release)... so fingers crossed!

thx ... it's nice that u put so much effort in to this ... gona do some debugging on the functions of demonbuddy ... which u think are buggy ... maybee they fixed it ....^^ allready ... an other thing that would be great is to ... work the same kind as d3 is ... d3inferno.com shows from reversenginering how the structure is build up ... the mods and the items ... this way you could build up much acurater evaluating algorithms .. i builded up the structure already so if u want the code i can give it to u ...

It's still no better - the problem I'm afraid is with the way they try to read *ALL* variables from Diablo 3 itself... so they ask Diablo 3 how many slots it takes, what kind of item it is, etc. etc. etc. - and for every bit of data trying to be read, there seems to be increased chance of that data coming back incorrectly. Whereas what *I* do is take the "internalname" from Diablo 3 and then calculate what I can just off that (eg if the internal name begins with "handxbow_" then my code flags it as a 2 slot item, non-stackable item, weapon type, one-handed crossbow type, etc. - so it's only trying to get 1 name from Diablo 3 rather than lots of data) - which is why you'll have seen all my own custom functions for translating internalnames into item types, 2-slot item, stackable item etc. (it's also how I was able to support follower items and class-unique items before DB ever did, and why my stashing mechanism doesn't get stuck trying to infinitely stash the same item over and over because it never thinks a 2 slot item is a 1 slot item and thus keep swapping it with a ring or something over and over!).

Also looking up your bug with Act 2 helped me find another bug - I noticed that if it has nothing to stash AND nothing to salvage when it starts town-run (ie it wants to teleport to town and go immediately to the vendor) - then it bugs out and thinks it's already reached the vendor instantly. This specifically probably could happen on any act not just act 2, so we'll have another bugfix in for this next release too, yay!

 

[taquitos]

For the next release, do you think you could allow us to modify the sale/salvage rules? I pick up all blue+ stuff ilvl61+ (700g per salvage isnt bad) and for blue armors and rings, the salvage value is usually much higher than the sale value. But for blue weapons and rare+ for armor, jewelry, weapons, the vendor value is oftentimes much higher than the salvage value. In your previous version of the loot rule replacer, I was able to run the loot rules from the attached lootrules file and set it to vendor blue+weapons and rare+everything else. The current one seems to override all these rules and I was wondering if you could bring back that functionality. Thanks.

 

[madmoremax]

Fast question. Does it pick up any lvl of legendary?
If not how do i fix it?

 

[GilesSmith]

Fast question. Does it pick up any lvl of legendary?
If not how do i fix it?

Yes.

For the next release, do you think you could allow us to modify the sale/salvage rules? I pick up all blue+ stuff ilvl61+ (700g per salvage isnt bad) and for blue armors and rings, the salvage value is usually much higher than the sale value. But for blue weapons and rare+ for armor, jewelry, weapons, the vendor value is oftentimes much higher than the salvage value. In your previous version of the loot rule replacer, I was able to run the loot rules from the attached lootrules file and set it to vendor blue+weapons and rare+everything else. The current one seems to override all these rules and I was wondering if you could bring back that functionality. Thanks.

I'll see about allowing the custom loot-rules for sale & salvage again in a future release. Though I prefer to have a version that is "best for all" - I know this isn't always possible (everyone wants different things), but I like to be the default options / the simple choices be the "best they can be" without people needing to run custom loot-rules... eg the option to sell or salvage could have a middle-option "Salvage some" - which perhaps only salvages items of ilvl 61 - while always selling ilvl 62 and 63? Or always selling ilvl 63 and salvaging 62 and lower (inferno craft mat levels only always, of course). Any opinions on this possible 3rd option to save people needing custom loot-rules?

 

[madmoremax]

Thanks for the quick answer =)

 

[sifer]

It doesnt pick up the lvl 54+ yellow rings.

 

[taquitos]

Yes.



I'll see about allowing the custom loot-rules for sale & salvage again in a future release. Though I prefer to have a version that is "best for all" - I know this isn't always possible (everyone wants different things), but I like to be the default options / the simple choices be the "best they can be" without people needing to run custom loot-rules... eg the option to sell or salvage could have a middle-option "Salvage some" - which perhaps only salvages items of ilvl 61 - while always selling ilvl 62 and 63? Or always selling ilvl 63 and salvaging 62 and lower (inferno craft mat levels only always, of course). Any opinions on this possible 3rd option to save people needing custom loot-rules?

Sounds like a pretty good solution. Thanks for the fast update and hard work!

 

[Beacon]

thanks for the update giles !

 

[Champagne]

idk how but i turned off my bots like two hours ago cuz db was acting up again today. i log in to my act1 inferno monk and he has over 1k nightmare essences

i cnt even sell them, when i try i get an error lol. idk if its cuz of this plugin but i got em

 

[GilesSmith]

idk how but i turned off my bots like two hours ago cuz db was acting up again today. i log in to my act1 inferno monk and he has over 1k nightmare essences
i cnt even sell them, when i try i get an error lol. idk if its cuz of this plugin but i got em

Nope - the plugin won't salvage anything that doesn't give inferno level essences item-wise. Only times it can salvage lower-level stuff is if you have a bugged/corrupt install (rare, but fresh install of DemonBuddy in a new, clean, empty folder is always something EVERYBODY should do every time you try a new release of Demonbuddy, rather than upgrading by overwriting the old files, and avoid the built-in-updater)... or the plugin is disabled/not installed to correct folder (in which case it won't run )... or you're using some sort of batch-restarter/relogger/command-line-tool to load DB (something the Demonbuddy guys say should be fixed "soon")!