[Plugin] Giles Stash & Loot Rule Replacer

[lajt]

Its weird, because it affects my ru and en clients a different way. RU one picks all blue+, EN one picks everything up :S
What I've tried is:
disabling custom pick rules
using latest objecthandler with ignoring lootrules ticked
using 1.3.x objecthandler with the stashreplacer rules
disabling other plugins
and possible permutations of the above

Simplest thing are hardest to find

Now something different: i've checked your plugin, and it's really amazing how it calculates item values. However since item prices are non-linearic in diablo series, how about implementing an advanced feature whick allows users to give certain values to stats, also the ability to change the medhod score is valuated? Afaik its atm purely based on additions, while a multiplicative manner would increase the ability to scale the values of item further more. I know its not that important till we get a six parameter search criteria in auction house, just an idea...

Thanks for taking your time!

 

[GilesSmith]

Hi Giles,
just to be sure what I have to do with your plugin for AGB
1. use custom loot rule found in the post #337
2. use demon townrun
3. in config use Custom pickup loot

that's it?

Yeah. And make sure you don't have the world object handler plugin option "Disable Loot Rule Filtering" enabled. But that should be exactly it. Same for Inrego's Sarkoth plugin or Stove's treasure goblin plugin.

 

[FTW]

I have some mimor issues

1. not going to stash anymore -> go sell to Arghus -> go salvage -> tp back
2. not selling all junk items like follower items and some others junk (in loot rules from post #337 I change the magic +61 to loot all magic instead)
3. when inventory full, while trying to TP back to town to sell/stash/savalges items, he still try to pick up the items so the bot is unable to TP

so all Gems, crafting mats are still in my inventory instead in the stash and some junk items too from my #2 issues

is it a misconfig or issues?! because in 1.7 everything going well

look like the plugin is not active but it is... I uncheck and check it a lot of time + restart DB and D3

I'll try tomorrow with a fresh install of DB

 

[Midas]

Atm for anyone with issues, that's the first step (it's surprising what clean install of DB & plugins in a clean folder does).
- Also make sure you aren't using any really ancient and now defunct plugins that cause problems these days (like the old notificationok clicker, or the old "unstucker").
- Also make sure you aren't using some special custom routine-plugin, like the old AGB Sarkoth or Inrego's Sarkoth or Stove's Treasure Hunter - they handle item pickups themselves, and have all been abandoned by their creators.
- Try launching DB manually, the normal way - not through any reloggers or batch restarters (they have their own problems - DemonBuddy doesn't give plugins enough time to load before starting routines if loaded through command line).
- Just be sure and double-check you have set the options correctly (if you want to use my filter options, select "Use Giles Filters Below" radio button in the middle of the config window).

All pretty obvious things but worth listing anyway, plus there's whatever I've listed in the Common Problems and Compatibility sections of the 1st post!

If you do have problems, and then get it working, please post what you did to fix it/what was causing the problems, as it may help others (or help me)

Thanks alot for the support Giles!

I did some testing!! Reinstalled everything from scratch, but isolated only your two plugins (stash and worldobject).
Then I laid down some weapons and armor of various ilevel at the beginning of the profile and tested the custom filtering.

Here is my problem. When you choose say level 61+ it only picks up 62 or 63. If you chose 60+ then it picks up 61, 62, 63.

This is confirmed with blue or yellow.

just thinking...maybe you meant it this way. It was just confusing for me as i interpret 61+ as meaning it would pick up 61 aswell.

For now just setting a number below the one i want

 

[PainfulDeath]

Atm for anyone with issues, that's the first step (it's surprising what clean install of DB & plugins in a clean folder does).
- Also make sure you aren't using any really ancient and now defunct plugins that cause problems these days (like the old notificationok clicker, or the old "unstucker").
- Also make sure you aren't using some special custom routine-plugin, like the old AGB Sarkoth or Inrego's Sarkoth or Stove's Treasure Hunter - they handle item pickups themselves, and have all been abandoned by their creators.
- Try launching DB manually, the normal way - not through any reloggers or batch restarters (they have their own problems - DemonBuddy doesn't give plugins enough time to load before starting routines if loaded through command line).
- Just be sure and double-check you have set the options correctly (if you want to use my filter options, select "Use Giles Filters Below" radio button in the middle of the config window).

All pretty obvious things but worth listing anyway, plus there's whatever I've listed in the Common Problems and Compatibility sections of the 1st post!

If you do have problems, and then get it working, please post what you did to fix it/what was causing the problems, as it may help others (or help me)

Does DB have default functionality of NotificationOk pushers like it has the unstucker functionality or? I do still have NotificationOkClick plug-in because I didn't see anything that would indicate that it's obsolete anymore =)

 

[Momentusa]

"[13:06:59.297 N] [GilesStashReplacer 1.8.1] No more space to pickup a 2-slot item, now running town-run routine.
[13:08:05.794 V] Using power Walk clickPos:<2941.904, 2812.825, 24.04533> worldDynamicId:1999503360 targetACDGuid:-1
[13:08:06.315 D] Generating path to Town Portal (Definite) - <2985.959, 2795.399, 23.94531>
[13:08:06.329 D] Raycast path generated.
[13:08:06.329 D] Generated path to <2985.959, 2795.399, 23.94531> (Town Portal (Definite)) with 1 hops.
[13:08:06.329 V] Using power Walk clickPos:<2985.959, 2795.399, 23.94531> worldDynamicId:1999503360 targetACDGuid:-1
[13:08:07.038 V] Using power Walk clickPos:<2941.904, 2812.825, 24.04533> worldDynamicId:1999503360 targetACDGuid:-1
[13:08:07.702 V] Using power Walk clickPos:<2985.959, 2795.399, 23.94531> worldDynamicId:1999503360 targetACDGuid:-1
[13:08:07.831 V] [ItemRules] Matched Sawtooth Amulet of Omens with rule: :Salvage
[13:08:07.835 V] [ItemRules] Matched Charred Armguards of Omens with rule: :Salvage
[13:08:07.841 V] [ItemRules] Matched Vigorous Warlord Plate of Fortitude with rule: :Salvage
[13:08:07.847 V] [ItemRules] Matched Thawing Archon Armor of the Gladiator with rule: :Salvage
[13:08:07.849 V] [ItemRules] Matched Ring of Valor with rule: :Salvage
[13:08:07.854 V] [ItemRules] Matched Potent Warlord Spaulders of Spikes with rule: :Salvage
[13:08:07.860 V] [ItemRules] Matched Sheltering Doom Pauldrons of Valor with rule: :Salvage
[13:08:07.863 V] [ItemRules] Matched Relentless Grand Taiji of Gore with rule: :Salvage
[13:08:07.865 V] [ItemRules] Matched Ruthless Doom Hammer of Assault with rule: :Salvage
[13:08:07.868 V] [ItemRules] Matched Assailing Colossus Blade of Severing with rule: :Salvage
[13:08:07.874 V] [ItemRules] Matched Hermetic Warlord Gauntlets of Omens with rule: :Salvage
[13:08:07.877 V] [ItemRules] Matched Deadly Slag Hammer of Burning with rule: :Salvage
[13:08:07.880 V] [ItemRules] Matched Vicious Runic Arcus of Sores with rule: :Salvage
[13:08:07.886 V] [ItemRules] Matched Codex of Valor with rule: :Salvage
[13:08:07.892 V] [ItemRules] Matched Sawtooth Warbands of Pain with rule: :Salvage
[13:08:07.898 V] [ItemRules] Matched Beguiling Doom Pauldrons of Valor with rule: :Salvage
[13:08:07.900 V] [ItemRules] Matched Cruel Kwan Dao of Smiting with rule: :Salvage
[13:08:07.910 V] [ItemRules] Matched Vicious Runic Quiver with rule: :Salvage
[13:08:07.917 V] [ItemRules] Matched Lacerating Hellscape Mask of the Fortress with rule: :Salvage
[13:08:07.925 V] [ItemRules] Matched Hermetic Manitou Mask of Pain with rule: :Salvage
[13:08:07.928 V] [ItemRules] Matched Tranquil Amulet with rule: :Salvage
[13:08:07.936 V] [ItemRules] Matched Socketed Warlord Leg Plates of Valor with rule: :Salvage
[13:08:07.939 V] [ItemRules] Matched Confident Impellor of Pain with rule: :Salvage
[13:08:07.941 V] [ItemRules] Matched Cleave Helix with rule: :Keep
[13:08:07.948 V] [ItemRules] Matched Glittering Sovereign Vambraces of Pain with rule: :Salvage
[13:08:07.952 V] [ItemRules] Matched Relentless Balestarius of Severing with rule: :Salvage
[13:08:07.959 V] [ItemRules] Matched Socketed Kwan Dao of Severing with rule: :Salvage
[13:08:07.970 V] [ItemRules] Matched Ominous Archmage Headpiece of Pain with rule: :Salvage
[13:08:07.976 V] [ItemRules] Matched Tranquil Ring of Extermination with rule: :Salvage
[13:08:08.621 V] Using power Walk clickPos:<2941.904, 2812.825, 24.04533> worldDynamicId:1999503360 targetACDGuid:-1
[13:08:09.687 V] Using power Walk clickPos:<2985.959, 2795.399, 23.94531> worldDynamicId:1999503360 targetACDGuid:-1
[13:08:10.380 V] Using power Walk clickPos:<2941.904, 2812.825, 24.04533> worldDynamicId:1999503360 targetACDGuid:-1
[13:08:10.774 D] Start/Stop Button Clicked!
[13:08:10.818 N] Stopping the bot.
[13:08:10.818 D] CurrentBot.Stop()
[13:08:10.818 D] Navigator.Clear()
[13:08:10.819 D] Navigator.Clear
[13:08:10.819 D] TreeHooks.Instance.ClearAll()
[13:08:10.819 D] OnStop event
[13:08:10.819 D] OnStop Event Invoking
[13:08:10.819 D] QuestOrderManager.OnBotStop(). Resetting caches.
[13:08:10.821 D] Resetting current behavior.
[13:08:10.821 D] QuestOrderManager.OnBotStop(). Resetting caches.
[13:08:10.821 D] Resetting current behavior.
[13:08:10.822 N] [GilesItemStats 0.2.1] ===== Giles Item Stats Report =====
[13:08:10.823 N] [GilesItemStats 0.2.1] Total tracking time: 0h 38m 10s
[13:08:10.823 N] [GilesItemStats 0.2.1] Total items: 967 [1520.08 per hour]
[13:08:10.823 N] [GilesItemStats 0.2.1] Item totals by quality:
[13:08:10.824 N] [GilesItemStats 0.2.1] - White: 87 [136.76 per hour] {9 %}
[13:08:10.824 N] [GilesItemStats 0.2.1] --- ilvl 55 White:29 [45.59 per hour] {3 %}
[13:08:10.825 N] [GilesItemStats 0.2.1] --- ilvl 58 White:31 [48.73 per hour] {3.21 %}
[13:08:10.825 N] [GilesItemStats 0.2.1] --- ilvl 60 White:27 [42.44 per hour] {2.79 %}
[13:08:10.825 N] [GilesItemStats 0.2.1] - Magic: 748 [1175.82 per hour] {77.35 %}
[13:08:10.825 N] [GilesItemStats 0.2.1] --- ilvl 57 Magic:62 [97.46 per hour] {6.41 %}
[13:08:10.826 N] [GilesItemStats 0.2.1] --- ilvl 58 Magic:29 [45.59 per hour] {3 %}
[13:08:10.826 N] [GilesItemStats 0.2.1] --- ilvl 60 Magic:229 [359.98 per hour] {23.68 %}
[13:08:10.826 N] [GilesItemStats 0.2.1] --- ilvl 61 Magic:181 [284.52 per hour] {18.72 %}
[13:08:10.827 N] [GilesItemStats 0.2.1] --- ilvl 62 Magic:176 [276.66 per hour] {18.2 %}
[13:08:10.827 N] [GilesItemStats 0.2.1] --- ilvl 63 Magic:71 [111.61 per hour] {7.34 %}
[13:08:10.827 N] [GilesItemStats 0.2.1] - Rare: 132 [207.5 per hour] {13.65 %}
[13:08:10.828 N] [GilesItemStats 0.2.1] --- ilvl 61 Rare:27 [42.44 per hour] {2.79 %}
[13:08:10.828 N] Bot Thread Ended. Was this requested?
[13:08:10.828 N] [GilesItemStats 0.2.1] --- ilvl 62 Rare:73 [114.75 per hour] {7.55 %}
[13:08:10.828 N] [GilesItemStats 0.2.1] --- ilvl 63 Rare:32 [50.3 per hour] {3.31 %}
[13:08:10.829 N] [GilesItemStats 0.2.1] Item totals by ilvl:
[13:08:10.829 N] [GilesItemStats 0.2.1] - ilvl55:29 [45.59 per hour] {3 %}
[13:08:10.830 N] [GilesItemStats 0.2.1] - ilvl57:62 [97.46 per hour] {6.41 %}
[13:08:10.831 N] [GilesItemStats 0.2.1] - ilvl58:60 [94.32 per hour] {6.2 %}
[13:08:10.831 N] [GilesItemStats 0.2.1] - ilvl60:256 [402.42 per hour] {26.47 %}
[13:08:10.831 N] [GilesItemStats 0.2.1] - ilvl61:208 [326.97 per hour] {21.51 %}
[13:08:10.832 N] [GilesItemStats 0.2.1] - ilvl62:249 [391.42 per hour] {25.75 %}
[13:08:10.832 N] [GilesItemStats 0.2.1] - ilvl63:103 [161.91 per hour] {10.65 %}
[13:08:10.833 N] [GilesItemStats 0.2.1] ===== End Of Report =====
[13:08:10.833 D] QuestOrderManager.OnBotStop(). Resetting caches.
[13:08:10.833 D] Resetting current behavior.
[13:08:10.833 D] QuestOrderManager.OnBotStop(). Resetting caches.
[13:08:10.833 D] Resetting current behavior.
[13:08:10.834 D] Calling OnDone() on current behavior. WaitTimerTag: IsDone: False, WaitTime: 10000000, QuestId: 1, StepId: 0, QuestName: Quest Id: 1, IsDoneCache: False, Behavior: Zeta.TreeSharp.PrioritySelector,
[13:08:10.834 D] QuestOrderManager.OnBotStop(). Resetting caches.
[13:08:10.834 D] Resetting current behavior.
[13:08:10.834 D] Calling OnDone() on current behavior. WaitTimerTag: IsDone: False, WaitTime: 10000000, QuestId: 1, StepId: 0, QuestName: Quest Id: 1, IsDoneCache: False, Behavior: Zeta.TreeSharp.PrioritySelector,
[13:08:10.834 D] QuestOrderManager.OnBotStop(). Resetting caches.
[13:08:10.834 D] Resetting current behavior.
[13:08:10.834 D] Calling OnDone() on current behavior. WaitTimerTag: IsDone: False, WaitTime: 10000000, QuestId: 1, StepId: 0, QuestName: Quest Id: 1, IsDoneCache: False, Behavior: Zeta.TreeSharp.PrioritySelector,
[13:08:10.834 D] QuestOrderManager.OnBotStop(). Resetting caches.
[13:08:10.834 D] Resetting current behavior.
[13:08:10.834 D] Calling OnDone() on current behavior. WaitTimerTag: IsDone: False, WaitTime: 10000000, QuestId: 1, StepId: 0, QuestName: Quest Id: 1, IsDoneCache: False, Behavior: Zeta.TreeSharp.PrioritySelector,
[13:08:10.834 D] QuestOrderManager.OnBotStop(). Resetting caches.
[13:08:10.834 D] Resetting current behavior.
[13:08:10.835 D] Calling OnDone() on current behavior. WaitTimerTag: IsDone: False, WaitTime: 10000000, QuestId: 1, StepId: 0, QuestName: Quest Id: 1, IsDoneCache: False, Behavior: Zeta.TreeSharp.PrioritySelector,
[13:08:10.835 D] QuestOrderManager.OnBotStop(). Resetting caches.
[13:08:10.835 D] Resetting current behavior.
[13:08:10.835 D] Calling OnDone() on current behavior. WaitTimerTag: IsDone: False, WaitTime: 10000000, QuestId: 1, StepId: 0, QuestName: Quest Id: 1, IsDoneCache: False, Behavior: Zeta.TreeSharp.PrioritySelector,
[13:08:10.835 D] QuestOrderManager.OnBotStop(). Resetting caches.
[13:08:10.835 D] Resetting current behavior.
[13:08:10.835 D] Calling OnDone() on current behavior. WaitTimerTag: IsDone: False, WaitTime: 10000000, QuestId: 1, StepId: 0, QuestName: Quest Id: 1, IsDoneCache: False, Behavior: Zeta.TreeSharp.PrioritySelector,
[13:08:10.835 D] QuestOrderManager.OnBotStop(). Resetting caches.
[13:08:10.835 D] Resetting current behavior.
[13:08:10.835 D] Calling OnDone() on current behavior. WaitTimerTag: IsDone: False, WaitTime: 10000000, QuestId: 1, StepId: 0, QuestName: Quest Id: 1, IsDoneCache: False, Behavior: Zeta.TreeSharp.PrioritySelector,
[13:08:10.835 D] QuestOrderManager.OnBotStop(). Resetting caches.
[13:08:10.835 D] Resetting current behavior.
[13:08:10.836 D] Calling OnDone() on current behavior. WaitTimerTag: IsDone: False, WaitTime: 10000000, QuestId: 1, StepId: 0, QuestName: Quest Id: 1, IsDoneCache: False, Behavior: Zeta.TreeSharp.PrioritySelector,
[13:08:10.836 D] QuestOrderManager.OnBotStop(). Resetting caches.
[13:08:10.836 D] Resetting current behavior.
[13:08:10.836 D] Calling OnDone() on current behavior. WaitTimerTag: IsDone: False, WaitTime: 10000000, QuestId: 1, StepId: 0, QuestName: Quest Id: 1, IsDoneCache: False, Behavior: Zeta.TreeSharp.PrioritySelector,
[13:08:10.836 D] QuestOrderManager.OnBotStop(). Resetting caches.
[13:08:10.836 D] Resetting current behavior."

It is running back and forth infront of stash, looks like its on the way to the vendor at the top.
Using AGB with demonbuddy townrun checked. Custom loot rules.

Also, on my other bot running champ farming, the new version seems to find it hard to pickup some items, then blacklists them and moves on. These items are not blocked by any terrain either, like a clear path to it. Will probably revert back to the older 1.7 until some of the bugs are fixed in this version. I hope more bug reports come soon.

 

[xenohadden]

erm loving the update giles but its now picking up all greys

 

[Hajkfas]

Sell part of the code does not function correctly. It will get confused and pace back and fourth when trying to sell an item.

When I have the plugin set to sell something, it would just pace back and fourth. Salvaging makes it work fine.

However after done salvaging, it wants to sell the lower ilvl items, so it gets back to the back and fourth loop again.

 

[PainfulDeath]

[10:28:49.688 N] [GilesStashReplacer 1.7] Serpent Seeker [XBow_norm_base_08-78] [TwoHandCrossbow] = 70788
[10:28:49.688 N] [GilesStashReplacer 1.7] ***** KEEP *****
[10:28:49.821 N] [GilesStashReplacer 1.7] Primal Facade [voodooMask_norm_base_03-91] [VoodooMask] = 15875
[10:28:49.821 N] [GilesStashReplacer 1.7] ***** KEEP *****

Both barely over the default score, but still both will never sell on AH.
helm (WD only) 70 str 158 vita 1 socket
xbow 926 DPS 125 str 192 int 169 vita WD zombie charger skill mana cost reduce

upd. another one

[10:56:01.281 N] [GilesStashReplacer 1.7] Tournament Vow [Shield_norm_base_06-147] [Shield] = 17328
[10:56:01.281 N] [GilesStashReplacer 1.7] ***** KEEP *****

ilvl 62 shield with 47 str 78 int 69 vit 33 phys Res 8% life 186 regen 17 MF - I see exact same shield on AH (without res and regen) for 30k, so I am guessing this wouldn't sell =)

 

[giuntina]

v1.8 Uploaded:
-- Huge overhaul of the new plugin-based item filtering and config window - massively customizable item pickup handling now.
-- DemonBuddy vendoring/selling routine now replaced with my own - sells items one-at-a-time, like my salvage and stash routines.
-- Option to sell all junk (non-stash-worthy) items instead of salvaging them.
-- Option to pick between using plugin item pickup filters, or use your own custom pickup loot-rules if my filters don't give you enough options.
-- If you use Giles World Object Handler Plugin option to "Disable Loot Rule Filtering" - you no longer need any loot rules! It won't matter what you pick.
(If you do not use my world object handler plugin, then use the new almost-empty loot-rules added to the downloads - even custom loot rules no longer need sell or salvage categories
-- Sell and salvaging now have no requirement for loot-rules - will intelligently salvage all items that give inferno craft mats if you have salvaging enabled, and will sell everything else that isn't stashed.
-- Item pickup speed vastly optimized when many items are in loot-range.
-- Many item pickup errors fixed, more error handling and diagnostic logging added incase of pickup problems/loops.
-- Blue jewelry with a single stat of max GF, MF or Life-On-Hit will now get enough score to be stashed with default scores.
-- Various other minor tweaks and alterations.

For gems, tomes, designs/plans, potions, do you use any item name check in your code ?
I mean using a localized client it's a problem ?
I always edited the itemname part in old rules, but now ?

 

[Momentusa]

Sell part of the code does not function correctly. It will get confused and pace back and fourth when trying to sell an item.

When I have the plugin set to sell something, it would just pace back and fourth. Salvaging makes it work fine.

However after done salvaging, it wants to sell the lower ilvl items, so it gets back to the back and fourth loop again.

I believe I have the same problem.

 

[xenohadden]

tried a fresh install still looting greys

 

[BBD90]

Bit of a hit and miss for me at the moment. When it works, it's amazing but when it doesn't my inventory gets full really fast and I turn into a sad Panda. Still following this thread and waiting on updates.

If you need any sort of log or anything let me know ill be running this all night long.

 

[Thirdi]

Getting the same problem as other people with it picking up everything including greys and whatnot. After I got the issue I did a clean install of DB and all plugins (I only use your plugins and I run A1 champ packs). Still having the problem. Going to just switch back to an older version until someone figures out whats up since I know nothing of programming in the slightest.

I use VMware to bot with

edit: Switching to version 1.7 fixed the problem with looting grays for me. Not sure what happened when I installed the newest version.

 

[bobdan]

aww yeah its picking up greys for me as well think it might have to do with the code to pickup quicker its accidentally doing it or something.

 

[thekingkong]

thought I was the only one having this problem with the grey items. Also, when I set it to pick up 62+ weapons, it failed to pick up the lvl62 xbow as well. Appreciate your good work as always =]

 

[moca]

I believe I have the same problem.

and me too

 

[moca]

Seems Giles is having a good sleep now, after a hardworking night, he deserves it.... let's all be patient.

 

[bobdan]

hopefully i figured it out, if you are using giles world object handler make sure you go into config and disable loot rule filtering checkbox IS NOT checked.

now its not picking up greys.

 

[bobdan]

hopefully i figured it out, if you are using giles world object handler make sure you go into config and disable loot rule filtering checkbox IS NOT checked.

now its not picking up greys.

yeah i put all my loot options as low as they could go and its run around and killed a few things and picked up some blue items so i think this is working now.

sorry for double post just wanted to confirm this is what is working for me.