Focused Crusader Support (Read This If Your Crusader Is Being Stupid)

[Fujiyama]

This is correct actually. I forgot that CoE is a dynamic multiplicative damage boost and since it takes a second or so to start doing bombardment damage casting it at 2 or 1 second left on the electric buff would be the most damage.

This! He's also a little late when casting Iron Skin first - since he won't always react the very second physical start.

 

[jubisman]

Hi bro,it is a amazing job! there are something i had to report:1.as other guys said that it missed lots of elites,whatever yellow or blue~~~2.Waitting for the convention element at physical is too late,the best timing is the 3skills burst at electric last 2secs ：）
whatever thx to your great job!
BTW:when in combat it runs here and runs there but not cast the skills to kill the monsters~~even i unchecked the "spam steed charge in combat"

Here's the thing: problem 1 is not a crusader problem, it's a trinity problem, so I'll not be addressing it here. xz jv and I have some ideas to fix this problem for ALL classes, but it's gonna take a while more likely than not, so let's try and focus on other bugs here for now.

Problem #2 is duly noted, thanks for the report.

I am using this on HC, so I try to be as safe as possible.
Right now I am running LoN build with Shield Glare and no Consecration and can safely go up to GR58.

1) Is Hexing Pants of Mr. Yan logic included when using the LoN build?
2) If I switch to Norvald's Fervor set for speedfarming: is the logic to use Steed Charge as the primary source of damage implemented when the Norvald's set is detected? Meaning would it use Iron Skin + Steed Charge and run around elites and the rift boss to kill them?
3) More of a general suggestion: is it possible to implement a feature, where all the avoidances are set to zero if bot activates the Invincibility shrine, until the last 10 seconds of the Invincibility buff duration, and then the values restore to their pre-shrine values?
4) Is it possible to do something about Molten Cores and Grotesques? Seems like the current max 30 range is not doing it. The sader jumps on the horse and most of the time runs back and forth on the very edge of the explosions that they leave behind, resulting in sometimes catching 1 or even 2 explosions, which in HC is really not what you want to see.

Thank you!

1. Yes it is, but idk how well it works.
2. You just need Belt of the Trove and Mortal Drama in the cube, so yes, I don't see why not.
3. I have thought about this for some time, but it's not as simple to implement as it may sound, so not right now. Sorry.
4. Avoidance doesn't work well, I know. There's absolutely nothing I can do about it though. xz jv will fix it eventually, but it's probably the hardest thing to fix about trinity, so it's going to take a while.

Actually for the invoker/punish build you need to keep attacking with punish to maintain the block% bonus of punish. There's no reason to stop using punish even when waiting for COE.

It doesn't stop using punish to run around if you're using Invoker. It only loiters if you DON'T have punish.

Sorry to ask. But at your cs, at line 142, shouldnt

if (isSteedCharging && CurrentTarget != null && !IsDoingGoblinKamakazi)
be
if (isSteedCharging && CurrentTarget == null && !IsDoingGoblinKamakazi)
instead?

Not really. Why do you say that?

New changes are amazing. Running 70s for 115b xp/hr with ~8-10deaths per hour. My gear is pretty retardedly good though.
But I have now started to notice that it seems to be ignoring the hexing pants functionality? It runs around during steed charge and all that good stuff, but stands still when casting the "combo", and remains stationary untill most of the bombardment hits have landed. Meaning I should wear different pants, but hexing are just so good if actually used properly.
Any comment?

A lot of skills in D3 require you to be still to cast them. I'm guessing this is the case with bombarment. The only other moment where it stops is when the Loiter code fails to kick in, which is being looked into.

Heya Jubis!! xD

I'll test it today.. But now, that u are figuring out the LoN-Sader build, can u take a look at this http://www.diablofans.com/builds/70029-2-4-phalanx-bowmen-bounties-t10 ? Is a Bounty build for LoN-Sader, this liretally fuck T10, i think now u can just add Phalanx support to this..

Let me know now, what do u think about that and if u can support it now..

Thanks again man, keep up this GREAT work!

Soon, but not right now.

Its working wonder for me while using the LoN-build, but when im using Norvalds to farm Death Breaths the bot is not unmounting at bosspacks (not using consecration, iron skin, bombardment or Akarats). Any quick fix for the bot to spot the Norvalds set as it does with LoN?

The DB farming build is not supported currently.

my thorn invoker sader still not casting any law at all. I reinstalled DB and trinity 2 times, and mess with check/uncheck cd settings numerous times also playing with slides from 0 to 100% yet still unable to make it use law...

I am frustrated. everything else works fine but without law activation I am 5 levels handicapped on Grift, was working prior to .22 release, then after .22 installation this bug occurs, also tried .23 with same problem.

Would you please send me a code to re-enforce my bot to use law sametime when it uses reflect/consecration? thx

Can you please copy your build over to d3planner and post the link here?

 

[demonD]

Can you please copy your build over to d3planner and post the link here?

http://www.d3planner.com/618673155

 

[darkfriend77]

http://www.d3planner.com/618673155

I didn't added .... Laws other then Laws of Justices for the Invoker ... sry ...

I added it ... later to my code ... however ... that's the easy impl. for laws I use ...

                // Cast any possible laws ...
                if (CanCastLawsOf(out power))
                    return power;

        private static bool CanCastLawsOf(out TrinityPower power)
        {
            if (CanCast(SNOPower.X1_Crusader_LawsOfJustice2) && !CacheData.Buffs.HasBuff(SNOPower.X1_Crusader_LawsOfJustice_Passive2, 6) && (Player.CurrentHealthPct <= CrusaderSettings.LawsOfJusticeHpPct || CrusaderSettings.SpamLaws))
            {
                power = new TrinityPower(SNOPower.X1_Crusader_LawsOfJustice2);
                return true;
            }
            else if (CanCast(SNOPower.X1_Crusader_LawsOfHope2) && !CacheData.Buffs.HasBuff(SNOPower.X1_Crusader_LawsOfHope_Passive2, 6) && (Player.CurrentHealthPct <= CrusaderSettings.LawsOfHopeHpPct || CrusaderSettings.SpamLaws))
            {
                power = new TrinityPower(SNOPower.X1_Crusader_LawsOfHope2);
                return true;
            }
            else if (CanCast(SNOPower.X1_Crusader_LawsOfValor2) && !CacheData.Buffs.HasBuff(SNOPower.X1_Crusader_LawsOfValor_Passive2, 6))
            {
                power = new TrinityPower(SNOPower.X1_Crusader_LawsOfValor2);
                return true;
            }
            else
            {
                power = null;
                return false;
            }
        }

 

[jubisman]

Thanks darkfriend77 . Your ShouldWaitForConventionElementMaxWaitSec is awesome by the way, despite the name not making sense

 

[Alobut]

My thorn invoker is not casting Bombardment in new Trinity version

Trinity 2.14.19 ---> max GRift 71 ok
Trinity 2.14.23 ---> max GRift 65 Bombardment it does not work

http://www.d3planner.com

 

[darkfriend77]

Thanks darkfriend77 . Your ShouldWaitForConventionElementMaxWaitSec is awesome by the way, despite the name not making sense

yep ... damn ... refactoring bad ... when i changed from sec to cycles ...

However ... cleared grift 73 with the actual code ... which is really a great achievment ...

There is still some tweaking ...

- Riftvalue ... isn't working well ... getting stuck by riftvalues that are ignored ... need to do some more testing
- KillTrash below %x is weaker then trash pack size ... bot runs a away from mobs that are at low health ... might be good for low rifts bad for high rifts
- Ignore Minions ... leads to get stuck by minions ... need to do some more testing

 

[demonD]

I didn't added .... Laws other then Laws of Justices for the Invoker ... sry ...

I added it ... later to my code ... however ... that's the easy impl. for laws I use ...

                // Cast any possible laws ...
                if (CanCastLawsOf(out power))
                    return power;

        private static bool CanCastLawsOf(out TrinityPower power)
        {
            if (CanCast(SNOPower.X1_Crusader_LawsOfJustice2) && !CacheData.Buffs.HasBuff(SNOPower.X1_Crusader_LawsOfJustice_Passive2, 6) && (Player.CurrentHealthPct <= CrusaderSettings.LawsOfJusticeHpPct || CrusaderSettings.SpamLaws))
            {
                power = new TrinityPower(SNOPower.X1_Crusader_LawsOfJustice2);
                return true;
            }
            else if (CanCast(SNOPower.X1_Crusader_LawsOfHope2) && !CacheData.Buffs.HasBuff(SNOPower.X1_Crusader_LawsOfHope_Passive2, 6) && (Player.CurrentHealthPct <= CrusaderSettings.LawsOfHopeHpPct || CrusaderSettings.SpamLaws))
            {
                power = new TrinityPower(SNOPower.X1_Crusader_LawsOfHope2);
                return true;
            }
            else if (CanCast(SNOPower.X1_Crusader_LawsOfValor2) && !CacheData.Buffs.HasBuff(SNOPower.X1_Crusader_LawsOfValor_Passive2, 6))
            {
                power = new TrinityPower(SNOPower.X1_Crusader_LawsOfValor2);
                return true;
            }
            else
            {
                power = null;
                return false;
            }
        }

thx! now i see since you mentioned it. I was using valor and hope only during my previous runs, this time i tried with justice and it activates again! "phew!" all the troubles i gone thru if only had I switched to justice once...

Anyway, where and how do I paste the code in? I do not have any code editor btw, take your time and put the code in next patch if you will please. meanwhile i will use justice only in Grift, but will be nice if i can use valor/hope in normal rift for quicker clear soon. thx

 

[Fujiyama]

View attachment CrusaderCombat.cs

I'm stuck at work, but I've been watching the bot and there are still some issues. Granted this is the same code as the newest Trinity.

I tried some quick and dirty fix: Add checks to loiter so it won't cast on lightning or physical. The bot will be dismounted a little bit more, but it works better for me. Edit: Better Iron Skin/Bombardment/TP. The loitering seems to cause problems.

I'll attach the file, but keep in mind it's done in a hurry - just posting it so you can test it and provide more feedbak for jubisman.

 

[fanaticc]

Jubisman Greetings men , some times I still got the problem steed charge spam after rift can't port to town and the bot need reset the game ( more if u use Swiftsteed) got the last version trinity .

 

[Krazydrummer]

Jubisman Greetings men , some times I still got the problem steed charge spam after rift can't port to town and the bot need reset the game ( more if u use Swiftsteed) got the last version trinity .

Hmm thats odd I have not gotten stuck at all since the newest version was released. I use "Use Steed OOC" and "Spam Steed on CD" with a swiftmount. I can't think of any other setting though that would affect it.

 

[nirvx]

This is correct actually. I forgot that CoE is a dynamic multiplicative damage boost and since it takes a second or so to start doing bombardment damage casting it at 2 or 1 second left on the electric buff would be the most damage.

Bombardment is snapshotted at the exact time you press the hotkey, and keeps that snapshot for the full duration of the bombardment damage. So you can cast it at any time while phys is up and you're good to go. Casting it while the lightning buff is up would be a loss

 

[fanaticc]

Hmm thats odd I have not gotten stuck at all since the newest version was released. I use "Use Steed OOC" and "Spam Steed on CD" with a swiftmount. I can't think of any other setting though that would affect it.

Just a question you are using the Version trinity from this post or the official?
I am using Trinity 2.14.23 from the sticky in the front page is the same right?

any diffence between this and the official?

 

[kekz]

Bombardment is snapshotted at the exact time you press the hotkey, and keeps that snapshot for the full duration of the bombardment damage. So you can cast it at any time while phys is up and you're good to go. Casting it while the lightning buff is up would be a loss

Incorrect for CoE, it is updated dynamically, true for iron skin however.

 

[jubisman]

Bombardment is snapshotted at the exact time you press the hotkey, and keeps that snapshot for the full duration of the bombardment damage. So you can cast it at any time while phys is up and you're good to go. Casting it while the lightning buff is up would be a loss

Where do you get this from? Can you link to any evidence supporting this?

Just a question you are using the Version trinity from this post or the official?
I am using Trinity 2.14.23 from the sticky in the front page is the same right?

any diffence between this and the official?

.23 is more up to date than this one, but CrusaderCombat.cs is the same in both.

 

[Krazydrummer]

Bombardment is snapshotted at the exact time you press the hotkey, and keeps that snapshot for the full duration of the bombardment damage. So you can cast it at any time while phys is up and you're good to go. Casting it while the lightning buff is up would be a loss

CoE is a dynamic buff and applies its damage increase when it rolls to that specific element. This means that you cannot snapshot CoE for any ability at all. It will dynamically apply the damage buff to whatever is going out, thats why the ring is so special for alot of builds. Its a pure double damage item. You can test it out for yourself, the bombardment damage takes 5 seconds total for it to finish doing damage. Thats 1 second for the first bombardment to hit and then 4 seconds of 10 hits if you are using the mortal drama (which you should be). So that means there are three situations that can happen:

1) You cast Bombardment at the immediate start of the CoE Physical
In this case you will have 1 second of the physical debuff where the first bombardment is landing (no damage happening), 3 seconds of 200% buffed damage and 1 second of shitty fire CoE buffed damage
2) You cast Bombardment at 1 second left of CoE Lightning
In this case we have 1 second of waiting for the first bombardment to hit and then 4 seconds of 200% buffed CoE Physical Bombardment damage.
3) You cast Bombardment on some other random CoE element
In this case I dont know why you casted it but you have 5 seconds of terrible damage.

Those are the three cases now lets look at some numbers that I took just now while standing at a rift guardian testing out numbers.

Case 1) For 3 seconds I did ~5.5-6 billion damage per hit and then 1 second ~2.7 billion damage
Case 2) For 4 seconds I did ~5.5-6 billion damage and there were no 2 billion damage hits
Case 3) I hit every time for ~2.5 billion

You can test this out, I took off belt of the trove to test this because that belt just brings chaos while trying to accurately time everything.

 

[Lorilol]

Bombardment is snapshotted at the exact time you press the hotkey, and keeps that snapshot for the full duration of the bombardment damage. So you can cast it at any time while phys is up and you're good to go. Casting it while the lightning buff is up would be a loss

It is not true for CoE, the damage changes dynamically.

Regarding LoN bombardment, I've been running 67s with 6~9min clear time but I've got 2 main problems that has been related here already:

1) I can't synchronize Iron Skin with bombardment properly. I've tried Iron Skin Health Pct with 25%~30% but it has been activated indistinctly. So I'm using it with 100%.

2) Many times Steed Charge is activated just before CoE physical cycle what destroys synergy. if I used Swiftmount It would be much worse.

There are 2 small problems but could be big problems if I tried to do 70+:

1) "Riftvalue ... isn't working well ... getting stuck by riftvalues that are ignored"

2) Arcane avoidance

 

[Okahuma]

Just a report. Sorry if this is already reported.

report:With Spam Steed Charge marked (also tested with 2.14.23, same result), when CoE goes to phys, instead of getting down from the horse and casting the big burst of Iron Skin+Bomb, it just runs around on the horse (which does a lot of damage and all, but it should cast the Iron Skin+Bomb). As others have said, it would be even better if it cast the big burst halfway through electric CoE.

Edit: I'm using Swiftmount.

 

[Fujiyama]

For better timing, is there a way to tell for how long an element buff has been active? Let us say we deny steed/loitering a second or two before physical, trigger Iron Skin a second before, then cast Bombardment? And is there any potential delay when checking the cached buff?

 

[Krazydrummer]

For better timing, is there a way to tell for how long an element buff has been active? Let us say we deny steed/loitering a second or two before physical, trigger Iron Skin a second before, then cast Bombardment? And is there any potential delay when checking the cached buff?

If you look at the buff on your bar and notice the sweeping clock motion of the cooldown, the buff is 4 seconds long so each quarter of the icon is one second.