Starting a demo lock with maybe some Afflic at the higher levels, will post issues as I find them.
First up, pulling with shadowbolt set when you have immolate set to be used (thinking around level 10) causes it to double cast shadowbolt which has the knock on effect of casting immolate then corruption very late in the sequence which is quite inefficient. Pull casts really need the same lastspell check you have for immolate during rotations, I think this would solve that problem.
The adds logic seems poor for low levels, had to turn this off from 1-15 so far.
At low demo levels, once casting immolate and corrup the bot will stand there with the Felguard pounding but not casting anything. I put a Cast Shadowbolt spell in the two demo routines so it's at least doing something instead of just standing around. Maybe at higher levels the rotation fills out, but at the lower levels it's strange looking and slower DPS.
Pet logic seems like it could use a few tweaks: I've only briefly looked at this since I was on the run last night, but the bot has slow casted Felguard in combat even with Soulburn available, which resulted in him dieing and again .. looking odd. I think a few tweaks to the logic here to prevent the bot EVER hardcasting a pet in combat (if mobs are beating on him better to just dps them first, maybe it becomes better with the talent that reduces summ time but thats still some time off), and to cast a pet in combat only if he can soulburn it. Outside combat either is fine.
That's all so far. Want to say thanks on getting Soul Harvest and a lot of non-clipping spells working. My excitement usually fades after using a new CC when inside the first 10 minutes of using the bot casts UA/Immolate like 3 times in a row, and soul harvests then runs off 1 second into it. So good job
If I could make one final suggestion .. demo bots look a bit static and clunky compared with players due to the mob dieing far away with the pet, and the bot being slightly slow at running to the corpse. And really, very few players just stand there when the mob is at 10% they are usually running over ready to loot.
Is it possible to add a command at say 25% (the hp may take some tweaking) that stops casting and has the bot running towards the mob so that by the time he gets there immo/dots/felguard will have finished the mob off and the bot is ready to loot and move on?
I think this would make things look and flow a lot smoother.
...?
Btw, make sure use instancebuddy for instances and questbuddy for questing.
