YourBuddy MoP BT - A warrior raiding custom routine

[Dagradt]

are you crazy? Iv is definitely a dps gain when used properly. It's meant for super-low rage situations when you have nothing better to do. (also an emergency heal)

it's not as great for fury as it is for arms, but it's still a dps increase. More time you spend doing damage = higher damage.

You should be pooling rage anyway for cs dumps unless enrage is dropping or has dropped off.

On incredibly high damage fights, yes, er is better. But in general, iv is the best of the 3 talents on that tier, by a fairly large margin.

he lives!!!

 

[Dagradt]

Updated version with several bugfixes won't take long anymore. It also has a completely rewritten behaviourtree making it several ms per traverse faster then the current one. Also some code cleanup done, and some optimization (Still alot optimization to be done).


Hit me up on Skype M8! I've heard you're very busy, but if you feel like ...


Glad you like the CR, will look into CD stacking in one of the upcoming releases.

PM me your Skype info

 

[gorunn]

Updated version with several bugfixes won't take long anymore. It also has a completely rewritten behaviourtree making it several ms per traverse faster then the current one. Also some code cleanup done, and some optimization (Still alot optimization to be done).


Hit me up on Skype M8! I've heard you're very busy, but if you feel like ...


Glad you like the CR, will look into CD stacking in one of the upcoming releases.

PM me your Skype info

This look good, Nomnom and Dag exchanging Skypes.. Possible coop of two good authors of exceptional CC's?

 

[Romao]

This look good, Nomnom and Dag exchanging Skypes.. Possible coop of two good authors of exceptional CC's?

This would be a great Christmas gift

 

[xsilverdicex]

hey, first of all the single target aspect of this CC is amazing, does the job very well except sometime's there is a 2-3 second delay in combat on pulling. Main problem i am having though is the CC never switches to AOE rotation i have it checked in the GUI, and i'm using the talents/glyphs in your popup image. is there anything else i need to do to make it detect multipul mobs?

 

[nomnomnom]

hey, first of all the single target aspect of this CC is amazing, does the job very well except sometime's there is a 2-3 second delay in combat on pulling. Main problem i am having though is the CC never switches to AOE rotation i have it checked in the GUI, and i'm using the talents/glyphs in your popup image. is there anything else i need to do to make it detect multipul mobs?

I tried to reproduce but I could'nt get it to "not work". Keep in mind that there are several very strict rules regarding AoE for fury, and those are implemented.

I'd suggest to create a fresh install of your Honorbuddy and try again, if you don't want to try that, provide me with your YBMoP Settings file and a logfile of the encounters.

========================================

@ Everyone --> Revision 45 is up on the SVN!
Rev 45 should pool up rage even better then previous without wasting DPS. It'll get rid of that rage during CS debuff . Rev42 --> Rev45 gave me a steady 3k dps increase on target dummy (69k to 72k) (Average, did 4 runs with each version with 30m dmg per run).

If you feel adventurus, feel free to try out the Experimental rotation. It is NOT finished yet though!

 

[xsilverdicex]

what are the rule's regarding AOE?

 

[Apoc]

Checked through some code, here's some fixes for you.

1) Always check "fast conditionals" first if you use them often. Eg; CanInterrupt in Dependencies.cs. Check your custom setting *first* then check if the target is casting, and can be interrupted. You always want to "fail" as quickly as possible. (A quick boolean comparison is going to be faster than running through the memory wrapping API)

2) In "CreateCombat" (Main.cs), I'd suggest removing your string comparison code.

new PrioritySelector(ret => Default() && YBMoP_BT_Settings.Instance.cRotSelect == "Standard",

Change this to an enum if at all possible. String comparisons are slow, and should be avoided if possible. (Considering you have 2 values, I'd suggest just changing it to a bool value and be done with it)

3) You don't need to check the target's health % when casting Execute. (This is done for you in SpellManager.CanCast. Special conditionals on spells are checked by WoW itself)

4) Your checks for HS are bad. You may want to change

Cast("Heroic Strike", ret => Me.CurrentRage >= 110 || !TargetHpCheck() && ((DeadlyCalmAura() && Me.CurrentRage >= 30) || (MeColossusSmashAura() && Me.CurrentRage >= 40))),

To

Cast("Heroic Strike", ret => Me.RagePercent >= 90 || (!TargetHpCheck() && ((DeadlyCalmAura() && Me.CurrentRage >= 30) || (MeColossusSmashAura() && Me.CurrentRage >= 40)))),

RagePercent >= 90 takes care of the glyph. (I personally don't always use it, so your code will never dump rage with HS for me)

5) Storm Bolt requirements check... string comparisons, etc. Fix it. (I'd suggest making a switch statement if that's how you want to do it, as it'll be far faster)

6) I'm not entirely sure why you even check if you have a main hand when using heroic throw. Simply cast it if the user has it enabled. (CanCast will take care of the rest)

And the rest basically goes without saying. Just make the above suggested optimizations everywhere, and you should be set.

 

[nomnomnom]

Checked through some code, here's some fixes for you.

1) Always check "fast conditionals" first if you use them often. Eg; CanInterrupt in Dependencies.cs. Check your custom setting *first* then check if the target is casting, and can be interrupted. You always want to "fail" as quickly as possible. (A quick boolean comparison is going to be faster than running through the memory wrapping API)

2) In "CreateCombat" (Main.cs), I'd suggest removing your string comparison code.

new PrioritySelector(ret => Default() && YBMoP_BT_Settings.Instance.cRotSelect == "Standard",

Change this to an enum if at all possible. String comparisons are slow, and should be avoided if possible. (Considering you have 2 values, I'd suggest just changing it to a bool value and be done with it)

3) You don't need to check the target's health % when casting Execute. (This is done for you in SpellManager.CanCast. Special conditionals on spells are checked by WoW itself)

4) Your checks for HS are bad. You may want to change

Cast("Heroic Strike", ret => Me.CurrentRage >= 110 || !TargetHpCheck() && ((DeadlyCalmAura() && Me.CurrentRage >= 30) || (MeColossusSmashAura() && Me.CurrentRage >= 40))),

To

Cast("Heroic Strike", ret => Me.RagePercent >= 90 || (!TargetHpCheck() && ((DeadlyCalmAura() && Me.CurrentRage >= 30) || (MeColossusSmashAura() && Me.CurrentRage >= 40)))),

RagePercent >= 90 takes care of the glyph. (I personally don't always use it, so your code will never dump rage with HS for me)

5) Storm Bolt requirements check... string comparisons, etc. Fix it. (I'd suggest making a switch statement if that's how you want to do it, as it'll be far faster)

6) I'm not entirely sure why you even check if you have a main hand when using heroic throw. Simply cast it if the user has it enabled. (CanCast will take care of the rest)

And the rest basically goes without saying. Just make the above suggested optimizations everywhere, and you should be set.

Thanks for looking through and pointing out your concerns. I'll definitely use your advice to improve this CC, thanks!

 

[nomnomnom]

SVN download URL has changed!!!

 

[Pipedreams]

what are the rule's regarding AOE?

Mobs are set to be counted with u.IsWithinMeleeRange as a condition, which i believe is 5yds, while whirlwind's range is 8yds (unglyphed). That's probably why you are having issues!

Edit: This is apparently on the fix list for NomNomNom, it should be an easy one, in the meantime, just stand closer to mobs to trigger aoe.

 

[simplyxz]

Is anyone else getting serious FPS lags when using this profile? When running CCs on my DK they all run fine with no FPS lags, this on the other hand is extremely slow in combat.. Any ideas how to fix this?

 

[Pipedreams]

Is anyone else getting serious FPS lags when using this profile? When running CCs on my DK they all run fine with no FPS lags, this on the other hand is extremely slow in combat.. Any ideas how to fix this?

What botbase are you using? Lazyraider in raidbot mode is running perfectly for me.

 

[randomstraw]

What botbase are you using? Lazyraider in raidbot mode is running perfectly for me.

radibot causes fps lag here, too. but i guess my maschine just can't handle it.

using this CC with Tyrael @ 200 Ticks = perfect.

 

[nomnomnom]

radibot causes fps lag here, too. but i guess my maschine just can't handle it.

using this CC with Tyrael @ 200 Ticks = perfect.

Keep in mind its not 100% Tyrael compatible yet! Working on that .

The lag is caused by either AoE or slow pc. Upcoming version will reduce the resource usage of HB, so that will improve it for everyone .

 

[daorigin]

Keep in mind its not 100% Tyrael compatible yet! Working on that .

The lag is caused by either AoE or slow pc. Upcoming version will reduce the resource usage of HB, so that will improve it for everyone .

i get dps loss with tyrael - i got 3ghz quad with 8gb of ram n 2gb of gpu that isnt a slow pc but i do see a fps loss with raidbot.

 

[randomstraw]

Keep in mind its not 100% Tyrael compatible yet! Working on that .

The lag is caused by either AoE or slow pc. Upcoming version will reduce the resource usage of HB, so that will improve it for everyone .

oh, its not?

whats missing? for me tyrael works way better than raidbot. raidbot gives me lags.

 

[Romao]

oh, its not?

whats missing? for me tyrael works way better than raidbot. raidbot gives me lags.

Have you tried Lazyraider? I play with it on raidbot option. And you can adjust the ticks. It works for me. As i dont have a super PC, Raidbot make my game lag alot.

 

[nomnomnom]

The CC might lag for people, as it tries to run as fast as possible. Probaly AoE situations will turn out even worse. I'd still suggest sticking with Raidbot if your PC can handle it, otherwise indeed Lazyrader and adjust the ticks.

Upcoming version is in the making. Not a major edit, just optimizing most of the code and implementing Apoc's mentioned changes. Also rotational updates ofcourse . Few more days!

People are getting ranked on World of Logs with the current rotation.

 

[Romao]

The CC might lag for people, as it tries to run as fast as possible. Probaly AoE situations will turn out even worse. I'd still suggest sticking with Raidbot if your PC can handle it, otherwise indeed Lazyrader and adjust the ticks.

Since the last update in AoE situation my game lag a little even using Lazyraider, i was getting upset cuz i love this routine and currently raiding with it. Even thought of buying a new PC to run it . But then try Tyrael and it got fine. Clearly in this last update the CC run alot faster, it was a big increase in the DPS.

Upcoming version is in the making. Not a major edit, just optimizing most of the code and implementing Apoc's mentioned changes. Also rotational updates ofcourse . Few more days!

This make me anxious to see this excellent routine get some implement by Apoc.

People are getting ranked on World of Logs with the current rotation.

Indeed!