I'm just wating for the monk stuff to get sorted out and I'll release v0.44
Also, thanks man
Unified GilesPlugin's Unnoficial Updates File
- Thread starter jubisman
- Start date
- Status
Also, thanks man
rrrix
New Member
- Joined
- Jul 11, 2010
- Messages
- 3,449
- Reaction score
- 61
It's included in my questing pack, http://www.thebuddyforum.com/demonb...4-full-questing-all-acts-complete-tested.html
Pinata? what is that?
And sure - but, where do you want it to go? Avoidance? Blacklist? Target priority? Boss? Interact range?
Magi
New Member
- Joined
- Oct 12, 2012
- Messages
- 1,242
- Reaction score
- 7
Damn dude. I gotta try this out. Nice work!
Sorry rrrix,
I have test v39 and have little bug during my leveling (just little on chest and shrine) but I don't follow next work on it ^^ ( I try already follow this and items rule version
) It's cool if you continue to refresh it.
If all people are right, I think to take your version or fork for official "Unified version" is very good idea =)
It's included in my questing pack, http://www.thebuddyforum.com/demonb...4-full-questing-all-acts-complete-tested.html
Pinata? what is that?
And sure - but, where do you want it to go? Avoidance? Blacklist? Target priority? Boss? Interact range?
Pinata is breakable object in Whimsyshire ^^
fuimusbruce
New Member
- Joined
- Aug 2, 2012
- Messages
- 450
- Reaction score
- 2
It's included in my questing pack, http://www.thebuddyforum.com/demonb...4-full-questing-all-acts-complete-tested.html
Pinata? what is that?
And sure - but, where do you want it to go? Avoidance? Blacklist? Target priority? Boss? Interact range?
yep breakable object in whimsy...was thinking putting it with resplendent chest since its whimsys version of that...but unsure if that is really the right spot as it is a breakable, here is the code
GizmoType: DestructibleLootContainer Name: Pinata-5020 ActorSNO: 211861
any one would like to test whether this will work for town run?
this should theoretically solve the stuck problem.....
consider this as a suggestion, I don't see if it's working or not.
this should theoretically solve the stuck problem.....
consider this as a suggestion, I don't see if it's working or not.
Code:
diff --git a/GilesTrinity.cs b/GilesTrinity.cs
index fd4af46..eca5677 100644
--- a/GilesTrinity.cs
+++ b/GilesTrinity.cs
@@ -1255,6 +1255,7 @@ namespace GilesTrinity
private static Vector3 vLastMoveToTarget;
private static float fLastDistanceFromTarget;
private static DateTime lastMovementCommand = DateTime.Today;
+ private static DateTime lastTownRunCommand = DateTime.Today;
// Actual combat function variables
private static bool bMappedPlayerAbilities = false;
@@ -5310,6 +5311,20 @@ namespace GilesTrinity
return RunStatus.Running;
}
+
+ // K: Check town run here
+ if (bWantToTownRun)
+ {
+ ACDAnimationInfo myAnimationState = ZetaDia.Me.CommonData.AnimationInfo;
+ Log("Current State id:" + myAnimationState.Current + " state id: " + myAnimationState.State);
+ if (myAnimationState != null && myAnimationState.State == AnimationState.Channeling)
+ {
+
+ double fSecondAfterRunTown = DateTime.Now.Subtract(lastTownRunCommand).TotalSeconds;
+ if (fSecondAfterRunTown > 4 && fSecondAfterRunTown < 8)
+ {
+ // We should wait between the last seconds of town run
+ BotMain.StatusText = "We should wait between the last seconds of town run";
+ Log("We should wait between the last seconds of town run");
+ return RunStatus.Running;
+ }
+ }
+ }
if (settings.bDebugInfo)
{
sStatusText = "[GilesTrinity] ";
@@ -8894,11 +8909,18 @@ namespace GilesTrinity
if (!bLastTownRunCheckResult)
bPreStashPauseDone = false;
bWantToTownRun = true;
+ break;
}
}
}
}
bLastTownRunCheckResult = bWantToTownRun;
+ // K: check time for town run
+ if (bWantToTownRun && DateTime.Now.Subtract(lastTownRunCommand).TotalSeconds > 6)
+ {
+ lastTownRunCommand = DateTime.Now;
+
+ }
return bWantToTownRun;
}
Last edited:
mylo
Member
- Joined
- Jun 14, 2012
- Messages
- 128
- Reaction score
- 9
I know it's a bit of an elephant in the room, but really I think we all know this should be ported over to rrrix's trinity fork for future versions and put on Github. I'm just throwing this out there, it'll stop a lot of duplicated work in future and much better revisioning etc. Probably better to do this sooner than later, not sure who wants to take on this project if anyone though?
I take this project, I already contacted rrix on PM, and try to view if he want share his code or if I just make a fork and go on separate way.In addition, yesterday, I start speaking with Jubisman for refactoring the code after release v0.45.
In two case, we will put the result on GitHub or tfs (CodePlex or TFS online). I prefer tfs solution, because there may be several people to manage code and not only 1 guy which is forced to merge all work (In free version).
I go sleep a bit and tomorrow, I come back to rrrix to decide how he want make.
And after job, I start setup codeplex project.
if someone want help me (and may be rrrix), he can PM me.
Magi
New Member
- Joined
- Oct 12, 2012
- Messages
- 1,242
- Reaction score
- 7
I agree with the above, I think what rrix is doing is in the right direction. Definitely more manageable. I'm going to test out his modifications and see how my bot performs. I think porting over what has been done since .41 is simple enough and getting this into some kind of manageable repository where multiple parties can maintain the code would be best.
Basically everything hti has said above is right on.
Honestly, i'd rather have only one person in charge of doing merges; allowing a bunch of people to do merges to the canonical repo is a bad idea at this stage. Also, PLEASE consider using git (even if not github, pick somebody else) and not tfs. I'm not a huge fan of TFS.
BTW you can add as many ssh-keys to github as you like... you can just make a role account...
Magi
New Member
- Joined
- Oct 12, 2012
- Messages
- 1,242
- Reaction score
- 7
However we decide to set things up, I am giving a +1 for converting to rrrix's stuff (sooner than later)
I'm using his version right now, and things seem to be going well. Loot pickup definitely seems improved/fixed. That was a huge problem for my specific profiles. That alone sells me beyond the real work he put into eliminating the enormous trinity file. Way to go rrrix!
I'm using his version right now, and things seem to be going well. Loot pickup definitely seems improved/fixed. That was a huge problem for my specific profiles. That alone sells me beyond the real work he put into eliminating the enormous trinity file. Way to go rrrix!
bombastic
New Member
- Joined
- Jun 18, 2012
- Messages
- 430
- Reaction score
- 3
I've started to play a monk, and made a "inna edtion" version based on 0.43.
What that version does? If you have the popular combo breath of heaven / blind flash / sweeping wind AND a full inna set, some things will change:
* Sweeping Wind never goes off. It will auto recast before it wears off;
* Sweeping Wind is casted only after breath of heaven and blinding flash are both activated (to maximize damage);
* Mantra of Conviction is more spammed to maximize damage as well.
* You must have a 5 pieces inna set for this to work. And check the option in the GUI, obviously.
* Without sweeping wind wearing off your monk always have full damage, because of an bug/exploit blizzard never fixed
In rares occasions is still possible to lose the buff: looting chest / corpses when the buff is wearing off, if connection lags, or for being incapacited (frozen, nightmare, stunned, etc)
Now we need a plugin to equip a dual weapon / cast sw / equip dual wield
ps: all my changes regarding inna set are marked with //intell -- inna
What that version does? If you have the popular combo breath of heaven / blind flash / sweeping wind AND a full inna set, some things will change:
* Sweeping Wind never goes off. It will auto recast before it wears off;
* Sweeping Wind is casted only after breath of heaven and blinding flash are both activated (to maximize damage);
* Mantra of Conviction is more spammed to maximize damage as well.
* You must have a 5 pieces inna set for this to work. And check the option in the GUI, obviously.
* Without sweeping wind wearing off your monk always have full damage, because of an bug/exploit blizzard never fixed
In rares occasions is still possible to lose the buff: looting chest / corpses when the buff is wearing off, if connection lags, or for being incapacited (frozen, nightmare, stunned, etc)
Now we need a plugin to equip a dual weapon / cast sw / equip dual wield
ps: all my changes regarding inna set are marked with //intell -- inna
Last edited:
rrrix
New Member
- Joined
- Jul 11, 2010
- Messages
- 3,449
- Reaction score
- 61
Oh gosh, what did I get myself into
I agree ksmaze that it's unfortunate Giles himself isn't here to chime in, but, "the show must go on" ...
I must say I've never done an open source project before and have only worked in a closed source environment with trusted peers, so I'm not really sure how to setup and manage this context. Need to look up some best practices I suppose.
I would be happy just being a contributor, rather than doing the administrative or ownership end.
I have no preference to a revision control system, but agree we need one.
Please note that I am not a software engineer by profession, but rather an enterprise sysadmin with a big toolbox to get things done.
Questions that come to mind:
Who should have access to make changes?
How do we manage the circle of trust?
Do changes have to be approved before they're available to everyone?
How should testing work - e.g. if I make a change that fixes my problem but breaks something hti had spent 3 hours on?
I agree ksmaze that it's unfortunate Giles himself isn't here to chime in, but, "the show must go on" ...
I must say I've never done an open source project before and have only worked in a closed source environment with trusted peers, so I'm not really sure how to setup and manage this context. Need to look up some best practices I suppose.
I would be happy just being a contributor, rather than doing the administrative or ownership end.
I have no preference to a revision control system, but agree we need one.
Please note that I am not a software engineer by profession, but rather an enterprise sysadmin with a big toolbox to get things done.
Questions that come to mind:
Who should have access to make changes?
How do we manage the circle of trust?
Do changes have to be approved before they're available to everyone?
How should testing work - e.g. if I make a change that fixes my problem but breaks something hti had spent 3 hours on?
Magi
New Member
- Joined
- Oct 12, 2012
- Messages
- 1,242
- Reaction score
- 7
Oh gosh, what did I get myself into
I agree ksmaze that it's unfortunate Giles himself isn't here to chime in, but, "the show must go on" ...
I must say I've never done an open source project before and have only worked in a closed source environment with trusted peers, so I'm not really sure how to setup and manage this context. Need to look up some best practices I suppose.
I would be happy just being a contributor, rather than doing the administrative or ownership end.
I have no preference to a revision control system, but agree we need one.
Please note that I am not a software engineer by profession, but rather an enterprise sysadmin with a big toolbox to get things done.
Questions that come to mind:
Who should have access to make changes?
How do we manage the circle of trust?
Do changes have to be approved before they're available to everyone?
How should testing work - e.g. if I make a change that fixes my problem but breaks something hti had spent 3 hours on?
Yeah you're screwed man lol jk.
the less the better, others should fork the source and ask to merge if you try to use Git. there are many online free Git server except Github(and I don't like its free version)
wow, are you really talking about a circle?!... if you want to keep the code correct and safe, give only the guaranteed contributor the permission to commit the changes. like here only J and Darkfriend can change the source code.
no problem, that's what version control for. just reverse back to the right version. and I believe this is what Nesox is always doing
but... testing is painful anyway.... lol
- Status