Two Trinity fixes: Steed Charge & Stash Rift Stones

[bombastic]

1) To make Trinity respect your options in Items / Town Run / Keep Rift/Trial/GR in Stash, replace in Plugins\Trinity\Items\TrinityItemManager.cs:

From:

if (Trinity.Settings.Loot.TownRun.KeepTieredLootRunKeysInBackpack && item.ItemType == ItemType.KeystoneFragment && item.TieredLootRunKeyLevel >= 1)
return false;
if (Trinity.Settings.Loot.TownRun.KeepTrialLootRunKeysInBackpack && item.ItemType == ItemType.KeystoneFragment && item.TieredLootRunKeyLevel == 0)
return false;
if (Trinity.Settings.Loot.TownRun.KeepRiftKeysInBackpack && item.ItemType == ItemType.KeystoneFragment && item.TieredLootRunKeyLevel <= -1)
return false;

To:

if (item.ItemType == ItemType.KeystoneFragment)
{
if (
(Trinity.Settings.Loot.TownRun.KeepTieredLootRunKeysInBackpack && item.TieredLootRunKeyLevel >= 1)
||
(Trinity.Settings.Loot.TownRun.KeepTrialLootRunKeysInBackpack && item.TieredLootRunKeyLevel == 0)
||
(Trinity.Settings.Loot.TownRun.KeepRiftKeysInBackpack && item.TieredLootRunKeyLevel <= -1)
)
return false;
else
return true;
}

After that, trinity will stash your stones properly.

2) To fix Steed Charge going in an endless loop when trying to Town Portal, just edit all your profiles and replace TownPortal and TrinityTownPortal tags to UseTownPortal.

The native UseTownPortal tag is the only one that try to move a bit when TP fails. QuestTools tags, atm, does not do that. From logs:

09:48:20.299 DEBUG DefaultNavigationProvider Generating path to Moving a little, no tp was cast! - <886.4965, 676.6354, 0.1>
09:48:20.306 DEBUG DefaultNavigationProvider Successfully generated path from {X=169,Y=353} to {X=173,Y=355} in 00:00:00.0017326 with 5(3) hops
09:48:20.333 DEBUG DefaultNavigationProvider Client path generated.
09:48:20.334 DEBUG DefaultNavigationProvider Generated path to <886.4965, 676.6354, 0.1> (Moving a little, no tp was cast!) with 3 hops.

Hopefully rrrix will fix both

 

[Kevin Spacey]

ty, i will use it =)

 

[Kevin Spacey]

any ideas how to add attack radius for kamikadze mode for goblins?
to override profile tags
i dig into Weighting.cs and HandleTarget.cs without success =(

 

[barbarian6]

any idea how to make bot stash gems and mats only in 1 specific tab? not in every free one...

 

[bombastic]

any ideas how to add attack radius for kamikadze mode for goblins?
to override profile tags
i dig into Weighting.cs and HandleTarget.cs without success =(

I didn't test, but try this in RefreshObjects.cs:

Delete these 2 lines...

                AnyTreasureGoblinsPresent = false;
                CurrentBotKillRange = Settings.Combat.Misc.NonEliteRange;

...and add these instead:

                CurrentBotKillRange = Settings.Combat.Misc.NonEliteRange;
				
				if (AnyTreasureGoblinsPresent && Settings.Combat.Misc.GoblinPriority == GoblinPriority.Kamikaze && CurrentBotKillRange < 60f)
					CurrentBotKillRange = 60f;

                AnyTreasureGoblinsPresent = false;

 

[barbarian6]

it does not work bombastic, still keeping trial keys and GR keys in backpack instead of stash (even taking them from stash to backpack)

that's how this file looks like on my end:

public bool ShouldStashItem(ACDItem item, ItemEvaluationType evaluationType)
{
ItemEvents.ResetTownRun();

if (Current.ItemIsProtected(item))
return false;

// Vanity Items
if (DataDictionary.VanityItems.Any(i => item.InternalName.StartsWith(i)))
return false;

if (item.ItemType == ItemType.KeystoneFragment)
{
if (
(Trinity.Settings.Loot.TownRun.KeepTieredLootRunKeysInBackpack && item.TieredLootRunKeyLevel >= 1)
||
(Trinity.Settings.Loot.TownRun.KeepTrialLootRunKeysInBackpack && item.TieredLootRunKeyLevel == 0)
||
(Trinity.Settings.Loot.TownRun.KeepRiftKeysInBackpack && item.TieredLootRunKeyLevel <= -1)
)
return false;
else
return true;
}
if (Trinity.Settings.Loot.ItemFilterMode == ItemFilterMode.DemonBuddy)
{
return Current.ShouldStashItem(item);
}

CachedACDItem cItem = CachedACDItem.GetCachedItem(item);

 

[bombastic]

it does not work bombastic, still keeping trial keys and GR keys in backpack instead of stash (even taking them from stash to backpack)

that's how this file looks like on my end:

It does work, I assure you.

Your problem about demonbuddy always taking them from stash is another thing.

R-RIFT.xml profile, for example, take them no matter what is your settings. To prevent that, comment out the line, like this:

<!-- <GetItemFromStash questId="1" greaterRiftKey="True" /> -->

 

[barbarian6]

Thanks for response. Will give it a go in the eve

 

[lennart1337]

My Crusader just uses condemn and standing still, not attacking or moving when theres mobs. I used a crusadercombat.cs and it worked with that one. But with new trinity it doesnt workanymore. any solutions?

 

[Kevin Spacey]

bombastic man, any ideas how to fix - bot pick up empowered shrine even if it uncheked in trinity
dont sure about other shrines