Tweaked pickup rule for darkfriend's loot plugin

fr0stebyte · Dec 5, 2012

[Updated] Tweaked pickuprule.dis for darkfriend's loot plugin

Optimized pickup.dis for latest Rules

PICKUP
1H ilvl 61+
Gloves ilvl57+
Jewelry ilvl54+
Armor 61+ not ignored below

WILL NOT pickup:

Blues && iLvl 60-

Weapons:

Twohanded
Bow
Crossbow
Staff
Polearm
Daibo
Hand Crossbow

Offhands

Shields
Quivers
Mojo
Orbs

Armor

Boots
Cloaks
SpiritStone
VoodooMask
WizardHats

Picks up all LEGENDARIES and JEWELRY

Code:

[SIZE=1]// +---------------------------------------------------------------------------+
// |  ______ _______ ______ __  __      _______ ______ 
// | |   __ \_     _|      |  |/  |    |   |   |   __ \
// | |    __/_|   |_|   ---|     <     |   |   |    __/
// | |___|  |_______|______|__|\__|    |_______|___|   
// | ++++++++++++++++++++++++++++++++++++++++++++++++++
// +---------------------------------------------------------------------------+                                                 
Changelog:
v0.3

    Picking up all legendaries no matter iLvl
    Tidy update from Midas
    Midas Glove Pickup rule, now picking up all lvl58+ gloves
// +---------------------------------------------------------------------------+
// |  _______ ______ _______ ______ _______ _______ _____   
// | |     __|   __ \    ___|      |_     _|   _   |     |_ 
// | |__     |    __/    ___|   ---|_|   |_|       |       |
// | |_______|___|  |_______|______|_______|___|___|_______|
// +---------------------------------------------------------------------------+                                               

// craftingPlans on the ground have all quality normal cant decide here
[QUALITY] == "Normal" && [TYPE] == "CraftingPlan"

// +---------------------------------------------------------------------------+
// |  _____   _______ _______ _______ _______ _____  _______ ______ ___ ___ 
// | |     |_|    ___|     __|    ___|    |  |     \|   _   |   __ \   |   |
// | |       |    ___|    |  |    ___|       |  --  |       |      <\     / 
// | |_______|_______|_______|_______|__|____|_____/|___|___|___|__| |___|                                                                     
// +---------------------------------------------------------------------------+
           
[QUALITY] == "Legendary"

// +--------------------------------------------------------------------------------------+
// |  ______ _______ ______ _______ 
// | |   __ \   _   |   __ \    ___|
// | |      <       |      <    ___|
// | |___|__|___|___|___|__|_______|                     
// +--------------------------------------------------------------------------------------+

//Special Glove Pickup Rule
[QUALITY] == "Rare"  && [TYPE] == "Gloves" && [LEVEL] >=58

//Weapon Ignore Rules
[QUALITY] == "Rare"  && [LEVEL] <= 61 && [BASETYPE] == "Weapon" -> [IGNORE]
[QUALITY] == "Rare"  && [BASETYPE] == "Weapon" && [TWOHAND] -> [IGNORE]
[QUALITY] == "Rare"  && [TYPE] == "Bow" -> [IGNORE]
[QUALITY] == "Rare"  && [TYPE] == "Crossbow" -> [IGNORE]
[QUALITY] == "Rare"  && [TYPE] == "Staff" -> [IGNORE]
[QUALITY] == "Rare"  && [TYPE] == "Polearm" -> [IGNORE]
[QUALITY] == "Rare"  && [TYPE] == "Daibo" -> [IGNORE]
[QUALITY] == "Rare"  && [TYPE] == "HandCrossbow" -> [IGNORE]

//Off Hand Ignore Rules
[QUALITY] == "Rare"  && [TYPE] == "Shield" -> [IGNORE]
[QUALITY] == "Rare"  && [TYPE] == "Quiver" -> [IGNORE]
[QUALITY] == "Rare"  && [TYPE] == "Mojo" -> [IGNORE]
[QUALITY] == "Rare"  && [TYPE] == "Orb" -> [IGNORE]

//Armor Ignore Rules
//[QUALITY] == "Rare"  && [TYPE] == "Legs" -> [IGNORE]
//[QUALITY] == "Rare"  && [TYPE] == "Belt" -> [IGNORE]
//[QUALITY] == "Rare"  && [TYPE] == "Helm" -> [IGNORE]
//[QUALITY] == "Rare"  && [TYPE] == "MightyBelt" -> [IGNORE]
[QUALITY] == "Rare"  && [LEVEL] <= 60 && [BASETYPE] == "Armor"  -> [IGNORE]
[QUALITY] == "Rare"  && [TYPE] == "Boots" -> [IGNORE]
[QUALITY] == "Rare"  && [TYPE] == "Cloak" -> [IGNORE]

//Hats Ignore Rules
[QUALITY] == "Rare"  && [TYPE] == "SpiritStone" -> [IGNORE]
[QUALITY] == "Rare"  && [TYPE] == "VoodooMask" -> [IGNORE]
[QUALITY] == "Rare"  && [TYPE] == "WizardHat" -> [IGNORE]

//Jewelry Ignore Rule
[QUALITY] == "Rare"  && [TYPE] == "FollowerSpecial"  -> [IGNORE]

//Pickup Rules
[QUALITY] == "Rare"  && [LEVEL] >= 61  && [BASETYPE] == "Weapon"
[QUALITY] == "Rare"  && [BASETYPE] == "Jewelry"
[QUALITY] == "Rare"  && [LEVEL] > 60  && [BASETYPE] == "Armor"

// +---------------------------------------------------------------------------+
// |  _______ _______ _______ _______ ______ 
// | |   |   |   _   |     __|_     _|      |
// | |       |       |    |  |_|   |_|   ---|
// | |__|_|__|___|___|_______|_______|______|                                                                                                   
// +---------------------------------------------------------------------------+
//Magic GTFO
[QUALITY] == "Magic" -> [IGNORE][/SIZE]

Instructions:

Download Updated Trinity
Replace pickup.dis file on your /Plugins/GilesTrinity/ItemRules/ folder
Select Use Custom Script Rules on Trinity Settings

Link: pickup.dis

Info:
If you want to revert some rules just add // or remove them at will

fr0stebyte · Dec 14, 2012

Changelog:
v0.3

Picking up all legendaries no matter iLvl
Tidy update from Midas
Midas Glove Pickup rule, now picking up all lvl57+ gloves

FAQ:
Q: Does it pickups up all legendaries and stash them?
A: It picks up all, but stashing is sorted out with legendary.dis, for that you change in config.dis and add an // to ignore legendary stashing rules

Q: Gosh, frost, your rules are so strict, how can loosen or close them up?
A: Simply remove/add some // from the desired item.

Q: What about trinity gems, potions?
A: Trinity options handle them itself, if it doesn't currently PM

Accepting future suggestions for simple editing or ideias.

Having an idea to work on a gui front end.

Give some likes on the helpers.

Mammon · Dec 14, 2012

Thx, appreciate it

darkfriend77 · Dec 15, 2012

nice contribution thx ... if u havent access to my private repo for donators ...then .... send me a PM

Midas · Dec 15, 2012

fr0stebyte thanks a lot for this!!!

Sidenote: That link to dropbox is a different pickup.dis to the "code" section of your post.

According to the patch notes for 1.05, "Items below iLevel 58 no longer drop in Inferno difficulty". Therefore some of the rules that refer to level are superfluous. Obviously no one would be using darkfriends rules outside of inferno.

For example in the legendary section:

[QUALITY] == "Legendary" && [LEVEL] > 57
[QUALITY] == "Legendary" && [LEVEL] > 50 && [TYPE] == "Jewelry"
//ignore rule
[QUALITY] == "Legendary" && [LEVEL] <= 56 -> [IGNORE]

No need to specify legendary jewelry above 50 because they all will be, and no need to ignore legendaries below 56 since there is none in inferno.

This whole legendary section can simply be reduced to:

[QUALITY] == "Legendary"

ooo look how sleek that line is

Another one is:

[QUALITY] == "Rare" && [LEVEL] <= 54 && [BASETYPE] == "Jewelry"-> [IGNORE]

Again this does nothing.

Also this applies to some of the pickup code.

So I have tidied things up a bit and come up with this version. What do you think?

Code:

// +---------------------------------------------------------------------------+
// |  ______ _______ ______ __  __      _______ ______ 
// | |   __ \_     _|      |  |/  |    |   |   |   __ \
// | |    __/_|   |_|   ---|     <     |   |   |    __/
// | |___|  |_______|______|__|\__|    |_______|___|   
// | ++++++++++++++++++++++++++++++++++++++++++++++++++
// +---------------------------------------------------------------------------+                                                 

// +---------------------------------------------------------------------------+
// |  _______ ______ _______ ______ _______ _______ _____   
// | |     __|   __ \    ___|      |_     _|   _   |     |_ 
// | |__     |    __/    ___|   ---|_|   |_|       |       |
// | |_______|___|  |_______|______|_______|___|___|_______|
// +---------------------------------------------------------------------------+                                               

// craftingPlans on the ground have all quality normal cant decide here
[QUALITY] == "Normal" && [TYPE] == "CraftingPlan"

// +---------------------------------------------------------------------------+
// |  _____   _______ _______ _______ _______ _____  _______ ______ ___ ___ 
// | |     |_|    ___|     __|    ___|    |  |     \|   _   |   __ \   |   |
// | |       |    ___|    |  |    ___|       |  --  |       |      <\     / 
// | |_______|_______|_______|_______|__|____|_____/|___|___|___|__| |___|                                                                     
// +---------------------------------------------------------------------------+
           
[QUALITY] == "Legendary"

// +--------------------------------------------------------------------------------------+
// |  ______ _______ ______ _______ 
// | |   __ \   _   |   __ \    ___|
// | |      <       |      <    ___|
// | |___|__|___|___|___|__|_______|                     
// +--------------------------------------------------------------------------------------+

//Weapon Ignore Rules
[QUALITY] == "Rare"  && [LEVEL] <= 61 && [BASETYPE] == "Weapon" -> [IGNORE]
[QUALITY] == "Rare"  && [BASETYPE] == "Weapon" && [TWOHAND] -> [IGNORE]
[QUALITY] == "Rare"  && [TYPE] == "Bow" -> [IGNORE]
[QUALITY] == "Rare"  && [TYPE] == "Crossbow" -> [IGNORE]
[QUALITY] == "Rare"  && [TYPE] == "Staff" -> [IGNORE]
[QUALITY] == "Rare"  && [TYPE] == "Polearm" -> [IGNORE]
[QUALITY] == "Rare"  && [TYPE] == "Daibo" -> [IGNORE]
[QUALITY] == "Rare"  && [TYPE] == "HandCrossbow" -> [IGNORE]

//Off Hand Ignore Rules
[QUALITY] == "Rare"  && [TYPE] == "Shield" -> [IGNORE]
[QUALITY] == "Rare"  && [TYPE] == "Quiver" -> [IGNORE]
[QUALITY] == "Rare"  && [TYPE] == "Mojo" -> [IGNORE]
[QUALITY] == "Rare"  && [TYPE] == "Orb" -> [IGNORE]

//Armor Ignore Rules
//[QUALITY] == "Rare"  && [TYPE] == "Legs" -> [IGNORE]
//[QUALITY] == "Rare"  && [TYPE] == "Belt" -> [IGNORE]
//[QUALITY] == "Rare"  && [TYPE] == "Helm" -> [IGNORE]
//[QUALITY] == "Rare"  && [TYPE] == "MightyBelt" -> [IGNORE]
[QUALITY] == "Rare"  && [LEVEL] <= 60 && [BASETYPE] == "Armor"  -> [IGNORE]
[QUALITY] == "Rare"  && [TYPE] == "Boots" -> [IGNORE]
[QUALITY] == "Rare"  && [TYPE] == "Cloak" -> [IGNORE]

//Hats Ignore Rules
[QUALITY] == "Rare"  && [TYPE] == "SpiritStone" -> [IGNORE]
[QUALITY] == "Rare"  && [TYPE] == "VoodooMask" -> [IGNORE]
[QUALITY] == "Rare"  && [TYPE] == "WizardHat" -> [IGNORE]

//Jewelry Ignore Rule
[QUALITY] == "Rare"  && [TYPE] == "FollowerSpecial"  -> [IGNORE]

//Pickup Rules
[QUALITY] == "Rare"  && [LEVEL] > 61  && [BASETYPE] == "Weapon"
[QUALITY] == "Rare"  && [TYPE] == "Gloves"
[QUALITY] == "Rare"  && [BASETYPE] == "Jewelry"
[QUALITY] == "Rare"  && [LEVEL] > 60  && [BASETYPE] == "Armor"

// +---------------------------------------------------------------------------+
// |  _______ _______ _______ _______ ______ 
// | |   |   |   _   |     __|_     _|      |
// | |       |       |    |  |_|   |_|   ---|
// | |__|_|__|___|___|_______|_______|______|                                                                                                   
// +---------------------------------------------------------------------------+
//Magic GTFO
[QUALITY] == "Magic" -> [IGNORE]

fr0stebyte · Dec 15, 2012

That was a minor thing, the hole important thing was the ignore/pickup priority.
Thank you,

Applying to main pickup

Midas · Dec 15, 2012

Actually one more important change.

Move the glove pickup line to be above the armor ignore rule;
[QUALITY] == "Rare" && [TYPE] == "Gloves"

The rules evaluate in order, so if you have the glove pickup at the bottom, it will ignore gloves below 60 due to the rule that ignores armor below 60.

fr0stebyte · Dec 15, 2012

updatng the dropbox file when i get home,
quoted code is updated

edit: link updated

604hunter · Dec 15, 2012

hey guys,

for some reason its not picking up ilvl61 maces such as Goedendag

fr0stebyte · Dec 15, 2012

fixed

Midas · Dec 15, 2012

604hunter said:
hey guys,

for some reason its not picking up ilvl61 maces such as Goedendag

That's on purpose. It is set to pickup weapons above 61, ie only 62 and 63.

The base damage of level 61 weapons is not high enough. Even with level63 damage mods, the 61 weapons aren't that great.

Quick test for this, search the AH for all maces, sort by largest damage and look at the top results. There will be 90% level 63, 9% 62 and maybe eventually you'll find 1% 61.

This pickup rule is trying to prevent you from wasting time picking up and going to town to identify worthless level 61 weapons, even if you miss the 1 in 100,000 that is worth something

fr0stebyte · Dec 15, 2012

Midas said:
That's on purpose. It is set to pickup weapons above 61, ie only 62 and 63.

The base damage of level 61 weapons is not high enough. Even with level63 damage mods, the 61 weapons aren't that great.

Quick test for this, search the AH for all maces, sort by largest damage and look at the top results. There will be 90% level 63, 9% 62 and maybe eventually you'll find 1% 61.

This pickup rule is trying to prevent you from wasting time picking up and going to town to identify worthless level 61 weapons, even if you miss the 1 in 100,000 that is worth something

All items can roll 63 affixes now, affix is based on monster level, a3 or mp all monsters are 63

Winster · Dec 15, 2012

So if i do not alter the legendary file, it will still pickup all legendary items based on your script, and then identify and deposit them like the default loot setup via trinity?

EDIT :: Will it also pick up all potions tomes and gems based on the trinity setup? or do i need to add that to this file

fr0stebyte · Dec 15, 2012

i think it picksup gems based on trinity, potions.
If you change the legendary line it picksup and stashs all

fr0stebyte · Dec 15, 2012

Custom requests or bug fixes pm

Blabla1 · Dec 16, 2012

hey guys,

is darkfriends working with ru client or do i need other rules (i think i do)

fr0stebyte · Dec 16, 2012

it works with ru but only legendaries i think.
They have a custom legendary_ru.dis

Blabla1 · Dec 16, 2012

fr0stebyte said:
it works with ru but only legendaries i think.
They have a custom legendary_ru.dis

just looked for a legendary_ru, couldnt find it. i searched trinity download https://www.assembla.com/code/unifiedtrinity/git/nodes/Releases and dark https://subversion.assembla.com/svn/CustomTrinity/trunk/

Midas · Dec 16, 2012

fr0stebyte said:
All items can roll 63 affixes now, affix is based on monster level, a3 or mp all monsters are 63

You can only polish a turd so much. Level 61 weapons are still turds even with level 63 affixes. This is because damage mods either add to base damage or increased % of base damage and the base damage on level 61 is too low, so even with level 63 affixes they are still steaming piles of turd, just with some spit and polish

Have a peak on the AH to confirm

wynects · Dec 17, 2012

really no idea why my bot will sell my legendary although i just copy and paste the "rare" part in the pickup.dis, i never touch the other files
I'm using the latest version of giletrinity
sad when see this in my junk log

Offhand - Quiver 'Quiver'. Score = 37355 {legendary item}
Dexterity=197. Vitality=182. Sockets=1. Crit Chance %=9. Attack Speed %=14

sorry for my bad english

Tweaked pickup rule for darkfriend's loot plugin

Member

Member

New Member

Member

New Member

Member

New Member

Member

New Member

Member

New Member

Member

New Member

Member

Member

New Member

Member

New Member

New Member

New Member