Trinity 2.3.2 and QuestTools 3.1.14

[tonchori]

Idk if anyone has problems like this but after updating he finishes a rift, barely using sw and then he tp's to town and spams sw and just standing there.

 

[S o u L D u s T]

Quest tools Error?

[QuestTools][<UpgradeGemsTask>d__32] No valid gems found to upgrade! Leaving game...
Using town portal, reason: Unable to upgrade gem - leaving game

previously we were able to get DB to upgrade the gem based on the % chance of upgrading.......
my gems are in the 40's and at this rate. they'll never get bumped up.....

 

[rrrix]

Quest tools Error?

[QuestTools][<UpgradeGemsTask>d__32] No valid gems found to upgrade! Leaving game...
Using town portal, reason: Unable to upgrade gem - leaving game

previously we were able to get DB to upgrade the gem based on the % chance of upgrading.......
my gems are in the 40's and at this rate. they'll never get bumped up.....

This means you couldn't upgrade your gems, no matter what.

 

[jiznadj]

Will loot rules recognize ancient items now?

[QUALITY] == "Ancient"

 

[ilovediablo]

Attached!

As always, big thanks to xzjv and jubisman!!

Trinity Changelog 2.3.2

Added Monk WoL as primary (last resort, when no spirit generator is present)
Added TownRun UI Option to Enable/Disable of using "Pickup" validation when stashing items (Disable to revert to "how it used to be")
Added Pickup UI Option to disable picking up legendary follower items
Bot should no longer get stuck with max blood shards - needs testing
Bot should not longer sell Horadric Cache's
Added IsAncient to TrinityCacheObject and [ANCIENT] (int 0/1) to loot rules
Ancient items should now always be kept when using "ItemRanks" loot mode

Trinity Changelog 2.3.0
(I've removed a bit of the technical stuff, to shorten it):

Trinity will now check "pickup" settings when determining if an item should stashed or sold (if it's not supposed to be picked up, it won't be stashed and will be sold)
Added Stash and Backpack Item Sorting -- "Sort Stash" button can now be used anywhere - bot will return to town to sort the stash.
Item Pickup tab has been changed: Checkboxes have replaced Blue/Yellow pickup options for Weapons, Armor and Jewelry. Added Options for Trial Keys and Ramadalini's Gift


Phalanx should be cast more reliably now
Teleport: removed unnecessary time check and added special case for Time And Space rune
Fixed Legendary minimap markers causing the bot to get stuck because weighting was seeing it as a non-legendary item
Fixed monk recasting Mantras too quickly, draining Spirit
Added Legendary Potions Pickup Option
Added Items > Item Rank UI
Added ItemRank Settings class
Tweaks & fixes for new Item Sort
Manually merged tony's DH & WD Fixes:
Demonhunter and wd logic for healthglobes with certain passives
Fix demonhunter not casting any skills if RoV offCD On
Adding behaviour with RoV offCD and DarkCloud rune
Added Trinity tab to Demonbuddy Interface - includes buttons to sort stash, backpack, and reload item rules. More options to come.
Dashing Strike off CD for SWK should be working properly now
Dashing Strike should now be cast off cooldown when SWK is detected
Added option to cast Epiphany off cooldown
SWK Sweeping Wind now has a special logic and will only be cast when there's enemies in close range
Cleaned up Dashing Stike code a little
Dashing Strike will no longer be used to attack while trying to avoid
Removed unnecessary checks from Mantra logic
Added special logic for Mantra Of Salvation With Taeguk Gem - should now try to cast it OOC to keep the buff up
Removed unused internal static bool DoesNotHaveMonkMantraAbility()
Set default for HiPriorityHG as false
Moved Smoke Screen further up and Cluster Arrow further down
Fixed Breath of Heaven Being spammed
Added a little bit of exception handling to QuickDump to make it easier to find invalid items
Fix Raekor's Burden ID
Trinity now tells you which items it has invalid data for when dumping Build/Items
Added line of sight check to BestPierceTarget method, Fixed blackthorn amulet SNO
Gold/XP Inactivity timer is now reset on BotStart/BotStop events
Halved the time it takes to blacklist things when flip-flopping
Crusader: Increased usage of Heavens Fury when 'Fate of the Fell' is equipped
Fix for Innas set having wrong number of items required for set bonuses
Added option to cast Rain of Vengeance off CD
Removed Craft Tomes pickup option (item no longer exists)
Added missing Laws of Valor checkbox under Combat->Crusader
Improved WitchDoctor use of Harvest/Horrify and CombatMovement
Performance update for Hotbar Skills

QuestTools Changelog 3.1.14:

CompleteGreaterRiftTag will now leave the game if no valid upgradable gems are found
Fixed ChangeMonitor not logging when Log Level was not Verbose
ExploreDungeonTag will no longer error-out when doing a townrun
Added a small wait delay to MoveToActor when IsLoadingWorld and after Successfully interacting with a portal
MoveToObjectiveTag: Fixed exception where _objectiveObject had invalid ACD
Changed settings label to 'Disable Combat At Wave' instead of 'level'
Added DB version number to status bar

rrrrix Can u add back the gem upgrade chance back in the next patch in Questools?

the 1% upgrade option is vital to me, pls tks

 

[S o u L D u s T]

This means you couldn't upgrade your gems, no matter what.

thanks for your quick response rrrix.

the 1% chance is still a chance. if you would be so kind as to add back the option please?

 

[ilovediablo]

Attached!

As always, big thanks to xzjv and jubisman!!

Trinity Changelog 2.3.2

Added Monk WoL as primary (last resort, when no spirit generator is present)
Added TownRun UI Option to Enable/Disable of using "Pickup" validation when stashing items (Disable to revert to "how it used to be")
Added Pickup UI Option to disable picking up legendary follower items
Bot should no longer get stuck with max blood shards - needs testing
Bot should not longer sell Horadric Cache's
Added IsAncient to TrinityCacheObject and [ANCIENT] (int 0/1) to loot rules
Ancient items should now always be kept when using "ItemRanks" loot mode

Trinity Changelog 2.3.0
(I've removed a bit of the technical stuff, to shorten it):

Trinity will now check "pickup" settings when determining if an item should stashed or sold (if it's not supposed to be picked up, it won't be stashed and will be sold)
Added Stash and Backpack Item Sorting -- "Sort Stash" button can now be used anywhere - bot will return to town to sort the stash.
Item Pickup tab has been changed: Checkboxes have replaced Blue/Yellow pickup options for Weapons, Armor and Jewelry. Added Options for Trial Keys and Ramadalini's Gift


Phalanx should be cast more reliably now
Teleport: removed unnecessary time check and added special case for Time And Space rune
Fixed Legendary minimap markers causing the bot to get stuck because weighting was seeing it as a non-legendary item
Fixed monk recasting Mantras too quickly, draining Spirit
Added Legendary Potions Pickup Option
Added Items > Item Rank UI
Added ItemRank Settings class
Tweaks & fixes for new Item Sort
Manually merged tony's DH & WD Fixes:
Demonhunter and wd logic for healthglobes with certain passives
Fix demonhunter not casting any skills if RoV offCD On
Adding behaviour with RoV offCD and DarkCloud rune
Added Trinity tab to Demonbuddy Interface - includes buttons to sort stash, backpack, and reload item rules. More options to come.
Dashing Strike off CD for SWK should be working properly now
Dashing Strike should now be cast off cooldown when SWK is detected
Added option to cast Epiphany off cooldown
SWK Sweeping Wind now has a special logic and will only be cast when there's enemies in close range
Cleaned up Dashing Stike code a little
Dashing Strike will no longer be used to attack while trying to avoid
Removed unnecessary checks from Mantra logic
Added special logic for Mantra Of Salvation With Taeguk Gem - should now try to cast it OOC to keep the buff up
Removed unused internal static bool DoesNotHaveMonkMantraAbility()
Set default for HiPriorityHG as false
Moved Smoke Screen further up and Cluster Arrow further down
Fixed Breath of Heaven Being spammed
Added a little bit of exception handling to QuickDump to make it easier to find invalid items
Fix Raekor's Burden ID
Trinity now tells you which items it has invalid data for when dumping Build/Items
Added line of sight check to BestPierceTarget method, Fixed blackthorn amulet SNO
Gold/XP Inactivity timer is now reset on BotStart/BotStop events
Halved the time it takes to blacklist things when flip-flopping
Crusader: Increased usage of Heavens Fury when 'Fate of the Fell' is equipped
Fix for Innas set having wrong number of items required for set bonuses
Added option to cast Rain of Vengeance off CD
Removed Craft Tomes pickup option (item no longer exists)
Added missing Laws of Valor checkbox under Combat->Crusader
Improved WitchDoctor use of Harvest/Horrify and CombatMovement
Performance update for Hotbar Skills

QuestTools Changelog 3.1.14:

CompleteGreaterRiftTag will now leave the game if no valid upgradable gems are found
Fixed ChangeMonitor not logging when Log Level was not Verbose
ExploreDungeonTag will no longer error-out when doing a townrun
Added a small wait delay to MoveToActor when IsLoadingWorld and after Successfully interacting with a portal
MoveToObjectiveTag: Fixed exception where _objectiveObject had invalid ACD
Changed settings label to 'Disable Combat At Wave' instead of 'level'
Added DB version number to status bar

rrrrix Can u add back the gem upgrade chance back in the next patch in Questools?

the 1% upgrade option is vital to me,

because i always choose to upgrade the highest gem, but i just saw the bot tried upgrade one gem which is 0% chance , i suspect it is because 1% rules is missing..



pls tks

 

[unpack]

Thank rrrix Continuously updated and available for download

 

[Arotished]

What do you mean? Armory's spending bloodshards just fine here

Armory spends bloodshards good but when you come across a bloodshard goblin (or whatever it is) you recessive to many bloodshard so that you usually fills up your 500 limit (even with only a minimum 50 bloodshard spending limit in armory). If you reach your 500 bloodshard limit and there is more bloodshard on the ground, the bot tries to pick it up until the inactive timer kicks in instead of teleporting to town and spend the 500 bloodhard before coming back and picking the remaining up.

 

[Xenetron]

[2.1.2] G45+ The Strongest Monk Build (Quin69) - Monk - Diablo III Builds - Diablo Fans

Monk doesn't use Wave of Light properly and sometimes spams SW using the above build Rrrix.

If anyone can take a look, it still runs OK, just every now and then spams the shit out of SW for no reason

 

[howmakewood]

[2.1.2] G45+ The Strongest Monk Build (Quin69) - Monk - Diablo III Builds - Diablo Fans

Monk doesn't use Wave of Light properly and sometimes spams SW using the above build Rrrix.

If anyone can take a look, it still runs OK, just every now and then spams the shit out of SW for no reason

remove the sunwuko set spam sweeping winds part from monkcombat.cs
this to be precise:

 // Sunwuko set Sweeping Winds spirit dumping
            if (!UseOOCBuff && TargetUtil.AnyMobsInRange(10f) && Player.PrimaryResource > 100 &&
                CanCast(SNOPower.Monk_SweepingWind, CanCastFlags.NoTimer) && hasSWK)
            {
                Trinity.SweepWindSpam = DateTime.UtcNow;
                return new TrinityPower(SNOPower.Monk_SweepingWind);
            }

and if it stops using sweeping after that remove "&& !hasSWK" from

// Sweeping wind
            if (!UseOOCBuff && CanCast(SNOPower.Monk_SweepingWind) && !GetHasBuff(SNOPower.Monk_SweepingWind) && !hasSWK &&
                ((TargetUtil.AnyElitesInRange(25, 1) || TargetUtil.AnyMobsInRange(20, 1) || hasInnaSet ||
                (CurrentTarget.IsBossOrEliteRareUnique && CurrentTarget.RadiusDistance <= 25f)) &&
                // Check our mantras, if we have them, they are up first
                (Monk_HasMantraAbilityAndBuff() &&
                // Check if either we don't have blinding flash, or we do and it's been cast in the last 8000ms
                (Trinity.TimeSinceUse(SNOPower.Monk_BlindingFlash) <= 8000 || CheckAbilityAndBuff(SNOPower.Monk_BlindingFlash) ||
                TargetUtil.AnyElitesInRange(25, 1) && Trinity.TimeSinceUse(SNOPower.Monk_BlindingFlash) <= 12500))) &&
                Player.PrimaryResource >= minSweepingWindSpirit)

 

[Necro19]

Hey there, iv'e noticed when Running Main+3 Followers in Rift and they are close to 100% , and my toons still hunting Mobs behind my Main... The Leader runs out of sight and going to the next level instead of running back to the Riftguardian that appeared already in level 1.

 

[iPanda]

how do i make the bot to keep only ancient items using the itemranks?

 

[akak21c]

My bot do no pick-up Arcane Dust but I checked 'Caft Materials' in Misc Pcikup Options.
And bot sell all Arcane Dust when he got the Arcane Dust after salvage Magic Items in
town run.

 

[reocba20]

referring to shards, still leaving the ground, but it does not gets bug

 

[rrrix]

thanks for your quick response rrrix.

the 1% chance is still a chance. if you would be so kind as to add back the option please?

I remove it, because that's now the default

Basically it works like this:

IF You have "upgrade keystones" it will attempt to upgrade the keystone first. If you can't upgrade a keystone, it will check to see if you can upgrade a gem. If you can't upgrade either a gem or a keystone it will leave the game.

IF you have "upgrade gems" it will just attempt to upgrade gems - based on the priority you selected, and if that is unavailable, then based on if you have any gems at all to upgrade. If you still can't upgrade any gems, it will leave the game.

It leaves the game to avoid getting perma-stuck when your gems are higher than the rift level.

Here's the function that calculates the chance. I could have been wrong in this, but I just know I kept getting stuck when my all my gems were of a higher rank than my rift level.

        public static Func<ACDItem, float> GetUpgradeChance = gem =>
        {
            var lootRunLevel = ZetaDia.Actors.Me.InTieredLootRunLevel;
            var delta = lootRunLevel - gem.JewelRank;


            if (delta >= 10) return 1f;
            if (delta <= -15) return 0f; //Diablo3 disables upgrades for -15 levels difference
[COLOR=#ff0000]            if (gem.JewelRank >= 25 && delta < 0) // Gems over 25 cannot be upgraded if the gem level is less than the rift level[/COLOR]
[COLOR=#ff0000]                return 0f;[/COLOR]


            switch (delta)
            {
                case 9: return 0.9f;
                case 8: return 0.8f;
                case 7: return 0.7f;
                case 6: return 0.6f;
                case 5: return 0.6f;
                case 4: return 0.6f;
                case 3: return 0.6f;
                case 2: return 0.6f;
                case 1: return 0.6f;
                case 0: return 0.6f;
                case -1: return 0.3f;
                case -2: return 0.15f;
                case -3: return 0.08f;
                case -4: return 0.04f;
                case -5: return 0.02f;
                default: return 0.01f;
            }
        };

 

[pimpampum]

Just did 32 rift in a char with 40 leg gems. Instead of trying to upgrade (delta was -8 right? so it should try to upgrade if I understood correctly) it simply townportalled and left game. Intended?

I've been upgrading gems of higher level than the rift's level with no issue before the patch, did something change?

 

[rrrix]

Are you sure of this? At least until this patch, I've been upgrading level 38+ gems with no problem in 30+ rifts. Maybe something was changed in this patch?

Also, just did 32 rift in a char with 40 leg gems. Instead of trying to upgrade (delta was -8 right? so it should try to upgrade if I understood correctly) it simply townportalled and left game. Intended?

I just know i was getting stuck on level 30 rifts with > level 30 gems. Yes, leaving the game is indented (because, the questStep won't change unless you upgrade a gem).

Try this file, and let me know if you can still continue. Place this attachment into your QuestTools\ProfileTags directory, make sure you OVERWRITE the existing "CompleteGreaterRiftTag.cs".

If you don't REPLACE the file, but add it somewhere else, your DB will break and start throwing errors.

 

[pimpampum]

Try this file, and let me know if you can still continue.

So far, about 2 grifts completed in each of 10 diferent DB installations, not a single stuck. Working perfectly here. Thank you!

(lvl 25 to 33 rifts, all gems above rift level by a good measure)

Requests for next trinities:

1) Slider for casting black hole when X enemies (similar to crusader's gazillion abilities sliders.At the moment it is only used in elite , no in big packs as I would like)
2) Slider for wizard kiting activating on X %life. Ignoring kite distance if not below that threshold. For low grifts and bounties farming!
3) Give higher priority to shrines should be activated by default. Just saw a bot ignore a conduit pylon all the while fighting the RG, only to get the pylon once the fight was over.
4) Anyway to give higher priority to nephalem globes (yellow balls?) Can't figure out how, unless it requires giving higher priority to life balls too.

 

[rrrix]

So far, about 2 grifts completed in each of 10 diferent DB installations, not a single stuck. Working perfectly here. Thank you!

(lvl 25 to 33 rifts, all gems above rift level by a good measure)

Requests for next trinities:

1) Slider for casting black hole when X enemies (similar to crusader's gazillion abilities sliders.At the moment it is only used in elite , no in big packs as I would like)
2) Slider for wizard kiting activating on X %life. Ignoring kite distance if not below that threshold. For low grifts and bounties farming!
3) Give higher priority to shrines should be activated by default. Just saw a bot ignore a conduit pylon all the while fighting the RG, only to get the pylon once the fight was over.
4) Anyway to give higher priority to nephalem globes (yellow balls?) Can't figure out how, unless it requires giving higher priority to life balls too.

Good ideas, thanks pimpampum.