Singular - A community driven All-In-One CC - It Just Plain Works - (Pt. 2)

[Clu]

As soon as you come up with a list of all spell IDs in the game that are not interruptable (or an exclusive list that are interruptable) this is not feasable. We could add an option in the setting to disable interrupts completely, but that's about it at this point.

might be a pointless comment, but wow provides an api (it's lua though) to detect if a spell is interruptable

UnitCastingInfo - World of Warcraft Programming: A Guide and Reference for Creating WoW Addons

styx may provide something similar aswell

 

[Crowley]

As soon as you come up with a list of all spell IDs in the game that are not interruptable (or an exclusive list that are interruptable) this is not feasable. We could add an option in the setting to disable interrupts completely, but that's about it at this point.

Could do it like Ultimate Pala does for debuffs. Have boxes you can type in what spells NOT to interrupt instead though.

 

[DarkTemplar24]

Would just like to state that the Shadowpriest portion of this thing is freaking amazing. It never dies, even when it aggros 4-5 mobs that are the same level.

 

[Apoc]

Helpers.Common.CreateInterruptSpellCast(ret=>StyxWoW.Me.CurrentTarget),

Use that instead of your custom interrupt. It will deal with only interrupting... interruptable spells.

 

[eracer]

For hunters can you add an option to not call or revive a pet, maybe by setting the pet slot to 0, or adding an enable/disable option? I'm using rarekiller to tame loque'nahak and i don't want the cc to call a pet when I'm trying to tame.

Thank you for the great CC

 

[eracer]

I think I figured out how to add the "Use Pet" option on my own. I only did limited testing using beastmaster spec. I added a "Use Pet" option under the class specific settings. This should also dismiss any existing pet if you have it set to false. Please let me know if i screwed something up, this is my first time contributing to this CC.

 

[Crowley]

Anyway to get Druids to use Travelform?

Travel Form - Spell - World of Warcraft

I put 783 in the ground mount in settings and ticked use mount.
Also tried it without those settings ofc. No log since i didn't know if it was coded in yet or what or if i just haven't set shit up right. Can give one if needed.

Latest HB and svn...as of 10 minutes ago anyways.

 

[Saif]

Apoc,

In the SVN it is saying revision 493 but when you load singular it is still just Revision 480. Just wanted to let you know.

Saif

 

[zeldrak]

Hey Apoc, just curious about the other two rogue specs. I'm currently finishing a rogue to 85 in combat, but once I'm there I'd like to try out the other two specs, and I see that Singular doesn't support, or fully support, them just yet. All I can really do is link you to EJ, manaflask.com, or max dps for rotations as I haven't figured a solid one out yet, if that would help. I just finished running with an 85 Assassination spec rogue that was pulling over 15k dps in reg/heroic gear since he was still gearing out his rogue. that's all, was just curious.

 

[Noelbuddy]

1st I want to thank Apoc and all the people helping him for this great cc.I tired on my protection and i love it.I like the charge part of it the only down thing about it when i tried to run from the boss and it charged back to it ><.
2nd if u select the other tank as a tank in lazybot does cc taunt from him or her when taunt is turn on?
3rd I notice that this cc doing use holy shield on the rotation as protection paladin

 

[Noelbuddy]

1st I want to thank Apoc and all the people helping him for this great cc.I tired on my protection and i love it.I like the charge part of it the only down thing about it when i tried to run from the boss and it charged back to it ><.
2nd if u select the other tank as a tank in lazybot does cc taunt from him or her when taunt is turn on?
3rd I notice that this cc doing use holy shield on the rotation as protection paladin

 

[raphus]

Big commit inc.

Changelog:

Druid lowbie behaviors have been improved.
Mage lowbie behaviors have been improved.
Mage CreateMagePolymorphOnAddBehavior has been improved.
Mage CreateStayAwayFromFrozenTargetsBehavior has been added.
Spell.Heal composites have been added.
All healing classes are now using Spell.Heal for healing spells which increases the effectiveness of heals and mana management significantly
Spell.Resurrect composite has been added.
All healing classes are now using Spell.Resurrect for resurrection purposes.
Spell.PreventDoubleCast composites have been added.
Priest and Warlock classes are using Spell.PreventDoubleCast to avoid double casting spells like Immolate, Devouring Plague etc.
Unit.HasAura/HasMyAura should be working properly now.
Safers.EnsureTarget composite has been improved.

 

[benkoren]

@Apoc / @Raphus: Here's the most effective way for a Frost DK to use Blood Tap (rather than just on blind cooldown):

Bump for the Blood Tap update for the Frost DK (not blood):

Spell.Cast("Blood Tap", ret => StyxWoW.Me.UnholyRuneCount >= 1 && StyxWoW.Me.FrostRuneCount == 0 && StyxWoW.Me.DeathRuneCount == 0 && StyxWoW.Me.CurrentTarget.Distance <= 10),​

 

[benkoren]

Big commit inc.

Changelog:

Druid lowbie behaviors have been improved.
Mage lowbie behaviors have been improved.
Mage CreateMagePolymorphOnAddBehavior has been improved.
Mage CreateStayAwayFromFrozenTargetsBehavior has been added.
Spell.Heal composites have been added.
All healing classes are now using Spell.Heal for healing spells which increases the effectiveness of heals and mana management significantly
Spell.Resurrect composite has been added.
All healing classes are now using Spell.Resurrect for resurrection purposes.
Spell.PreventDoubleCast composites have been added.
Priest and Warlock classes are using Spell.PreventDoubleCast to avoid double casting spells like Immolate, Devouring Plague etc.
Unit.HasAura/HasMyAura should be working properly now.
Safers.EnsureTarget composite has been improved.

HasMyAura still does not appear to be working. I'm testing on a test dummy (with nobody else on it, of course) with the attached code. The difference between the attached and what's in the trunk is the following line:

Spell.Cast("Serpent Sting", ret => !StyxWoW.Me.CurrentTarget.HasMyAura("Serpent Sting")),

HasMyAura in the above call always returns false, resulting in a spam of Serpent Sting. Full ClassSpecific code and HB log is attached.

- Ben

 

[raphus]

Bump for the Blood Tap update for the Frost DK (not blood):

added.

HasMyAura still does not appear to be working. I'm testing on a test dummy (with nobody else on it, of course) with the attached code. The difference between the attached and what's in the trunk is the following line:

Spell.Cast("Serpent Sting", ret => !StyxWoW.Me.CurrentTarget.HasMyAura("Serpent Sting")),

HasMyAura in the above call always returns false, resulting in a spam of Serpent Sting. Full ClassSpecific code and HB log is attached.

- Ben

Update. It should work properly now

 

[benkoren]

added.



Update. It should work properly now

HasMyAura is working PERFECTLY now. Thank you very much.

One fairly significant issue I'm having with HB in general is its perception of range from the max edge of the hit box. For example, on the final Death Wing fight, take a look at how close the character has to be before the bot even attempts to fire an ability (see screenshot). Is there any way you could disable the distance checks for us when movement is disabled?

 

[tazmo]

Here's my feedback as a leveling warlock currently Demonology ~ 30

The addon is great overall has alot of potential, things id like to see include

• Finer class spell control
• Finer general char control (rest % etc)

Here's the Character problems i have been facing as a warlock lvl 31

• Im Getting Adds and then just hell firing myself to death
• i dont let myself heal up enough - run around with 30 % health
• Keeps casting [1:25:03 AM:378] [Singular-DEBUG] Successfully cast Soul Harvest basically every time cool down is up, even while mounted and traveling between WP
• When killing groups doesn't seem to be looting all bodies

 

[vitalic]

something is weird about this latest revision, my character keeps standing around doing nothing since i updated, i see things like this:

[Singular] Target is invalid. Switching to Myself!
[Singular] Casting Avenger's Shield on Myself

any ideas? log attached

 

[benkoren]

Attached is the Frost DK code updated to use the now-working HasMyAura. Tested in both solo and heroic raid play.

- Ben

 

[benkoren]

Somehow the Outbreak correction for Frost DKs got wiped out of your trunk. I think you guys may be getting your working versions mixed up, this has happened a couple times. This is what Outbreak should be:

Spell.Cast("Outbreak", ret => !StyxWoW.Me.CurrentTarget.HasMyAura("Frost Fever") || !StyxWoW.Me.CurrentTarget.HasMyAura("Blood Plague")),

I've also updated Outbreak in the attachment of the post above this one.

- Ben