Singular - A community driven All-In-One CC - It Just Plain Works - (Pt. 2)

Jon310 · Oct 24, 2011

Croga said:
Same problem as before with the Warrior: At some point he just refuses to move, throwing the same error over and over.

Comment out line 191 for now. Ill see if something has changed that's causing this to fail. Search Heroic Fury if your using a simple text editor.

I commented it out on the svn, I'll have to see if I can get that working again. I've already tried a few things that didn't work. Hopefully I can get heroic fury working again.

xsilverdicex · Oct 25, 2011

Does the dk one Detect dungeon or raid, and disbale Death grip (taunt)?? i cant see an option to turn it off manually

Croga · Oct 25, 2011

Jon310 said:
Comment out line 191 for now. Ill see if something has changed that's causing this to fail. Search Heroic Fury if your using a simple text editor.
I commented it out on the svn, I'll have to see if I can get that working again. I've already tried a few things that didn't work. Hopefully I can get heroic fury working again.

Now it stops using abilities after a while. Just autoattacks, nothing else. With about the same errors only on a different line.

Can't upload the log as it's over 1MB and the forum doesn't allow .rar files.

Jon310 · Oct 25, 2011

Croga said:
Now it stops using abilities after a while. Just autoattacks, nothing else. With about the same errors only on a different line.

Can't upload the log as it's over 1MB and the forum doesn't allow .rar files.

You were also getting an error from spell.cs line 267, are you still getting the same error with spell.cs? If so it might be something for apoc to look into.

Croga · Oct 26, 2011

Jon,

The message is:

Code:

[13:50:34:696] System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.
   at System.ThrowHelper.ThrowKeyNotFoundException()
   at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
   at Singular.ClassSpecific.Warrior.Fury.<CreateFuryCombat>b__15(Object ret) in e:\HB\HB 5387 Croga\CustomClasses\Singular 2\ClassSpecific\Warrior\Fury.cs:line 128
   at Singular.Helpers.Spell.<>c__DisplayClass27.<Cast>b__25(Object ret) in e:\HB\HB 5387 Croga\CustomClasses\Singular 2\Helpers\Spell.cs:line 267
   at TreeSharp.Decorator.CanRun(Object context)
   at TreeSharp.Decorator.#h.#nF.MoveNext()
   at (Object )
   at TreeSharp.Composite.Tick(Object context)
   at TreeSharp.PrioritySelector.#h.#nF.MoveNext()
   at (Object )
   at TreeSharp.Composite.Tick(Object context)
   at TreeSharp.PrioritySelector.#h.#nF.MoveNext()
   at (Object )
   at TreeSharp.Composite.Tick(Object context)
   at TreeSharp.PrioritySelector.#h.#nF.MoveNext()
   at (Object )
   at TreeSharp.Composite.Tick(Object context)
   at TreeSharp.PrioritySelector.#h.#nF.MoveNext()
   at (Object )
   at TreeSharp.Composite.Tick(Object context)
   at TreeSharp.Decorator.#h.#nF.MoveNext()
   at (Object )
   at TreeSharp.Composite.Tick(Object context)
   at TreeSharp.PrioritySelector.#h.#nF.MoveNext()
   at (Object )
   at TreeSharp.Composite.Tick(Object context)
   at TreeSharp.PrioritySelector.#h.#nF.MoveNext()
   at (Object )
   at TreeSharp.Composite.Tick(Object context)
   at TreeSharp.PrioritySelector.#h.#nF.MoveNext()
   at (Object )
   at TreeSharp.Composite.Tick(Object context)

My apologies for not posting this yesterday. My frustration got the better of me

Phoenix_x1337 · Oct 26, 2011

Are affliction warlocks implemented yet for PvP?

Jon310 · Oct 26, 2011

Croga said:
Jon,

The message is:
CODE REMOVED

My apologies for not posting this yesterday. My frustration got the better of me

Have you tried updating to 5418? Cleave, along with the same spell.cs line, is what the error is hitting on now, but cleave is working fine for me.

If you haven't updated to 5418 give that a try and let me know if your still getting the same error.

Croga · Oct 27, 2011

Jon310 said:
Have you tried updating to 5418? Cleave, along with the same spell.cs line, is what the error is hitting on now, but cleave is working fine for me.
If you haven't updated to 5418 give that a try and let me know if your still getting the same error.

lol.... Cleave was the issue the last time around as well..... before some older fix some time ago.

I'm not going to update to 5418 anytime soon. The warrior, nor this CC, is important enough for me to risk instability with other parts of the bot. Seeing as this is the only class I have issues with, I'll just drop the warrior until there's nothing else left to do.

Croga · Oct 27, 2011

Paladin does nothing but Exorcism.
Even after editing the "retribution.cs" to only include:

Code:

Spell.Cast("Exorcism", ret => StyxWoW.Me.HasAura("The Art of War")),

, removing all other references to Exorcism, it will still only cast Exorcism.

spifkie · Oct 27, 2011

Recently started a Human Arms Warrior, but it seems to error a lot. Log is attached.
The error is actually so severe that I can't even use the Arms spec anymore. It just keeps running from the mob until I die, for the time being I switched to Fury.

I know it say revision 423 but developers just forget to update that number as I am using revision 425.

Jon310 · Oct 27, 2011

spifkie said:
Recently started a Human Arms Warrior, but it seems to error a lot. Log is attached.
The error is actually so severe that I can't even use the Arms spec anymore. It just keeps running from the mob until I die, for the time being I switched to Fury.

I know it say revision 423 but developers just forget to update that number as I am using revision 425.

Grr. same spell.cs error, different spells in the fury.cs, and arms.cs. I'll see if I can make them low level compatible again. Didn't see that you guys were not lvl 85 and that's why I couldn't reproduce the error. I'll do some work with some low level warriors that I worked on singular v1 with. See if I can get this error free for you guys.

Apoc · Oct 27, 2011

Jon310 said:
Grr. same spell.cs error, different spells in the fury.cs, and arms.cs. I'll see if I can make them low level compatible again. Didn't see that you guys were not lvl 85 and that's why I couldn't reproduce the error. I'll do some work with some low level warriors that I worked on singular v1 with. See if I can get this error free for you guys.

Check the main Spell.Cast func. I added some stuff there a bit ago to deal with Spell.Cast via spells with no range, and "self only" casts. (Think Starfall, frost nova, etc)

That may be whats causing the issue.

Also I fixed Spell.CastOnGround. 100% positive it works now, since its been charge->leaping on my war constantly. (Haven't bothered to figure out how to fix it just yet)

Jon310 · Oct 27, 2011

Apoc said:
Check the main Spell.Cast func. I added some stuff there a bit ago to deal with Spell.Cast via spells with no range, and "self only" casts. (Think Starfall, frost nova, etc)

That may be whats causing the issue.

Also I fixed Spell.CastOnGround. 100% positive it works now, since its been charge->leaping on my war constantly. (Haven't bothered to figure out how to fix it just yet)

I tried using Spell.Cast("Cleave", false, ret => StyxWoW.Me.CurrentTarget, ret => StyxWoW.Me.HasAura("Incite")....
so spell , movement check, onUnit, requirements

Still giving the same error.

And another strange thing, I cant get this to error out on my lvl 85 regardless of setting. Lower levels, I get the exact errors others are reporting. I got the cc error free on low levels by making those sections only apply to lvl 85's, but that seems kind of a rough fix.

Apoc · Oct 28, 2011

Jon310 said:
I tried using Spell.Cast("Cleave", false, ret => StyxWoW.Me.CurrentTarget, ret => StyxWoW.Me.HasAura("Incite")....
so spell , movement check, onUnit, requirements

Still giving the same error.

And another strange thing, I cant get this to error out on my lvl 85 regardless of setting. Lower levels, I get the exact errors others are reporting. I got the cc error free on low levels by making those sections only apply to lvl 85's, but that seems kind of a rough fix.

Looks like the issue is with you not checking if the toon even knows CS.

Code:

                Spell.Cast(
                    "Cleave", ret =>
                              // Only even think about Cleave for more than 2 mobs. (We're probably best off using melee range)
                              Clusters.GetClusterCount(StyxWoW.Me, Unit.NearbyUnfriendlyUnits, ClusterType.Cone, 6f) >= 2 &&
                              // If we have Incite, Deadly Calm, or enough rage (pooling for CS if viable) we're good.
                              (StyxWoW.Me.HasAura("Incite", 1) ||
                               CanUseCleave() ||
                               StyxWoW.Me.ActiveAuras.ContainsKey("Deadly Calm"))),

And

Code:

        static bool CanUseCleave()
        {
            // Pooling rage for upcoming CS. If its > 8s, make sure we have 60 rage. < 8s, only pop it at 85 rage.
            if (SpellManager.HasSpell("Colossus Smash"))
                return SpellManager.Spells["Colossus Smash"].CooldownTimeLeft().TotalSeconds > 8 ? StyxWoW.Me.RagePercent > 60 : StyxWoW.Me.RagePercent > 85;

            // We don't know CS. So just check if we have 60 rage to use cleave.
            return StyxWoW.Me.RagePercent > 60;
        }

You're doing a lot of "slow" things by re-checking the same stuff over and over. Check how I simplified it.

Apoc · Oct 28, 2011

spifkie said:
Recently started a Human Arms Warrior, but it seems to error a lot. Log is attached.
The error is actually so severe that I can't even use the Arms spec anymore. It just keeps running from the mob until I die, for the time being I switched to Fury.

I know it say revision 423 but developers just forget to update that number as I am using revision 425.

The number is auto-generated when you checkout/update a file. (Its the current revision number of the file.)

SingularRoutine.cs rarely gets touched, so you likely don't see it updating often.

Jon310 · Oct 28, 2011

Apoc said:
Looks like the issue is with you not checking if the toon even knows CS.

Code:

snip

And

Code:

snip

You're doing a lot of "slow" things by re-checking the same stuff over and over. Check how I simplified it.

Didn't even think about having to check colossus smash when checking the cooldown. I'm going to have to check whether I have the spells in the few places that I do look for cooldowns. And holy hell that code looks better.

Both fury and arms should work for all levels now. Thanks for the help Apoc.

Croga · Oct 31, 2011

Croga said:
Paladin does nothing but Exorcism.
Even after editing the "retribution.cs" to only include:

Code:

Spell.Cast("Exorcism", ret => StyxWoW.Me.HasAura("The Art of War")),

, removing all other references to Exorcism, it will still only cast Exorcism.

No news on this issue? As far as I can see this is affecting all Paladin CCs, resulting in basically no viable Ret CC. Either the paladin never casts Exorcism, reducing his DPS to errrrr..... Holy levels, or it continuously casts it, reducing his mana to 0.

Laricia · Oct 31, 2011

What Class are you?: Druid
What Spec are you?: Feral/Bear
What 'context' is the bot in? (Instance, BG, Normal): CombatBot
What level are you?: 25
What revision of Singular are you using?: last SVN Version, Check every Day
Have you made any modifications to Singular?: No
Are you using a branched build, or the trunk build? (Only viable for developers):
What version of Honorbuddy are you using?: last HB

hello,

I have no log, because it's not really a fault there that can record the log!
I love the warrior tank version of the singular and so I wanted to play a bear.
Unfortunately, not only runs the cc as a bear, but only as a cat. why?
hope you can help me.

lg

Apoc · Oct 31, 2011

Laricia said:
What Class are you?: Druid
What Spec are you?: Feral/Bear
What 'context' is the bot in? (Instance, BG, Normal): CombatBot
What level are you?: 25
What revision of Singular are you using?: last SVN Version, Check every Day
Have you made any modifications to Singular?: No
Are you using a branched build, or the trunk build? (Only viable for developers):
What version of Honorbuddy are you using?: last HB

hello,

I have no log, because it's not really a fault there that can record the log!
I love the warrior tank version of the singular and so I wanted to play a bear.
Unfortunately, not only runs the cc as a bear, but only as a cat. why?
hope you can help me.

lg

Its likely your spec causing the issue. (We assume you're a bear if you take the Thick Hide talent (what bear wouldn't take it?))

Apoc · Nov 1, 2011

Fairly big commit.

Moved the taunt toggle to the general Singular settings. You can now globally turn on/off taunt for any tank spec from the main tab in the UI.

Ferals now have a bunch of options, including form overrides (for bears who raid, and may be better switching to cat form while another tank has the boss, to get a bit more DPS

). This is UNTESTED. I will be testing it soon, so if it does not work, please revert to before the change was made.

Also, you can now specify health %s for SI, FR, and Barkskin.

Oh... and druids learned how to charge again.

Singular - A community driven All-In-One CC - It Just Plain Works - (Pt. 2)

Member

New Member

Well-Known Member

Member

Well-Known Member

New Member

Member

Well-Known Member

Well-Known Member

Member

Attachments

Member

Well-Known Member

Member

Well-Known Member

Well-Known Member

Member

Well-Known Member

New Member

Well-Known Member

Well-Known Member