Simcraft Implemented, a Raidbot Derivate with Integrated Combat

[PriorityCR]

whats is the command that I add to use tranquilize shot every time the boss is with Savage Howl as buff?

 

[Trashbin]

Here you go, I add the line for you..

View attachment 170604

Your custom upped my DPS from 27k to 31.5 in survival specc, awesome job!
Do you have a custom for BM aswell perhaps? Ty

 

[captainsubtext]

Is there some exception in the hb log ?

"New APL" just means he found valid simc file in the folder.

Behaviors Created ! means that it actually loaded the profile

You missed collosus smash in your ability list. and i cant get scabbard trinket to work.

 

[Kane49_2]

You missed collosus smash in your ability list. and i cant get scabbard trinket to work.

Nah its in there, you however can not yet use the "buff.colossus_smash" expressions, debuff.colossus_smash and using it is in though.

For trinkets:

trinket1=scabbard_of_kyanos,id=118882
trinket2=tectus_beating_heart,id=113645,bonus_id=567

in combination with

actions+=/use_item,name=scabbard_of_kyanos,if=cooldowns_enabled&((active_enemies>1|!raid_event.adds.exists)&((talent.bladestorm.enabled&cooldown.bladestorm.remains=0)|buff.avatar.up|buff.bloodbath.up|target.time_to_die<25))

Does work, i should probably add support for use_item,slot though

 

[PriorityCR]

Nah its in there, you however can not yet use the "buff.colossus_smash" expressions, debuff.colossus_smash and using it is in though.

For trinkets:

trinket1=scabbard_of_kyanos,id=118882
trinket2=tectus_beating_heart,id=113645,bonus_id=567

in combination with

actions+=/use_item,name=scabbard_of_kyanos,if=cooldowns_enabled&((active_enemies>1|!raid_event.adds.exists)&((talent.bladestorm.enabled&cooldown.bladestorm.remains=0)|buff.avatar.up|buff.bloodbath.up|target.time_to_die<25))

Does work, i should probably add support for use_item,slot though

hats is the command that I add to use tranquilize shot every time the boss is with Savage Howl as buff?

 

[shineey]

Yo, try the new Version !
Shadow Orb is simply returning the number of shadow orbs, is it supposed to do something else ?

Shadow_orb is working as intended now! thanks! Although I'm experiencing another problem that I had forgotten about. I noticed it on my Shadow Priest that it was not casting Mind Blast at all. But after I removed "cooldown_react" from the mind blast conditions in the copy/pasted simulationcraft simc file, it seemed to work fine. Idk if that's an issue with simcraft or the code on your end.

 

[Kane49_2]

Shadow_orb is working as intended now! thanks! Although I'm experiencing another problem that I had forgotten about. I noticed it on my Shadow Priest that it was not casting Mind Blast at all. But after I removed "cooldown_react" from the mind blast conditions in the copy/pasted simulationcraft simc file, it seemed to work fine. Idk if that's an issue with simcraft or the code on your end.

Cooldown react is only true when the cooldown gets reset by something, i will check if theres a combat log event for that but its not working for now.

 

[Kane49_2]

Actually a few of the apis used in shadow priest profiles (default ones) are only working partly or not at all.
I wouldnt trust shadowy_apparitions_in_flight / miss_react and cooldown_react

 

[shineey]

Actually a few of the apis used in shadow priest profiles (default ones) are only working partly or not at all.
I wouldnt trust shadowy_apparitions_in_flight / miss_react and cooldown_react

Is cooldowns_enabled a global variable? It works correctly when I put "&cooldowns_enabled" after my CDs for my ret pally, but on my Spriest, it casts shadowfiend despite having "&cooldowns_enabled" after every instance of casting shadowfiend or mindbender.

 

[jowneh]

how does this work im so confused lol, but everyone seems to be understanding what to do?

 

[shineey]

how does this work im so confused lol, but everyone seems to be understanding what to do?

1. go to the github page
2. click on "Download ZIP" (or if you use svn, you can get the svn url right above)
3. extract ZIP (or create svn repo) in ../Honorbuddy/Bots/SimulationCraft
4. Download "Profiles.zip" from page 1
5. Create folder named "Simulation Profiles" in ../Honorbuddy/
6. Start Honorbuddy
7. Select "Simcraft Impl" from dropdown at top of HB
8. Hit Start
9. Select correct spec from popup
10. enjoy

 

[pr0blem]

The Balance Druid profile is completely backwards, casting wrath instead of starfire and vice-versa. It also spam casts Starsurge instead of using them 1 at a time to empower the next wrath and starfire casts.

I could see this working for any class that has a 100% smash your face on the keyboard rotation where procs don't matter.

 

[shineey]

The Balance Druid profile is completely backwards, casting wrath instead of starfire and vice-versa. It also spam casts Starsurge instead of using them 1 at a time to empower the next wrath and starfire casts.

I could see this working for any class that has a 100% smash your face on the keyboard rotation where procs don't matter.

As Kane92 said on the previous page, miss_react and cooldown_react arent completely implemented yet it seems like, so some of the spells used on a proc arent working for some casters it seems like. With this last update, my Shadow Priest rotation seemed to start working correctly after I removed miss_react and cooldown_react from the simc file, but my Demo Lock's rotation is still completely fucked for some reason. My lock just spams corruption.

It looks like some of the more class-specific conditionals need to be implemented in order for some classes to function properly.

 

[shineey]

SPriest works well, but I'm getting this error in the HB console:

We couldnt find Shadow Word: Pain by Id but there is an Aura with its name: 589 / 589
<01:09>:Õ mind_flay System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.
   at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
   at Simcraft.TwoKeyedDictionary`3.get_Item(KT i) in e:\Program Files (x86)\Honorbuddy\Bots\simpl\trunk\Database.cs:line 231
   at Simcraft.SimcraftImpl.GetAllSpells(String token) in e:\Program Files (x86)\Honorbuddy\Bots\simpl\trunk\SimcraftTop.cs:line 495
   at Simcraft.SimcraftImpl.FindBuff(String token) in e:\Program Files (x86)\Honorbuddy\Bots\simpl\trunk\SimcraftTop.cs:line 592
   at Simcraft.SimcraftImpl.BuffProxy.NewInternal(String token) in e:\Program Files (x86)\Honorbuddy\Bots\simpl\trunk\SimcraftProxies.cs:line 610
   at Simcraft.SimcraftImpl.SpellBasedProxy.TryGetMember(GetMemberBinder binder, Object& result) in e:\Program Files (x86)\Honorbuddy\Bots\simpl\trunk\SimcraftProxies.cs:line 1466
   at CallSite.Target(Closure , CallSite , Object )
   at Simcraft.BPIEJFGJOK.<GeneratePriestShadowPvEBehavior>b__55f(Object _if)
   at Simcraft.SimcraftImpl.<>c__DisplayClass7b.<Cast>b__78(Object _ret) in e:\Program Files (x86)\Honorbuddy\Bots\simpl\trunk\SimcraftImpl.cs:line 729

as well as:

01:38>:Õ insanity System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.
   at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
   at Simcraft.TwoKeyedDictionary`3.get_Item(KT i) in e:\Program Files (x86)\Honorbuddy\Bots\simpl\trunk\Database.cs:line 231
   at Simcraft.SimcraftImpl.GetAllSpells(String token) in e:\Program Files (x86)\Honorbuddy\Bots\simpl\trunk\SimcraftTop.cs:line 495
   at Simcraft.SimcraftImpl.FindBuff(String token) in e:\Program Files (x86)\Honorbuddy\Bots\simpl\trunk\SimcraftTop.cs:line 592
   at Simcraft.SimcraftImpl.BuffProxy.NewInternal(String token) in e:\Program Files (x86)\Honorbuddy\Bots\simpl\trunk\SimcraftProxies.cs:line 610
   at Simcraft.SimcraftImpl.SpellBasedProxy.TryGetMember(GetMemberBinder binder, Object& result) in e:\Program Files (x86)\Honorbuddy\Bots\simpl\trunk\SimcraftProxies.cs:line 1466
   at CallSite.Target(Closure , CallSite , Object )
   at Simcraft.WDUDZZVPWY.<GeneratePriestShadowPvEBehavior>b__55b(Object _if)
   at Simcraft.SimcraftImpl.<>c__DisplayClass7b.<Cast>b__78(Object _ret) in e:\Program Files (x86)\Honorbuddy\Bots\simpl\trunk\SimcraftImpl.cs:line 729

 

[captainsubtext]

Nah its in there, you however can not yet use the "buff.colossus_smash" expressions, debuff.colossus_smash and using it is in though.

For trinkets:

trinket1=scabbard_of_kyanos,id=118882
trinket2=tectus_beating_heart,id=113645,bonus_id=567

in combination with

actions+=/use_item,name=scabbard_of_kyanos,if=cooldowns_enabled&((active_enemies>1|!raid_event.adds.exists)&((talent.bladestorm.enabled&cooldown.bladestorm.remains=0)|buff.avatar.up|buff.bloodbath.up|target.time_to_die<25))

Does work, i should probably add support for use_item,slot though

missed the trinket1 line in the .simc file. works perfect now thanks!
colossus smash is still not working!

 

[Kane49_2]

As Kane92 said on the previous page, miss_react and cooldown_react arent completely implemented yet it seems like, so some of the spells used on a proc arent working for some casters it seems like. With this last update, my Shadow Priest rotation seemed to start working correctly after I removed miss_react and cooldown_react from the simc file, but my Demo Lock's rotation is still completely fucked for some reason. My lock just spams corruption.

It looks like some of the more class-specific conditionals need to be implemented in order for some classes to function properly.

Most of it is me needing to fix things, unfortunately feedback on a few classes has been slow so i dont actually know whats wrong there ^^

The two errors are that it can't find the buffs mind_flay and insanity, are these actually buffs ? did you mean something else in that line or does simcraft provide a mindflay buff that does something special ?

 

[Kane49_2]

The Balance Druid profile is completely backwards, casting wrath instead of starfire and vice-versa. It also spam casts Starsurge instead of using them 1 at a time to empower the next wrath and starfire casts.

As you can probably guess its not supposed to do that XD

Single target its supposed to starsurge when :
solar empowerment is down and eclipse energy > 20
or solar empowerment is down and eclipse energy <-40
or charges = 2 and the recharge time has below 6 seconds or it simply has 3 charges

As i said, its tough for me to fix classes i dont understand myself (or that i dont have on 90+) but i will try to see what makes the balance druid mess up when i get back from home.

 

[Kane49_2]

Is cooldowns_enabled a global variable? It works correctly when I put "&cooldowns_enabled" after my CDs for my ret pally, but on my Spriest, it casts shadowfiend despite having "&cooldowns_enabled" after every instance of casting shadowfiend or mindbender.

The conditions are evaluated left to right, so you should always put cooldowns_enabled at the start of the condition or put the rest of the condition into brackets

 

[pr0blem]

As you can probably guess its not supposed to do that XD

Single target its supposed to starsurge when :
solar empowerment is down and eclipse energy > 20
or solar empowerment is down and eclipse energy <-40
or charges = 2 and the recharge time has below 6 seconds or it simply has 3 charges

As i said, its tough for me to fix classes i dont understand myself (or that i dont have on 90+) but i will try to see what makes the balance druid mess up when i get back from home.

Yeah I wasn't trying to offend or anything ;-P I hope you didn't take it that way.
I changed the starfire/wrath values to work better, the biggest problem with starsurge (other CC's do the same thing from time to time) is that the buff isn't instant and takes time to reach your target before it becomes active, so relying on the value solar/lunar empowerment to be true is often why it shoots all of your starsurges at once, the best way would be to have it send out starsurge, shoot its next starfire or 2 wrath and then search for whether it should be using another starsurge or if it should be prioritizing starfall depending on how many charges it has as it casts its last starfire/wrath. I currently use enyo+uggla's cc and I have it changed for me to cast starsurge manually.

It also tends to be better to only use starsurge when you are on the lunar side of things as empowered starfire does way more damage.
It also doesn't use Incarnation: Chosen Of Elune, and for some reason it doesn't like to cast moonfire all the time/keep it up.

I love the concept behind this, as simcraft is usually what people look to for guidance in their builds/rotations but unfortunately there are some downfalls (for now!?)

This is what I changed
actions.aoe+=/wrath,if=(eclipse_energy>=0&eclipse_change>cast_time)|(eclipse_energy>0&cast_time>eclipse_change)
actions.aoe+=/starfire,if=(eclipse_energy<=0&eclipse_change>cast_time)|(eclipse_energy<0&cast_time>eclipse_change)

 

[shineey]

The two errors are that it can't find the buffs mind_flay and insanity, are these actually buffs ? did you mean something else in that line or does simcraft provide a mindflay buff that does something special ?

The "Insanity" was being thrown originally, because Mind Flay changes to Insanity when you spend shadow orbs. When you spend the shadow orbs, you gain a buff "insanity" but you also cast insanity of mind flay (the icon and spell changes on the bar).

The mind_flay error occurred when I changed insanity to mind_flay in the simc file because I thought it would be the same as a ret pally where templar verdict changes to final verdict with the talent, but when I did that, my priest wouldnt even cast insanity so I changed it back.

The routine works correctly with insanity in the simc, but it spams the HB console with that error message for some reason. But as far as I can tell, there isnt a side effect to the effectiveness of the routine.

References for Insanity: the BUFF and the SPELL