I am posting this here, after having already posted it on the discord, for those of you not on the discord. Any help or wisdom would be appreciated.
I think I know how to fix 2 problems in the WoL builds, but I don't have the know how to make it work. I have been staring at the code for hours trying to figure out how to 'talk' to DB to no avail. So. Other than navigation, I only seem to find 2 problems with the bot that I believe can be solved with 1 fix. If it is stuck between mobs it doesn't always realize it needs to cast WoL, this mostly seems to happen in doorways. If it can't gain proper targetting (im assuming this is what is happening) on a mob, usually because they are located in doorways or on map edges, it does not cast WoL. In the code, using dashing strike is described as casting at (CurrentTarget.Position), however, WoL is described as (CurrentTarget). I assume by simply changing to current target position it should fix the problem, as it will often still dashing strike under the same conditions that are prohibiting it from using WoL.
So long story short, can someone find a way to make WoL accept (CurrentTarget.Position), as when I simply try to substitute that in, I get errors in DB and the routine will not run
Compiler Error: C:\Users\Stephanie\Desktop\Dandelions\Plugins\Trinity\Routines\Monk\WoLEdited.cs(198,26) : error CS0029: Cannot implicitly convert type 'Zeta.Common.Vector3' to 'Trinity.Framework.Actors.ActorTypes.TrinityActor'
This is the error when attempting to sub in CurrentTarget.Position for WoL
The problem in mine appears to not be target distance, but rather, targeting issues involving the environment, wether it be doors, map edges, especially large environmental objects, etc. These are the only things that keep it from using WoL. But it continues to use Dashing strike in most cases. When it does, sometimes it causes the mob to follow just ever so slightly, allowing the bot a targetting path, and thus a successful cast of WoL.
I ran comparative tests for 3 hrs last night using identical build (
https://www.d3planner.com/406131377) with the LoN WoL, One Punch, and my own version of One Punch with minor edits regarding kiting distance that I am not even entirely sure are used. Here are the results (
https://docs.google.com/spreadsheets/d/15SGdZ-bfId1Fg6MBR2_xF7z7APFCQfUmhLvEWvxwmnc/edit?usp=sharing). From them, I can conclude that there is a negligible difference in speed between the 3 builds. However, I find LoN WoL to be unreliable to be left alone, it must be baby sat in case it resets game or it will not reapply initial Sweeping Winds. I still must test the 3 using augmented ancient gear at higher GRS, using WH instead of Kyo's soul belt, and with the generator build as Fuzio0 has mentioned having success with.
If anyone knows how to code, take a swing at the WoL targeting issue and see if you can't get it to attempt to cast 1f in different random directions from target, if it cannot cast WoL on target or target.position (if you can get that working too).