PureRotation V2

[jw505]

May I make one suggestion for the pala prot spec? Really hope to see them in the logic. I know near to nothing about coding so I hope it's not too difficult to put them in the logic.

1. Could there be a setting: use Shield of the Righteous at holy power "N" (1-5 or maybe 3-5, 1/3: as soon as it's available use it; 5: only at 5hp use it.) so we can control when to use the spell. This way (say i set it to 5) it will only use the shield on 5 HP and often it's at 3 or 4 where I can use it manually to block some damages. it's very crucial at some boss encounters like horridon and tortos and sha in TOES where they have frequent massive attack and I dont have enough haste that can cover all the time.


Sorry about my English, I hope you can understand what I meant.

 

[Stormchasing]

May I make one suggestion for the pala prot spec? Really hope to see them in the logic. I know near to nothing about coding so I hope it's not too difficult to put them in the logic.

1. Could there be a setting: use Shield of the Righteous at holy power "N" (1-5 or maybe 3-5, 1/3: as soon as it's available use it; 5: only at 5hp use it.) so we can control when to use the spell. This way (say i set it to 5) it will only use the shield on 5 HP and often it's at 3 or 4 where I can use it manually to block some damages. it's very crucial at some boss encounters like horridon and tortos and sha in TOES where they have frequent massive attack and I dont have enough haste that can cover all the time.


Sorry about my English, I hope you can understand what I meant.

with this idea, u should set it to 6 or 0 when controlling it manual? (and no it isn't that hard to code that piece^^)

 

[Stormchasing]

0.5

<?xml version="1.0" encoding="utf-8"?>
<PRSettings>
<EnableWoWChatOutput>True</EnableWoWChatOutput>
<ThrottleTime>0.5</ThrottleTime>
<UseCooldowns>True</UseCooldowns>
<UseAoEAbilities>True</UseAoEAbilities>
<EnableRaidPartyBuffing>True</EnableRaidPartyBuffing>
<EnableInterupts>True</EnableInterupts>
<EnableFlock>False</EnableFlock>
<EnableDispelNonHeals>False</EnableDispelNonHeals>
<OverhealPercent>95</OverhealPercent>
<IncludetotalAbsorb>35</IncludetotalAbsorb>
<includeMyHeals>True</includeMyHeals>
<DispelDebuffs>LowPriority</DispelDebuffs>
<AoEHealCount>3</AoEHealCount>
<AoEHealHP>87</AoEHealHP>
<TargetTankTarget>True</TargetTankTarget>
<EnableSelfHealing>True</EnableSelfHealing>
<UsePotion>True</UsePotion>
<Trinket1Choice>OnBoss</Trinket1Choice>
<Trinket2Choice>OnBoss</Trinket2Choice>
<UseGloves>True</UseGloves>
<EnableGiftoftheNaaru>True</EnableGiftoftheNaaru>
<GiftNaaruHp>60</GiftNaaruHp>
<UseRacials>OnBoss</UseRacials>
</PRSettings>

fresh install or after a crash? if this is from a fresh one, please quote again after a crash

 

[Stormchasing]

Blood DK:

The settings for Rune Tap Percent and RuneTap & WoTN Percent are mixed together. The comment for NeedRuneTap also shows the default should be 90, but it's 80 in the settings file. The descriptions also don't match the actual setting.

[Setting]
[Styx.Helpers.DefaultValue(90)]
[Category("Blood")]
[DisplayName("RuneTap Percent")]
[Description("Will use RuneTap when Will of the Necropolis procs at the set Healthpercent. (Self Healing (General Tab) must be enabled as well.)")]
public int RuneTapWoTNPercent

and

[Setting]
[Styx.Helpers.DefaultValue(80)]
[Category("Blood")]
[DisplayName("RuneTap & WoTN Percent")]
[Description("Will use RuneTap at the set Healthpercent.")]
public int RuneTapPercent

I've been using it quite a bit lately, if I notice anything else I'll let you know!

most of the comments were done while developing and never touched again after testing so ... if comment says 90 and we do 80 ... it is because we found out it is better at 80.

display name wrong, will fix it on next commit

 

[Millz]

I used Demo Warlock spec and found sometimes PR did some strange things. I attached with a log. You can find out sometime it just spam rapidly Corruption and Doom on a single target. Hope this will help the CR becomes better and better. Thanks for your great works.

Thanks, found the bug, think it should be fixed now. Can you retry?

Made a couple of changes;
- Fixed Doom/Corruption spam
- Corruption AoE dotting now 40 yards, up from 20.
- Force Doom to refresh when Perfect Aim procs.

 

[jw505]

with this idea, u should set it to 6 or 0 when controlling it manual? (and no it isn't that hard to code that piece^^)

Great! Looking forward to the change and try it in combat~~

 

[Staffix]

Thanks for testing. Did you have cooldowns on? Currently with cooldowns enabled, it *should* use the fire elemental totem.

yeah, set it to auto mode
tested hotkey afterwards, but it seems like its overwriting it somehow? putting it searing totem as a prio over ele. totem?

other than that, it seems like enhance is working quite well..
i'm doing roughly 50-60k dps as 460 ilvl, according to simulationcraft i should be doing 52k dps (with light movement and player skill: good)

 

[blacka_bro]

Thanks, found the bug, think it should be fixed now. Can you retry?

Made a couple of changes;
- Fixed Doom/Corruption spam
- Corruption AoE dotting now 40 yards, up from 20.
- Force Doom to refresh when Perfect Aim procs.

awsome.. too bad i dont have the trinket yet

 

[Millz]

Affliction

- Life Tap calculations improved.
- Fixed Fel Flame sometimes casting unnecessarily.
- Fixed UA double casting
- Drain Soul & Malefic Grasp will now cast while moving.
- UA will no longer refresh when setting force refresh on stat increase enabled. This is due to an issue with the Honorbuddy core which has been reported.
- Priority change; Life Tap -> Fel Flame
- Unit scanning logic greatly improved to include all valid units we're in combat with around us, rather than just around the target.
- Changed scanning conditions to improve performance
- Multi-DoTing will now prioritize units to select those with the highest HP value.
- Soul Shards reacting should now be faster.
- Updated Seed of Corruption logic. Requires further work.

Affliction still requires a lot more work. This is just a start.

 

[killgogeta]

Honnorbuddy crash with my drood when i select purerotation. Work fine before don t know why he made that. Works with singular or mad

 

[Millz]

Honnorbuddy crash with my drood when i select purerotation. Work fine before don t know why he made that. Works with singular or mad

You're on an outdated version, update it from SVN.

[14:27:16.473 D] PureRotation 2.0.7 v1.0.0.0

If you're still having issues, see this post; http://www.thebuddyforum.com/honorb...l-one/115706-purerotation-v2.html#post1123545

 

[Clubwar]

For automatic or semi-auto mode set AoE count to 2. Set multi-dot to everything around me and enabled in single target. Can't remember off the top of my head what the fire specific settings are though - but defaults will be fine.

I try your configuration, and yes now LB work always in 2 or more adds, but i detected other bug.

Mage never use alter time

View attachment 96501

 

[Millz]

I try your configuration, and yes now LB work always in 2 or more adds, but i detected other bug.

Mage never use alter time

View attachment 96501

What talent do you have as tier 6? i.e. Invocation, Rune of Power...

Off topic, you probably want to change this to True (especially if raiding);
EnableManaGem: False

 

[Clubwar]

What talent do you have as tier 6? i.e. Invocation, Rune of Power...

Off topic, you probably want to change this to True (especially if raiding);
EnableManaGem: False

Invocation is my tier 6 talent.

And thx for advise i change gem, but i normally no have problem whit mana

 

[Millz]

Invocation is my tier 6 talent.

And thx for advise i change gem, but i normally no have problem whit mana

Do you have PoM?

 

[Clubwar]

Do you have PoM?

Yes i have.

 

[neo1337]

Thanks, found the bug, think it should be fixed now. Can you retry?

Made a couple of changes;
- Fixed Doom/Corruption spam
- Corruption AoE dotting now 40 yards, up from 20.
- Force Doom to refresh when Perfect Aim procs.

Just tried it,still not working D:

Its still spamming corruption & doom on single targets. I am using it in hotkey mode.

 

[Insanityy]

is it possible to post on first page what specs have pvp rotations ?
cheers

 

[Millz]

Yes i have.

Should be fixed now. Update from SVN.

 

[Millz]

Just tried it,still not working D:

Hmm. Tried something else, can you update and try again? If it doesnt work post a log file.