i have no clue whats going on but basically it will fly around the area's it is meant to when it sees a battle pet the whole thing freezes momentarily and starts trying to attack but blacklisting at the same time and never attacks anything. i have blacklist and whitelist off i have pvp off and i have 300yards on using GB2.. any idea's??
RebornBuddy Forums
Register a free account today to become a member! Once signed in, you'll be able to participate on this site by adding your own topics and posts, as well as connect with other members through your own private inbox!
[PLUGIN] Pokebuddy - Gotto kill em all!
- Thread starter maybe
- Start date
toliman
Member
- Joined
- Jun 20, 2012
- Messages
- 625
The hitch with the updated battle pet swapper inserted into Pokehbuddy, is that it needs to operate before PB gets the pulse to act.
sometimes, it doesn't load in time to swap before the battle has started.
PB needs a little bit of a patch to get it working when PB is idle. nothing major.
it's kind of a simple plugin. i don't think it's changed in a year or so.
A) it reads the levels of your current pets, and uses that to decide which profile to load.
AFAIK, it only uses the first pet, which is "usually" the lowest level.
(this can be modified if needed, to use the lowest level (for ringer settings) out of the 3 pets.)
B) it changes the current profile, to another one inside the PetArea folder depending on your current pet level.
C) if i remember, it won't change the profile unless the loaded profile is already from the PetArea folder.
that last point, i'd have to check if that's still the case. and if it works with grind/gather bots, etc. i haven't used it in a while.
toliman
Member
- Joined
- Jun 20, 2012
- Messages
- 625
Took a while to get the gist of this.
The flying mobs in wyrmrest temple, dragonblight, are not all that great. it's a fairly mediocre farming area for the dragonbone hatchlings, but it's more prolific than most nearby areas in northrend.
If you're farming for pet XP (levelling pets), go to zul'drak. The wavelings are 30-40 deep, respawn faster and combat is reduced if you extend the PB range out past 100.
For the wavelings or the dragonbone hatchlings, you will often get dragged into combat in that area, which will slow down or prevent PB from engaging, depending on the bot and the CC you use.
I'd probably want to see a log before jumping to any conclusions about what's happening there, since it might not be a blacklist, but the bot that you're using.
Switch to Combat bot, manually walk around the middle of dragonblight using PB to see if your settings in PB are working, and that the CC is killing mobs in the area at low level, since that might also be a factor in why it's ignoring pet battles.
My Bot sucks with PB, i dont change anything. I dont know what to do. Yesterday the bot work fine and now he do nothing at the same spot without any changes ...
View attachment 5696 2013-12-07 00.06.txt
View attachment 5696 2013-12-07 00.06.txt
honorrunar
Member
- Joined
- Apr 1, 2010
- Messages
- 50
Hmm. Why do i have to disable Framelock for this to work??
It's so slow.
It's so slow.
laria
Well-Known Member
- Joined
- Jan 15, 2010
- Messages
- 5,386
Hmm. Why do i have to disable Framelock for this to work??
It's so slow.
PetBattle related plugins make heavy use of luacalls (like wowaddons do), and framelock stops rendering wow frames until all these luacalls are finished. This slows down wow to an unacceptable speed and therefore doesn't work currently.
toliman
Member
- Joined
- Jun 20, 2012
- Messages
- 625
WoW, actually changes the UI when a pet is captureable. It also provides data that PB uses to make decisions about capturing pets, including information about pets you already have.
When a pet is unknown, PB doesn't really know about that until the option to capture comes up. The Pet Battles UI shows if you have a similar pet, and the current quality of your version of the pet.
In most cases, PB follows the rarity drop down list on the very first options screen, "better than what I have" is the best choice for most people, as it will capture newer pets if they are of a better quality.
In terms of hunting down specific missing pets, you need a way to compare your pets against a list of all wild or collection pets and their locations. Which is very much out of the capability of a plugin alone.
DomesticWarlord
Community Developer
- Joined
- May 16, 2013
- Messages
- 368
Question and request for Maybe
Is there any way you could code it so that in the pet logics we can assign which pet abilities to take into battle? I want to start making some pet logics to hand out to people but if I make a logic for a tier 2 ability and they have tier 1 selected it won't do any good.
Also I did search for this in the thread and saw a few times where it was requested but never responded to, thought I'd try muy luck in getting a response.
Is there any way you could code it so that in the pet logics we can assign which pet abilities to take into battle? I want to start making some pet logics to hand out to people but if I make a logic for a tier 2 ability and they have tier 1 selected it won't do any good.
Also I did search for this in the thread and saw a few times where it was requested but never responded to, thought I'd try muy luck in getting a response.
TreeK
New Member
- Joined
- Jul 10, 2012
- Messages
- 170
You can do this now:
Code:
<SpellLayout>ASSIGNABILITY1(420)@ASSIGNABILITY2(506)@ASSIGNABILITY3(507)</SpellLayout>Just add that line into your XML file - with the desired abilities of course. Ends up looking something like:
Code:
<PetBattleSettings>
<Logic>CASTSPELL(2) COOLDOWN(SKILL(2)) EQUALS false $ Health(ENEMYPET) ISLESSTHAN 13@CASTSPELL(3) COOLDOWN(SKILL(3)) EQUALS false $ Health(ENEMYPET) ISGREATERTHAN 20@CASTSPELL(1) COOLDOWN(SKILL(1)) EQUALS false</Logic>
<SpellLayout>ASSIGNABILITY1(420)@ASSIGNABILITY2(506)@ASSIGNABILITY3(507)</SpellLayout>
</PetBattleSettings>No way to do it through the UI at this point, though it does try to automatically fill in the abilities from what I can tell. Have to manually change the files, but it is still very useful.
This seems to be fairly correct from my brief study of the plugin. Honestly, the plugin has huge places for improvement. I implemented a couple of them and was able to get everything BUT the movement to work very well (my changes also introduced a bug with it thinking it is still in combat or something afterwards, but I believe I just forgot to reset a variable somewhere).
Some notes to the developer (Note, everything here is an attempt to make the bot run fast enough to use framelock):
First off, this is far better suited for a BotBase. If I can find the time and motivation tomorrow, I may work on converting it myself.
You are calling functions that should not change during one frame MANY times.
InPetCombat and WildBattleTarget are examples of this, which both get called way too often for the resources that the functions take. Try storing the value and only updating it when you absolutely NEED to make sure that it is up to date.
Another big problem is how you are handling movement. I am not entirely sure what the best solution is without converting to a BotBase, but completely taking control of Honorbuddy is causing a lot of problems. I was trying to give honorbuddy control again by simply returning, but GatherBuddy2 kept trying to move me again afterwards (although the lag was completely removed).
I'm sure there are more improvements, but those were the hugest ones that I took note of. Let me know if you have any questions as to what I mean, or why I think it needs improving.
Hello,
I'm using the "beta" version of PB. Off-combat PB is not swaping the pets, and I'm getting this message:
Any tips?
I'm using the "beta" version of PB. Off-combat PB is not swaping the pets, and I'm getting this message:
Code:
PB] Pulsing BPS
[PB] Heavily injured pets : 1
[PB] Checking slot 1 level
[PB] Going to switch slot 1
[PB] view, total = C_PetJournal.GetNumPets() for wantlevel=1,23 do for i=1, total do petID, _, owned, _, level, favorite, _, _, _, _, _, _, _, isWild, canBattle, isTradeable, _, _ = C_PetJournal.GetPetInfoByIndex(i) if (petID ~= nil) then health, maxHealth, power, speed, rarity = C_PetJournal.GetPetStats(petID) if (health == maxHealth and level==wantlevel and favorite == true and isTradeable == true and isWild == true and owned == true and canBattle==true) then C_PetJournal.SetPetLoadOutInfo(1,petID) return end end end end
[PB] Pulsing BPS
[PB] Enough pets injured, trying to heal/rez pets
[PB] Heavily injured pets : 1
[PB] Checking slot 1 level
[PB] Going to switch slot 1
[PB] view, total = C_PetJournal.GetNumPets() for wantlevel=1,23 do for i=1, total do petID, _, owned, _, level, favorite, _, _, _, _, _, _, _, isWild, canBattle, isTradeable, _, _ = C_PetJournal.GetPetInfoByIndex(i) if (petID ~= nil) then health, maxHealth, power, speed, rarity = C_PetJournal.GetPetStats(petID) if (health == maxHealth and level==wantlevel and favorite == true and isTradeable == true and isWild == true and owned == true and canBattle==true) then C_PetJournal.SetPetLoadOutInfo(1,petID) return end end end endAny tips?
I've converted this into a BotBase (although it is still fairly minimal, still looking through your code and figuring out things I missed implementing). Sending you a PM to find out what you think I should do with it, since it still uses a bunch of your functions right now.
EDIT: Working pretty well now (and this is with framelock on), although I have only tested it with a flying mount. Using it with BGBuddy with no problems.
EDIT2: Still no response from him. Created a thread in the meantime, let me know if you want it removed or whatever.
EDIT: Working pretty well now (and this is with framelock on), although I have only tested it with a flying mount. Using it with BGBuddy with no problems.
EDIT2: Still no response from him. Created a thread in the meantime, let me know if you want it removed or whatever.
toliman
Member
- Joined
- Jun 20, 2012
- Messages
- 625
maybe can elaborate on what's coming up, but if it helps, I'll take a shot.
Currently, the ability loadout is saved when you create the logic, or save over the current logic.
The new db can hold several logics for each pet, which is a good start.
the problem so far is creating a way to choose which logic to use when the pet is loaded into the slot.
Right now, there can be only one...
And it sort of loads okay. It doesn't choose between stored logic yet.
Analytically, the best way to go is to have PB choose a logic & loadout based on the zone, or the trainer, or the goal/mode intended.
So, you would go into the plugin, choose a mode, and the database would filter out all the pets it could use that had a "puppy logic", and a "Ringer logic", and cache the results.
This would also be useful for pvp pre selection or trainer compositions, so the npc id of a trainer could be read, and a loadout/pets changed as appropriate.
This requires reading a player's individual pets and putting them into cached lists, which is adding a lot more work to the current system.
The database is a good start, but battle pet swapper would need to also grab the zone id, and cache the local pet id's so the ringer/puppy pets list can be cached and scanned based on family type as a new filter type. Eg. Avoiding weak pets as ringer/puppy choices when in one zone, and rescanning the zone before choosing new pets.
This part is a challenge, because it requires tagging each logic for a mode it should be used for. And showing all the logic and loadouts is a design/interface challenge too. And saving/loading a list of pets to use. Creating a zone id of pets by level and family, updating the entire database every time there's a PB or pet update, etc.
The other, much larger challenge is creating 5 to 8 logics per pet, for 550+ pets. And a way to push updates to everyone and keep custom logic you might want.
Well, it's more like 400 x 6, it's still fearsome work to cover all the various logic types. The list could be compressed with some ability analysis, ie level 1/2/4 abilities with cooldowns for puppy logic, a zone database with wild pet types fed into it, and so on. But It's a huge amount of time & work for not much in performance.
Really requires a collaborative project to manage pet collection logic sharing, due to the rapid changes and voting or choosing between logics for each pet can make it difficult to get a solid 4566+ logic database. Give or take.
And the whole thing will change when 6.0 and WOD comes along as well, depending how pet breeding works, or if it's a grind/mini game. Etc.
Most of the mode changes will also affect loadout choices, if PB is slot swapping the lowbie pet, etc. and it all requires a considerable logic review . In most cases, it would also change pets when PvP queued, change pets if boosting/power levelling, and change pets for the trainers, or farming fable pets, or just searching for rare/elusive pets as it does now.
(though the bot is currently incapable of handling most all of the 60 trainers, and celestial /fable pets just due to the setup each trainer after level 20 needs... Eg. pet training logic, means choosing the precise pets that people will /won't have, using response logic to certain abilities, and having the bot do nothing for 6 to 7 minutes waiting for bandages/repairs) or swapping a main team for a backup team, or a custom built team (or seven) to defeat the celestial /fable pets.
To put the workload into perspective, it would be easier to build a Botbase that tracks down and captures rare Hunter pets, then swaps stable slots so you can collect multiple rare pets. And swaps zones to do so.
It would be easier to build an arena Botbase that learns strategy and tactics, line of sight movement, how to verbally taunt, respond to abuse, and act dumb, jump from a ledge, snowfall and fire from the air, then cancel within 29 ft, to run behind a column between shots, etc.
It would be easier to implement RNG into the battleground bots, so they choose between tactics in a battleground that don't involve standing in a pile up, and can process stacking commands eg grab flag. Move to a friendly, or a speed token if it's up, look to find a gap between the enemy and friendly mobs, use boosts past enemy targets to avoid range, double back if surrounded, etc. Things that advanced agent AI can do.
What PB does now, works. If I had to choose something to redo, it would be working zone integration with battle pet swapper and battle pet collector, And resurrect bpc.
The rest, can wait until WoD.
Toliman, are you part of Team Random? I made some HUGE improvements to the bot and I posted a thread about it (so others could use it if they wanted). I want to know what you guys think of my changes, and what should be done about them, as we can probably both work on development =P
