[Plugin] Mr.ItemRemover2 - Deletes , Opens and Sells items in your Bags

[ginuwine12]

Got a netherweave and a frostweave bag deleted on my toons, i don't have a log of it..
but i'll try and buy new bags and run it again

(didn't vendor them, deffinatly delted it.)

yup deleted one bag for me too ^^

 

[Florida]

I was wondering why my Stormwind Satchel was disappearing.

 

[Wullie]

There's a bug:

                    Slog("{0} is a bag, ignoring.", item.Name);
                    return;

Should be:

                    Slog("{0} is a bag, ignoring.", item.Name);
                    continue;

Or else it stops looking at any items if you happen to have a bag in your bags.

 

[bambam922]

uh oh! got a issue with the selling of food/drink item level. I had my setting at 79, so it wouldnt sell my lvl 80 drinks.. but it did anyway. so then i set it to 70, and it still sold the lvl 80 drink.

View attachment 119443

This is the first time this has happened since your last update.

EDIT: cleared compiled assemblies, cache, and MIR2 character settings. will report back if this solves the problem.

EDIT2: Still does the same thing. Something in your last update must of borked somethings. I know you will fix it though

I think I solved this. It looked like it evaluated the item twice, once as a drink and another as a regular white item. In this instance, I was missing a check of the lists. I think I fixed this.

Did a fresh SVN checkout and deleted all MIR2 settings, assemblies, caches...problem persists. Here is a much simpler log so you can see it is selling level 80 drink when I have my selling setting set to 79.

View attachment 119446

EDIT: until this is fixed, I just put my level appropriate drinks on protected list.

EDIT2: for whatever reason, it is working properly now with level 85 drinks. I have my setting at 84, and it doesnt sell my 85 drinks, like it is properly not supposed to. perhaps it was just that specific drink that was screwy? idk. but it works now.

Weird. Also, keep in mind that only foods/drinks from ProtectedItems.xml are in the lists. This may be the problem.
I am actually planning on removing Food and Drink Lists, but I have to wait to implement it because the API I need to use is currently only available in Staff-only internal builds. So if I were to make the change now, it would be completely broken.

Ok looks like I just shot myself in the foot.

While HB was running and on Mr.ItemRemover2 version 2.3.1, I deleted its folder and a bunch of errors came out. I decided to ignore this, close HB, did a clean install of version 2.3.2 and tried the bot again. Upon enabling of Mr.ItemRemover in the plugins, the following errors come out:...

I've tried doing a fresh install of honorbuddy in a separate folder in My Documents and re-downloaded all my personal plugins (including version 2.3.2 of MIR2) and routines. The same error still comes up whenever I try to enable MIR2. I also tried the Dev Version, same errors keep popping up.

Log:View attachment 119625

Looks like the folder path you posted had a space where it wasn't supposed to be. The folder MUST be called MrItemremover2. If it can't get into that folder, it will think you are missing those files.

Got a netherweave and a frostweave bag deleted on my toons, i don't have a log of it..
but i'll try and buy new bags and run it again

(didn't vendor them, deffinatly delted it.)

I noticed that I did not have a check when items were deleted for bags. I added these checks so this should no longer happen, hopefully.
MIR2 does not unequip them, so I have no idea why that happens.

If you run 3 orso bots you sometimes get "Error file is in use can't read"...because another bot is trying to read the file at the same time.

Is there any way to fix this or minimize the problem? Because it completely stops the bot untill you click the error box.
/Best Mac

Make separate HB installs.

There's a bug:

                    Slog("{0} is a bag, ignoring.", item.Name);
                    return;

Should be:

                    Slog("{0} is a bag, ignoring.", item.Name);
                    continue;

Or else it stops looking at any items if you happen to have a bag in your bags.

Fixed. Thanks.


Update Version 2.3.3
Misc Bug fixes.
Added check for bags when removing.
Added loading of lists again when merchant frame is opened.
return; -> continue;
Added check for Food/Drink at all selling areas
ONLY MAJOR UPDATES WILL BE ATTACHED TO THREAD. MINOR UPDATES REQUIRE UPDATE FROM SVN

 

[Crown]

well.. honorbuddy freezes sometimes (80% of the time) i try to open the MIR2 Settings or enable/disbale mir2 - what causes this?

 

[radix2]

I`ve got trouble with this plugin - i tried to use open/combine, but, however, items don?t get combined

HB just tells me:

[MIR2]: Enabling Check because Loot Ended
[MIR2]: EnableCheck was Passed!
[MIR2]: Turning off Check Since Done!

so it seems the plugin is doing something at all, but nothing gets combined.
when pushing "check bag items now" in settings window its working- but it doesent do anything automatically - neither by timed check nor after looting.
any ideas??

 

[dutamulia]

Will open only one stack of lovely charm and them stopped.

 

[ticklets]

So, I set Sell Greys, Drinks and Soulbound to TRUE but everything else remains FALSE. It doesn't sell any soulbound items though! Is this because sell White/Yellow/Blue is set to false?

 

[bambam922]

Been studying for finals and I will look into bugs later tonight after I take my last exam.

 

[dutamulia]

MIR is not correctly overriding protected item list file in HB main folder, I still have my [Roasted beef] kept, it is not selling the food.

I had to edit the file, and then MIR is still not selling the food, but at least now it can mailed.

 

[tumbum]

Possible to open Bags (like "hidden stach") with MIR2?

 

[Igoblin]

Why cant sell FOOD and DRINKS?? I check TRUE in the SELL tab! the plugin sell green, soulbound etc really fine! but dont sell food and drink....

 

[dutamulia]

Thanks again for this useful plugin, I have a request.

A single button super clean mode which will do the following :

1. Sell everything that can be sold the next time we visit a vendor or interval
2. Destroy everything that can't be sold (except protected & quest items of course)
Utilizing mammoth mount vendor would be a great plus.

Perfectly suits bot army leveling and farming. Please consider it, thank you.

Wanted to make donation but my Paypal account is not yet have the established seller status so it might take a while

 

[Malice211]

Love the plugin...just wondering if it was possible to have it set up to open Tiny Treasure Chests when they are found? it is item id #67539 I believe. I have "Enable open/combine" set to true but I guess this item is not in the list of items to open. Thanks


EDIT

I just opened up the "Itemnameopenlist" file that is in the plugin section and I see the Tiny Treasure Chest on the list...not sure why it is not opening them.

 

[Susi992]

"open/combine" -funktion dont work for me need it so much

 

[Bertrand]

There is a serious issue that needs to be adressed here, two quest items in nagrand, the blanked that needs to be used on a fire and the warmaul banner that needs to be placed on 10 dead corpses both provided by an npc are being destroyed when the bot does its regular bag check. I though by default it should protect all quest related items but seems that is not the case here.

 

[profx]

Why it is deleting my last bag?

 

[Xom]

Yup, deleting last bag...

 

[Mays]

So what about working with IDs? At eng clent plugin works fine but it dont wanna work at ru client.

 

[sMuve]

If I start the same HB client twice, the MIR2 of the second HB seems to load other lists. How can i tell MIR or HB to use the same MIR list on every account / wow id ?