[Plugin] Giles Stash & Loot Rule Replacer

[cityhall89]

I love the loot rules! Thank you very much for all your hard work.

I do have a suggestion that may improve profitability for using the 61+ magic items rules. Would it be at all possible to add a condition based upon sell value when determining to salvage or vendor? Ie if a magic item has a sell value over 1k vendor else salvage

Thanks

 

[PainfulDeath]

1) World Object Handler It has a config option for minimum gold stack size to pickup. DemonBuddy itself doesn't actually support gold-stack sizes. World Object handler lets you control it though. It defaults to 300. Check the config window for that plugin.
2) Make sure the item rule for tomes is; <ItemRule itemName="Tome of*" stack="1" /> or just try with the loot-rules I provided and see if they work, to rule out your own custom-loot-rules being buggy rather than 1.6.5 of the plugin being buggy.

1) thanks
2) Don't I have exactly that line for tomes in my rules? =) I think I do. How would one test rules for being buggy, save for discarding them and trying other rules? It immediately implements changes i do for other stuff (like I recently changed to only pickup 63 blues, instead of 61+ and it started doing exactly that) but the tomes seem to escape him. Also haven't seen any plans lately. -_- Although all the plans dropping to me so far are utter crap anyway.

Also

[21:56:46.686 N] [GilesStashReplacer 1.6.5] The Grasp [Ring_22-83] [Ring] = 13773
[21:56:46.686 N] [GilesStashReplacer 1.6.5] ***** KEEP *****

this is 6% AS 1 socket 42 phys res 15 minimum damage ring. Seems to be worthless and such a good score for jewerly =)

 

[GilesSmith]

2) Don't I have exactly that line for tomes in my rules? =) I think I do. How would one test rules for being buggy, save for discarding them and trying other rules? It immediately implements changes i do for other stuff (like I recently changed to only pickup 63 blues, instead of 61+ and it started doing exactly that) but the tomes seem to escape him. Also haven't seen any plans lately. -_- Although all the plans dropping to me so far are utter crap anyway.

There's no reason tomes shouldn't be picked up with that loot rule. But if you hang on for a few hours/til late tonight (early hours of this morning british time), I'll be updating this plugin to a version that works without needing any pickup loot rules - will replace DemonBuddy item pickup with something more stable and reliable, will support all items (including all follower item types), will more accurately look for full backups and hopefully avoid those infinite item-pickup-loops people get stuck with default DemonBuddy, will allow capping potions at 100 (so don't pickup anymore over 100), will only pickup designs/plans that are legendary (valuable) not all those crappy rare ones, will support any language (item names in other languages for designs/plans/potions will be irrelevant), etc. etc. - you'll be able to either use a new version of World Object Handler that completely disables item pickup rules, or if you don't want to use that plugin, can use loot-rules that just allow pickup of any and every item and let the plugin do the filtering (won't be as reliable/feature-rich as using with world object handler). Here's the config windows atm;

I'm just doing more tweakings and testings of it all atm before releasing.

I love the loot rules! Thank you very much for all your hard work.
I do have a suggestion that may improve profitability for using the 61+ magic items rules. Would it be at all possible to add a condition based upon sell value when determining to salvage or vendor? Ie if a magic item has a sell value over 1k vendor else salvage
Thanks

Unfortunately this isn't currently possible, without an update from DemonBuddy to read that sale-value variable from Diablo 3 memory!

 

[greenblood]

Looks awesome. Can't wait to try this out.

 

[PainfulDeath]

There's no reason tomes shouldn't be picked up with that loot rule. But if you hang on for a few hours/til late tonight (early hours of this morning british time), I'll be updating this plugin to a version that works without needing any pickup loot rules - will replace DemonBuddy item pickup with something more stable and reliable, will support all items (including all follower item types), will more accurately look for full backups and hopefully avoid those infinite item-pickup-loops people get stuck with default DemonBuddy, will allow capping potions at 100 (so don't pickup anymore over 100), will only pickup designs/plans that are legendary (valuable) not all those crappy rare ones, will support any language (item names in other languages for designs/plans/potions will be irrelevant), etc. etc. - you'll be able to either use a new version of World Object Handler that completely disables item pickup rules, or if you don't want to use that plugin, can use loot-rules that just allow pickup of any and every item and let the plugin do the filtering (won't be as reliable/feature-rich as using with world object handler). Here's the config windows atm;

Just wanted to point out that not all rare plans are crappy, and there are no legendary designs to my knowledge, they are all "magic" and all quite valuable.

Also, the config windows look pretty neat, but it will not eliminate the need of pickup files at least for me for now as I like to use different rules for magic and rare items (rare4 61+, magic1 63 only) and that wouldn't be possible with that window.
Yes, I know you can't comply to every little of whim of everyone, just saying. =)

 

[GilesSmith]

Just wanted to point out that not all rare plans are crappy, and there are no legendary designs to my knowledge, they are all "magic" and all quite valuable.
Also, the config windows look pretty neat, but it will not eliminate the need of pickup files at least for me for now as I like to use different rules for magic and rare items (rare4 61+, magic1 63 only) and that wouldn't be possible with that window.
Yes, I know you can't comply to every little of whim of everyone, just saying. =)

The plans that appear yellow (all the "Exalted:" plans) are all crappy aren't they? I haven't seen an exalted one that is worth much? Let me know if you know of any specifics. The "legendary" ones are, I mean, the ones that appear in the legendary color when you get them listed in the AH (I don't actually think they can even drop in act 1, from what I remember hearing, but I could be wrong).

I'm trying to be as accommodating as I can to everybody. But at the moment my priority is replacing the extremely unreliable DemonBuddy pickup code and bag-full-detection code. Wouldn't you rather have your bot pickup all 61+'s (blue and yellow) and not ever get stuck picking items up? Maybe you wouldn't. But if I understand people's reasoning's behind their desires for unique and specific customization, then I can either accommodate them or make things even better for them - why do you want to pick up blues but only blues of level 63+, is there a specific drop that is worth a lot you know about that I can make sure is being detected? As it is I've re-wrote huge swathes of DemonBuddy routines, and am working on getting it all working smoothly. User specific customization can come later, and come easily

(btw, if you only keep magic1 ilvl 63 for weapons, then it already has special checks in for high DPS magics even if you've only told it to pick up rares, so you won't miss out on them... if it's for another reason though, please do let me know!)

 

[greenblood]

The plans that appear yellow (all the "Exalted:" plans) are all crappy aren't they? I haven't seen an exalted one that is worth much? Let me know if you know of any specifics. The "legendary" ones are, I mean, the ones that appear in the legendary color when you get them listed in the AH (I don't actually think they can even drop in act 1, from what I remember hearing, but I could be wrong).

I got a legendary plan from Sarkoth, don't remember which one it was because 10 minutes later all my DHs were banned but it was a plan and had the legendary color. I got like hundreds of rare plans in that time so a legendary must be really rare in act 1.

 

[GilesSmith]

I got a legendary plan from Sarkoth, don't remember which one it was because 10 minutes later all my DHs were banned but it was a plan and had the legendary color. I got like hundreds of rare plans in that time so a legendary must be really rare in act 1.

Oh, good to know they do drop, I've never seen one on any bot I run, ever! I feel so left out

 

[xenohadden]

The plans that appear yellow (all the "Exalted:" plans) are all crappy aren't they? I haven't seen an exalted one that is worth much? Let me know if you know of any specifics. The "legendary" ones are, I mean, the ones that appear in the legendary color when you get them listed in the AH (I don't actually think they can even drop in act 1, from what I remember hearing, but I could be wrong).

I'm trying to be as accommodating as I can to everybody. But at the moment my priority is replacing the extremely unreliable DemonBuddy pickup code and bag-full-detection code. Wouldn't you rather have your bot pickup all 61+'s (blue and yellow) and not ever get stuck picking items up? Maybe you wouldn't. But if I understand people's reasoning's behind their desires for unique and specific customization, then I can either accommodate them or make things even better for them - why do you want to pick up blues but only blues of level 63+, is there a specific drop that is worth a lot you know about that I can make sure is being detected? As it is I've re-wrote huge swathes of DemonBuddy routines, and am working on getting it all working smoothly. User specific customization can come later, and come easily

(btw, if you only keep magic1 ilvl 63 for weapons, then it already has special checks in for high DPS magics even if you've only told it to pick up rares, so you won't miss out on them... if it's for another reason though, please do let me know!)

All the plan arn't worthless

6 property ones sell for a shit ton. I found one yesterday exalted gran chest thing, sold it for 6 million Also giles all the legendary patterns can drop in act 1, same as the gem patterns, just a low chance (same as ivl 63).

Love the look of the upgrade and ill definitely be using it, if i could provide you with a list of every plan worth keeping would the help out? I've got em all written down ^^

 

[greenblood]

Unless you can make sure it won't miss any of the rare 6 property or legendary plans just leave it as it is. It's not a big deal to sell the crappy plans that get stashed once a day or so.

 

[gukku]

look really cool can't wait till it come out thank you so much for your wonderful plugins

 

[xenohadden]

Found it

 

[xenohadden]

also don't know if you do this already giles but it should keep a stack of potions on it to use if it gets low, if you can add that in aswell would be helpful ;P

 

[PainfulDeath]

The plans that appear yellow (all the "Exalted:" plans) are all crappy aren't they? I haven't seen an exalted one that is worth much? Let me know if you know of any specifics. The "legendary" ones are, I mean, the ones that appear in the legendary color when you get them listed in the AH (I don't actually think they can even drop in act 1, from what I remember hearing, but I could be wrong).

I'm trying to be as accommodating as I can to everybody. But at the moment my priority is replacing the extremely unreliable DemonBuddy pickup code and bag-full-detection code. Wouldn't you rather have your bot pickup all 61+'s (blue and yellow) and not ever get stuck picking items up? Maybe you wouldn't. But if I understand people's reasoning's behind their desires for unique and specific customization, then I can either accommodate them or make things even better for them - why do you want to pick up blues but only blues of level 63+, is there a specific drop that is worth a lot you know about that I can make sure is being detected? As it is I've re-wrote huge swathes of DemonBuddy routines, and am working on getting it all working smoothly. User specific customization can come later, and come easily

(btw, if you only keep magic1 ilvl 63 for weapons, then it already has special checks in for high DPS magics even if you've only told it to pick up rares, so you won't miss out on them... if it's for another reason though, please do let me know!)

Nope, yellow plans can be pretty expensive (as many already wrote), you just want to look at 5-6 property ones. Ofc 4 property noone wants. (There is a pattern to naming them by the way, so it probably can be easily described with a regular expression). When I said there are no legendary designs I meant strictly designs (the gem recipes), I think they are all "blue".

As to why I want 63+ blues - they sometimes have good AH-potential. Like 20 MF + 100 primary stat or same with GF. Your addon already detects them, but I just want to make sure the bot picks em up. Magic items 61-62 are default trash, at least I can't imagine anything besides maybe blue 62 jewelry (MF/GF) that might sell on AH (Come to think of it, I should add them to my pickup list ).

PS. Just a minor question. Do I understand correctly, that "Magic1" is for any magic item and any rare and any legendary, and "Magic2" (does this even exist in loot rules? ) would be pretty much the same excluding magic items with 1 affix?

 

[GilesSmith]

Found it

Great, very useful, thanks!

Nope, yellow plans can be pretty expensive (as many already wrote), you just want to look at 5-6 property ones. Ofc 4 property noone wants. (There is a pattern to naming them by the way, so it probably can be easily described with a regular expression). When I said there are no legendary designs I meant strictly designs (the gem recipes), I think they are all "blue".
As to why I want 63+ blues - they sometimes have good AH-potential. Like 20 MF + 100 primary stat or same with GF. Your addon already detects them, but I just want to make sure the bot picks em up. Magic items 61-62 are default trash, at least I can't imagine anything besides maybe blue 62 jewelry (MF/GF) that might sell on AH.

Yeah I've NEVER had a good plan pickup so thought/assumed all the exalted were worthless - that list will come in handy (I'll have a look at it later and see if I can spot the obvious pattern in naming, will be easier).

As far as the 63+ blues - really then the only reason you'd want to explicitly express 63+ blues 61+ rares instead of just 61+ rares is to reduce the frequency of town-runs a little (and ofc slightly reduce how many items you go to pickup/how many inferno craft mats you end up stashing). So lack of ability to specific two separate item levels for two different qualities wouldn't ruin anything for you, it'd be nothing more than a very minor convenience/preference?

PS. Just a minor question. Do I understand correctly, that "Magic1" is for any magic item and any rare and any legendary, and "Magic2" (does this even exist in loot rules? ) would be pretty much the same excluding magic items with 1 affix?

Magic 2 would work - there is some internal quality referencing in Diablo. There's a Rare5 and a Rare6 (and some others I think), too - they might relate to stat roll chances, or specific affix combos, but as everything is so random anyway I think you're best picking Magic1 (the lowest level blue) or Rare4 (the lowest level yellow).

 

[GilesSmith]

Damn was meant to edit these in to my last post, oh well

Found it

Is that list just a list of *ALL* plans... or specifically a list of all the *VALUABLE* plans?

also don't know if you do this already giles but it should keep a stack of potions on it to use if it gets low, if you can add that in aswell would be helpful ;P

One of the new features coming in is to cap potions at 100 (one full stack) - so not picking any more up if you already have 100, otherwise keep picking up til you top up to the cap!

 

[greenblood]

Yeah picking up magic1 jewelry is not a bad idea. Stuff with max or near max GF/MF sells for alot even with no other stats on it. Do amulets and rings even get a high enough score to be kept if theres no other stats on it just high MF or GF??

 

[PainfulDeath]

[00:14:21.200 N] [GilesStashReplacer 1.6.5] Pathfinder's Defense [Bracers_norm_base_04-60] [Bracers] = 19090
[00:14:21.200 N] [GilesStashReplacer 1.6.5] ***** KEEP *****

Such a good score for:
bracer 59 str 72 int 135 vita 45 phys res 3% crit chance - worth nothing (20-30k max) on AH.

 

[PainfulDeath]

Great, very useful, thanks!
As far as the 63+ blues - really then the only reason you'd want to explicitly express 63+ blues 61+ rares instead of just 61+ rares is to reduce the frequency of town-runs a little (and ofc slightly reduce how many items you go to pickup/how many inferno craft mats you end up stashing). So lack of ability to specific two separate item levels for two different qualities wouldn't ruin anything for you, it'd be nothing more than a very minor convenience/preference?



Magic 2 would work - there is some internal quality referencing in Diablo. There's a Rare5 and a Rare6 (and some others I think), too - they might relate to stat roll chances, or specific affix combos, but as everything is so random anyway I think you're best picking Magic1 (the lowest level blue) or Rare4 (the lowest level yellow).

One would argue that it's not that "little", but instead it reduces the frequency of town-runs at least twice or even more. =) Thanks for other advice, will take that into consideration.

 

[GilesSmith]

[00:14:21.200 N] [GilesStashReplacer 1.6.5] Pathfinder's Defense [Bracers_norm_base_04-60] [Bracers] = 19090
[00:14:21.200 N] [GilesStashReplacer 1.6.5] ***** KEEP *****

Such a good score for:
bracer 59 str 72 int 135 vita 45 phys res 3% crit chance - worth nothing (20-30k max) on AH.

I genuinely appreciate the help and report of more stats/item slots that need tweaking, so that I may further enhance this work in return for you to use. I'm constantly altering things to nudge the peculiar rolls that can generate high scores out into the trash pile and will continue to do so. Already this plugin filters out more rubbish and keeps more worthwhile items than even the most gigantic hand-created loot-rules file could manage, but I'll keep trying to reach closer to perfection!

Just because it has been bothering me from some of your posts though - the sarcasm and tone isn't always necessary, please remember I'm not a developer, I'm not paid, I don't demand or even ask for donations or want them, I don't even ask for thanks, but sarcastic little tones for no reason at all really grate my conscience. If I've misread some of the nature of your posts, apologies, we all know text is useless at conveying intention or tone between people who are otherwise strangers!

Yeah picking up magic1 jewelry is not a bad idea. Stuff with max or near max GF/MF sells for alot even with no other stats on it. Do amulets and rings even get a high enough score to be kept if theres no other stats on it just high MF or GF??

Yes Certainly should do! I'll double-check but I'm pretty sure a blue amulet with for example ~40% GF will generate over 13,500 score (I will confirm later though). I do remember trying to tweak it so that this was so.