[Plugin] CombatHelper - Targeting, pulling, RaF and stability fixes

[Xanathos]

I have a question, lofi, on how this interact with HB. Specifically how does it interact with HB's pull value. Meaning, which takes precedence based on which one is a larger distance (read: If HB is set to 30 and the plugin is 15, which happens where?).

 

[Xanathos]

Ok, I tried this and I have a few issues...

1) This plugin does nothing for PvP (It still ignores other faction players, so I still get my ass kicked because HB ignores. They are still NOT in the targetlist (repFixed in the next release of HB)).
2) This plugin overrides restlogic of the CC (and keeps pulling mobs in range which are NOT aggroed but are in combat with eachother) which results in death due to mana or hp issues.
3) This plugin overrides lootlogic, and keeps pulling and not looting (which causes killed mobs to despawn, and I'm there for the loot in the first place, lol).
4) This plugin is pulling mobs that are not mentioned in the profile, nor is their faction ID in the profile, and they are neutral (so they don't attack unless attacked).

This is what I noticed so far in 30 minutes of use. I can live with the not PvPing part since the next release of HB should solve this, but the rest and looting logic override is a no no for me.
I'm grinding in heavily populated regions with a high mob concentration and quick respawns. It might tick your plugin off a bit.

Nice work on the plugin itself, and I'm sure it's usefull for many people.

Regards, Liquid.

I haven't tried it with PvP yet, but I've seen the same thing with looting that you do. It won't loot until its entire pull capable list is clear. This isn't an issue until you're in an area like you're talking about. My recommendation is to have it force loot (at least a single loot) once the number of lootable bodies reaches a certain threshold.

I've seen your #4, too. Basically this plugin is VERY aggressive. If *anything* is able to be attacked in the range you specify in the plugin it *will* attack it... No ifs, ands, or buts.

 

[lofi]

Ok, I tried this and I have a few issues...

1) This plugin does nothing for PvP (It still ignores other faction players, so I still get my ass kicked because HB ignores. They are still NOT in the targetlist (repFixed in the next release of HB)).

I'm not sure what has broken with PvP. While in Battleground, try targeting a player and click "Unit Check".. that will tell if the Plugin is working. I added "PullSpell" back to configurations, which may help in PvP.

2) This plugin overrides restlogic of the CC (and keeps pulling mobs in range which are NOT aggroed but are in combat with eachother) which results in death due to mana or hp issues.

It doesn't override rest, but sometimes it prevents the bot from getting to rest state because it reacts too quickly. I added a fix for chain pulling that should mitigate this issue.

3) This plugin overrides lootlogic, and keeps pulling and not looting (which causes killed mobs to despawn, and I'm there for the loot in the first place, lol).

I added back an old fix for looting that I thought was redundant. Seems to handle looting a lot better now.

4) This plugin is pulling mobs that are not mentioned in the profile, nor is their faction ID in the profile, and they are neutral (so they don't attack unless attacked).

This is correct, it completely overrides the Factions and Min/Max target levels in the profile. If someone could clue me in on how to read those parameters, I could add it to targeting logic. I would also like to add a parameter to ignore neutral mobs, but I'm unsure how to check this condition.

This is what I noticed so far in 30 minutes of use. I can live with the not PvPing part since the next release of HB should solve this, but the rest and looting logic override is a no no for me.
I'm grinding in heavily populated regions with a high mob concentration and quick respawns. It might tick your plugin off a bit.

Nice work on the plugin itself, and I'm sure it's usefull for many people.

Regards, Liquid.

Thanks, appreciate the feedback!

I have a question, lofi, on how this interact with HB. Specifically how does it interact with HB's pull value. Meaning, which takes precedence based on which one is a larger distance (read: If HB is set to 30 and the plugin is 15, which happens where?).

When the CC pulls it uses the pull setting from HB (or it's own setting), and when CombatHelper pulls it uses the plugin setting. You can tell if it's plugin pulling because you will see the "[CombatHelper] Engaging ..." log message. I could integrate this if I figured out how to read the bot settings, but in most cases the default values should work fine.

I haven't tried it with PvP yet, but I've seen the same thing with looting that you do. It won't loot until its entire pull capable list is clear. This isn't an issue until you're in an area like you're talking about. My recommendation is to have it force loot (at least a single loot) once the number of lootable bodies reaches a certain threshold.

I've seen your #4, too. Basically this plugin is VERY aggressive. If *anything* is able to be attacked in the range you specify in the plugin it *will* attack it... No ifs, ands, or buts.

Looting fixed in latest release! Also, fixed chain pulling (the aggressive behavior). Give it a try.


Also included in update: re-start is skipped if Bot is in Questing mode, or inside an instance.

 

[lofi]

Hey wow crashes everytime it restarts hb for some reason i just set the time to 10000min so its no np i guess for me

Hmm I just had it crash as well while re-starting using AB. I think the re-start works fine with GB2. I made a small edit to leave re-start disabled by default in the configurations. I recommend using it only for GB2 and Grind bot.

 

[LiquidAtoR]

Thanks for your reply. When I am gonna grind again I will retry the new release again (that is unless they have a new HB release out before that time).

I was more referring to World PvP (so outside of a battleground). Inside BG's I'm a healer anyways and have no issues.
It's when I'm grinding, a ****horde passes by, seeing that I'm <25% HP and nearly OOM after a fight, and decides he can take me (and only then they can 75% of the time).
If the bot would fight back, I would not have a problem with it, but the bot is not.
And your plugin doesn't include them to the target list either.

So it's outside the BG's, not inside that I have the issue with.

Regards, Liquid.

 

[Xanathos]

Okay, follow-up question.

What would happen if I set the HB pull range to be 5 and the plugin pull range to be 20. Would the plugin start attacking at 20 but then move to be within 5 (as HB also uses the pull range as the "distance" range for ranged attacks) or would the plugin start attacking at 20 and stay at 20?

 

[Jon310]

Thank you for this amazing plugin. It has become one of my must haves for everything.

I have one small issue in pvp. I find that it always targets a players pet before the player. Is there any way you can put an emphasis on the player so that it does not target the pet before actual players.

Thanks again, Jon

 

[Pearl1219]

It keeps trying to attack friendly demolishers in Isle of Conquest.

Says this

[CombatHelper] Assisting party/raid member...
[CombatHelper] Engaging Demolisher from 59 yards...
[CombatHelper] Stopping movement
[CombatHelper] Auto-attacking
[CombatHelper] ERROR: Object reference not set to an instance of an object.. See debug log.

And when I click unit check

[CombatHelper] Checking if Demolisher is a good target...
[CombatHelper] Target is not hostile!
[CombatHelper] Unit is targeting my raid member!

 

[psykik]

+rep
Fantastic profile, has resolved my issues of walking past targets, leaving my pet to die and going afk in combat... Thank you! 1000000% better!!!`

 

[tjwow2011]

It's still targeting pets over players and refuses to stop, it's a great big "look I'm a bot" flag, can you please blacklist all player pets so it does not target them anymore? And yes, I've made the same request on thread for the CC I'm using as well, because HB targets pets instead of players when they are close by no matter what, using this plugin or not using the plugin, so most likely it all needs to be blacklisted somewhere.

 

[Insoo]

Is this working with the latest release of HB?

 

[Roflcake]

Update this pls, was awesome when it worked.

 

[tomei]

One problem with this plugin is that in BGs it will keep targeting the pet and not the enemy player.

 

[Xanathos]

Seems that it only targets a pet when it attacks you, not just generically.

Was useful in one case when I kept nuking this Shaman's totem that was spitting fire at me. =)

 

[moers]

is this working?

 

[Xanathos]

is this working?

Mostly, yes.

 

[azerus]

i stopped to use it, coz it target pet and totem
without it bot never target pet and totem

 

[Xanathos]

I wonder what happened to lofi?

 

[azerus]

it help a lot with simpleCC coz it target faster BUT bad side is IT target pet

 

[lofi]

Added logic to avoid targeting pets in BGs when other good targets are available. Stuck in combat fix should now work regardless of mob level / distance. Also fixed bug in assist logic (could cause it target friendlys). Try the latest release.