[PB] Atomic MoP Shuffle for Jewelcrafting and Enchanting

NiklasNikke · Oct 23, 2013

It might be a problem with PB, indeed yes. You do not have the possibility to test it out yourself? I will try and disable all my addons tommorow, and see if the problem persists. I might also have to post it in the PB thread.

Yes, it is sometimes a bit buggy. It will sometimes skip fetching mail completely and just try and begin crafting stuff. If I restart it a few times it will eventually fetch the mail and work correctly. I really do appreciate you releasing this though, it looks neat. I hope I get it to work 100 % one day.

Megman · Oct 23, 2013

AtomicBomb said:
It is not hard, but it is not easy either if you are not familliar with the code.

Added pretty much all the gem that exist and it worked pretty well. Have not tried to craft em all yet, but so far so good

tyty

AtomicBomb · Oct 24, 2013

NiklasNikke said:
It might be a problem with PB, indeed yes. You do not have the possibility to test it out yourself? I will try and disable all my addons tommorow, and see if the problem persists. I might also have to post it in the PB thread.

Yes, it is sometimes a bit buggy. It will sometimes skip fetching mail completely and just try and begin crafting stuff. If I restart it a few times it will eventually fetch the mail and work correctly. I really do appreciate you releasing this though, it looks neat. I hope I get it to work 100 % one day.

No I'm not able to test this sadly. Read the first paragraph of the thread.

As for the fetching mail, the profile will skip fetching from mailbox (for both JC mats and ore) if there is no new mail. This is something I have fixed with Yemik but I have not updated the profile with the change yet.

NiklasNikke · Oct 24, 2013

AtomicBomb said:
No I'm not able to test this sadly. Read the first paragraph of the thread.

As for the fetching mail, the profile will skip fetching from mailbox if there is no new mail. This is something I have fixed with Yemik but I have not updated the profile with the change yet.

Oh, I am sorry for skipping that part

I'd like to receive that updated profile too, whenever it's ready!

AtomicBomb · Oct 25, 2013

Profile update:

0.720:
- Fixed an issue where the profile would try to fetch filtered ore from Mail.
- Fixed an issue where the profile would try to fetch an ore type from the Guild Bank even if it prevously knew it had no more of that ore.
- Fixed an issue where the profile was fetching the ore and JC material from mail only if the player had new mail.

Just as a general guideline. The profile can only process a certain amount of ore at a time. The amount it can process will vary depending on how many free bag space you have and how many item different item you will craft. In my testing, with 4 x empty Embersilk Bag, I was able to shuffle 1500-2000 ore (potentially 2500+ now with the change I made with the enchanting material being forwarded after every loop) at a time without overflowing the bags with gems and enchanting material. If the bags get overcrowded, issues will show up. This is something I tried to find a solution for when first testing the profile and I came to the conclusion it was a minor inconvenience versus the amount of work it would require to find a workaround.

Also, I might look into adding a barebone framework for those who would like to add their normal enchant recipe in the near future.

NiklasNikke · Oct 25, 2013

I am very thankful for your update, seems to be working pretty good.

I'm very interested in being able to easily add more enchants/gem cuts, especially enchants as these are very limited atm.

TaeTae · Oct 27, 2013

Doesn't buy jeweller's settings

Helitjah · Nov 8, 2013

How can we add some enchants/gems to craft ?
btw very useful profile, thank you

A2dK · Aug 27, 2014

This profile has stopped working since update to HB version 746... anyone having the same problem? any way to fix it?

AtomicBomb · Aug 31, 2014

Fix for latest PB version...

Find this line of code:

Code:

<Declaration Code="public uint RecipeID;" />

and replace it with

Code:

<Declaration Code="public int RecipeID;" />

Sorry for not updating the profile, but WoD is coming soon and I'm currently planning my shuffle profile for WoD with everything I learned from creating, and now testing for 1+ month, this profile.

Digdag · Sep 13, 2014

Thank you so much for making this wonderful profile, AtomicBomb.

I have been looking for a solution to my problems for a while now and you just solved it!

I only wish I could have the enchanter and jewel crafter on separate toons.

joachimb · Oct 13, 2014

I am trying this on my JC, it's awesome.

Thank you !

But my enchanter is another toon, how can I make him forward the stuff to disenchant to this other toon ?
I think this option is missing, I just need to forward the bands, etc. and then I will run your shuffle agin on my enchanter

joachimb · Oct 17, 2014

No one ? Or did I ask something stupid ? ^^"

AtomicBomb · Oct 17, 2014

Sorry joachimb but the profile is not able to mail ornate band or shadofire necklace to another toon.

joachimb · Oct 17, 2014

Is there any way you could maybe make the JC deposit in GB, and the Alch withdraw ornate band and showfire necklaces ?
I have no idea about coding but I will look in this week end if I can figure out how to do it myself copying the coding for the other items

AtomicBomb · Oct 17, 2014

joachimb said:
Is there any way you could maybe make the JC deposit in GB, and the Alch withdraw ornate band and showfire necklaces ?
I have no idea about coding but I will look in this week end if I can figure out how to do it myself copying the coding for the other items

The best way to do it would be to mail it directly to your enchanter. Assuming it's on the same account.

Since WoD is coming, I have no interest in updating or adding stuff to this profile since it will be soon obsolete.
With that said you can try to using code that is already present to work for Shadowfire Necklace/Ornate Band.
First, make sure you activate Mail Rare Shadowfire Necklace/ Rare Ornate Band in the setting then find this block:

Code:

			<If Condition="MailRareOrnateShadowfire" IgnoreCanRun="True">
				<If Condition="InbagCount(90905) &gt; 0 || InbagCount(90904) &gt; 0" IgnoreCanRun="True">
					<If Condition="Me.Name != BankerName &amp;&amp; !string.IsNullOrEmpty(BankerName)" IgnoreCanRun="True">
						<CustomAction Code="CharacterSettings.Instance.MailRecipient = BankerName;" />
						<CustomAction Code="Log(Colors.Azure,&quot;Mailing Rare Ornate Band and Rare Shadowfire Necklace to Banker&quot;);" />
						<WaitAction Condition="false" Timeout="500" />
						<MailItemAction Category="Gem" SubCategoryType="WoWItemGemClass" SubCategory="None" Mail="All" UseCategory="False" ItemID="90904, 90905" Amount="0" AutoFindMailBox="True" Location="0, 0, 0" />
					</If>
				</If>
				<If Condition="!CraftJewellery" IgnoreCanRun="True">
					<CustomAction Code="MailRareOrnateShadowfire = false;" />
				</If>
			</If>

and replace or add to (depending if you still want to send rare jewellery) the Shadowfire Necklace/Ornate Band ID to these line (90905 and 90904 are the rare ID):

Code:

<If Condition="InbagCount(90905) &gt; 0 || InbagCount(90904) &gt; 0" IgnoreCanRun="True">

and

<MailItemAction Category="Gem" SubCategoryType="WoWItemGemClass" SubCategory="None" Mail="All" UseCategory="False" ItemID="90904, 90905" Amount="0" AutoFindMailBox="True" Location="0, 0, 0" />

I have no idea if this will work well with a huge amount of jewellery, but you can try it. Also, with HB 749 ProfessionBuddy is pretty much broken at the moment.

joachimb · Oct 17, 2014

Thank you very much for your help, I will look into it

It's true, WOD is coming ... just when I got every profession to 600, I start understanding mechanisms and they get replaced

jonuts82 · Oct 19, 2014

Won't craft rings or necklaces. Just sits there. Log says:

Code:

[19:34:25.984 N] Crafting [Shadowfire Necklace]
[19:34:26.998 D] PB: Wait for 00:00:01 or until false Completed
[19:34:27.003 N] You are crafting: [Shadowfire Necklace]
[19:34:27.008 D] PB: Casting Shadowfire Necklace, recast :1500
[19:34:26.999 D] Activity: Casting: Shadowfire Necklace
[19:34:29.457 D] PB: Casting Shadowfire Necklace, recast :1500
[19:34:31.903 D] PB: Casting Shadowfire Necklace, recast :1500
[19:34:34.353 D] PB: Casting Shadowfire Necklace, recast :1500
[19:34:36.820 D] PB: Casting Shadowfire Necklace, recast :1500
[19:34:39.255 D] PB: Casting Shadowfire Necklace, recast :1500
[19:34:41.686 D] PB: Casting Shadowfire Necklace, recast :1500
[19:34:43.933 N] (Singular) info: 20 seconds since ProfessionBuddy BotBase last called Singular
[19:34:44.110 D] PB: Casting Shadowfire Necklace, recast :1500
[19:34:46.530 D] PB: Casting Shadowfire Necklace, recast :1500
[19:34:49.020 D] PB: Casting Shadowfire Necklace, recast :1500
[19:34:51.464 D] PB: Casting Shadowfire Necklace, recast :1500
[19:34:53.915 D] PB: Casting Shadowfire Necklace, recast :1500
[19:34:56.359 D] PB: Casting Shadowfire Necklace, recast :1500

joachimb · Oct 19, 2014

Yeah, PB is broken since the update.
He won't withdraw from GB either, i think it's PB related not profile ...

I hope it will be repaired even with MOP coz the gold from selling directly necklaces and bands was nice (no point in disenchanting on my server)

Gatherer · Oct 30, 2014

This is beautiful thank you so much!

[PB] Atomic MoP Shuffle for Jewelcrafting and Enchanting

New Member

Member

Member

New Member

Member

New Member

Member

New Member

New Member

Member

New Member

Member

Member

Member

Member

Member

Member

New Member

Member

New Member