[PB] Atomic MoP Shuffle for Jewelcrafting and Enchanting

[AtomicBomb]

Atomic MoP Shuffle for Jewelcrafting and Enchanting​

I recently lost my accounts and as a result I doubt I will get back to WoW botting anytime soon. I decided to share my private profile in hope that it could be useful to some folks. For this reason I am not able to develop this further but if there is issue I will try to fix it as long as at it doesn't require me to have a WoW account. This profile should not have any major issues but it is a profile I recently created and I didn't have time to thoroughly test it.

This profile does not include all the Gems Cut and Enchants, only the one I needed at the time have been added. If there is Gems Cut or Enchants missing that you need you will have to manually add them. It should not be too hard if you follow the step I did for the other ones.


FEATURES

- It does everything you expect from a JC-ENCH Shuffle: Prospect, Craft/Disenchant Shadowfire/Ornate, Craft Rare Jewellery, Craft Gems, Craft Primal, Craft Sha Crystal and Craft Enchants.
- It also does more: Fetch/Forward Material, JC Research and Conversion of Enchanting Material.
- It craft in a clever way. If you set it to craft 3 Bold Primordial Ruby and 3 Brilliant Primordial Ruby. It will craft 1 Bold Primordial Ruby then 1 Brilliant Primordial Ruby and loop until it have the set amount in bags. Instead of crafting 3 Bold then 3 Brilliant.
- All the set amount are subtracted from the item amount you have in your bags.
- The profile know when it's done and it will stop when it is. If you use HBRelog it will skip the current task.
- You can change the settings directly in the profile. This can be useful if you have multiple bot and you want to globally make change to the settings.

Not implemented: Craft Gems with surplus of Uncommon Gems.


REQUIREMENTS

- Only Dalaran is supported. You can easily add new cities at the bottom of the profile.
- JC and/or ENCH at 600 is highly recommended and make sure you have the recipe for what you are trying to craft because it can cause calculation issue. This is something that is easily fix but I did not have time to implement it.
- If you want to shuffle a huge amount of material I highly recommend to have at a minimum 4 x [Embersilk Bag]


SETTINGS

MODULE (Set to true or false to activate the module you need)

00 - Fetch Material
01 - Prospect Ore
02 - Research
03 - Craft Jewellery
04 - Craft Gems
05 - Craft Primal
06 - Convert Enchanting Mats
07 - Craft Sha Crystal
08 - Craft Enchant
09 - Forward

FETCHING (Set to true or false to activate a material fetching method)

02 - Fetch Ore from Mail
02 - Fetch Ore from Guild Bank
10 - Fetch JC Mats from Mail
12 - Fetch JC Mats from Guild Bank
22 - Fetch ENCH Mats from Guild Bank

PROSPECT (Set to true or false to activate prospecting for the specified ore)

11 - Prospect: Ghost Iron
12 - Prospect: Kyparite
13 - Prospect: Black Trillium
14 - Prospect: White Trillium

RESEARCH

(Set the amount of research to craft)
00 - Research: Secrets of the Stone

(Set to true or false to activate a research)
01 - Research: Serpent's Heart
10 - Research: Imperial Amethyst
11 - Research: Primordial Ruby
12 - Research: River's Heart
13 - Research: Sun's Radiance
14 - Research: Vermilion Onyx
15 - Research: Wild Jade

CRAFT JEWELLERY

(Set the amount of item to craft) * The amount is subtracted from the amount of item you have in your bags.
11 - Craft: Roguestone Shadowband
11 - Craft: Skymage Circle
11 - Craft: Tiger Opal Pendant
11 - Craft: Widow Chain
11 - Craft: Reflection of the Sea
11 - Craft: Lord's Signet
11 - Craft: Lionsfall Ring
11 - Craft: Heart of the Earth
11 - Craft: Golembreaker Amulet
11 - Craft: Band of Blood

(Set to true or false to activate)
12 - Craft: Ornate Band
12 - Craft: Shadowfire Necklace
13 - Disenchant: Ornate Band
13 - Disenchant: Ornate Band Rare
13 - Disenchant: Shadowfire Necklace
13 - Disenchant: Shadowfire Necklace Rare
14 - Vendor: Ornate Band
14 - Vendor: Ornate Band Rare
14 - Vendor: Shadowfire Necklace
14 - Vendor: Shadowfire Necklace Rare

CRAFT GEMS (Set the amount of item to craft) * The amount is subtracted from the amount of item you have in your bags.

00 - Craft: Bold Primordial Ruby
00 - Craft: Delicate Primordial Ruby
00 - Craft: Brilliant Primordial Ruby
01 - Craft: Fractured Sun's Radiance
01 - Craft: Quick Sun's Radiance
01 - Craft: Smooth Sun's Radiance
02 - Craft: Sparkling River's Heart
02 - Craft: Solid River's Heart
03 - Craft: Purified Imperial Amethyst
03 - Craft: Veiled Imperial Amethyst
03 - Craft: Glinting Imperial Amethyst
04 - Craft: Lightning Wild Jade
04 - Craft: Piercing Wild Jade
04 - Craft: Energized Wild Jade
05 - Craft: Reckless Vermilion Onyx
05 - Craft: Artful Vermilion Onyx
05 - Craft: Fierce Vermilion Onyx
05 - Craft: Deadly Vermilion Onyx
05 - Craft: Potent Vermilion Onyx

CRAFT PRIMAL (Set the amount of item to craft) * The amount is subtracted from the amount of item you have in your bags.

00 - Craft: Burning Primal Diamond
00 - Craft: Agile Primal Diamond
00 - Craft: Reverberating Primal Diamond
00 - Craft: Revitalizing Primal Diamond
00 - Craft: Austere Primal Diamond

CONVERT ENCHANTING MATERIAL

(Set the percentage of material you want converted)
00 - [%] Convert Spirit Dust
00 - [%] Convert Mysterious Essence

(Set to true to convert material until it have enough to craft Sha Crystal)
01 - Convert for Sha Crystal

CRAFT ENCHANTS

(Set the amount of Sha Crystal needed inbag to activate crafting of enchant relying on Sha Crystal)
00 - Sha Crystal Threshold

(Set the amount of item to craft) * The amount is subtracted from the amount of item you have in your bags
01 - Craft: Enchant Weapon - Jade Spirit
01 - Craft: Enchant Weapon - Dancing Steel
01 - Craft: Enchant Bracer - Super Intellect
01 - Craft: Enchant Bracer - Greater Agility
01 - Craft: Enchant Bracer - Exceptional Strength

FORWARDING

(Set your characters name)
00 - Banker Name
00 - Alchemist Name

(Set to true or false to activate a forwarding method)
01 - Mail to Alchemist: Primal Diamond Material *
02 - Mail to Banker: Rare Jewellery
02 - Mail to Banker: Rare Ornate and Shadowfire
02 - Mail to Banker: Gems Cut
02 - Mail to Banker: Gems Remains
02 - Mail to Banker: Primal Cut
02 - Mail to Banker: Primal Remains
02 - Mail to Banker: Serpent's Eye Remains
03 - Mail to Banker: Enchanting Material
03 - Mail to Banker: Sha Crystal

* The amount of Primal Diamond Material sent is "rounded". If you have 5 Vermilion, 7 Wild Jade and 13 Imperial Amethyst. It will mail 4 Vermilion, 4 Wild Jade, 4 Imperial Amethyst.


KNOWN ISSUES

Just as a general guideline. The profile can only process a certain amount of ore at a time. The amount it can process will vary depending on how many free bag space you have and how many item different item you will craft. In my testing, with 4 x empty Embersilk Bag, I was able to shuffle 1500-2000 ore (potentially 2500+ now with the change I made with the enchanting material being forwarded after every loop) at a time without overflowing the bags with gems and enchanting material. If the bags get overcrowded, issues will show up.

This is something I tried to find a solution for when testing the profile and I came to the conclusion it was a minor inconvenience versus the amount of work it would require to find a workaround.

DOWNLOAD

View attachment Atomic MoP Shuffle Jewelcrafting-Enchanting 0.720.zip

SVN Link


CHANGE LOG

Spoiler

0.720:
- Fixed an issue where the profile would try to fetch filtered ore from Mail.
- Fixed an issue where the profile would try to fetch an ore type from Guild Bank even if it prevously knew it had no more of that ore.
- Fixed an issue where the profile was fetching the ore and JC material from mail only if the player had new mail.

0.715:
- Added the ability to fetch Ore from mail.
- Fixed a potential issue with fetching from mail without having mail in the mailbox. It would cause an infinite loop.

0.712:
- Fixed error with Mailing Rare Ornate Band and Shadowfire Necklace settings.

0.711:
- Fixed error related to ShaCrystalThreshold.

0.710:
- Fixed red error
- Tweaked minor stuff
- Added settings to disenchant or not rare ornate band and rare shadowfire necklace
- Added the ability to vendor uncommon and/or rare for ornate band and shadowfire necklace
- Added the ability to forward the rare ornate band and rare shadowfire necklace

0.705:
- Added a new method for Gbank coords. If this one doesn't work there is the old updated one commented out.
- Sha Crystal Threshold have been redone and should work.
- [10 - Fetch JC Mats from Mail] was implemented.
- Misc minor fix.

0.701:
- Forgot to comment out unused Fetching method.

---

If this profile have been useful to you please consider buying me some much needed coffee (preferably dark roast ).

 

[divinerock]

Profile dont walk from JC vendor to Bank, it's just mount up and stands. Solved this by changing Guild Bank cords, then profile worked like a charm.
Great work, thanks ♥

 

[theatristformallyknownasG]

Interesting, will try when I get back from holidays

G

 

[AtomicBomb]

Profile dont walk from JC vendor to Bank, it's just mount up and stands. Solved this by changing Guild Bank cords, then profile worked like a charm.
Great work, thanks ♥

Thanks for letting me know about the Bank coords. I had to change how the profile navigated around at last minute since the method I was using was broke with latest HB (or just PB?) version. After the changes, I remember the bank coords not working but I was not sure if I fixed it or not. If you can paste your MoveToGbank subroutine, I will add it.

Let me know if you guys have any feedback or come across more issues.

 

[zakanator]

Here's a list of guild bank co-ordinates that I use for my profile
<If Condition="Me.MapId == 0" IgnoreCanRun="True">
<!--Undercity-->
<If Condition="Me.ZoneId == 1497" IgnoreCanRun="True">
<!--Trade Quarters Northern Guild Bank-->
<CustomAction Code="GBankLocations.Add(new WoWPoint(1603.914, 248.4631, -51.2896));" />
<!--Trade Quarters Western Guild Bank-->
<CustomAction Code="GBankLocations.Add(new WoWPoint(1587.67, 248.6573, -51.2757));" />
<!--Trade Quarters Eastern Guild Bank-->
<CustomAction Code="GBankLocations.Add(new WoWPoint(1603.5, 231.7855, -51.27944));" />
<!--Trade Quarters Southern Guild Bank-->
<CustomAction Code="GBankLocations.Add(new WoWPoint(1587.577, 232.0571, -51.27575));" />
</If>
<!--Stormwind-->
<If Condition="Me.ZoneId == 1519" IgnoreCanRun="True">
<!--Trade District Guild Bank-->
<CustomAction Code="GBankLocations.Add(new WoWPoint(-8920.106, 621.256, 100.226));" />
<!--Dwarven District Guild Bank-->
<CustomAction Code="GBankLocations.Add(new WoWPoint(-8315.161, 582.8967, 100.3132));" />
</If>
<!--Ironforge-->
<If Condition="Me.ZoneId == 1537" IgnoreCanRun="True">
<!--The Commons Guild Bank-->
<CustomAction Code="GBankLocations.Add(new WoWPoint(-4887.285, -977.4463, 503.9403));" />
</If>
</If>
<If Condition="Me.MapId == 1" IgnoreCanRun="True">
<!--Orgrimmar-->
<If Condition="Me.ZoneId == 1637" IgnoreCanRun="True">
<!--Valley of Strength Guild Bank-->
<CustomAction Code="GBankLocations.Add(new WoWPoint(1533.167, -4362.145, 20.54772));" />
<!--Valley of Honor Guild Bank-->
<CustomAction Code="GBankLocations.Add(new WoWPoint(1886.409, -4683.326, 38.5004));" />
<!--Valley of Wisdom Guild Bank-->
<CustomAction Code="GBankLocations.Add(new WoWPoint(1951.516, -4216.525, 37.19798));" />
<!--Goblin Slums Guild Bank-->
<CustomAction Code="GBankLocations.Add(new WoWPoint(1573.427, -4172.664, 51.74817));" />
</If>
<!--Thunder Bluff-->
<If Condition="Me.ZoneId == 1638" IgnoreCanRun="True">
<!--Lower Rise Guild Bank-->
<CustomAction Code="GBankLocations.Add(new WoWPoint(-1257.805, 64.37354, 127.6252));" />
</If>
<!--Darnassus-->
<If Condition="Me.ZoneId == 1657" IgnoreCanRun="True">
<!--Temple Gardens Guild Bank-->
<CustomAction Code="GBankLocations.Add(new WoWPoint(9935.946, 2517.147, 1318.54));" />
</If>
</If>
<!--Silvermoon-->
<If Condition="Me.ZoneId == 3487" IgnoreCanRun="True">
<!--Bazaar Guild Bank-->
<CustomAction Code="GBankLocations.Add(new WoWPoint(9525.154, -7223.089, 17.4742));" />
<!--Royal Exchange Guild Bank-->
<CustomAction Code="GBankLocations.Add(new WoWPoint(9810.221, -7488.104, 14.53273));" />
</If>
<!--The Exodar-->
<If Condition="Me.ZoneId == 3557" IgnoreCanRun="True">
<!--Central Hub Guild Bank-->
<CustomAction Code="GBankLocations.Add(new WoWPoint(-3909.753, -11548.94, -149.9568));" />
</If>
<!--Dalaran-->
<If Condition="Me.ZoneId == 4395" IgnoreCanRun="True">
<!--North Guild Bank-->
<CustomAction Code="GBankLocations.Add(new WoWPoint(5961.328, 616.5127, 650.6276));" />
<!--South Guild Bank-->
<CustomAction Code="GBankLocations.Add(new WoWPoint(5651.325, 682.1651, 651.9932));" />
</If>

 

[divinerock]

Thanks for letting me know about the Bank coords. I had to change how the profile navigated around at last minute since the method I was using was broke with latest HB (or just PB?) version. After the changes, I remember the bank coords not working but I was not sure if I fixed it or not. If you can paste your MoveToGbank subroutine, I will add it.

Let me know if you guys have any feedback or come across more issues.

  <SubRoutine SubRoutineName="MoveToGbank">
    <Declaration Code="List&lt;WoWPoint&gt; GBankLocations = new List&lt;WoWPoint&gt;();" />
    <Declaration Code="WoWPoint GbankLocation;" />
    <CustomAction Code="GBankLocations.Clear();" />
    <CustomAction Code="GbankLocation = WoWPoint.Zero;" />
    <!-- Dalaran -->
    <While Condition="Me.ZoneId == 4395 &amp;&amp; DistanceTo(5981.751, 608.2755, 650.6271) &gt; 55" IgnoreCanRun="True">
      <MoveToAction Location="5960.406, 596.5264, 650.627" MoveType="Location" Pathing="Navigator" Entry="0" />
    </While>
    <WaitAction Condition="false" Timeout="500" />
  </SubRoutine>

 

[AtomicBomb]

Here's a list of guild bank co-ordinates that I use for my profile

The WoWPoint coordinate is how I used to do it until it stopped working for me after either a HB or PB update. The issue I had was when moving to the jewelcrafting shop. Once it reached the destination it just idled there and it would not buy jeweller's setting from the vendor. I had to move my toon away from the WoWPoint to make the profile continue and buy stuff from the vendor. It's why I relied back on the old MoveTo, it's not ideal but this way I know it won't break for sure.

@divinerock
Thanks, I will add it tomorrow probably.

 

[zakanator]

Why are you using a subroutine to move to the vendors? BuyItemAction will automatically navigate to the vendor location.

 

[AtomicBomb]

Updated the profile:

Added my old Gbank coordinate and left the old updated one commented in case it doesn't work but I don't see why it wouldn't work.
Fully implemented fetching jewelcrafting material from mail. Apparently It was not finished.
Re-done Sha Crystal threshold.

As for the rare jewellery not mailing. Are you talking about the Band of Blood, Lord's Signet, etc... or the rare Ornate Band/Shadowfire Necklace? The profile will not mail the rare Ornate/Shadowfire.
If it's the Band of Blood, Lord's Signet, etc... I took a look at the code and it's seems fine but hard to know for sure. If you can upload a log of the profile full crafting process to pastebin.com I will take a look at it.

Also you can try with only Craft Jewellery, Forward and Forward Rare Jewellery activated.

 

[AtomicBomb]

I meant Ornate Band/Shadowfire Necklace so the code should be fine. Why not mailing Ornate Band/Shadowfire Necklace tho?

This is not something I needed at the time of the profile creation. Rare Ornate/Shadowfire was my source of Ethereal Shard so I always disenchanted them.
It is possible to add this but I'm afraid it would require several changes, and since I can't test, it could lead to new issues showing up.

 

[tsatsa]

Does it allows to sell all jewelry to the vendor? All, or just greens

 

[AtomicBomb]

Does it allows to sell all jewelry to the vendor? All, or just greens

There is no jewellery selling support. Only disenchant for Ornate/Shadowfire.

 

[AtomicBomb]

Could u make disenchanting blue ornate ring/shadowfire necklace choosable(maybe sending them too)? DE value for this item is less then 50g when market value is over 100g.

If you shuffle a ridiculous amount of material daily, I doubt the Ornate/Shadowfire would sell fast enough to be worth it. But in small amount I understand it could be worth more.

Find and delete these line to disable disenchanting rare Ornate/Shadowfire. Eventually, I'll add a setting to turn on/off disenchant of blue Ornate/Shadowfire because it will be easy to do.
I'll add rare Ornate/Shadowfire mailling and uncomnmon jewellery vendoring if it doesn't require too many changes.

<CallSubRoutine SubRoutineName="DisenchantRare" />

 

[everblue]

some kind of error when i try to load the profile. something like cannot contain "--" or whatever. I guess i'm the only one this is happening to? I've used a fresh copy of HB, so i'm at a loss

 

[dmalt]

Open it up in something like Notepad ++ which gives line numbers. Find the line number it's referring to which is a commented out sub routine and add --> to the line above it ad it's missing a comment ending.

Other than that for me once it's loaded I get this repeatedly spammed in the log and it doesn't move:

System.NullReferenceException: Object reference not set to an instance of an object.
at Bots.Gatherbuddy.GatherbuddyBot.(Object )
at Styx.TreeSharp.Decorator.CanRun(Object context)
at Styx.TreeSharp.Decorator.
.
()
at Styx.TreeSharp.Composite.Tick(Object context)
at Styx.TreeSharp.PrioritySelector.
.
()
at Styx.TreeSharp.Composite.Tick(Object context)
at Styx.TreeSharp.PrioritySelector.
.
()
at Styx.TreeSharp.Composite.Tick(Object context)
at Styx.CommonBot.TreeRoot.()
Cleared POI - Reason Exception in Root.Tick()
Cleared POI

Any ideas?

 

[AtomicBomb]

Profile update:

Thanks for reporting that red error. It was an issue related to me commenting out the old MoveToGbank subroutine. I just removed it assuming the new one work just fine.
Along with fixing that embarassing red error, I added:

- Settings to activate disenchant for rare Ornate Band and Shadowfire Necklace.
- Vendoring rare and/or uncommon Ornate Band and Shadowfire Necklace.
- Mailling Rare Ornate Band and Rare Shadowfire Necklace to banker.

Just so you guys know, there is a chance that I will create red error every time I update the profile but I am extremely careful and try to avoid this.

 

[Megapowen]

Do i need setup anything or just start it?

 

[AtomicBomb]

Do i need setup anything or just start it?

You need to set the settings because, at default, everything is either at false or 0.

 

[AtomicBomb]

Updated a mom ago and this is what i get.


Err: While (!StopLoop && Me.FreeNormalBagSlots > 0 && (ShaCrystalThreshold && (WeaponJadeSpirit > 0 || WeaponDancingSteel > 0 || BracerSuperIntellect > 0 || BracerGreaterAgility > 0 || BracerExceptionalStrength > 0)))
Compile Error : Operator '&&' cannot be applied to operands of type 'int' and 'bool'

Err: If ((!ShaCrystalThreshold && (WeaponJadeSpirit > 0 || WeaponDancingSteel > 0 || BracerSuperIntellect > 0 || BracerGreaterAgility > 0 || BracerExceptionalStrength > 0)) || (WeaponJadeSpirit < 1 && WeaponDancingSteel < 1 && BracerSuperIntellect < 1 && BracerGreaterAgility < 1 && BracerExceptionalStrength < 1))
Compile Error : Operator '!' cannot be applied to operand of type 'int'

Err: Custom Action if (SettingShaCrystalThreshold > 0) { if (SettingShaCrystalThreshold >= InbagCount(74248)) { ShaCrystalThreshold = true; } else { ShaCrystalThreshold = false; } } else { ShaCrystalThreshold = true; } )
Compile Error : Cannot implicitly convert type 'bool' to 'int'

Thanks for the report Yemik.

ShaCrystalThreshold was set as a "int" while it should have been a "bool". I updated the profile to fix this.

 

[AtomicBomb]

After the update: (i dont have this option chosen)

Err: Custom ActionMailRareOrnateShadowfire = (bool)Settings["02 - Mail to Banker: Rare Ornate/Shadowfire"]
System.NullReferenceException: Object reference not set to an instance of an object.
at CodeDriver.Code562896585(Object context)
at HighVoltz.Composites.CustomAction.Run(Object context) in e:\HB\HB\Bots\Professionbuddy\Composites\CustomAction.cs:line 70


and it still has a problem with fetching JC materials from mail for me.

and btw how many stacks of ore u shuffle per day?

Fixed the red error in 0.712.
For the fetching JC material from mail: It will only try to fecth material if one of those settings are activated: Research or CraftJewellery or CraftGems or CraftPrimal. Also you need 8+ free bags slot.
If those conditions are met then the problem could be the code itself but after looking at it I did not find anything weird going on. Hard to say.

Well the biggest shuffle I did with this profile was 2k ghost iron ore. With that amount of ore, if you don't forward the enchanting mats your bags will eventually get full.
It should be able to handle +/- 1k ore. A lot more if you enable enchanting mats forwarding and it's working as expected (mailing everytime it's done disenchanting and/or converting)