What's new
By:
  • Visit Rebornbuddy
  • Visit Panda Profiles
  • Visit LLamamMagic
  • Visit Resources
  • Visit Downloads
  • Visit Portal
RebornBuddy Forums

Register a free account today to become a member! Once signed in, you'll be able to participate on this site by adding your own topics and posts, as well as connect with other members through your own private inbox!

[Orderbot] [Plugin] [Fish v3.0+] and profiles support thread

guppysb said:
Loving the tag setup Matt, thanks for the hard work.

However, I think I found a small bug. When it is selecting bait, it cycles through all the baits and selects all of them until it finds the correct bait. Also, if the currently selected bait is the correct bait, it'll still cycle, not a big deal. The real problem comes when you have bait/lure in your inventory that is a higher level than your fisher. It'll try to select it, but since your level is too low, you won't be able to. And so, it's stuck in this infinite loop of trying to select that bait in order to move onto the next bait. Let me know if I am doing something wrong on my end.
Click to expand...

It doesn't know, unfortunately what bait you already have selected. So it has to loop for now.

I did run into the issue of bait level while testing and thought I had fixed it..but now both of my fishers are at 60... =(. It should, attempt to click it and continue, but I might have messed that up when fixing other issues. I will see if i can logically fix the bug without being able to actually test and push it up.
 
ExMatt said:
It doesn't know, unfortunately what bait you already have selected. So it has to loop for now.

I did run into the issue of bait level while testing and thought I had fixed it..but now both of my fishers are at 60... =(. It should, attempt to click it and continue, but I might have messed that up when fixing other issues. I will see if i can logically fix the bug without being able to actually test and push it up.
Click to expand...

Thanks for the quick reply Matt. I deal with C# for a living, but haven't had the chance to start debugging RebornBuddy stuff yet. Maybe later on tonight I'll take a look at the code and see what I can come up with.
 
guppysb said:
Loving the tag setup Matt, thanks for the hard work.

However, I think I found a small bug. When it is selecting bait, it cycles through all the baits and selects all of them until it finds the correct bait. Also, if the currently selected bait is the correct bait, it'll still cycle, not a big deal. The real problem comes when you have bait/lure in your inventory that is a higher level than your fisher. It'll try to select it, but since your level is too low, you won't be able to. And so, it's stuck in this infinite loop of trying to select that bait in order to move onto the next bait. Let me know if I am doing something wrong on my end.
Click to expand...

Pretty sure it cycles because it reads chat, so it has to cycle through them, it can't tell what you currently have selected, you could make this much faster by having less types of bait and lures in your inventory, same goes for bait you can't use, why are you carrying that around anyways ?:P
 
tishat said:
Pretty sure it cycles because it reads chat, so it has to cycle through them, it can't tell what you currently have selected, you could make this much faster by having less types of bait and lures in your inventory, same goes for bait you can't use, why are you carrying that around anyways ?:P
Click to expand...

Just finished level 20 fishing quest as 20 fisherman, guy gave me level 22 lures :P
 
I have pushed an update to my git with better code for selecting bait (still currently needs keybinds), but no longer needs to read from the chatlog, so it can select bait much quicker... and skips it if you have the proper bait selected. I am no longer suggesting to just use the zip file attached to the OP. If you don't use Git or SVN, you can download the files from github as a zip.

https://github.com/MGramolini/ExBuddy

Reply if you need help or PM me.
 
Eyeball said:
Hi Matt,

Just tried to load this plugin as specified in first post. Here's a log with the error I'm getting.

View attachment 187611


I then load a profile and hit start to which it does nothing.
Click to expand...


You are correct..sorry about that...I am no longer supporting Fish by itself, but the ExBuddy project as a whole. I have updated the post. Please pull the whole orderbot tags project.
 
lorolo said:
Bot seems to hang when trying to fish Illuminati Perch using Priority Pirira, Scrips farm profile.

https://drive.google.com/file/d/0B1zmfHgj9lP5eGxHazdnc1V6WEk/view?usp=sharing is the log of the error.
Click to expand...

That error is an issue that I see from time to time that I don't have any control over. For some reason the bot will throw an error trying to get the state of the enum for FishingState. Restarting the bot fixes it. I most commonly saw this myself when switching between my characters without restarting the bot.

Let me know if you run into any other issues.
 
Hi sorry to be a pain, ive installed the plugin via SVN and nothing new has appeared. apart from skywatcher and enableflight. The options for fishing itself is still the same as without, and the option to select bait is still the same as before.
anyone mind explaining this alittle to me, im probably missing something so obvious.
Thanks.
 
Yambo99 said:
Hi sorry to be a pain, ive installed the plugin via SVN and nothing new has appeared. apart from skywatcher and enableflight. The options for fishing itself is still the same as without, and the option to select bait is still the same as before.
anyone mind explaining this alittle to me, im probably missing something so obvious.
Thanks.
Click to expand...

I haven't updated the documentation really..but here are some new things you can now do.

Code: 
        <Baits>
          <Bait name="Stonefly Nymph" condition="Core.Player.HasAura(850)"/>
		  <Bait name="Goblin Jig"/>
        </Baits>
        <Collectables>
			<Collectable name="Illuminati Perch" value="826" />
        </Collectables>

Conditional or backup baits, and the ability to collect more than one fish per fishing area at different collectable values (sometimes comes in handy)
 
Hmm,
I goofed up somewhere. The code below purchased 2 vials of hi-cordial. I was expecting 3? Giant Crane Fly baits. What'd I mess up? :) Is that 3 in ShopPurchaseCount the place number of item in the list or something? I'll have to look at that, maybe that's it. If it is, I need more coffee.


Code: 
<!DOCTYPE Profile [
	<!ENTITY Location "Idyllshire">
	
		<!ENTITY ShopPurchase3 "CraneFly">
			<!ENTITY ShopPurchase3_Count "3">
]>



Code: 
	<TurnInCollectables location="&Location;" forcePurchase="false">
					<Collectables>
					<CollectableTurnIn name="Illuminati Perch" value="826" />
					</Collectables>
				    <ShopPurchases>
						<If condition="not HasAtLeast(12712,99)">
							<ShopPurchase shopItem="&ShopPurchase3;" maxCount="&ShopPurchase3_Count;"/>
						</If>
					</ShopPurchases>   
				</TurnInCollectables>
 
Last edited:
Any chance the public enum ShopItem ID is wrong , that does look correct, I have not used any haveAtleast qualifiers though with that tag, so not entirely sure.
 
Facepalm.

So, It works fine without the quantity check.

My only worry was ending up with not enough or too many baits, but the answer was already baked in. Just tell it to buy 150 and it does the math. Nice one ExMatt :) Trying to make it hard when you made it easy.
 
Last edited:
Calleil said:
Hmm,
I goofed up somewhere. The code below purchased 2 vials of hi-cordial. I was expecting 3? Giant Crane Fly baits. What'd I mess up? :) Is that 3 in ShopPurchaseCount the place number of item in the list or something? I'll have to look at that, maybe that's it. If it is, I need more coffee.


Code: 
<!DOCTYPE Profile [
	<!ENTITY Location "Idyllshire">
	
		<!ENTITY ShopPurchase3 "CraneFly">
			<!ENTITY ShopPurchase3_Count "3">
]>



Code: 
	<TurnInCollectables location="&Location;" forcePurchase="false">
					<Collectables>
					<CollectableTurnIn name="Illuminati Perch" value="826" />
					</Collectables>
				    <ShopPurchases>
						<If condition="not HasAtLeast(12712,99)">
							<ShopPurchase shopItem="&ShopPurchase3;" maxCount="&ShopPurchase3_Count;"/>
						</If>
					</ShopPurchases>   
				</TurnInCollectables>
Click to expand...

You can't do If tags around xml that is not a profile behavior FYI it just ignores it.
 
Calleil said:
Facepalm.

So, It works fine without the quantity check.

My only worry was ending up with not enough or too many baits, but the answer was already baked in. Just tell it to buy 150 and it does the math. Nice one ExMatt :) Trying to make it hard when you made it easy.
Click to expand...

Yea, its not really a buy count, more of an max inventory count that if you have that much it won't buy any more.
 
Sorry I haven't got around to releasing lots of public documentation for these tags... its just that I have so much I want to release! and so little time. (well... i do have time but a3s takes up a lot of it).
 
That sounds like you have ExBuddy installed wrong. I have seen this happen a few times before. From your startup it doesn't look like you have any duplicates, so that probably isn't the issue.
I am able to run the profile as is both of my friends that test for me.

Are you using SVN or git to pull the project or copying from a zip folder? Would you mind showing me your folders? You can go to command line and browse to your plugins folder and type tree..

ex. C:\Users\Name\RB\Plugins>tree

right-click > Mark
select the text and right click to copy. paste

├───ExBuddy
│ ├───Agents
│ ├───Attributes
│ ├───Data
│ ├───Enumerations
│ ├───Helpers
│ ├───Interfaces
│ ├───Logging
│ ├───Navigation
│ ├───OrderBotTags
│ │ ├───Behaviors
│ │ │ ├───Examples
│ │ │ └───Objects
│ │ ├───Fish
│ │ │ └───Examples
│ │ ├───Gather
│ │ │ ├───Examples
│ │ │ │ └───Transform
│ │ │ ├───GatherSpots
│ │ │ ├───Prototype
│ │ │ │ └───Profiles
│ │ │ └───Rotations
│ │ ├───Objects
│ │ └───Schema
│ ├───Plugins
│ │ ├───EnableFlight
│ │ ├───RetainerMaid
│ │ └───Skywatcher
│ ├───Properties
│ ├───Providers
│ └───Windows
 
You must log in or register to reply here.
Back
Top