What's new
  • Visit Rebornbuddy
  • Visit Panda Profiles
  • Visit LLamamMagic
  • Visit Resources
  • Visit Downloads
  • Visit Portal
RebornBuddy Forums

Register a free account today to become a member! Once signed in, you'll be able to participate on this site by adding your own topics and posts, as well as connect with other members through your own private inbox!

Magitek - All In One - Still going strong!

Status
Not open for further replies.
Tested and Dragoon still does the same thing although not everytime. It's more like every other time.
 
Now Magitek isn't working for me at all. I don't know why. I'll post a log.

It's just running to the fate and stops.I'll post a log. View attachment 144261

[07:31:43.877 D] System.ArgumentNullException: Value cannot be null.
Parameter name: key
at System.Collections.Generic.Dictionary`2.FindEntry(TKey key)
at System.Collections.Generic.Dictionary`2.TryGetValue(TKey key, TValue& value)
at ff14bot.Helpers.MultiKeyDictionary`3.TryGetValue(L subKey, V& val)
at ff14bot.Helpers.MultiKeyDictionary`3.ContainsKey(L subKey)
at ff14bot.Managers.Actionmanager.HasSpell(String spellName)
at Magitek.Helpers.Casting.<>c__DisplayClass3.<Cast>b__0(Object ret) in c:\Users\Darryl\Desktop\X-Files\RebornBuddy\Routines\Magitek\Helpers\Casting.cs:line 20
at TreeSharp.Decorator.CanRun(Object context)
at TreeSharp.Decorator.<Execute>d__0.MoveNext()
at TreeSharp.Composite.Tick(Object context)
at TreeSharp.PrioritySelector.<Execute>d__0.MoveNext()
at TreeSharp.Composite.Tick(Object context)
at TreeSharp.Decorator.<Execute>d__0.MoveNext()
at TreeSharp.Composite.Tick(Object context)
at TreeSharp.PrioritySelector.<Execute>d__0.MoveNext()
at TreeSharp.Composite.Tick(Object context)
at TreeSharp.PrioritySelector.<Execute>d__0.MoveNext()
at TreeSharp.Composite.Tick(Object context)
at ff14bot.Behavior.HookExecutor.Run(Object context)
at TreeSharp.Action.RunAction(Object context)
at TreeSharp.Action.<Execute>d__0.MoveNext()
at TreeSharp.Composite.Tick(Object context)
at TreeSharp.Decorator.<Execute>d__0.MoveNext()
at TreeSharp.Composite.Tick(Object context)
at TreeSharp.PrioritySelector.<Execute>d__0.MoveNext()
at TreeSharp.Composite.Tick(Object context)
at TreeSharp.Decorator.<Execute>d__0.MoveNext()
at TreeSharp.Composite.Tick(Object context)
at TreeSharp.PrioritySelector.<Execute>d__0.MoveNext()
at TreeSharp.Composite.Tick(Object context)
at TreeSharp.Decorator.<Execute>d__0.MoveNext()
at TreeSharp.Composite.Tick(Object context)
at TreeSharp.PrioritySelector.<Execute>d__0.MoveNext()
at TreeSharp.Composite.Tick(Object context)
at ff14bot.TreeRoot.()

The above is what is causing your problem.

Code:
public static Composite Cast(Selection<string> spell, Selection<bool> reqs = null, Selection<GameObject> onTarget = null, Selection<int> nonspam = null, Selection<bool> doublecast = null)
        {
            return new Decorator(ret =>
            {
              [B]if (!Actionmanager.HasSpell(spell(ret)))[/B]
                    return false;

The bolded line above is exactly where it is dieing at. This tells me that at some point, null is being passed in for "spell". Need to check the Dragoon.cs file in the Rotations to see if there's a typo or something.
 
Now Magitek isn't working for me at all. I don't know why. I'll post a log.

It's just running to the fate and stops.I'll post a log. View attachment 144261

Not really sure what could have caused this besides setting the pull range way longer than that is actually possible, and I wasn't able to reproduce it actually running fates, but I've made a change that should make it not happen anymore. Note that the pull range box in the dragoon job settings actually does something now, so don't go setting it any higher than like 14 since piercing talon maxes out at 15.
 
Updated: Should fix an issue where no acceptable skill could be used while fate botting.
 
Testing now, and I adjusted Piercing Talon. Seems to be working well but I just started.

I have a suggestion if it's possible. The ability to change your Chocobo Companion stance say from Healer to DPS based on HP%. I'm not sure if this is a request for Magitek or better for a plugin. I apologize in advance.
 
Just had an issue with me arriving at a FATE and it just sitting there on the Chocobo not engaging anything. May be a FATEbot issue after update though.
 
[17:24:32.761 D] System.NullReferenceException: Object reference not set to an instance of an object.
at Magitek.Helpers.Combat.CheckForInterrupt() in e:\Addons\FF XIV\Reborn buddy\Routines\Magitek\Helpers\Combat.cs:line 84
at Magitek.Rotations.Bard.<CreateCombatBuffs>b__3(Object r) in e:\Addons\FF XIV\Reborn buddy\Routines\Magitek\Rotations\Bard.cs:line 51
at Magitek.Helpers.Casting.<>c__DisplayClass3.<Cast>b__0(Object ret) in e:\Addons\FF XIV\Reborn buddy\Routines\Magitek\Helpers\Casting.cs:line 23
at TreeSharp.Decorator.CanRun(Object context)
at TreeSharp.Decorator.<Execute>d__0.MoveNext()
at TreeSharp.Composite.Tick(Object context)
at TreeSharp.PrioritySelector.<Execute>d__0.MoveNext()
at TreeSharp.Composite.Tick(Object context)
at TreeSharp.PrioritySelector.<Execute>d__0.MoveNext()
at TreeSharp.Composite.Tick(Object context)
at TreeSharp.Decorator.<Execute>d__0.MoveNext()
at TreeSharp.Composite.Tick(Object context)
at TreeSharp.PrioritySelector.<Execute>d__0.MoveNext()
at TreeSharp.Composite.Tick(Object context)
at TreeSharp.PrioritySelector.<Execute>d__0.MoveNext()
at TreeSharp.Composite.Tick(Object context)
at ff14bot.TreeRoot.()

Interrupt error again
pls fix it.
 
Odd, piercing talon has always been 40 by default for me.
That's because that pull range box wasn't actually being used but it is now. If you set it further than any ability can reach, that will happen with every class.
 
Hi Ichiba! Thanks for the fix. Can I request that you put the current Revision in your first post, for players using your SVN update, so we can stay up to date and revise.
 
Update : Fixed null reference error when trying to interrupt.
Thank you!

++
i tested. still not work.

[11:33:20.366 D] System.NullReferenceException: Object reference not set to an instance of an object.
at Magitek.Helpers.Combat.CheckForInterrupt() in e:\Addons\FF XIV\Reborn buddy\Routines\Magitek\Helpers\Combat.cs:line 84
at Magitek.Rotations.Bard.<CreateCombatBuffs>b__3(Object r) in e:\Addons\FF XIV\Reborn buddy\Routines\Magitek\Rotations\Bard.cs:line 51
at Magitek.Helpers.Casting.<>c__DisplayClass3.<Cast>b__0(Object ret) in e:\Addons\FF XIV\Reborn buddy\Routines\Magitek\Helpers\Casting.cs:line 23
at TreeSharp.Decorator.CanRun(Object context)
at TreeSharp.Decorator.<Execute>d__0.MoveNext()
at TreeSharp.Composite.Tick(Object context)
at TreeSharp.PrioritySelector.<Execute>d__0.MoveNext()
at TreeSharp.Composite.Tick(Object context)
at TreeSharp.PrioritySelector.<Execute>d__0.MoveNext()
at TreeSharp.Composite.Tick(Object context)
at TreeSharp.Decorator.<Execute>d__0.MoveNext()
at TreeSharp.Composite.Tick(Object context)
at TreeSharp.PrioritySelector.<Execute>d__0.MoveNext()
at TreeSharp.Composite.Tick(Object context)
at TreeSharp.PrioritySelector.<Execute>d__0.MoveNext()
at TreeSharp.Composite.Tick(Object context)
at ff14bot.TreeRoot.()
 
Last edited:
i tested. still not work.
What specific ability are you trying to silence? I've tried this a bunch of times on a bunch of different abilities in a lot of different instances I never get this. Try making a new folder with a fresh install of RB and Magitek and see if it still happens.
 
helloes and thanks for everything you do!

i purchased RB yesterday and was a long time HB/DB user.

i'm leveling side jobs and am having issues with BLM. Specificaly not using Transpose or crossclass skills such as Raging Strikes. It's not using my High Quality food either...thats all i got for now :-)
 
++
i tested. still not work.
I tested this some more today and it looks like it can't really be fixed right now. Certain abilities don't correctly return their name when queried. Maybe abilities added since 2.3 or maybe earlier haven't been indexed. The only real option right now is disabling interrupt.
 
I tested this some more today and it looks like it can't really be fixed right now. Certain abilities don't correctly return their name when queried. Maybe abilities added since 2.3 or maybe earlier haven't been indexed. The only real option right now is disabling interrupt.

I'm going to reply in the Community Developer Forum as well....but this is the code I have in MoreDots for Bard's BluntArrow:

Code:
private async Task<bool> BluntArrow()
        {
            var partyManager = new HealManager.HealingManager();
            var _totalParty = partyManager.TotalParty.Select(r => r.ObjectId).ToList();
            var spells = new List<string> { ConjurerSpells.CureII.Name, ConjurerSpells.Medica.Name, ConjurerSpells.MedicaII.Name, ArcanistSpells.Physick.Name, ScholarSpells.Adloquium.Name };

            var unit = (from a in GameObjectManager.GetObjectsOfType<BattleCharacter>()
                        where a.CanAttack
                        where !_totalParty.Contains(a.ObjectId)
                        where a.Distance(Core.Player) < 25
                        where a.IsCasting && spells.Contains(a.SpellCastInfo.SpellData.Name)
                        select a).FirstOrDefault();


            if (unit != null)
            {
                await BardSpells.BluntArrow.Cast(unit);
                Logging.Write(Colors.OrangeRed, "[MoreDots] Interrupting " + unit.Name);
            }
            {
                return false;
            }
        }

This doesn't exactly translate over to the Treesharp that Magitek is written in....but try using SpellCastInfo.SpellData.Name instead of just SpellCastInfo.Name. I think doing that will fix your issue.
 
Often times, using the Fate Hunter, it would target a monster who's not part of the fate, and while my DRG will run up to the fate mobs, it won't target the fate mobs, leaving the target stuck on the non-fate mob.

Have tried targeting style : Fate Mob as well as Closest enemy.
 
I'm going to reply in the Community Developer Forum as well....but this is the code I have in MoreDots for Bard's BluntArrow:

This doesn't exactly translate over to the Treesharp that Magitek is written in....but try using SpellCastInfo.SpellData.Name instead of just SpellCastInfo.Name. I think doing that will fix your issue.
Mastahg seems to suggest that my code is fine and that there is actually a problem with SpellCastInfo.Name.


If anyone else notices abilities that cause magitek to stop acting while the enemy is casting or abilities that it won't interrupt, please note the ability name and run this in your console and report what it returns.

Code:
Log(((BattleCharacter)Core.Player.CurrentTarget).SpellCastInfo.ActionId);
Log(((BattleCharacter)Core.Player.CurrentTarget).SpellCastInfo.ActionType);
I will be doing this myself as well, but it will help a lot to get this done faster and to get info on abilities I might not encounter. Thanks.

EDIT: Nevermind for now I guess. Mastahg says he found what the issue is and it will probably be fixed in tomorrow's patch.
 
Last edited:
Status
Not open for further replies.
Back
Top