LokiPoe.InGameState.StashPanel.SwitchToTab

[cyberbot]

The SwitchToTab routine [LokiPoe.InGameState.StashPanel.SwitchToTab(Index)] is not working for me anymore. It just keeps clicking on the tab list drop-down menu in the client.

But is it just me?

 

[pushedx]

Do you mean the "SwitchToTab" using the tab name? I'll check it out, but it is likely it broke due to stash tab changes with typing now. I can't say the function will actually be kept though, because of how complex the logic is due to the way they handle tabs. The behavior of selecting tabs has 3 different ways of working, which is why it's not used in the bot right now. I left it an exposed API function in an attempt to avoid forcing people to go though their tab lists one by one, but it might be required.

For now, it would be advisable to simply use NextTab/PreviousTab for a 100% accurate method of traversing though the tab list.

The actual change does make the logic more easy to use now (assuming you're using alpha-numeric characters), but I would have to rewrite the function altogether.

 

[cyberbot]

So what are the three ways of selecting tabs?

1) SwitchToTab by name
2) NextTab/PreviousTab
3) ??

 

[darkbluefirefly]

So what are the three ways of selecting tabs?

1) SwitchToTab by name
2) NextTab/PreviousTab
3) ??

using input keys, arrow keys. From last I heard, Tab info does not get loaded unless you switch to that tab. hence if you or server lags, you see an empty tab, then updates with your items.

 

[pushedx]

So what are the three ways of selecting tabs?

1) SwitchToTab by name
2) NextTab/PreviousTab
3) ??

What I meant was there are 3 different sets of logic required to handle choosing a tab by name though the list in the client (before the 1.2.4 patch).

1. Not enough tabs to have the scroll list. You have to only handle the tab list display as the scroll list exists, but is unusable.
2. Enough tabs to have the scroll list, but not enough to have a scroll bar. The way you have to select tabs is simpler, because you don't have to deal with a scrollbar.
3. Enough tabs to have the scroll bar shown on the scroll list. This is by far the most complex. You have to be able to handle "scrolling" and the hit testing for GUI is inconsistent compared to #2.

The API logic is different in each case. Remember that all actions are input driven now, so there's no shortcuts that can be taken for doing any of the necessary actions. This makes that function overly complex.

 

[cyberbot]

I can see how the new feature of accessing a tab by the first letter will help speed up multiple selling/stashing routines. It would be a nice API feature to access this.

 

[pushedx]

Please test #938 to see if the functionality seems fixed now.

Being able to type the tab name to fast move though the list will not be supported. It has to use the scroll list.

 

[cyberbot]

The SwitchToTab function is working agan. Thanks.