Hey, been using your routine along with Tuanha's premium for prot paladin for PvE
Since yours can be modified and tuanhas cant, ive made a few changes to some of the logic on your prot profile, i made the suggestions to Tuanha in his paladin thread but nothing has happened even tho its such a simple addition.
I modified your EF on self slightly by using the Sacred Shield AP% increase variable function that you have. Line 599 to 618:
Code:
#region HEAL ME
if (Me.Combat && ProtPaladinSettings.Instance.AutoHeal)
{
current_AP = CurrentAttackPower();
if ((Me.CurrentHolyPower >= 3 || utils.isAuraActive(144569)) && Me.HealthPercent <= ProtPaladinSettings.Instance.HolyPowerAutoHealHP_EF_WoG)
{
if (utils.CanCast(ETERNAL_FLAME) && !utils.isAuraActive(ETERNAL_FLAME) && (utils.PlayerCountBuff(114637) >= 3))
{
previus_AP = current_AP;
utils.LogActivity(ETERNAL_FLAME + " current_AP=" + previus_AP + " I will recast it if AP>=" + previus_AP*(1+(ProtPaladinSettings.Instance.AttackPowerIncrement/100)));
return utils.Cast(ETERNAL_FLAME, Me);
}
if (utils.CanCast(ETERNAL_FLAME) && utils.isAuraActive(ETERNAL_FLAME) && (utils.PlayerCountBuff(114637) >= 3) && (current_AP >= (previus_AP * (1 + (ProtPaladinSettings.Instance.AttackPowerIncrement / 100)))))
{
previus_AP = current_AP;
utils.LogActivity(ETERNAL_FLAME + " RECAST: previus_AP=" + previus_AP + " current_AP=" + current_AP);
previus_AP = current_AP;
return utils.Cast(ETERNAL_FLAME, Me);
}
This should use EF when 3 or more HoPo OR when you have 4pc T16 active and HP is below the auto heal EF % and when 3 or more bastion stacks (can change this to 5 but i still need to test the code)
It will also use the SS ap% variable in setting to recast EF if you AP reaches that variable increase (with HoPo >=3 or 4pc active AND bastion stacks >=3 AND HP is below threshold) whether EF is currently active or not
Line 726 changed to:
Code:
if (utils.CanCast(HAMMER_OF_RIGHTEOUS, target, true) && (AOE))
{
utils.LogActivity(HAMMER_OF_RIGHTEOUS, target.Name);
return utils.Cast(HAMMER_OF_RIGHTEOUS, target);
}
This removes the use of Hammer of the righteous to apply weakened blows at the start of a fight, since crusader strike does this aswell now
So i think ive got this right but needs a bit more testing lol.
Seperate variables arent needed for SS and EF as you can only have 1 active of the 2 talents.
A variable to choose Bastion stacks would be awesome as well as a variable for the Holy Power to use it at.
Also i dont know the code to check if the Eternal flame is yours or it has been casted on you by someone else (dont know if that matters tho) if its possible?
If theres anything else i can think of and work out ill edit this post or make a new one.
Many thanks