Item Rules 2 - Magic1/2 & Rare4/5/6

[Reezz]

Hey everyone,

I notice that Item Rules 2 does not handle Magic2 / Rare4 / Rare5 / Rare6.
In the explanatory post on how to use the rules, it states that it should only be used for crafting recipes, but this is simply not true.

[Trinity] Item Rules doesn't handle Soul Link of type MightyBelt and quality Rare4!
[Trinity] Item Rules doesn't handle Dominion Memory of type Shoulder and quality Rare5!
[Trinity] Item Rules doesn't handle Thief's Greaves of type Legs and quality Rare4!
[Trinity] Item Rules doesn't handle Restless Disemboweler from Beyond of type Spear and quality Magic2!
[Trinity] Item Rules doesn't handle Inundating Ascended Gauntlets of Pain of type Gloves and quality Magic2!

I've created my custom item rules, and once I saw this I tried to remedy the situation, but it still will not parse the item rules correctly. I could understand the Magic1 / Magic2 since that isn't mentioned in the explanatory post (hence, it might not be incorporated into this version yet?). But Rare4/Rare5/Rare6 should work, I think?

Does anyone have any thoughts or experience with this?

 

[darkfriend77]

probably its [D3QUALITY] what you mean Magic2 / Rare4 / Rare5 / Rare6.
[QUALITY] is only Magic, Rare, Normal ... and so on ...
[ROLL] is 2 4 5 6 ...

it's all written in the ItemRules.txt

I did my documentation task ^^

// +------------------+--------------------------------------------------------+
// |    -CODE-        |  -PICKUP-     |        -Attribute-          | -Example-                                                 
// +------------------+---------------+-----------------------------+----------+
// |  [BASETYPE]      |     YES       | ItemBaseType                | Weapon 
// |  [QUALITY]       |     YES       | ItemQuality                 | Rare						 
// |  [D3QUALITY]     |     YES       | D3 Quality                  | Rare6
// |  [ROLL]          |     YES       | Attribute rolls             | 6
// |  [TYPE]          |     YES       | ItemType                    | Axe							 
// |  [LEVEL]         |     YES       | Level                       | 60
// |  [ONEHAND]       |     YES       | OneHand                     | true							
// |  [TWOHAND]       |     YES       | TwoHand                     | false							 
// +------------------+---------------+-----------------------------+----------+

 

[Reezz]

Then it should parse successfully when I had QUALITY. But it failed.

For QUALITY "Magic" I had no rules everything was classified as TRASH. So unless the items with problems have no QUALITY tag, I don't know.

I'll check my dropped items log tomorrow and report back. Cheers for the reply!

 

[Reezz]

Ok so I checked the Trinity log of the dropped items and it says that the Quality is "Rare5" or similar for the ones that are not handled correctly.

Am I missing something or is it not correct as it is currently implemented?

Attached is the log Any help is much appreciated.

View attachment trinityitemsdropped.zip