inconsistent ActorSNO of Death’s Breath

[tbdf]

hard-coded ActorSNO of Death’s Breath in Weighting.cs is inconsistent with the one in ItemsDropped.csv
seems to be causing occasional loss of Death’s Breath in extended battle with elite/boss

@Weighting.cs

//Death's Breath Priority
if (cacheObject.ActorSNO == 361989)
{
    cacheObject.Weight = MaxWeight;
    cacheObject.WeightInfo += string.Format("Adding {0} - Death's Breath",
        cacheObject.InternalName);
    break;
}

@ItemsDropped.csv
"449044",***,***,"itemFlippy_deathsBreath_Flippy_Global","Misc","CraftingReagent","Misc","Unknown","Rare4","1","True",

updated:
change ActorSNO to 449044 can fix occasional loss problem, bot will pickup Death’s Breath before extended battle fight

//Death's Breath Priority
if (cacheObject.ActorSNO == 449044)
{
    cacheObject.Weight = MaxWeight;
    cacheObject.WeightInfo += string.Format("Adding {0} - Death's Breath",
        cacheObject.InternalName);
    break;
}

 

[destroyer57]

Hope it helps to solve the problem of not picking some death breaths...

 

[iNFLUXAU]

tbdf, that's a pretty nice find!

Is this ID something I can adjust? Or for the buddy team to do.

 

[tvyper]

Nice catch man!
I hope @xzjv and @jubisman notices this post and implement the change.

 

[jvu0001]

Thanks, will give this a try.

 

[jubisman]

Duly noted and already implemented. Thanks for that, tbdf

 

[Uxxx]

so i was right that there is a low priority setting problem with death breath? its a shame. you really need this stuff often and a lot in the late game. but thanks for the fix. hope it gets updated for everybody soon.

 

[jubisman]

so i was right that there is a low priority setting problem with death breath? its a shame. you really need this stuff often and a lot in the late game. but thanks for the fix. hope it gets updated for everybody soon.

You weren't.

 

[Uxxx]

Duly noted and already implemented. Thanks for that, tbdf

You weren't.

seems kinda diffrent. but thanks for your work. i only want to improve it, not insult you in any way.

 

[jubisman]

seems kinda diffrent. but thanks for your work. i only want to improve it, not insult you in any way.

There was an ActorSNO missing, but that's because blizz added a new ActorSNO this patch. The priority was always the same, that's what I meant.

Don't feel bad, though, I wasn't insulted, I just got the impression you hadn't read through the thread.

 

[Uxxx]

There was an ActorSNO missing, but that's because blizz added a new ActorSNO this patch. The priority was always the same, that's what I meant.

Don't feel bad, though, I wasn't insulted, I just got the impression you hadn't read through the thread.

Nope, i just have on interrest of course in optimizing trinity too as a user. i got no programming skillz or anything but i can help with input. what you guys are gonna do with it is your thing. never wanted to annoy anybody