Hi there,
Thanks for the release!
Just wanted to check if the current ProfessionBuddy issues are on the radar as I can't see them in "known" issues?
From what I can see a bunch of the LUA functions are now returning true and false, where previously they were returning 1 or 0 or "nil". This is causing some issues with ProfessionBuddy's components.
GetMailAction
The current GetMailAction for example just stands by the mailbox for ages after getting mail.
Although I don't have access to the latest PB code, I can only assume it's still using this LUA (from the version before it went closed source). Last line of the MailFormat const in GetMailAction:
Code:
if foundMail == 0 and ((newMailCheck == 1 and HasNewMail() == nil) or newMailCheck ==0 ) and totalItems == numItems and beans ~= 1 then return 1 else return 0 end
Issue is that HasNewMail() == nil doesn't act the same way any longer, as it returns false.
The following fixes the issue:
Code:
if foundMail == 0 and ((newMailCheck == 1 and HasNewMail() == false) or newMailCheck ==0 ) and totalItems == numItems and beans ~= 1 then return 1 else return 0 end
GetItemFromBankAction
Again, simply doesn't work in latest build, for much the same reason. In the WithdrawItemFromGBankLuaFormat const the following needs changed:
Code:
if l == nil and c > 0 and (id == itemID or itemID == 0) then
To
Code:
if l == false and c > 0 and (id == itemID or itemID == 0) then
I use my own posting auction code so, but a lot of the LUA was borrowed from the built-in PB ones, and I had to modify a lot there to get things to work again, so I'm assuming it's a similar case with auction posting components. A few comparisons "==1" which needed altered to ==true, and a few of the nil to false ones. Specifically all calls to
CanSendAuctionQuery,
AuctionProgressFrame:IsVisible(),
GetContainerItemInfo(bag, slot) .
Depositing to the bank is also broken; assuming a similar issue, but not had a chance to look yet.
As an aside; the community would find it easier to help if ProfessionBuddy wasn't closed source. At present it's still using very similar code to the last version on the SVN so we can guess, but as time passes it'll be increasingly hard to point out issues. I think that's a real shame.
