HB ARCHIVES: FishingBuddy--DO NOT DELETE

orthofunk · Apr 3, 2015

tmptfate said:
This. Its using too much bag space with it auto filleting.

Also, the fish are worth much more on the AH if they are not filleted

Trevallion · Apr 3, 2015

Also, the fish are worth much more on the AH if they are not filleted

You guys can disable that on your own. If you open the Coroutines.Fillet.cs file in the Honorbuddy\Bots\FishingBuddy folder, you can just delete everything between "FilletTimer.Reset();" and "return false;" in the FilletFish() method. That sounds scary, but it just returns false every time the filletfish method is called.

Make a copy first so you don't hose it up. Actually, if you're not comfortable in c#, it's probably best to just wait on the devs, I guess.

anything · Apr 4, 2015

request option to choose which bait to use.
when fishing at garrison you end up receiving all of the baits randomly, and so it ends up using the wrong one.
its not too difficult to disable bait option and reequip it every 10mins in the mean time tho.

orthofunk · Apr 4, 2015

Trevallion said:
You guys can disable that on your own. If you open the Coroutines.Fillet.cs file in the Honorbuddy\Bots\FishingBuddy folder, you can just delete everything between "FilletTimer.Reset();" and "return false;" in the FilletFish() method. That sounds scary, but it just returns false every time the filletfish method is called.

Make a copy first so you don't hose it up. Actually, if you're not comfortable in c#, it's probably best to just wait on the devs, I guess.

perfect... thanks!

chinajade · Apr 6, 2015

Trevallion said:
My apologies, but I need to clarify my initial post. Fishing Buddy will apply Worm Supreme if it's the only lure in your bags. I just tried deleting Bright Baubles, and clicked the buff off of my pole and the bot correctly applied Worm Supreme to a standard and Ephemeral pole. After looking at the Coroutines.Lure.cs, it appears that it's simply looking for Worm Supreme last. When I moved it to the top of the dictionary entry, it works as expected. I don't know if there is another place in the code that the lure entries are sorted by fishing skill, so this may or may not be useful information. If they are simply applied in the order of the dictionary entries, then that would explain the behavior I'm seeing.

I may be wrong, but previously it would always use Worm Supreme over other lures in my bag. Thanks.

Many thanks for the follow-up, Trevallion!

We've added the additional information to HB-2144.

cheers,
chinajade

chinajade · Apr 6, 2015

Glowrockz said:
Hello, I was wondering if there is a way to make fishing buddy equip a certain fishing pole? I have a +30 and a +100 fishing pole, i was wondering if there was a way to make it equip my +30 pole every time.

Hi, Glowrockz,

Nae, FishingBuddy is hard-coded to equip the fishing pole that provides the highest fishing skill.
May we ask why you would find this decision undesirable?

cheers,
chinajade

chinajade · Apr 6, 2015

anything said:
request option to choose which bait to use.
when fishing at garrison you end up receiving all of the baits randomly, and so it ends up using the wrong one.
its not too difficult to disable bait option and reequip it every 10mins in the mean time tho.

Hi, Anything,

Highvoltz has already stated this kind of management is far far beyond the purpose of FishingBuddy. He indicated that for this level of management, you should look to solving the problem with a plugin.

cheers,
chinajade

chinajade · Apr 6, 2015

shane said:
Hi. Today I logged in to honorbuddy and found fishingbuddy is no longer loading. Please help

Hi, Shane, and thanks for the log.

The problem appears to be with your Honorbuddy installation, and not with FishingBuddy itself. Let's start by doing a 'clean install':

Honorbuddy:HelpDesk:"Clean installing" Honorbuddy

If still no joy, please open a thread in the Support forum, and attach a full log from the clean install.

cheers,
chinajade

[size=-2]Ref: [post=1908712]Shane's original post w/log[/post][/size]

chinajade · Apr 6, 2015

tmptfate said:
In the bot config, adding in 2 more items under "Gear" for fishing Hand and Feet items would be great because there are 2 fishing boots ([]Boots of the Bay - Item - World of Warcraft and []Nat Pagle's Extreme Anglin' Boots - Item - World of Warcraft) and a fishing enchant that can be placed on any gloves. Adding in the 2 additional options will allow maxing +fishing gear.

Hi, Tmptfate, and thanks for the suggestion.

We've opened feature request HB-2155("FishingBuddy: Add boots to the list of gear that FishingBuddy will equip?") against this issue.

cheers,
chinajade

anything · Apr 6, 2015

chinajade said:
Hi, Anything,

Highvoltz has already stated this kind of management is far far beyond the purpose of FishingBuddy. He indicated that for this level of management, you should look to solving the problem with a plugin.

cheers,
chinajade

Code:

diff -Naur FishingBuddy/Coroutines.Bait.cs FishingBuddyModified/Coroutines.Bait.cs
--- FishingBuddy/Coroutines.Bait.cs     2015-04-02 13:21:26.000000000 +1000
+++ FishingBuddyModified/Coroutines.Bait.cs     2015-04-06 18:56:54.855301300 +1000
@@ -47,7 +47,7 @@
                        return true;
                }

-               public static IEnumerable<WoWItem> Baits { get { return StyxWoW.Me.BagItems.Where(i => BaitDictionary.ContainsKey(i.Entry)); } }
+               public static IEnumerable<WoWItem> Baits { get { return StyxWoW.Me.BagItems.Where(i => BaitDictionary.ContainsKey(i.Entry)).OrderBy(i => i.Entry != FishingBuddySettings.Instance.UseBaitPreference); } }

                public static bool GotBaitOnPole
                {
diff -Naur FishingBuddy/FishingBuddySettings.cs FishingBuddyModified/FishingBuddySettings.cs
--- FishingBuddy/FishingBuddySettings.cs        2015-04-02 13:21:26.000000000 +1000
+++ FishingBuddyModified/FishingBuddySettings.cs        2015-04-06 18:50:51.702785300 +1000
@@ -70,6 +70,10 @@
                [Setting, Styx.Helpers.DefaultValue(true), Description("If set to true bot will automatically apply fishing baits"),
                Category("Fishing")]
                public bool UseBait { get; set; }
+
+        [Setting, Styx.Helpers.DefaultValue((uint)0), Description("Which bait to prefer (item id). If not found, other baits will be used."),
+        Category("Fishing")]
+        public uint UseBaitPreference { get; set; }
                #endregion

                #region Advanced

chinajade · Apr 6, 2015

anything said:

Code:

diff -Naur FishingBuddy/Coroutines.Bait.cs FishingBuddyModified/Coroutines.Bait.cs
--- FishingBuddy/Coroutines.Bait.cs     2015-04-02 13:21:26.000000000 +1000
+++ FishingBuddyModified/Coroutines.Bait.cs     2015-04-06 18:56:54.855301300 +1000
@@ -47,7 +47,7 @@
                        return true;
                }

-               public static IEnumerable<WoWItem> Baits { get { return StyxWoW.Me.BagItems.Where(i => BaitDictionary.ContainsKey(i.Entry)); } }
+               public static IEnumerable<WoWItem> Baits { get { return StyxWoW.Me.BagItems.Where(i => BaitDictionary.ContainsKey(i.Entry)).OrderBy(i => i.Entry != FishingBuddySettings.Instance.UseBaitPreference); } }

                public static bool GotBaitOnPole
                {
diff -Naur FishingBuddy/FishingBuddySettings.cs FishingBuddyModified/FishingBuddySettings.cs
--- FishingBuddy/FishingBuddySettings.cs        2015-04-02 13:21:26.000000000 +1000
+++ FishingBuddyModified/FishingBuddySettings.cs        2015-04-06 18:50:51.702785300 +1000
@@ -70,6 +70,10 @@
                [Setting, Styx.Helpers.DefaultValue(true), Description("If set to true bot will automatically apply fishing baits"),
                Category("Fishing")]
                public bool UseBait { get; set; }
+
+        [Setting, Styx.Helpers.DefaultValue((uint)0), Description("Which bait to prefer (item id). If not found, other baits will be used."),
+        Category("Fishing")]
+        public uint UseBaitPreference { get; set; }
                #endregion

                #region Advanced

Hi again, Anything, and thank you for the follow-up.

This is a considerably smaller scope than we envisioned the initial request. As such, we've opened HB-2161("FishingBuddy: Allow configuration for a preferred bait...") against the issue.

cheers,
chinajade

Jasko81 · Apr 8, 2015

Filleting On/Off Parameter

Hi,
I was wondering why filleting came into Fishingbuddy without Parameter, since it is quite simple to add this "feature".

For everyone wanting to turn it off/on like the Baits, heres a little hint:

Two files have to be edited:
FishingBuddySettings.cs and Coroutines.Fillet.cs

FishingBuddySettings.cs:
Find:

Code:

		#region Fishing

		[Setting, Styx.Helpers.DefaultValue(false),
		Description("Set this to true if you want to fish from pools, otherwise set to false."), Category("Fishing")]
		public bool Poolfishing { get; set; }

and add the Parameter:

Code:

		#region Fishing

		[Setting, Styx.Helpers.DefaultValue(false),
		Description("Set this to true if you want to fish from pools, otherwise set to false."), Category("Fishing")]
		public bool Poolfishing { get; set; }
// start
		[Setting, Styx.Helpers.DefaultValue(false),
		Description("Set this to true if you want to fillet the fish in your bags, otherwise set to false."), Category("Fishing")]
		public bool Filleting { get; set; }
// end

-> "Filleting" will show up as Parameter in Fishingbuddy:

Coroutines.Fillet.cs:
Find:

Code:

		// does nothing if no lures are in bag
		public async static Task<bool> FilletFish()
		{

			if (!FilletTimer.IsFinished || Me.IsCasting)
				return false;

and add:

Code:

		// does nothing if no lures are in bag
		public async static Task<bool> FilletFish()
		{

//  start
			if (!FilletTimer.IsFinished || Me.IsCasting || !FishingBuddySettings.Instance.Filleting)
//  end
				return false;

-> Now, if "Filleting" is set to true, FB will chop the fish in your bags, otherwise, if its set to false, FB will leave your fishes in one piece.

I upload the modified files to this Post.

- Jasko

EDIT: Forgot to mention: You can switch the parameter while the bot is running

Jasko81 · Apr 8, 2015

Prefered Baits

Hi,
thanks to Anything, I've added his suggestions to the files and attached them below:

Anything said:

Code:

diff -Naur FishingBuddy/Coroutines.Bait.cs FishingBuddyModified/Coroutines.Bait.cs
--- FishingBuddy/Coroutines.Bait.cs     2015-04-02 13:21:26.000000000 +1000
+++ FishingBuddyModified/Coroutines.Bait.cs     2015-04-06 18:56:54.855301300 +1000
@@ -47,7 +47,7 @@
                        return true;
                }

-               public static IEnumerable<WoWItem> Baits { get { return StyxWoW.Me.BagItems.Where(i => BaitDictionary.ContainsKey(i.Entry)); } }
+               public static IEnumerable<WoWItem> Baits { get { return StyxWoW.Me.BagItems.Where(i => BaitDictionary.ContainsKey(i.Entry)).OrderBy(i => i.Entry != FishingBuddySettings.Instance.UseBaitPreference); } }

                public static bool GotBaitOnPole
                {
diff -Naur FishingBuddy/FishingBuddySettings.cs FishingBuddyModified/FishingBuddySettings.cs
--- FishingBuddy/FishingBuddySettings.cs        2015-04-02 13:21:26.000000000 +1000
+++ FishingBuddyModified/FishingBuddySettings.cs        2015-04-06 18:50:51.702785300 +1000
@@ -70,6 +70,10 @@
                [Setting, Styx.Helpers.DefaultValue(true), Description("If set to true bot will automatically apply fishing baits"),
                Category("Fishing")]
                public bool UseBait { get; set; }
+
+        [Setting, Styx.Helpers.DefaultValue((uint)0), Description("Which bait to prefer (item id). If not found, other baits will be used."),
+        Category("Fishing")]
+        public uint UseBaitPreference { get; set; }
                #endregion

                #region Advanced

174602d1428515334-bot-fishingbuddy-pool-stationary-fishing-bot-usebaitpreference_winfo-png

-> With setting "UseBaitPreference" to an Item ID of a prefered bait, FB will try to put this bait on your pole when its in your bags, otherwise FB will choose another available bait.
With setting to any other value, FB will choose a bait according to its place in your bags.

Files to change are attached below, i've also added the on/off parameter for filleting mentioned a post above.
Replace them with the files existing in FishingBuddy-Folder.

- Jasko

Zeo · Apr 9, 2015

Dear Highvoltz,

It does not seem to use the Nat's Drinking Hat or Draenic Fishing Pole (Using the lure Auras).
Fishingbuddy does equip the items, but IF there are no better lures in your bag, I think it should alternate between the hat and the pole (Pole first if not on CD).

Ideally it would calculate what gives the most +fishing skill depending on the items in your bag.

By Example: Tentacled Hat + good lure is more as the +160 of the Nat's Drinking Hat with Aura, but if there is no lure in your bags the Aura from the Drinking had is better.
But if the Draenic Pole Aura is active you like Tentacled Hat again.
Same with temporarily poles that combined with good lures give mode +skill then the Aura.
Currently the Drinking Hat always seems to have priority over the Tentacled Hat (.FirstOrDefault).

Secondly I would add an option to use the Bladebone Hook if in bag (setting), as some people prefer to use it despite the argument that it does not save space in your bag at the end. (I think is does save space, as you have no spots filled with several partial stacks).

Hope this is clear and helps? If I can submit my suggested changes in the code I could adjust the code myself as I did in AutoAngler2.
(Not the proper calculations part as I noticed it was renamed and comes with the default Honnerbuddy distribution now).

Cheers.

Filin · Apr 10, 2015

Fishing buddy Error.

Hello.

First of all, Admins can move this thread if i placed it in the wrong section/thread, thx.

I got this error when i tried to Use the FishingBuddy in Darkmoon Faire

- Profile : [N - Fishing] Darkmoon Faire (Sealed Crates) - 1.1.xml

FishingBuddy: Warning: It took 240.3219551 seconds to pulse.
This can cause missed bites. To fix try disabling all plugins

The Fishing Buddy does not move. And when a Pool is nearby it walks up to it and fishes it, when the pool is empty it stops.

My Settings & Tools - Gyazo - 77bcced8ab6ad703f4f85d4c73fd65d4.png
FishingBuddy Config - Gyazo - 800e2b58901827e54aa97792aea5ad0a.png
My Plugins - Gyazo - 7d18c2cbe7917396e6603e22f6e4694d.png

Greetings.

Jasko81 · Apr 11, 2015

Hi Filin,

where did u get this profile?
Can u attach or link it please?
Actually this sounds like a profile related problem & should be posted where this profile is located.
(if its an old profile, u may have to add <Pathing Type="Circle" /> )

Greetings,
Jasko

Evil_14 · Apr 12, 2015

Jasko81 said:
Hi,
thanks to Anything, I've added his suggestions to the files and attached them below:

-> With setting "UseBaitPreference" to an Item ID of a prefered bait, FB will try to put this bait on your pole when its in your bags, otherwise FB will choose another available bait.
With setting to any other value, FB will choose a bait according to its place in your bags.

Files to change are attached below, i've also added the on/off parameter for filleting mentioned a post above.
Replace them with the files existing in FishingBuddy-Folder.

- Jasko

Awesome changes, thx!

chinajade · Apr 13, 2015

Zeo said:
Dear Highvoltz,

It does not seem to use the Nat's Drinking Hat or Draenic Fishing Pole (Using the lure Auras).
Fishingbuddy does equip the items, but IF there are no better lures in your bag, I think it should alternate between the hat and the pole (Pole first if not on CD).

Ideally it would calculate what gives the most +fishing skill depending on the items in your bag.

By Example: Tentacled Hat + good lure is more as the +160 of the Nat's Drinking Hat with Aura, but if there is no lure in your bags the Aura from the Drinking had is better.
But if the Draenic Pole Aura is active you like Tentacled Hat again.
Same with temporarily poles that combined with good lures give mode +skill then the Aura.
Currently the Drinking Hat always seems to have priority over the Tentacled Hat (.FirstOrDefault).

Secondly I would add an option to use the Bladebone Hook if in bag (setting), as some people prefer to use it despite the argument that it does not save space in your bag at the end. (I think is does save space, as you have no spots filled with several partial stacks).

Hope this is clear and helps? If I can submit my suggested changes in the code I could adjust the code myself as I did in AutoAngler2.
(Not the proper calculations part as I noticed it was renamed and comes with the default Honnerbuddy distribution now).

Cheers.

Hi, Zeo,

We've opened feature request HB-2190("FishingBuddy: Periodically re-evaluating best gear configuration") for this.

FishingBuddy ships in source-form as part of Honorbuddy. You can find the code in the .../Honorbuddy/Bots/FishingBuddy/ directory.

cheers,
chinajade

chinajade · Apr 13, 2015

Filin said:
Hello.

First of all, Admins can move this thread if i placed it in the wrong section/thread, thx.

I got this error when i tried to Use the FishingBuddy in Darkmoon Faire

- Profile : [N - Fishing] Darkmoon Faire (Sealed Crates) - 1.1.xml

FishingBuddy: Warning: It took 240.3219551 seconds to pulse.
This can cause missed bites. To fix try disabling all plugins

The Fishing Buddy does not move. And when a Pool is nearby it walks up to it and fishes it, when the pool is empty it stops.

My Settings & Tools - Gyazo - 77bcced8ab6ad703f4f85d4c73fd65d4.png
FishingBuddy Config - Gyazo - 800e2b58901827e54aa97792aea5ad0a.png
My Plugins - Gyazo - 7d18c2cbe7917396e6603e22f6e4694d.png

Greetings.

Jasko81 said:
Hi Filin,

where did u get this profile?
Can u attach or link it please?
Actually this sounds like a profile related problem & should be posted where this profile is located.
(if its an old profile, u may have to add <Pathing Type="Circle" /> )

Greetings,
Jasko

Hi, Filin, and thanks for the log.

[13:47:09.251 D] FishingBuddy-Debug: Poolfishing: False

You have not configured FishingBuddy correctly for pool fishing.

And Jasko is spot on...
If this doesn't get you going, you'll need to show (or link) us the profile, also.

cheers,
chinajade

Jwangner · Apr 13, 2015

I downloaded everything but it is still filleting fish...... Damn I wish this would end, fish sell for double what the fillet go for.

HB ARCHIVES: FishingBuddy--DO NOT DELETE

New Member

New Member

Member

New Member

Community Developer

Community Developer

Community Developer

Community Developer

Community Developer

Member

Community Developer

New Member

Attachments

New Member

Attachments

New Member

New Member

Attachments

New Member

New Member

Community Developer

Community Developer

New Member