What's new
By:
  • Visit Rebornbuddy
  • Visit Panda Profiles
  • Visit LLamamMagic
  • Visit Resources
  • Visit Downloads
  • Visit Portal

Focused Crusader Support (Read This If Your Crusader Is Being Stupid)

J

jubisman

New Member
Joined
Aug 17, 2012
Messages
1,732
Reaction score
28
Important: Please read everything in this post before asking questions. I won't answer anything that is already answered in here.

Since there have been lots of people having problem with their crusaders, be it Thorns-Invoker or LoN, I decided to create this thread to keep all of the complaints, bugs and feature requests in one place. So what I did was I tried to fix all of the latest reported issues and upload it here for you guys to try it out.

The issues that I have tried to address so far are:

  • Not being able to cast other skills while channeling Steed Charge (LoN and Invoker) - changed the current trinity behavior to only block Punish if Steed Charge is being channeled
  • Skills not syncing with Convention of Elements for maximum burst damage (LoN) - added some code to make sure Consecration and Iron Skin aren't cast for 2 cycles before Physical, and Shield Glare for 1 cycle (note: you need to have 'Wait for convention element' checked under Settings->Combat->Misc)
  • Steed Charge stopping Town Portal when 'Use Steed Charge Off CD' was checked (LoN) - added some more checks to stop Steed Charge from being cast when the player is currently not moving
  • Bombardment not always obeying the AoE Count slider (LoN)- made sure the slider applies to LoN as well
  • Bombardment not being cast reliably on trash mobs (Invoker) - added Bombardment logic
  • Bombardment not using Convention of Elements rotation efficiently (LoN) - merged Newk's code (thanks Newk!) and added reliable ways to time buffs and cooldowns
  • No support for LoN Bomarbadment-like speed farming builds - added speed farming gear variations to IsBombardmentBuild detection, so it should now use the same loitering and non-melee attacking logic as that build
  • Skills weren't being spammed when under the effects of a CDR pylon - added check to override wait for elements if that pylon's buff is detected
Click to expand...

What I want you guys to do is to test this and let me know what works and what doesn't.

Another important note for LoN saders: I changed the way Iron Skin and Consecration work. Before, you had to set both sliders in Settings->Combat->Crusader to 100% health to make sure they were spammed. This is no longer the case. The way it works now is you have to set the slider to a value that's consistent with emergency health, so make sure to set them to something like 20 or 30%. Doing so will lead trinity to try and detect the LoN build and use CoE cycles to decide what's the best time to cast them in order to maximize burst damage. The only time it will override the CoE cycle logic is when you drop below your emergency health sliders for Iron Skin and Consecration.

So keep that in mind and have fun.

Edit: all of this has already been merged into the main Trinity. You can download it from the official Trinity thread. Feel free to use this thread for discussion and crusader-related bug reports
 
Last edited:
Fresh install of DB, deleted trinity folder, extracted latest trinity folder to /plugins. Replaced this CrusaderCombat.cs in /Plugins/Trinity/Combat/Abilities/CrusaderCombat.cs and I get this... With DB release, beta, different folders.

Code: 
Demonbuddy v1.1.2892.445 started
Logging in...
T: 5247579581190675916 H: 3338389608
Attached to Diablo III with pid: 48004
Flashing window
Compiler Error: d:\DB2\Plugins\Trinity\Coroutines\BuyItemsFromVendor.cs(16,7) : warning CS0105: The using directive for 'Zeta.Common' appeared previously in this namespace
Compiler Error: d:\DB2\Plugins\Trinity\Coroutines\BuyItemsFromVendor.cs(17,7) : warning CS0105: The using directive for 'Zeta.Bot' appeared previously in this namespace
Compiler Error: d:\DB2\Plugins\Trinity\Coroutines\PutItemsInStash.cs(12,7) : warning CS0105: The using directive for 'Zeta.Common' appeared previously in this namespace
Compiler Error: d:\DB2\Plugins\Trinity\Coroutines\PutItemsInStash.cs(13,7) : warning CS0105: The using directive for 'Zeta.Bot' appeared previously in this namespace
Compiler Error: d:\DB2\Plugins\Trinity\Coroutines\TakeItemsFromStash.cs(12,7) : warning CS0105: The using directive for 'Zeta.Common' appeared previously in this namespace
Compiler Error: d:\DB2\Plugins\Trinity\Coroutines\TakeItemsFromStash.cs(13,7) : warning CS0105: The using directive for 'Zeta.Bot' appeared previously in this namespace
Compiler Error: d:\DB2\Plugins\Trinity\Movement\StuckHandler.cs(11,7) : warning CS0105: The using directive for 'System.Threading.Tasks' appeared previously in this namespace
Compiler Error: d:\DB2\Plugins\Trinity\Settings\Loot\ItemListSettings.cs(27,7) : warning CS0105: The using directive for 'System.Text' appeared previously in this namespace
Compiler Error: d:\DB2\Plugins\Trinity\Settings\Loot\ItemListSettings.cs(28,7) : warning CS0105: The using directive for 'System.IO' appeared previously in this namespace
Compiler Error: d:\DB2\Plugins\Trinity\UI\UIComponents\BindingMember.cs(18,7) : warning CS0105: The using directive for 'Trinity.Technicals' appeared previously in this namespace
Compiler Error: d:\DB2\Plugins\Trinity\UI\UIComponents\MarkupExtensions\WidthToColumnCountExtension.cs(6,7) : warning CS0105: The using directive for 'System' appeared previously in this namespace
Compiler Error: d:\DB2\Plugins\Trinity\UI\Visualizer\RadarCanvas\RadarHitTestUtility.cs(2,7) : warning CS0105: The using directive for 'System' appeared previously in this namespace
Compiler Error: d:\DB2\Plugins\Trinity\Framework\Grid\GridPoint.cs(5,19) : warning CS0660: 'Trinity.Bot.Providers.Grid.GridPoint' defines operator == or operator != but does not override Object.Equals(object o)
Compiler Error: d:\DB2\Plugins\Trinity\Framework\Grid\GridPoint.cs(5,19) : warning CS0661: 'Trinity.Bot.Providers.Grid.GridPoint' defines operator == or operator != but does not override Object.GetHashCode()
Compiler Error: d:\DB2\Plugins\Trinity\Items\ItemWrapper.cs(12,18) : warning CS0660: 'Trinity.Items.ItemWrapper' defines operator == or operator != but does not override Object.Equals(object o)
Compiler Error: d:\DB2\Plugins\Trinity\Coroutines\ExtractLegendaryPowers.cs(171,40) : warning CS0028: 'TrinityCoroutines.ExtractLegendaryPowers.Main()' has the wrong signature to be an entry point
Compiler Error: d:\DB2\Plugins\Trinity\UI\UIComponents\BindingMember.cs(41,50) : warning CS0108: 'Trinity.UI.UIComponents.BindingMember.PropertyChanged' hides inherited member 'Trinity.Objects.BaseObject.PropertyChanged'. Use the new keyword if hiding was intended.
Compiler Error: d:\DB2\Plugins\Trinity\UI\Visualizer\VisualizerViewModel.cs(613,50) : warning CS0108: 'Trinity.UI.RadarUI.VisualizerViewModel.PropertyChanged' hides inherited member 'Zeta.Common.Xml.XmlSettings.PropertyChanged'. Use the new keyword if hiding was intended.
Compiler Error: d:\DB2\Plugins\Trinity\UI\Visualizer\VisualizerViewModel.cs(616,29) : warning CS0114: 'Trinity.UI.RadarUI.VisualizerViewModel.OnPropertyChanged(string)' hides inherited member 'Zeta.Common.Xml.XmlSettings.OnPropertyChanged(string)'. To make the current member override that implementation, add the override keyword. Otherwise add the new keyword.
Compiler Error: d:\DB2\Plugins\Trinity\Combat\Abilities\CrusaderCombat.cs(99,21) : error CS0103: The name 'CombatOverrides' does not exist in the current context
Compiler Error: d:\DB2\Plugins\Trinity\Combat\Abilities\CrusaderCombat.cs(634,54) : error CS0117: 'Trinity.Combat.Abilities.CombatBase' does not contain a definition for 'CombatOverrides'
Compiler Error: d:\DB2\Plugins\Trinity\Combat\Abilities\CrusaderCombat.cs(58,125) : error CS0117: 'Trinity.TargetUtil' does not contain a definition for 'NumMobsInRange'
Compiler Error: d:\DB2\Plugins\Trinity\Coroutines\AutoEquipItems.cs(172,34) : warning CS1998: This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Compiler Error: d:\DB2\Plugins\Trinity\Coroutines\AutoEquipItems.cs(205,34) : warning CS1998: This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Compiler Error: d:\DB2\Plugins\Trinity\Coroutines\CoroutineHelper.cs(168,40) : warning CS1998: This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Compiler Error: d:\DB2\Plugins\Trinity\Coroutines\Gamble.cs(136,41) : warning CS1998: This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Compiler Error: d:\DB2\Plugins\Trinity\Coroutines\Resources\CoroutineHelper.cs(168,40) : warning CS1998: This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Compiler Error: d:\DB2\Plugins\Trinity\Helpers\IPluginCommunicator.cs(78,30) : warning CS0168: The variable 'ex' is declared but never used
Compiler Error: d:\DB2\Plugins\Trinity\Helpers\IPluginCommunicator.cs(115,34) : warning CS0168: The variable 'ex' is declared but never used
Compiler Error: d:\DB2\Plugins\Trinity\Helpers\MemoryHelper.cs(65,34) : warning CS0168: The variable 'ex' is declared but never used
Compiler Error: d:\DB2\Plugins\Trinity\Helpers\MemoryHelper.cs(75,34) : warning CS0168: The variable 'ex' is declared but never used
Compiler Error: d:\DB2\Plugins\Trinity\Helpers\Rotator.cs(122,19) : warning CS0168: The variable 'newAngle' is declared but never used
Compiler Error: d:\DB2\Plugins\Trinity\Helpers\ToStringReflector.cs(16,32) : warning CS0168: The variable 'properties' is declared but never used
Compiler Error: d:\DB2\Plugins\Trinity\UI\UIComponents\Converters\DisplayNameAttributeConverter.cs(43,30) : warning CS0168: The variable 'ex' is declared but never used
Compiler Error: d:\DB2\Plugins\Trinity\UI\UIComponents\Converters\EnumVisibilityConverter.cs(33,30) : warning CS0168: The variable 'ex' is declared but never used

edit: I should mention that replacing the crusader cs file with the original produces no errors, and Trinity loads. I don't know why the crusader combat cs is causing errors all over the place?
 
Last edited:
jubisman said:
Version of trinity?
Click to expand...
Installed Trinity 2.14.19 like you recommended. I edited my previous post to state: I should mention that replacing the crusader cs file with the original produces no errors, and Trinity loads. I don't know why the crusader combat cs is causing errors all over the place?
 
Ah crap, xzjv didn't release .22 yet. Sorry about that, I'll upload the entire thing for you then.

edit: Ok, try the new zip now.
 
Last edited:
jubisman said:
Ah crap, xzjv didn't release .22 yet. Sorry about that, I'll upload the entire thing for you then.

edit: Ok, try the new zip now.
Click to expand...
Awesome, thanks! Trinity loaded successfully, going to try it out now.

First findings: It just did a GR60 in 4 minutes, down from 10 with previous combat routine.. Awesome! Going to try higher. It was punching things when cooldowns were down, but I just noticed I did not have Spam Steed Charge in Combat checked.. doh.
 
Last edited:
nirvx said:
First findings: It just did a GR60 in 4 minutes, down from 10 with previous combat routine.. Awesome! It does still take some unnecessary damage which prevents me from going too high. It looks like it likes to punch things when cooldowns are down. Still an amazing improvement
Click to expand...
Glad to hear that it's working better! I noticed the punching too. There's probably something wrong with the loiter code that allows it to default attack intead of walking when steed charge is down.
 
For grifting or something else?

btw, I'll make a guide for LoN sader soon, so hold on to your Steeds.
 
There you go:

YCeTdl2.jpg


Couldn't get the avoidance options in the shot, but they're all off. Only 'Attack Mobs in AoE' is checked.
 
This is some amazing work jubisman, am pushing 68 at the moment. You sir, are a god.
 
blackthorn11 said:
Update it's doing 68 fine as well, however every once in awhile it won't kill all the elites it will leave one mob left up and just walk away and kill a random white mob.
Click to expand...
How many times have you seen this happening?
 
Any recommendation for the Crusader tab?
 
Last edited:
blackthorn11 said:
3 times total between the 5 grifts i've done since I asked for the settings.

EDIT: It seems to do this to mobs that are very mobile. It will kill as an example 2 out of the 3 elite mobs and leave the last one up especially if the last one walks away. Instead of chasing my crusader basically says "F you too" and walks off to attack white mob.
Click to expand...
I'll add it to my todo list then as low priority. Thanks for the report.
 
So I did download the file, put it in the Plugins folder instead of the old Trinity one. I launch DB but Trinity doesn't show up.
Did I put it in the wrong place or was there anything else I had to do ? Running the newest version of DB atm.
 
mhyr said:
So I did download the file, put it in the Plugins folder instead of the old Trinity one. I launch DB but Trinity doesn't show up.
Did I put it in the wrong place or was there anything else I had to do ? Running the newest version of DB atm.
Click to expand...

No, what you did should had worked. Any error message when you start DB?
 
mhyr said:
So I did download the file, put it in the Plugins folder instead of the old Trinity one. I launch DB but Trinity doesn't show up.
Did I put it in the wrong place or was there anything else I had to do ? Running the newest version of DB atm.
Click to expand...

Delete the old Trinity folder, then extract the new in its place.
 
You must log in or register to reply here.
Back
Top